Re: Fix issue 1605 (issue4377054)

2011-04-17 Thread Graham Percival
On Mon, Apr 18, 2011 at 03:53:45AM +, hanw...@gmail.com wrote: > doesnt dffe04e8e1a7c0b94fdfc30e44fe141dfbe7cbec already fix this? That patch follows ee02cd08e6bf81884323809241013c1834b413ed which is this (now closed) rietveld issue. Cheers, - Graham

Re: Fix issue 1605 (issue4377054)

2011-04-17 Thread hanwenn
On 2011/04/14 07:50:45, Graham Percival wrote: Could you swap the subject and message? i.e. I'd like to have a patch with first line of the commit being: PDF metadata for titles now handle unclosed parentheses I'd also be happy with: PDF metadata for titles now handle unclosed parent

Re: Event listener to extract (some) music events. (issue4373046)

2011-04-17 Thread hanwenn
http://codereview.appspot.com/4373046/diff/12001/input/regression/event-listener-output.ly File input/regression/event-listener-output.ly (right): http://codereview.appspot.com/4373046/diff/12001/input/regression/event-listener-output.ly#newcode5 input/regression/event-listener-output.ly:5: list

Re: shortened flags: choosing appropriate flag (issue4410049)

2011-04-17 Thread hanwenn
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode619 lily/stem.cc:619: static vector available_flag_lengths[2][5]; You cannot do this. This will screw up if two .ly files use fonts of different

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-17 Thread Janek Warchoł
2011/4/17 Graham Percival > > On Sat, Apr 16, 2011 at 10:26:03PM +0200, Janek Warchoł wrote: > > 2011/4/16 Janek Warchoł : > > > Like attached one? > > > > Oh wait! it was already added as CG 12.6 building an Ubuntu distro - > > not in unsorted policies. So issue 1453 is invalid/fixed. > > That ri

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Carl Sorensen
On 4/17/11 2:03 PM, "Federico Bruni" wrote: > > However my question was about the whiteout property of TabNoteHead. > IIRC, last year when I made a TabNoteHead transparent I could see a > small white area in place of TabNoteHead, because the whiteout property > of TabNoteHead was set to true by d

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Federico Bruni
Il giorno dom, 17/04/2011 alle 21.04 +0200, Patrick Schmidt ha scritto: > > Last year I found out that I had to set TabNoteHead whiteout > property to > > false when I make the TabNoteHead transparent: > > > http://lilypond-s-support-for-tablatures.3383434.n2.nabble.com/Re-tie-bug-in-2-13-10-td4291

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Patrick Schmidt
Am 17.04.2011 um 18:35 schrieb Federico Bruni: > Il giorno dom, 17/04/2011 alle 16.58 +0200, Patrick Schmidt ha scritto: >>> Anyway I believe that if you want to hide a note in Staff, you want >> to >>> hide the number in TabStaff as well. To me this is the main bug! >>> I hope that Patrick will

Re: Regtests 2.13.60

2011-04-17 Thread Phil Holmes
- Original Message - From: "Keith OHara" To: Sent: Sunday, April 17, 2011 5:37 PM Subject: Re: Regtests 2.13.60 Phil Holmes philholmes.net> writes: Les Nereides has lost a hairpin in the 4th bar. I don't believe the regtest has been changed, so this seems critical. I'll try to

Re: Regtests 2.13.60

2011-04-17 Thread Keith OHara
Phil Holmes philholmes.net> writes: > Les Nereides has lost a > hairpin in the 4th bar. I don't believe the regtest has been changed, so > this seems critical. I'll try to make a tiny bug report today; it looks like dynamic spanners with grace note timing get lost. (Phil if you want to add

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Federico Bruni
Il giorno dom, 17/04/2011 alle 16.58 +0200, Patrick Schmidt ha scritto: > > Anyway I believe that if you want to hide a note in Staff, you want > to > > hide the number in TabStaff as well. To me this is the main bug! > > I hope that Patrick will jump in and share his opinion on this > matter. > In

Re: a doc mistake

2011-04-17 Thread Graham Percival
On Sun, Apr 17, 2011 at 01:39:17PM +, Chen Jin wrote: > In 8.4 section of lilypond Contributor’s Guide, there are some descriptions > about Patch as follow: Thanks, fixed! The fix will not appear on the website until we release lilypond 2.15.0, but rest assured that it is "in the system". :)

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Patrick Schmidt
Am 17.04.2011 um 16:15 schrieb Federico Bruni: > Il giorno mer, 13/04/2011 alle 10.05 +0200, Valentin Villenave ha > scritto: >> Hi Federico, hi everybody, >> >> here's a patch for the documentation accordingly to what you proposed. >> I'm not entirely sure it's suitable to introduce a new funct

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Carl Sorensen" Cc: "Phil Holmes" ; Sent: Sunday, April 17, 2011 2:51 PM Subject: Re: stable/2.14 and fixed_2_x_y On Sun, Apr 17, 2011 at 07:12:18AM -0600, Carl Sorensen wrote: On 4/17/11 5:27 AM, "Graham Percival" wrote: > Given t

Regtests 2.13.60

2011-04-17 Thread Phil Holmes
Apart from the beaming problems reported in http://code.google.com/p/lilypond/issues/detail?id=1619 I find 2 other strange changes compared with 2.13.58 (not 59). Les Nereides has lost a hairpin in the 4th bar. I don't believe the regtest has been changed, so this seems critical. In song-rep

Re: [tablatures] snippet "Slides in tablature", NR 2.4.1

2011-04-17 Thread Federico Bruni
Il giorno mer, 13/04/2011 alle 10.05 +0200, Valentin Villenave ha scritto: > Hi Federico, hi everybody, > > here's a patch for the documentation accordingly to what you proposed. > I'm not entirely sure it's suitable to introduce a new function (or > more exactly, I'm wondering if it shouldn't rat

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Graham Percival
On Sun, Apr 17, 2011 at 07:12:18AM -0600, Carl Sorensen wrote: > On 4/17/11 5:27 AM, "Graham Percival" wrote: > > > Given the existing difficulties with the bug squad, there's no way > > that I can support asking them to play with git master. > > I think you misunderstood my comment. There are

a doc mistake

2011-04-17 Thread Chen Jin
In 8.4 section of lilypond Contributor’s Guide, there are some descriptions about Patch as follow: If the patch is updated, the category should be changed to patch-new (for normal contributors) or patch-new (for developers who are very confident about their patch). The second patch-

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Carl Sorensen
On 4/17/11 5:27 AM, "Graham Percival" wrote: > On Sun, Apr 17, 2011 at 05:15:00AM -0600, Carl Sorensen wrote: >> > >> But it would be nice if the Bug Squad could verify any issues that are fixed >> pre 2.13.61 so that the list of issues to verify is the backport candidates. > > Given the exist

Re: Build split and raising/verifying issues

2011-04-17 Thread Graham Percival
On Sun, Apr 17, 2011 at 01:32:59PM +0100, Phil Holmes wrote: > I'm reasonably confused about the ramifications of the split to 2.13 > and 2.14. Will there be release versions of 2.14, which will > require testing? What needs to be done in terms of regtest checking > for builds? As far as you nee

Build split and raising/verifying issues

2011-04-17 Thread Phil Holmes
I'm reasonably confused about the ramifications of the split to 2.13 and 2.14. Will there be release versions of 2.14, which will require testing? What needs to be done in terms of regtest checking for builds? What will constitute a critical bug, and do we need specific labels to identify whic

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Graham Percival
On Sun, Apr 17, 2011 at 05:15:00AM -0600, Carl Sorensen wrote: > > On 4/17/11 2:33 AM, "Graham Percival" wrote: > > > Instead, I think we should mark something as "fixed" if the patch > > is in git master, but add a "backport" label. You will remove > > that label when you actually do backport

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Carl Sorensen
On 4/17/11 2:33 AM, "Graham Percival" wrote: > On Sat, Apr 16, 2011 at 12:01:43PM -0600, Carl Sorensen wrote: >> On 4/16/11 5:02 AM, "Graham Percival" wrote: >> >>> If you fix something in the issue tracker, mark it fixed_2_15_0. >>> Carl will add fixed_2_13_61, _62, _63, _64, etc., when he

Re: shortened flags: choosing appropriate flag (issue4410049)

2011-04-17 Thread mtsolo
Please add a stemful regtest with several overrides just to make sure that this works completely. http://codereview.appspot.com/4410049/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode620 lily/stem.cc:620: It seems like this new st

Re: Beaming problem introduced with 2.13.60

2011-04-17 Thread m...@apollinemike.com
On Apr 17, 2011, at 1:45 AM, Nick Payne wrote: > Example below demonstrates (a couple of bars taken from Bach's chaconne). > This problem did not exist in versions prior to 2.13.60: > > %= > \version "2.13.60" > \language "english" > > \relative c' { >\time 3/4 >

Re: branching

2011-04-17 Thread Graham Percival
On Sat, Apr 16, 2011 at 01:04:16PM -0600, Carl Sorensen wrote: > > On 4/16/11 12:50 PM, "Han-Wen Nienhuys" wrote: > > > My proposal is that "ready-to-release" still is not strict enough for > > stable, so 2.14 version should be coming from something which moves > > slower than the master branch.

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-17 Thread Graham Percival
On Sat, Apr 16, 2011 at 10:26:03PM +0200, Janek Warchoł wrote: > 2011/4/16 Janek Warchoł : > > Like attached one? > > Oh wait! it was already added as CG 12.6 building an Ubuntu distro - > not in unsorted policies. So issue 1453 is invalid/fixed. > That rings a bell. ouch, Phil should have known

Re: stable/2.14 and fixed_2_x_y

2011-04-17 Thread Graham Percival
On Sat, Apr 16, 2011 at 12:01:43PM -0600, Carl Sorensen wrote: > On 4/16/11 5:02 AM, "Graham Percival" wrote: > > > If you fix something in the issue tracker, mark it fixed_2_15_0. > > Carl will add fixed_2_13_61, _62, _63, _64, etc., when he > > cherry-picks the patch to stable/2.14. > > Also,

PATCHES: 48-hour notice for event listener and shortened flags

2011-04-17 Thread Graham Percival
Tuesday, 10:00 Event listener to extract (some) music events. http://codereview.appspot.com/4373046/ shortened flags: choosing appropriate flag http://codereview.appspot.com/4410049/ Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu