Add predefined mandolin fretboards to lilypond. (issue4384055)

2011-04-10 Thread Carl . D . Sorensen
Reviewers: , Message: Marc Hohl has prepared a patch for mandolin predefined fretboards. The patch looks good to me. Please review. Thanks, Carl http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (righ

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread Carl . D . Sorensen
Instead of adding a property, is there a way to just make the default value of the property be staff_space? Thanks, Carl http://codereview.appspot.com/4385053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listi

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread Carl . D . Sorensen
Instead of adding a property, is there a way to just make the default value of the property be staff_space? Thanks, Carl http://codereview.appspot.com/4385053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listi

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread Graham Percival
On Sun, Apr 10, 2011 at 07:41:51PM +, mts...@gmail.com wrote: > New patch set uploaded w/ a regtest. Thanks added as http://code.google.com/p/lilypond/issues/detail?id=1608 > Before I push, could someone please run the regtests on this patch? I haven't checked it yet, but at least it's in th

Re: [frogs] PATCHES: anything lost?

2011-04-10 Thread Graham Percival
On Sun, Apr 10, 2011 at 02:57:30PM +, James Lowe wrote: > This one is missing (I think). > > http://lists.gnu.org/archive/html/lilypond-devel/2011-04/msg00121.html > > This was the one sent by Mark Hohl to Carl, but I didn't see > anything done Thanks added as http://code.google.com/p/lilypo

Re: LilyPond errors with gcc 4.6

2011-04-10 Thread Patrick McCarty
Hi Bernardo, On Wed, Mar 30, 2011 at 9:10 PM, Patrick McCarty wrote: > On 2011-03-29, Bernardo Barros wrote: >> I think we might need some little changes to compile lilypond with gcc 4. >> I'm getting the following errors with latest git. >> >> http://pastebin.com/gjsLv0Fe > > My guess is that th

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread mtsolo
New patch set uploaded w/ a regtest. Before I push, could someone please run the regtests on this patch? I got an anomaly in partcombine-midi.ly, but I don't know if that's because I messed up the regest or if in fact my code is buggy. I'm tending to think the former, as when I compile this fil

Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)

2011-04-10 Thread pkx166h
5th Draft, nothing to really check (apart from Marks 3 spacing edits) but have removed the ly file now pushed in commit 524f726a5de0033e68525c65e58430de9b60b7ca So this is just some admin work so I know that the latest iteration of the patch is here. http://codereview.appspot.com/412405

Re: Policy about not-yet-regression tests?

2011-04-10 Thread David Kastrup
Graham Percival writes: > On Sun, Apr 10, 2011 at 08:35:54AM +0200, David Kastrup wrote: >> We have a standard problem "bugfix should have regtest" which is not >> working all too well. If the responsibilities for bugfix and regtest >> get decoupled, this might help. After all, most bug reports

RE: [frogs] PATCHES: anything lost?

2011-04-10 Thread James Lowe
Graham, From: Listengine [listeng...@mx1.tuxfamily.net] on behalf of Graham Percival [gra...@percival-music.ca] Sent: 09 April 2011 01:00 To: Lily devel Cc: fr...@lilynet.net Subject: [frogs] PATCHES: anything lost? Here's the current patches list: http://

Re: Doc: Added @knownissue to Grace Notes for MIDI (issue4388041)

2011-04-10 Thread pkx166h
Pushed as commit53390e0570f4544c131e77323cdc4f4ea738bddd http://codereview.appspot.com/4388041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread Carl . D . Sorensen
Wow -- what a quick response! Thanks! I have a couple of comments. Carl http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm#newcode61 scm/define-g

Re: Added new Pagesize definition to paper.scm (issue4368049)

2011-04-10 Thread pkx166h
Pushed as commit 71e0343fdf2a1936b07db0a5892155351c72d553 http://codereview.appspot.com/4368049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-10 Thread mtsolo
Reviewers: , Message: Potential fix for issue 1604. Description: Allows users to prevent rests from automatically shifting. Please review this at http://codereview.appspot.com/4385053/ Affected files: M lily/multi-measure-rest.cc M scm/define-grob-properties.scm M scm/define-grobs.scm

Re: Add some polyphonically directed grobs (issue4387046)

2011-04-10 Thread tdanielsmusic
LGTM http://codereview.appspot.com/4387046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Policy about not-yet-regression tests?

2011-04-10 Thread Graham Percival
On Sun, Apr 10, 2011 at 08:35:54AM +0200, David Kastrup wrote: > We have a standard problem "bugfix should have regtest" which is not > working all too well. If the responsibilities for bugfix and regtest > get decoupled, this might help. After all, most bug reports already > require a demonstrat