Looks good enough to me -- it doesn't completely match our doc policies,
but the whole Ancient music doesn't follow them either, and fixing that
is a job for documentation writers, not programmers.
Please send me a git format-patch origin for this. (also, please read
the latest docs for git-cl
hi all,
documentation of new features is at
http://codereview.appspot.com/3989049/
p
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: Graham Percival,
Message:
On 2011/01/30 15:29:15, Graham Percival wrote:
This patch appears to be have been created in "reversed" fashion --
I'm certain
that you meant to *add* a new regtest, for example, instead of
*deleting* one.
That is understandable, but I really did mean it
On Sun, 2011-01-30 at 11:43 +0100, bart deruyter wrote:
> Perhaps a solution would be like what is being done with midi, setting
> a midi instrument. That way automatically the correct diagram for this
> specific instrument can be shown.
>
> e.g :
>
> Chords = \chordmode {
> \setDiagramInstrument
Unless I hear complaints (including a simple request for more time for
a particular item), these 3 patches will be pushed at 6pm on Tuesday,
1 Feb.
1)
remove bar-size and replace its usage by bar-extent
http://codereview.appspot.com/4025044/
2)
Fix 1120 in a way to avoid issues 1472, 1474
http://
LGTM.
http://codereview.appspot.com/3994045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sat, Jan 29, 2011 at 09:07:27PM +, Keith OHara wrote:
> Mike Solomon ufl.edu> writes:
>
> >
> > It seems that the variable `measures' is unused in this function - can this
> > be
> deleted?
>
> Who are you asking? git blame ("git credit" would have been a nicer name)
Aye, but nobod
This patch appears to be have been created in "reversed" fashion -- I'm
certain that you meant to *add* a new regtest, for example, instead of
*deleting* one.
I think that in the past 2 weeks, you've learned a lot about git and
codereview, so I'll just ask you to re-upload this patch.
http://co
Nice work!
My preference is the "compromise" solution too, for both stems up
and stems down
Trevor
- Original Message -
From: "Janek Warchoł"
To: ; "Carl Sorensen" ;
"Werner LEMBERG" ; "Xavier Scheuer"
Sent: Saturday, January 29, 2011 11:14 PM
Subject: fine-tuning new flags - fe
