This looks even better to me. Thanks!
I have a few comments below.
I'm delighted to have you manage the review and updates for this patch.
When it's time to apply the patch, if you'll create a patch using
git-format-patch, and email it to somebody to push (maybe Trevor
Daniels, or me), then we
I posted a revised patch under my own login, directly from the system
that compiled it,at
http://codereview.appspot.com/3743045/
Carl, the C G was clear enough that I had no trouble going straight to
Rietveld, but I can send (or you can grab) the revised patch to post
under this issue# if you pre
On 2010/12/21 22:56:05, Valentin Villenave wrote:
Oh, I didn't know 0 was false, in Guile you can have something like:
guile> (define a 0)
guile> (if a (display "true\n"))
true
guile>
Yep, Scheme is strict about #f: it's not equal to any other object.
Do you think I can push this patch no
On 2010/12/21 22:45:53, Neil Puttock wrote:
CENTER = 0, so is always false.
Oh, I didn't know 0 was false, in Guile you can have something like:
guile> (define a 0)
guile> (if a (display "true\n"))
true
guile>
(yes it's silly, but remember that the only things about programming I
know, I lear
On 2010/12/21 22:34:23, Valentin Villenave wrote:
Done (new patch). However, I can't really understand how this
condition could
ever be false. What kind of input could trigger the parser rule
without actually
containing a proper direction?
script_dir:
'_' { $$ = DOWN; }
On 2010/12/21 22:27:43, Neil Puttock wrote:
Use ly:dir? instead of (not (null? ...).
Duh. Nice catch, thanks!
Cheers,
V.
http://codereview.appspot.com/3743043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/list
On 2010/12/21 22:21:38, Neil Puttock wrote:
Almost there, but you're still setting 'direction unconditionally
instead of
checking first, i.e.,
Done (new patch). However, I can't really understand how this condition
could ever be false. What kind of input could trigger the parser rule
without
On 2010/12/21 22:12:46, Valentin Villenave wrote:
It does, since the 'direction property is never left null (I can work
around it,
though. But at first I did feel a bit shocked, I must say :-)
Use ly:dir? instead of (not (null? ...).
Cheers,
Neil
http://codereview.appspot.com/3743043/
___
On 12/21/10 1:14 PM, "Valentin Villenave" wrote:
> Greetings everybody, hi Trevor,
>
> I've been looking at the LM 4.4.2 Placement of objects > Within-staff
> objects, and I'm not sure we want to use "Down/Left" and "Up/Right" in
> the table. Yes, we all know that -1 and 1 may respectively mean
On 2010/12/21 14:19:56, Valentin Villenave wrote:
something like that? (see new patch set)
Almost there, but you're still setting 'direction unconditionally
instead of checking first, i.e.,
$$ = run_music_function (PARSER, $2);
if ($1)
{
unsmob $$ and set direction
}
Cheers,
Neil
http://c
On 2010/12/21 21:24:52, Carl wrote:
I can't understand why you don't want to push a patch that breaks all
your
scores... ;-)
Does this latest patch break your scores?
It does, since the 'direction property is never left null (I can work
around it, though. But at first I did feel a bit shoc
On 2010/12/21 20:45:42, Valentin Villenave wrote:
On 2010/12/20 16:22:30, Carl wrote:
actually, whilst it does pass make check, it breaks... all of my own
scores!
I can't understand why you don't want to push a patch that breaks all
your scores... ;-)
Does this latest patch break your sco
On 2010/12/20 16:22:30, Carl wrote:
IMO, go ahead and set the neutral direction. If it passes make check,
then call
it good.
Hi Carl,
actually, whilst it does pass make check, it breaks... all of my own
scores!
I use the following function:
filterDirections=
#(define-music-function (parse
Greetings everybody, hi Trevor,
I've been looking at the LM 4.4.2 Placement of objects > Within-staff
objects, and I'm not sure we want to use "Down/Left" and "Up/Right" in
the table. Yes, we all know that -1 and 1 may respectively mean either
"down" or "left" and either "up" or "right", but in th
On Tue, Dec 21, 2010 at 6:55 PM, Mark Polesky wrote:
> "I Saw Mommy Kissing Santa Claus", à la Messiaen?
Almost. http://tinyurl.com/3a86bxy
(Didn't know this one, thanks for the discovery!)
Cheers,
Valentin.
___
lilypond-devel mailing list
lilypond-d
Valentin Villenave wrote:
> Speaking of simple melodies, you might disapprove of my
> latest doc addition :-)
"I Saw Mommy Kissing Santa Claus", à la Messiaen?
- Mark
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailma
On Mon, Dec 20, 2010 at 09:12:11PM -0800, Mark Polesky wrote:
> In texinfo:
> @cindex foo-- add foo to the concept index
We use this one.
I think Trevor pretty much explained this stuff. I have a fever
so I'm thinking straight and I might have missed something below.
> @findex foo--
On 2010/12/21 15:21:29, Trevor Daniels wrote:
Looks fine to me, but then you've used the wording I suggested, so it
would,
wouldn't it :) Best wait for someone else to approve.
I believe that Graham and I have both approved it.
Carl
http://codereview.appspot.com/3705042/
Looks fine to me, but then you've used the wording I suggested, so it
would, wouldn't it :) Best wait for someone else to approve.
Trevor
http://codereview.appspot.com/3705042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.
On 2010/12/20 23:18:37, Neil Puttock wrote:
Simply set 'direction inside the parser
rule itself following the function evaluation.
Hi Neil,
something like that? (see new patch set)
Cheers,
Valentin.
http://codereview.appspot.com/3743043/
___
lilyp
On Tue, Dec 21, 2010 at 12:33 AM, Graham Percival
wrote:
> % bad:
> c2 d e d | c d e d | c d e d
>
> % good:
> c2 d e d | e f g f | g a b a
>
> % or even:
> c2 d e d | e f g f | g f e d
> \break
> c2 d e d | e f g f | g c, e d | c1
Why not use quarter-notes?
> I don't encourage accidentals
Hello,
Is this OK to give someone a patch to push?
James
http://codereview.appspot.com/3705042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://lists.gnu.org/archive/html/lilypond-devel/2005-05/msg00200.html
Mark Polesky wrote Tuesday, December 21, 2010 5:12 AM
In texinfo:
@cindex foo-- add foo to the concept index
@findex foo-- add foo to the function index
@kindex foo-- add foo to the keystroke index
@printi
23 matches
Mail list logo
