LGTM too.
http://codereview.appspot.com/2275042/diff/18001/lily/stencil-scheme.cc
File lily/stencil-scheme.cc (right):
http://codereview.appspot.com/2275042/diff/18001/lily/stencil-scheme.cc#newcode398
lily/stencil-scheme.cc:398: {
Don't say @co...@var{...}} but @var{...}.
http://codereview.ap
LGTM.
Thanks,
Patrick
http://codereview.appspot.com/2275042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
>> This looks like an oversight. The change is from 2004 where TeX
>> has been still used as the output device.
>
> Ok. So #'medium should be correct now?
Yes. Patch applied, thanks.
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
> \language italiano (like \clef treble) is very consistent. So
> you've convinced me that a string argument is OK.
Mhmm, in the documentation, please use
\language "italiano"
instead. Even newcomers must get used to it...
Werner
___
lilypo
http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly
File input/regression/note-names.ly (right):
http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode8
input/regression/note-names.ly:8: \version "2.13.37"
I prefer having \version statem
Reviewers: carl.d.sorensen_gmail.com,
Message:
Thanks. In the end, I committed this mostly as-is, but a change I made
while working on 1252 allowed me to do without the dummy Paper_columns.
Description:
Fix 1240.
Include fixed spacings in the calculation of minimum spacings.
Please review thi
On 10/24/10 8:17 PM, "Valentin Villenave" wrote:
> On Mon, Oct 25, 2010 at 3:57 AM, wrote:
>> Update the \version string in all of these files!
>
> Well, I was reluctant to put a minor version number. Do you think
> putting "2.14.0" would be okay?
>
>> Then, the argument to your music functio
On Mon, Oct 25, 2010 at 3:57 AM, wrote:
> Update the \version string in all of these files!
Well, I was reluctant to put a minor version number. Do you think
putting "2.14.0" would be okay?
> Then, the argument to your music function would not be a string, but
> rather a symbol:
>
> \language #
I like this a lot -- it's looking like real lilypond code, instead of a
hack.
Thanks for doing this!
Carl
http://codereview.appspot.com/2699041/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/2699041/diff/1/Documentation/changes.tely#n
Reviewers: ,
Message:
Greetings everybody.
Third time's a charm: here's a new attempt to get the \language "foobar"
syntax merged. Cons: this patch does move a lot of files around. Pros:
this is a lot less hackish that my two previous attempts.
Please have a look and feel free to comment; if th
On Sat, Oct 23, 2010 at 8:22 PM, Graham Percival
wrote:
> We're about 10-20 hours of work away from having 0 Critical
> issues. On one hand, that sounds great; we're almost there! On
> the other hand, we've been in this state for the past month. I'm
> not seeing a lot of excitement and work tow
On 10/24/10 6:17 AM, "Valentin Villenave" wrote:
>
> Better luck next time (if there is a next time, which I doubt)...
Don't give up now!
The documentation stuff can be worked out -- if you had posted it on
Rietveld, Graham would have given you feedback.
And now you've got the right way to
On 2010-10-20 15:34, Werner LEMBERG wrote:
why does LyricText #'font-series default to #'bold-narrow?
This looks like an oversight. The change is from 2004 where TeX has
been still used as the output device.
Ok. So #'medium should be correct now?
It's hardly worth it (it's just one change i
On Sun, Oct 24, 2010 at 1:56 PM, Valentin Villenave
wrote:
> On Sun, Oct 24, 2010 at 5:22 AM, Graham Percival
> wrote:
>> We're about 10-20 hours of work away from having 0 Critical
>> issues. On one hand, that sounds great; we're almost there! On
>> the other hand, we've been in this state for
On Sun, Oct 24, 2010 at 2:35 PM, Neil Puttock wrote:
> Well, to be fair, it's not the music function that's the problem;
> rather, you've neglected to make `make-void-music' a thunk, which
> means it's evaluated immediately music-functions.scm is loaded.
I had initially defined it using parenthes
On 2010/10/03 04:52:35, joeneeman wrote:
I was just waiting to see if the memory problems are still there. I
can't
reproduce them (and it seems that Neil can't either any more) so I'm
not
sure what to do. I could just push it and then revert if people
howl...
I'm still not sure what was go
On Sun, Oct 24, 2010 at 5:22 AM, Graham Percival
wrote:
> We're about 10-20 hours of work away from having 0 Critical
> issues. On one hand, that sounds great; we're almost there! On
> the other hand, we've been in this state for the past month. I'm
> not seeing a lot of excitement and work tow
On 24 October 2010 13:17, Valentin Villenave wrote:
> On Sun, Oct 24, 2010 at 1:40 PM, Neil Puttock wrote:
>> On 24 October 2010 12:32, Valentin Villenave wrote:
>>> Feel free to revert it.
>>
>> TBH, I'm sorely tempted to myself.
>
> Then please do.
>
>> There's a memory leak from `make-void-mu
On Sun, Oct 24, 2010 at 1:40 PM, Neil Puttock wrote:
> On 24 October 2010 12:32, Valentin Villenave wrote:
>> Feel free to revert it.
>
> TBH, I'm sorely tempted to myself.
Then please do.
> There's a memory leak from `make-void-music', which suggests you
> haven't done a regression test check
On 2010/10/08 05:32:32, Patrick McCarty wrote:
Looks great!
Thanks.
http://codereview.appspot.com/2275042/diff/2001/input/regression/stencil-scale.ly
File input/regression/stencil-scale.ly (right):
http://codereview.appspot.com/2275042/diff/2001/input/regression/stencil-scale.ly#newcode2
Reviewers: Valentin Villenave, Patrick McCarty,
Message:
On 2010/10/04 10:36:47, Valentin Villenave wrote:
Hi Neil, your patch looks awesome!
Thanks.
Wouldn't a number-pair be more consistent with existing markup
commands such as
translate-scaled?
Yep, and it saves a hash too. :)
Cheer
On 24 October 2010 12:32, Valentin Villenave wrote:
> On Sun, Oct 24, 2010 at 3:43 AM, Graham Percival
> Feel free to revert it.
TBH, I'm sorely tempted to myself.
There's a memory leak from `make-void-music', which suggests you
haven't done a regression test check or run make doc.
I don't thi
On Sun, Oct 24, 2010 at 3:43 AM, Graham Percival
wrote:
> I would have liked to see this in codereview before it showed up in git
> master.
Feel free to revert it.
> changes.tely:
> - why is \include "still recommended"?
Because \include works with "arabic.ly".
> pitches.itely:
> - if \inclu
LGTM.
This is a feature that has been needed. Thanks for working on it.
Carl
http://codereview.appspot.com/2642041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Carl
http://codereview.appspot.com/1698054/diff/17001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/1698054/diff/17001/ly/music-functions-init.ly#newcode602
ly/music-functions-init.ly:602: #(define (symbol-or-boolean? x) (or
(symbol? x)
On Sun, Oct 24, 2010 at 08:50:28AM +0100, Trevor Daniels wrote:
>
> We probably should. I don't see it affecting the
> fixing of the remaining critical issues much, as many
> of us are unable to contribute to those anyway.
Oh, it will definitely affect those Critical issues. People who
have spe
Am 24.10.2010 00:58, schrieb Carl Sorensen:
[...]
varsegno is now fixed, with commit bd4bb4efdb7e3a3e7ff23dbf35a33efb9b296bbc.
Thanks a lot, Carl - I was just about to have a closer look at the
definition of draw_bulb ... I owe you.
Marc
___
li
Graham Percival wrote Sunday, October 24, 2010 4:22 AM
We're about 10-20 hours of work away from having 0 Critical
issues. On one hand, that sounds great; we're almost there! On
the other hand, we've been in this state for the past month. I'm
not seeing a lot of excitement and work towards
28 matches
Mail list logo
