Re: bad "typo fix" :(

2010-08-19 Thread Graham Percival
On Thu, Aug 19, 2010 at 10:17:18PM -0700, Patrick McCarty wrote: > On Thu, Aug 19, 2010 at 10:10 PM, Graham Percival > wrote: > > Hi Patrick, > > > > I disagree most vehemently with your "fix" in > > af68a98e6c142e3479498b49ae924919efa94c77 > > Yes, it wasn't really a typo fix, but the word "expe

Re: bad "typo fix" :(

2010-08-19 Thread Patrick McCarty
On Thu, Aug 19, 2010 at 10:17 PM, Patrick McCarty wrote: > On Thu, Aug 19, 2010 at 10:10 PM, Graham Percival > wrote: >> Hi Patrick, >> >> I disagree most vehemently with your "fix" in >> af68a98e6c142e3479498b49ae924919efa94c77 > > Yes, it wasn't really a typo fix, but the word "experimented" do

Re: bad "typo fix" :(

2010-08-19 Thread Patrick McCarty
On Thu, Aug 19, 2010 at 10:10 PM, Graham Percival wrote: > Hi Patrick, > > I disagree most vehemently with your "fix" in > af68a98e6c142e3479498b49ae924919efa94c77 Yes, it wasn't really a typo fix, but the word "experimented" doesn't really make sense to me in this context. What would you sugges

bad "typo fix" :(

2010-08-19 Thread Graham Percival
Hi Patrick, I disagree most vehemently with your "fix" in af68a98e6c142e3479498b49ae924919efa94c77 Yours cordially, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Make pure-print-callbacks public (issue1983047)

2010-08-19 Thread Carl . D . Sorensen
LGTM Carl http://codereview.appspot.com/1983047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Mike Solomon
Done. http://codereview.appspot.com/1983047 On 8/19/10 7:52 PM, "Joe Neeman" wrote: > 2010/8/19 Mike Solomon >> This makes me wonder...if one creates a grob from the scheme-end, is there a >> way that it can get in on the pure-print-callback action?  Currently, the >> list is not defined publi

Re: Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Joe Neeman
2010/8/19 Mike Solomon > This makes me wonder...if one creates a grob from the scheme-end, is > there a way that it can get in on the pure-print-callback action? > Currently, the list is not defined publicly. A simple define-public should > do the trick, but I’m not sure...thoughts? > Not cur

Re: Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Mike Solomon
This makes me wonder...if one creates a grob from the scheme-end, is there a way that it can get in on the pure-print-callback action? Currently, the list is not defined publicly. A simple define-public should do the trick, but I’m not sure...thoughts? ~Mike On 8/19/10 3:28 PM, "Joe Neeman" wr

Re: Changing staff manually causes "couldn't fit music on page"

2010-08-19 Thread Xavier Scheuer
On 19 August 2010 21:30, Phil Holmes wrote: > > This example does not look as good as it did on 2.12 - the layout is > much tighter, with 10 systems on the first page, as opposed to 8 under > 2.12 - not sure it's an actual bug, though? Using 2.13.30 I get no > errors with the compilation. Aah, s

Re: Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Xavier Scheuer
On 19 August 2010 21:28, Joe Neeman wrote: > > Thanks for pointing this out. You can fix it by adding > ly:sustain-pedal::print to the list of pure-print-callbacks in > scm/define-grobs.scm at line 2438. I'll push this to git in a minute, > so it will be in the next release. Great news! Fast fix,

Re: Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Joe Neeman
On Thu, Aug 19, 2010 at 11:50 AM, Xavier Scheuer wrote: > Hi Joe! > > A recent message from 胡海鹏 - Hu Haipeng pointed out that the Dynamics > context do not seem to be well handled by the page breaking system. > It causes the "couldn't fit music on page" warning and the systems are > "piled up" i

Changing staff manually causes "couldn't fit music on page"

2010-08-19 Thread Xavier Scheuer
[This is another BUG, although the message is quite... similar! ;-D] Hi Joe! A recent message from 胡海鹏 - Hu Haipeng pointed out that the changing staff manually (\change Staff = staffName) do not seem to be well handled by the page breaking system. It causes the "couldn't fit music on page" wa

Dynamics context causes "couldn't fit music on page"

2010-08-19 Thread Xavier Scheuer
Hi Joe! A recent message from 胡海鹏 - Hu Haipeng pointed out that the Dynamics context do not seem to be well handled by the page breaking system. It causes the "couldn't fit music on page" warning and the systems are "piled up" in the first page. As a minimal example I just took the "Piano cente

Build: fix for 1115 extra whitespace in makelsr.py (issue2016041)

2010-08-19 Thread Carl . D . Sorensen
LGTM. Yes, it's ugly, but it's readable ugly. Thanks! Carl http://codereview.appspot.com/2016041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR 2.1 Vocal music

2010-08-19 Thread Trevor Daniels
Graham Percival wrote Thursday, August 19, 2010 6:43 PM On Thu, Aug 19, 2010 at 6:40 PM, Trevor Daniels wrote: BTW, there are several snippets in the LSR which would be good to incorporate but which are not tagged with docs. It's a real pain for me to do this Yes; any LSR editor can ad

Re: NR 2.1 Vocal music

2010-08-19 Thread Graham Percival
On Thu, Aug 19, 2010 at 6:40 PM, Trevor Daniels wrote: > > BTW, there are several snippets in the LSR which would be good > to incorporate but which are not tagged with docs.  It's a real pain > for me to do this - as far as I can see I have to effectively copy the > entire snippet and reenter it

Re: NR 2.1 Vocal music

2010-08-19 Thread Trevor Daniels
Trevor Daniels wrote Tuesday, August 17, 2010 1:23 PM Valentin: I've just pushed a patch which sets out NR 2.1 the way I want it to be. We can now begin work on fleshing out all the missing bits. To avoid merge conflicts we shall need to avoid changing the same parts of vocal.itely simultan

Re: Extra check in define-event-class patch

2010-08-19 Thread Mike Solomon
All changes implemented save ly:make-event-class, which I wouldn't want to touch in this issue as it is a public function and thus may cause renaming issues in both the repository and people's scores. I wouldn't mind opening a separate issue for it, but I'm not sure how one goes about registering