Hey all,
How's this as a simple example?
I will likely be pressed for time over the next week as I start a new job (a
teaching job in which one of the units will be on using Lilypond!). So,
while I won't really be able to take the lead on this feature's
documentation, I can certainly do guided an
On 2010/08/13 22:25:43, Carl wrote:
Let me know about the filename for the new callbacks, and I'll add
that to this
patch and push it.
I'd be happy with scm/define-music-callbacks.scm.
Cheers,
Neil
http://codereview.appspot.com/1986042/show
___
l
On 13 August 2010 09:12, Mike Solomon wrote:
> Done - thank you for the suggestion. Attached is the patch series, which
> can also be found on http://codereview.appspot.com/1867050 . Thank you!
Looks good. I've added quite a few comments, but just got a sever
error trying to publish them. :(
Let me know about the filename for the new callbacks, and I'll add that
to this patch and push it.
THanks,
Carl
http://codereview.appspot.com/1986042/diff/1/2
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/1986042/diff/1/2#newcode887
scm/define-music-display-
On 2010/08/13 11:04:00, Carl wrote:
LGTM.
Carl
Thanks Carl.
I'll push this patchset shortly (with regression tests).
-Patrick
http://codereview.appspot.com/1730044/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org
On 2010/08/13 03:15:48, Carl wrote:
Is the default OK now?
Looks fine to me.
Cheers,
Neil
http://codereview.appspot.com/1347041/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Carl,
LGTM.
Cheers,
Neil
http://codereview.appspot.com/1986042/diff/1/2
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/1986042/diff/1/2#newcode887
scm/define-music-display-methods.scm:887: (let* ((arguments
(ly:music-property expr 'time-signature-arguments
We're down to 8 Critical issues.
- 1 is a website issue that's basically finished.
- 1 is a doc issue that might already be finished (after an issue split)
That leaves 6 code issues. 3 of them have patches:
- Issue 1116:Title not centered
http://code.google.com/p/lilypond/issues/detail?id=111
On Thu, Aug 12, 2010 at 11:13 PM, Trevor Daniels wrote:
>
> Graham Percival wrote Thursday, August 12, 2010 7:38 PM
>>
>> I'd really rather that you helped out with programming (or at
>> least testing+reviewing patches) and critical doc issues...
>
> I looked through the 12 remaining critical issu
Looks ok here; I just did a build from scratch with it applied. The
only potential issue is whether it works with the regtest comparison,
but we can't test that until I make another release.
Please push. :)
http://codereview.appspot.com/1871058/show
___
LGTM.
Carl
http://codereview.appspot.com/1730044/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Graham Percival wrote Friday, August 13, 2010 7:28 AM
On Thu, Aug 12, 2010 at 03:05:38PM -0700, -Eluze wrote:
The lilypond executable may be called as follows from the command
line.
lilypond [option]... file...[[1]>file.log] [2>file.txt]
1> and 2> (and, for the matter, &> ) have nothin
On 8/12/10 7:20 PM, "Trevor Daniels" wrote:
>
> Mike Solomon wrote Thursday, August 12, 2010 10:16 AM
>
>>I added an extra symbol check to my event class patch:
>>
>> http://codereview.appspot.com/1867050
>>
>> Also, I have a regression test that creates a spanner engraver
>> from the
>>
13 matches
Mail list logo
