Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread Carl Sorensen
On 8/1/10 2:42 PM, "n.putt...@gmail.com" wrote: > LSR snippets get stamped with the last convert rule's version whenever a > full update's done, so the accordion snippet's version was already at > 2.13.29 from the autobeaming changes. And that's why the convert rule wouldn't automatically apply,

Re: Revised autobeam settings patch (issue1682049)

2010-08-01 Thread Carl Sorensen
On 8/1/10 10:33 AM, "Arno Waschk" wrote: > dear list, > > i am *completely* confused by this autobeaming thing and especially its > documentation. > even after reading it twice i do not have a clue how to practically use > those things. > it rather appears as a highly complex mixture of *either*

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread Patrick McCarty
On Sun, Aug 1, 2010 at 2:02 PM, Neil Puttock wrote: > On 1 August 2010 21:49, Patrick McCarty wrote: > >> I think I found the problem. >> >> With Guile 1.9, `module-public-interface' doesn't return an interface >> for `the-scm-module', which we rely on: >> >>  scheme@(guile-user)> (module-public-

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread David Kastrup
n.putt...@gmail.com writes: > LSR snippets get stamped with the last convert rule's version whenever a > full update's done, so the accordion snippet's version was already at > 2.13.29 from the autobeaming changes. > > I think a single commit's fine. Done. -- David Kastrup ___

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread Neil Puttock
On 1 August 2010 21:49, Patrick McCarty wrote: > I think I found the problem. > > With Guile 1.9, `module-public-interface' doesn't return an interface > for `the-scm-module', which we rely on: > >  scheme@(guile-user)> (module-public-interface the-scm-module) >  $1 = #f >  scheme@(guile-user)> >

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread Patrick McCarty
On Sun, Aug 1, 2010 at 1:03 PM, wrote: > On 2010/07/29 19:24:46, Neil Puttock wrote: >> >> + = scm_list_3 (ly_symbol2scm ("module-use!"), mod, used); >> >> This effectively exports all bindings, so all local defines are >> now exported. >> >> In the case of `profile-property-access.ly', the format

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread n . puttock
On 2010/08/01 20:09:40, dak wrote: "make test" did not turn up problems with unpatched docs (the docs are really just few lines in one file: there is no serious doc to speak of). But I don't really understand why. \musicglyph doesn't warn for invalid strings, so they slip through silently.

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread David Kastrup
n.putt...@gmail.com writes: > LGTM. > > Are you going to do the docs in a separate patch? "make test" did not turn up problems with unpatched docs (the docs are really just few lines in one file: there is no serious doc to speak of). But I don't really understand why. I can make the doc change a

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread pnorcks
On 2010/07/29 19:24:46, Neil Puttock wrote: + = scm_list_3 (ly_symbol2scm ("module-use!"), mod, used); This effectively exports all bindings, so all local defines are now exported. In the case of `profile-property-access.ly', the format call ends up using `ergonomic-simple-format' from l

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread n . puttock
LGTM. Are you going to do the docs in a separate patch? http://codereview.appspot.com/1908041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread dak
On 2010/08/01 14:27:05, Neil Puttock wrote: http://codereview.appspot.com/1908041/diff/10002/18002 File python/convertrules.py (right): http://codereview.appspot.com/1908041/diff/10002/18002#newcode3014 python/convertrules.py:3014: 'accDot': 'dot', indent http://codereview.appspot.com/19080

Re: Typos in English manual

2010-08-01 Thread Werner LEMBERG
> Here we go with spacing after end of sentence. Thanks a lot! Applied to git. It's really great that you have obviously far too much time for providing such patches :-) Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists

Re: Typos in English manual

2010-08-01 Thread Ralf Wildenhues
* Werner LEMBERG wrote on Sat, Jul 31, 2010 at 01:52:23PM CEST: > > > > Additionally, we want two spaces after a full stop in the source > > > documentation files. > > > > Ah, well, lemme see what I can do. > > :-) We have a style guide; say `info lilypond-contributor' (I just > see that there is

Re: Typos in English manual

2010-08-01 Thread Trevor Daniels
Carl Sorensen wrote Sunday, August 01, 2010 1:54 AM On 7/31/10 5:51 PM, "Wols Lists" wrote: Do you put a comma after "that is"? Either way, it feels right. I'd be inclined to say "don't stick a comma after a full stop", and yes I know that the dot isn't really a full stop at this point but

Re: Revised autobeam settings patch (issue1682049)

2010-08-01 Thread Arno Waschk
dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even after reading it twice i do not have a clue how to practically use those things. it rather appears as a highly complex mixture of *either* telling me what instructions and value exists *or

RE: Typos in English manual

2010-08-01 Thread James Lowe
Hello, -Original Message- From: lilypond-devel-bounces+james.lowe=datacore@gnu.org on behalf of Carl Sorensen Of course, we might want to consider (for the sake of non-native english speakers) actually deprecating both i.e. and e.g., and replacing them with "that is" and "for exampl

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread dak
On 2010/07/29 20:14:57, Neil Puttock wrote: On 2010/07/29 20:05:30, dak wrote: > I don't think that convert-ly is supposed to deal with Scheme markup conversion. > Searching for #: in the convertrules turns up exactly nothing. Why would it? You don't need that to catch all three types, si

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread dak
http://codereview.appspot.com/1908041/diff/2001/3003 File python/convertrules.py (right): http://codereview.appspot.com/1908041/diff/2001/3003#newcode3044 python/convertrules.py:3044: str = re.sub (r'(\\musicglyph\s*#"accordion\.)([a-zA-Z]+)"', On 2010/07/29 19:29:40, Neil Puttock wrote: Could

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread n . puttock
On 2010/08/01 00:11:44, Ian Hulin wrote: How did you guys track it down to this module? Since Patrick had already reported the failure, I cheated by applying the patch and compiling profile-property-access.ly. :) I only get from the regression test is this message (this is the tail of the lo

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread dak
On 2010/07/29 17:43:37, Graham Percival wrote: On 2010/07/29 13:01:47, c_sorensen_byu.edu wrote: > Right now you have put these conversions into a separate rule. Add them to > the 2.13.29 rule. Then I think you have to do make to get the rules into > convert-ly, but I'm not sure on that.

Re: [PATCH] fix to issue 1173

2010-08-01 Thread Neil Puttock
On 1 August 2010 13:25, Neil Puttock wrote: > Great!  I'll put it up on Rietveld and take a closer look later. http://codereview.appspot.com/1741060/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lily

Re: [PATCH] fix to issue 1173

2010-08-01 Thread Neil Puttock
On 1 August 2010 08:18, Mike Solomon wrote: > Done :) > Please let me know what you think. Great! I'll put it up on Rietveld and take a closer look later. Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailm

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread n . puttock
On 2010/08/01 12:41:41, dak wrote: I changed the source according to the suggestions, but it does not appear like the snippets or the docs are converted automatically. I have no idea how this is supposed to work, but if people say this is correct, I'll commit it in this form. The snippe

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

2010-08-01 Thread n . puttock
http://codereview.appspot.com/1908041/diff/10002/18002 File python/convertrules.py (right): http://codereview.appspot.com/1908041/diff/10002/18002#newcode3014 python/convertrules.py:3014: 'accDot': 'dot', indent http://codereview.appspot.com/1908041/diff/10002/18002#newcode3018 python/convertru

Re: [PATCH] fix to issue 1173

2010-08-01 Thread Mike Solomon
On 7/30/10 10:06 PM, "Neil Puttock" wrote: > On 30 July 2010 14:19, Mike Solomon wrote: >> This raises an error message if showLastLength is not used to show full >> measures. > > Ouch. :) > > We should always try to continue compilation (leaving aside syntax > errors, of course) so I think it