Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-07-04 Thread mtsolo
Great work! http://codereview.appspot.com/1730044/diff/17001/12002 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1730044/diff/17001/12002#newcode743 scm/define-markup-commands.scm:743: I think this is EXCELLENT work and has enough shared features with the recently-c

Revised autobeam settings patch (issue1682049)

2010-07-04 Thread Carl . D . Sorensen
Reviewers: , Message: I've posted a new patch for review that has the new autobeaming code. We now have three properties to control autobeaming: baseMoment (which sets the smallest time interval used for defining beaming), beatStructure (which defines the grouping of baseMoment intervals to for

Re: dist failure for gub

2010-07-04 Thread Reinhold Kainhofer
Am Sonntag, 4. Juli 2010, um 19:21:10 schrieb Jan Nieuwenhuizen: > Op zondag 04-07-2010 om 14:58 uur [tijdzone +0100], schreef Graham > > Percival: > > The dist check for gub is failing with the below message. Generally I > > can fix these things by just adding a file or two to EXTRA_DIST, but >

Re: Fix 1063: Nested property revert (issue1327043)

2010-07-04 Thread n . puttock
LGTM. http://codereview.appspot.com/1327043/diff/8001/9001 File input/regression/nested-property-revert.ly (right): http://codereview.appspot.com/1327043/diff/8001/9001#newcode1 input/regression/nested-property-revert.ly:1: \version "2.13.19" 2.13.27 http://codereview.appspot.com/1327043/diff/

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-07-04 Thread n . puttock
http://codereview.appspot.com/1579041/diff/30001/31004 File lily/metronome-engraver.cc (right): http://codereview.appspot.com/1579041/diff/30001/31004#newcode82 lily/metronome-engraver.cc:82: && g->get_property_data ("break-align-symbol") text_->get_property ("break-align-symbol") OK, so it's u

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-07-04 Thread n . puttock
On 2010/07/04 20:36:28, janneke-list_xs4all.nl wrote: It does. The symbol order does determine the priority. Hmm, this doesn't appear to be the case, since key signatures are preferred over time signatures for aligning. Problem is, at start of a stave the *only* symbol that is present is th

Re: dist failure for gub

2010-07-04 Thread Jan Nieuwenhuizen
Op zondag 04-07-2010 om 20:04 uur [tijdzone +0100], schreef Graham Percival: > I wouldn't call it stupid -- given the pretty-much-un-documented state > of our build process, getting anything to do something requires a fair > amount of ingenuity and hard work. Ow, crap. It's plain make, nothing

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-07-04 Thread Jan Nieuwenhuizen
Op zondag 04-07-2010 om 19:54 uur [tijdzone +], schreef n.putt...@gmail.com: > > Alas, it can't. When adding staff-bar to that list, the broken > > marks appear next to the bar numbers, right at the start of the > > staves. > > That's a shame. It would be great if the symbol order in > 'bre

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-07-04 Thread n . puttock
Hi Jan, On 2010/06/22 19:01:58, jan.nieuwenhuizen wrote: Alas, it can't. When adding staff-bar to that list, the broken marks appear next to the bar numbers, right at the start of the staves. That's a shame. It would be great if the symbol order in 'break-align-symbols determined the priori

Re: dist failure for gub

2010-07-04 Thread Graham Percival
On Sun, Jul 4, 2010 at 6:21 PM, Jan Nieuwenhuizen wrote: > > Apparently the newly added lilypond-book directory does something > stupid, builds without using a target or something. I wouldn't call it stupid -- given the pretty-much-un-documented state of our build process, getting anything to do

Illegal char in snippet map error

2010-07-04 Thread Trevor Daniels
I've just upgraded from 2.13.14 to 2.13.26 (mingw on Vista) in preparation for checking doc patches while Graham is away and I find that has introduced an error when I run lilypond-book on the doc files. The same error occurs on the two files I've tried and is, for example, error: failed files:

Re: dist failure for gub

2010-07-04 Thread Jan Nieuwenhuizen
Op zondag 04-07-2010 om 14:58 uur [tijdzone +0100], schreef Graham Percival: > The dist check for gub is failing with the below message. Generally I > can fix these things by just adding a file or two to EXTRA_DIST, but > this looks more complicated. Any ideas? > (oh... might it need some cleani

dist failure for gub

2010-07-04 Thread Graham Percival
The dist check for gub is failing with the below message. Generally I can fix these things by just adding a file or two to EXTRA_DIST, but this looks more complicated. Any ideas? (oh... might it need some cleaning? Are those files included in "make clean" / should they be?) Cheers, - Graham l

Re: generating bibliographic entries

2010-07-04 Thread Francisco Vila
2010/7/4 Graham Percival : > [1] biber is a variant of bibtex which can handle utf-8; this > would allow us to display accented names properly, instead of just > removing the accent or whatever. .bib files can contain accented characters coded in Latin-1 which is single-byte. -- Francisco Vila.

Re: pushing for doc editors

2010-07-04 Thread Jean-Charles Malahieude
Le 04/07/2010 14:44, Jan Nieuwenhuizen disait : Op zondag 04-07-2010 om 13:22 uur [tijdzone +0100], schreef Graham Percival: then I'll go off and find a coffee shop or something) for the next month. Please be careful, people have gone off to a coffee shop for a month and did not return for y

Re: pushing for doc editors

2010-07-04 Thread Jan Nieuwenhuizen
Op zondag 04-07-2010 om 13:22 uur [tijdzone +0100], schreef Graham Percival: > then I'll go off and find a coffee shop or something) for > the next month. Please be careful, people have gone off to a coffee shop for a month and did not return for years... ;-) -- Jan Nieuwenhuizen | GNU LilyPon

generating bibliographic entries

2010-07-04 Thread Graham Percival
Yo, I know that some people here are paranoid about having "generated files" in the git tree. However, I'd like to propose that we allow this for the bibliographic entries: - Documentation/web/cite-us.bib : this would be a typical .bib file, containing normal bibtex entries for any paper that u

Re: pushing for doc editors

2010-07-04 Thread Graham Percival
On Sun, Jul 04, 2010 at 08:33:36AM +0100, Trevor Daniels wrote: > > All seems to work still. So I could hold the doc fort for you > for a month while you jolly off. Enjoy your trip! Great! Colin and James: please send patches to Trevor until 3 Aug. He wrote most of the Learning Manual, and is

.txt files for snippets in lilypond-book really needed?

2010-07-04 Thread Reinhold Kainhofer
In the past, lilypond-book created a dummy .txt file for each snippet, containing only the static phrase "image of music". From the git commit logs (commit 215ba29639e8f47b938389f864e807d98783792f by Han-Wen on July 18, 2004): * scripts/lilypond-book.py (Lilypond_snippet.write_ly): create

Re: pushing for doc editors

2010-07-04 Thread Trevor Daniels
Graham, you wrote Saturday, July 03, 2010 10:28 PM I'm leaving for LSM next Wednesday, and after that I'm going to Vancouver for two weeks. I won't have access to a machine capable of compiling lilypond in less than 4 hours, so I'd like somebody else to handle testing+pushing doc patches, fro