Re: Vertical spacing regression !?

2010-06-26 Thread Joe Neeman
Thanks, I've reverted the patch in the meantime. However, the information that you see in annotate-spacing is actually computed after line-breaking, and so the additional computations in the patch aren't actually redundant (the problem is that they aren't cached sensibly and they aren't actually co

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-06-26 Thread Han-Wen Nienhuys
On Sat, Jun 26, 2010 at 11:47 AM, Jan Nieuwenhuizen wrote: > Op zaterdag 26-06-2010 om 00:06 uur [tijdzone +], schreef > pnor...@gmail.com: > >> Let me know what you think. > > It's getting there... > > This is not exactly what I had in mind > > +    (if (or (eq? (caar commands) 'moveto) > +  

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-06-26 Thread Jan Nieuwenhuizen
Op zaterdag 26-06-2010 om 00:06 uur [tijdzone +], schreef pnor...@gmail.com: > Let me know what you think. It's getting there... This is not exactly what I had in mind +(if (or (eq? (caar commands) 'moveto) + (eq? (caar commands) 'rmoveto)) + (let ((command (car commands

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-06-26 Thread Carl Sorensen
On 6/26/10 3:27 AM, "Mike Solomon" wrote: > Sorry - I should have replied to this earlier, but I was away from my > computer. > In woodwinds, I believe that the "make-connected-shape-stencil" does exactly > this - I use it to draw paths and automate finding extents. Rather than > adding two t

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-06-26 Thread Carl . D . Sorensen
LGTM, with a couple of minor spacing issues. Carl http://codereview.appspot.com/1730044/diff/17001/12002 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1730044/diff/17001/12002#newcode2782 scm/define-markup-commands.scm:2782: (make-override-markup '(line-cap-style

Re: Vertical spacing regression !?

2010-06-26 Thread Arno Waschk
git bisect says: 891840d4b25b71e9caac50174077d6461bb5cc7f is the first bad commit commit 891840d4b25b71e9caac50174077d6461bb5cc7f Author: Joe Neeman Date: Mon Jun 21 23:11:42 2010 +0300 Fix 1062. Include RehearsalMark, etc. in the pure-height of pre-line-breaking systems.

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-06-26 Thread Mike Solomon
Sorry - I should have replied to this earlier, but I was away from my computer. In woodwinds, I believe that the "make-connected-shape-stencil" does exactly this - I use it to draw paths and automate finding extents. Rather than adding two things w/ similar functionalities to Lilypond, I think it

Re: Vertical spacing regression !?

2010-06-26 Thread Arno Waschk
will try to find out, but in the moment i am searching an old version which does in general not have the problem i am facing... the rumor of it appearing between 2.13.18 and 2.13.19 does not seem true... arno On Sat, 26 Jun 2010 11:03:24 +0200, Joe Neeman wrote: Ok, but do you know which c