Re: Dependencies in Lilypond

2010-06-08 Thread Mike Solomon
Hey Carl, Your bezier curve suite is wonderful - I need the solver for an entirely different issue in my waveforms project, which is itching to be thrown on Reitveld by someone who is more savvy than I! Takers? ~Mike On 6/8/10 5:59 PM, "Carl Sorensen" wrote: > \On 6/8/10 7:46 AM, "Jan Nie

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread Carl . D . Sorensen
Having gotten approval from Graham and Neil, and having responded to Neil's comments, I'll go ahead and push. I'll also post the set that I'm pushing for completeness. Thanks, Carl http://codereview.appspot.com/1545043/diff/6001/7001 File Documentation/contributor/programming-work.itexi (rig

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-06-08 Thread n . puttock
Hi Jan, I've tested the latest patch, and it looks pretty good so far. Here are a few thoughts on positioning: -) A metronome mark at a full-bar rest should be aligned with the barline instead of the paper column to the left of the rest. -) If there's a tempo change at a key signature, the met

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread n . puttock
Hi Carl, LGTM too. Cheers, Neil http://codereview.appspot.com/1545043/diff/6001/7001 File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/1545043/diff/6001/7001#newcode1304 Documentation/contributor/programming-work.itexi:1304: @code{test-redo}? In my e

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread percival . music . ca
Looks good to me! http://codereview.appspot.com/1545043/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread Carl . D . Sorensen
Reviewers: Graham Percival, Message: Thanks for the review. I've posted a new version. Thanks, Carl http://codereview.appspot.com/1545043/diff/1/2 File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/1545043/diff/1/2#newcode1305 Documentation/contrib

Re: RehearsalMark and Barline placement at the beginning of a line

2010-06-08 Thread Neil Puttock
On 8 June 2010 17:24, Xavier Scheuer wrote: > 2010/6/7 Neil Puttock : >> \override Score.RehearsalMark #'X-offset = #shift-right-at-line-begin Oops, I'd forgotten how this should be used; it doesn't return a useful value (since it uses ly:grob-translate-axis! to perform the shift), so should onl

Re: fix ly:parser-parse-file in an ly file (issue1345041)

2010-06-08 Thread Nicolas Sceaux
Le 7 juin 2010 à 21:35, reinhold.kainho...@gmail.com a écrit : > On 2010/06/07 19:17:27, Neil Puttock wrote: >> On 2010/06/07 13:59:45, Reinhold wrote: >> > However, I fail to see where this is actually used... > >> It's called whenever Guile encounters the character sequence #{ for > parsing >>

Re: Bezier curves [was: Dependencies in Lilypond]

2010-06-08 Thread Alexander Kobel
On 2010-06-08 17:59, Carl Sorensen wrote: P.S. If you have more stuff you want to do with Beziers, give me a shout. I've taken Dr. Sederberg's class, so I'm somewhat aware of clever tricks with splines. That's where my bezier stuff came from earlier. Whoever wants to do something serious with

Re: Add regression tests for lilypond-book (issue1556043)

2010-06-08 Thread reinhold . kainhofer
Reviewers: Graham Percival, Message: Updated to use pdflatex and dblatex in the regtests only when available. If not, use the .tex/.xml rather than .pdf files. http://codereview.appspot.com/1556043/diff/1/45 File make/lilypond-book-rules.make (right): http://codereview.appspot.com/1556043/diff

Re: RehearsalMark and Barline placement at the beginning of a line

2010-06-08 Thread Xavier Scheuer
2010/6/7 Neil Puttock : > Use shift-right-at-line-begin (which is described as a kludge in the > Changelog. :) Great! I had never heard of that function. > \override Score.RehearsalMark #'X-offset = #shift-right-at-line-begin Can't it be the default settings? I mean, why isn't it? Are there so

Re: Dependencies in Lilypond

2010-06-08 Thread Carl Sorensen
\On 6/8/10 7:46 AM, "Jan Nieuwenhuizen" wrote: > Op dinsdag 08-06-2010 om 12:55 uur [tijdzone +0200], schreef Mike > Solomon: >> 2) If I can't, do you know of a functional reduce-row-echelon c++ or c file >> that I can freely copy and paste? All of the one's I've found are buggy for >> certain

Re: Dependencies in Lilypond

2010-06-08 Thread Graham Percival
On Tue, Jun 08, 2010 at 03:46:47PM +0200, Jan Nieuwenhuizen wrote: > Op dinsdag 08-06-2010 om 12:55 uur [tijdzone +0200], schreef Mike > Solomon: > [cc: lilypond-devel, for the archives] > > Hi Mike, > > > 1) Can I add a new dependency, and if so, where would I indicate the > > necessity of said

Re: Follow-up to dependencies

2010-06-08 Thread Jan Nieuwenhuizen
Op dinsdag 08-06-2010 om 14:56 uur [tijdzone +0200], schreef Mike Solomon: > For now, I've clepped the lines of code I need from gsl (roughly 40) and > put them in a file in lily/. So everything works fine. That said, I don't > know what the GNU philosophy is about cutting and pasting from o

Re: Dependencies in Lilypond

2010-06-08 Thread Jan Nieuwenhuizen
Op dinsdag 08-06-2010 om 12:55 uur [tijdzone +0200], schreef Mike Solomon: [cc: lilypond-devel, for the archives] Hi Mike, > 1) Can I add a new dependency, and if so, where would I indicate the > necessity of said dependency? in configure.in (write/copy and paste a test) Documentation/i

Add regression tests for lilypond-book (issue1556043)

2010-06-08 Thread percival . music . ca
The code looks ok, but I couldn't check it due to the docbook issue (below). http://codereview.appspot.com/1556043/diff/1/45 File make/lilypond-book-rules.make (right): http://codereview.appspot.com/1556043/diff/1/45#newcode48 make/lilypond-book-rules.make:48: cd $(outdir) && dblatex $(notdir $

Re: Lilypond-book: Factor out the formatting from lilypond-book into separate classes (issue1543042)

2010-06-08 Thread percival . music . ca
Looks good to me; it compiles cleanly from scratch, and all doc formats look normal. (I couldn't check images inside info, since I don't know how to display those) http://codereview.appspot.com/1543042/show ___ lilypond-devel mailing list lilypond-deve

Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread percival . music . ca
Looks mostly good. http://codereview.appspot.com/1545043/diff/1/2 File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/1545043/diff/1/2#newcode1305 Documentation/contributor/programming-work.itexi:1305: Yes, -jX CPU_COUNT=X would be useful, but I'd rather