Re: [PATCH]: Fix issue 1096

2010-05-29 Thread Reinhold Kainhofer
Am Donnerstag, 27. Mai 2010, um 15:39:46 schrieb Carl Sorensen: > Benjamin Peterson prepared a patch to fix this issue. > > It's in the lexer, and I'm not at all comfortable with the lexer. However, > the patch has been demonstrated to work and to not break the regtests. Actually, while it does

Re: [PATCH]: Fix issue 1096

2010-05-29 Thread Reinhold Kainhofer
Am Samstag, 29. Mai 2010, um 17:04:34 schrieb Benjamin Peterson: > 2010/5/28 Reinhold Kainhofer schrieb: > > Am Donnerstag, 27. Mai 2010, um 15:39:46 schrieb Carl Sorensen: > >> Benjamin Peterson prepared a patch to fix this issue. > >> > >> It's in the lexer, and I'm not at all comfortable with

Re: Add independent control of thickness and offset for underline markup (issue1347041)

2010-05-29 Thread Kieren MacMillan
Hi Carl, > Couldn't we define the offset as a multiple of 'line-thickness, instead of > an absolute value? That's how fret diagrams are scaled. Sounds good to me! To be clear, 'line-thickness and the thickness property of \underline are [potentially] two different independent values, right? Ch

Re: Add independent control of thickness and offset for underline markup (issue1347041)

2010-05-29 Thread Kieren MacMillan
Hi Neil, Thanks for the comments! [Should I be somehow commenting on codereview instead of here?] > I don't think we can remove the link between 'line-thickness and > underline offset, since it should scale based on staff-size. At small > staff-sizes, 'line-thickness gets progressively larger, w

Re: Add independent control of thickness and offset for underline markup (issue1347041)

2010-05-29 Thread Carl Sorensen
On 5/29/10 10:10 AM, "Kieren MacMillan" wrote: > Hi Neil, > > Thanks for the comments! > [Should I be somehow commenting on codereview instead of here?] Either way works. > >> I don't think we can remove the link between 'line-thickness and >> underline offset, since it should scale based on

Re: broken links for "next section in reading order"

2010-05-29 Thread Graham Percival
On Wed, May 26, 2010 at 05:05:08PM +0100, James Lowe wrote: > Graham, > > Graham Percival wrote: >> Anyway, what does the texinfo manual say about @-commands in node >> names? Could you look this up, James? > > http://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html#Node-Line-Requirements

Re: [PATCH]: Fix issue 1096

2010-05-29 Thread Benjamin Peterson
2010/5/28 Reinhold Kainhofer schrieb: > Am Donnerstag, 27. Mai 2010, um 15:39:46 schrieb Carl Sorensen: >> Benjamin Peterson prepared a patch to fix this issue. >> >> It's in the lexer, and I'm not at all comfortable with the lexer.  However, >> the patch has been demonstrated to work and to not b