label:Frog for issue tracker

2009-12-02 Thread Graham Percival
I've added a label:Frog for the google issue tracker; this indicates a task suitable for a new contributor. I'm kind-of bending the definition of "Frog", since a bunch of the issues are documentation tasks... but then again, I figured that since the main developers get their hands dirty with the d

Re: Lettered tablature patch

2009-12-02 Thread Trevor Daniels
Hi Dana Many thanks for this. It is not only interesting and useful, but quite a bit _is_ new to me. The variability it exposes is rather daunting! Makes me wonder how far we shall get along this road, but we'll proceed one step at a time and hopefully arrive somewhere useful. Trevor --

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Trevor Daniels
Carl Sorensen wrote Wednesday, December 02, 2009 10:29 PM In order to do the proper explanation, it seems to me we need to be clear on three things: 1) Stacking priority depends on outside-staff-priority if it's present 2) If not, it depends on script-priority 3) How to decide if objects h

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Neil Puttock
2009/12/2 Carl Sorensen : > Oh, I had misunderstood.  Actually, according to gdb, the \turn has a > script-priority of 0. Oops, of course, since it's the only Script in the stack. > >> >>> Does this mean we need to establish the outside-staff-priority for *all* >>> scripts? >> >> No, since some

Re: CG improvements-collector position (was: [frogs] Frog's Lament)

2009-12-02 Thread Graham Percival
On Wed, Dec 02, 2009 at 11:25:00AM -0500, Chris Snyder wrote: > Graham Percival wrote: >> Despite my agreements to both paragraphs above, I agree more with >> the first than the second. Namely, I don't see the point of >> keeping a list of stuff to add to the docs; that's a recipe for >> not getti

Re: Detailed instructions for jail mode

2009-12-02 Thread Graham Percival
On Wed, Dec 02, 2009 at 08:35:27AM +0100, Bertalan Fodor wrote: > > Dunno what the wave thing is all about, but I'm totally fine with > > better jail instructions. It would go in Usage 1.7 Jail, or > > Security issues, or Running as a web service, or something like > > that. > > Would you prefer

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Carl Sorensen
On 12/2/09 2:47 PM, "Neil Puttock" wrote: > 2009/12/2 Carl Sorensen : > >> But it seems to me that if outside-staff-priority is set for one grob, and >> not for the other, then they should be compared by script-priority, since >> there is *not* an outside-staff priority. > > That's exactly w

Add option to indicate frets by letters in tablature (issue164063)

2009-12-02 Thread n . puttock
Hi Trevor, This looks OK apart from a few minor details (I've mentioned the interface/doc issues in the main thread). I look forward to the next instalment. Cheers, Neil http://codereview.appspot.com/164063/diff/1/2 File input/regression/tablature-letter.ly (right): http://codereview.appspot

Re: Lettered tablature patch

2009-12-02 Thread Neil Puttock
2009/12/2 Trevor Daniels : > Happy to do this, but I'm a little puzzled as > the list seems far from complete.  The > tab-note-heads-engraver reads several event > properties and sets 'text and 'staff-position. > Should they be added to the list too, or are > all read event properties excluded? I

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Neil Puttock
2009/12/2 Carl Sorensen : > But it seems to me that if outside-staff-priority is set for one grob, and > not for the other, then they should be compared by script-priority, since > there is *not* an outside-staff priority. That's exactly what I mean: in the case above, the turn has no outside-sta

787 -- Eliminate segfaults due to empty list and unitialized properties (issue163048)

2009-12-02 Thread n . puttock
LGTM. http://codereview.appspot.com/163048/diff/1/2 File lily/script-column.cc (left): http://codereview.appspot.com/163048/diff/1/2#oldcode161 lily/script-column.cc:161: g->set_property ("outside-staff-priority", indent (+ following lines) http://codereview.appspot.com/163048/diff/1/2#oldcode

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Carl Sorensen
On 12/2/09 2:19 PM, "Neil Puttock" wrote: > 2009/12/1 Carl Sorensen : > >> There is a question I have though, >> >> In your opinion, should >> >> c4^"1"^"2"\turn >> >> put the \turn at the top or the bottom of the stack? > > I think I prefer leaving it as it is, otherwise it breaks the ru

Re: Lettered tablature patch

2009-12-02 Thread Carl Sorensen
On 12/2/09 9:50 AM, "Trevor Daniels" wrote: > > > Carl Sorensen wrote Wednesday, December 02, 2009 3:40 PM >> >> On 12/2/09 2:26 AM, "Trevor Daniels" >> wrote: >>> >>> Following a suggestion by Neil I have also made the whiteout >>> behind >>> all fret numbers optional. This is controlle

Re: Issue 787 in lilypond: script stack order fails with 2 more notes

2009-12-02 Thread Neil Puttock
2009/12/1 Carl Sorensen : > There is a question I have though, > > In your opinion, should > > c4^"1"^"2"\turn > > put the \turn at the top or the bottom of the stack? I think I prefer leaving it as it is, otherwise it breaks the rule that outside-staff-priority should only take precedence over s

Re: Lettered tablature patch

2009-12-02 Thread Francisco Vila
2009/12/2 Trevor Daniels : > This is the first patch of a series aiming eventually to enable Baroque lute > tablature to be produced. Trevor, a big thank you for your time and effort on this feature, I hope you'll enjoy doing it. There are interested people in my work environment that follow any

Re: Lettered tablature patch

2009-12-02 Thread David Kastrup
"Trevor Daniels" writes: > Carl, you wrote Wednesday, December 02, 2009 3:43 PM >> >> You should then announce the patch by sending >> an email to lilypond-devel, with a subject line >> starting with PATCH:, asking for comments on the patch. >> >> Will this do? > > I'm not sure that would have co

Re: Editors invoked by git rebase -i

2009-12-02 Thread Jean-Charles Malahieude
Le 02/12/2009 13:38, Trevor Daniels disait : I used "git rebase -i" to combine several commits into one for the first time recently. This was in ubuntu. It threw me for a while because the first editor it brought up was nano (to edit the list of commits) and then vi (to edit the commit messages)

Re: Lettered tablature patch

2009-12-02 Thread demery
> For example, the third fret on a Baroque > lute is indicated by "r" rather than "c", as "c" can easily be > confused with "e". not quite right. I know none of what I say below is new to you Trevor, just trying to present a clear picture for the other readers here. Baroque tabulature for pluc

Re: Editors invoked by git rebase -i

2009-12-02 Thread David Kastrup
"Trevor Daniels" writes: > I used "git rebase -i" to combine several commits into > one for the first time recently. This was in ubuntu. > It threw me for a while because the first editor it > brought up was nano (to edit the list of commits) and > then vi (to edit the commit messages). Not bei

Re: Lettered tablature patch

2009-12-02 Thread Trevor Daniels
Carl Sorensen wrote Wednesday, December 02, 2009 3:40 PM On 12/2/09 2:26 AM, "Trevor Daniels" wrote: Following a suggestion by Neil I have also made the whiteout behind all fret numbers optional. This is controlled by the 'whiteout property of TabNoteHead. The default is #t to preserve

Re: Editors invoked by git rebase -i

2009-12-02 Thread Mark Knoop
At 12:38 on 02 Dec 2009, Trevor Daniels wrote: > I used "git rebase -i" to combine several commits into > one for the first time recently. This was in ubuntu. > It threw me for a while because the first editor it > brought up was nano (to edit the list of commits) and > then vi (to edit the commit

Re: Editors invoked by git rebase -i

2009-12-02 Thread Trevor Daniels
Hi Jonathan, you wrote Wednesday, December 02, 2009 4:27 PM On Wed, Dec 2, 2009 at 6:38 AM, Trevor Daniels wrote: I used "git rebase -i" to combine several commits into one for the first time recently. This was in ubuntu. It threw me for a while because the first editor it brought up was na

Re: Editors invoked by git rebase -i

2009-12-02 Thread Johannes Schindelin
Hi, On Wed, 2 Dec 2009, Trevor Daniels wrote: > I used "git rebase -i" to combine several commits into > one for the first time recently. This was in ubuntu. > It threw me for a while because the first editor it > brought up was nano (to edit the list of commits) and > then vi (to edit the commi

Re: Editors invoked by git rebase -i

2009-12-02 Thread Jonathan Kulp
[whoops! sent only to Trevor the first time...] On Wed, Dec 2, 2009 at 6:38 AM, Trevor Daniels wrote: > I used "git rebase -i" to combine several commits into > one for the first time recently. This was in ubuntu. > It threw me for a while because the first editor it > brought up was nano (to ed

CG improvements-collector position (was: [frogs] Frog's Lament)

2009-12-02 Thread Chris Snyder
Graham Percival wrote: Despite my agreements to both paragraphs above, I agree more with the first than the second. Namely, I don't see the point of keeping a list of stuff to add to the docs; that's a recipe for not getting anything done. I think that can depend on a particular person's work

Re: Lettered tablature patch

2009-12-02 Thread Trevor Daniels
Carl, you wrote Wednesday, December 02, 2009 3:43 PM I took a slightly different tack. I changed: An email should then be sent to lilypond-devel, with a subject line starting with PATCH:, asking for comments on the patch. To You should then announce the patch by sending an email to lilyp

Re: Editors invoked by git rebase -i

2009-12-02 Thread Ralf Mattes
On Wed, 02 Dec 2009 12:38:54 +, Trevor Daniels wrote: > I used "git rebase -i" to combine several commits into one for the first > time recently. This was in ubuntu. It threw me for a while because the > first editor it brought up was nano (to edit the list of commits) and > then vi (to edit

Re: Lettered tablature patch

2009-12-02 Thread Carl Sorensen
On 12/2/09 8:40 AM, "Trevor Daniels" wrote: > > > Carl Sorensen wrote Wednesday, December 02, 2009 3:21 PM > >> On 12/2/09 2:26 AM, "Trevor Daniels" >> wrote: >> I'll rewrite the CG. > > The bit that needs to be added is to say what the > CC field is actually for, and maybe to say what

Re: Editors invoked by git rebase -i

2009-12-02 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Mittwoch, 2. Dezember 2009 13:38:54 schrieb Trevor Daniels: > I used "git rebase -i" to combine several commits into > one for the first time recently. This was in ubuntu. > It threw me for a while because the first editor it > brought up was nano

Re: Lettered tablature patch

2009-12-02 Thread Carl Sorensen
Great job, Trevor! On 12/2/09 2:26 AM, "Trevor Daniels" wrote: > > Following a suggestion by Neil I have also made the whiteout behind > all fret numbers optional. This is controlled by the 'whiteout > property of TabNoteHead. The default is #t to preserve the current > behaviour. You also

Re: Lettered tablature patch

2009-12-02 Thread Trevor Daniels
Carl Sorensen wrote Wednesday, December 02, 2009 3:21 PM On 12/2/09 2:26 AM, "Trevor Daniels" wrote: I posted my first patch to Rietveld last night, but nothing seems to have been cc'd to the list. Not sure what I did wrong. It's at http://codereview.appspot.com/164063. Here's what it d

Re: Editors invoked by git rebase -i

2009-12-02 Thread Graham Percival
On Wed, Dec 02, 2009 at 12:38:54PM -, Trevor Daniels wrote: > It it possible to configure git to use another editor, > like the ubuntu default, gedit, for these? export VISUAL=gedit or something like that. You might be able to set EDITOR instead. Cheers, - Graham

Re: Lettered tablature patch

2009-12-02 Thread Carl Sorensen
On 12/2/09 2:26 AM, "Trevor Daniels" wrote: > I posted my first patch to Rietveld last night, but nothing seems to > have been cc'd to the list. Not sure what I did wrong. It's at > http://codereview.appspot.com/164063. Here's what it does. > This is the second person who has had this mis

Editors invoked by git rebase -i

2009-12-02 Thread Trevor Daniels
I used "git rebase -i" to combine several commits into one for the first time recently. This was in ubuntu. It threw me for a while because the first editor it brought up was nano (to edit the list of commits) and then vi (to edit the commit messages). Not being familiar with either, the way to

Re: Lettered tablature patch

2009-12-02 Thread Trevor Daniels
David Kastrup wrote Wednesday, December 02, 2009 11:15 AM "Trevor Daniels" writes: I posted my first patch to Rietveld last night, but nothing seems to have been cc'd to the list. Not sure what I did wrong. It's at http://codereview.appspot.com/164063. Here's what it does. This is the

Re: Lettered tablature patch

2009-12-02 Thread David Kastrup
"Trevor Daniels" writes: > I posted my first patch to Rietveld last night, but nothing seems to > have been cc'd to the list. Not sure what I did wrong. It's at > http://codereview.appspot.com/164063. Here's what it does. > > This is the first patch of a series aiming eventually to enable > Ba

Re: Lettered tablature patch

2009-12-02 Thread Marc Hohl
Trevor Daniels schrieb: I posted my first patch to Rietveld last night, but nothing seems to have been cc'd to the list. Not sure what I did wrong. It's at http://codereview.appspot.com/164063. Here's what it does. This is the first patch of a series aiming eventually to enable Baroque lut

Lettered tablature patch

2009-12-02 Thread Trevor Daniels
I posted my first patch to Rietveld last night, but nothing seems to have been cc'd to the list. Not sure what I did wrong. It's at http://codereview.appspot.com/164063. Here's what it does. This is the first patch of a series aiming eventually to enable Baroque lute tablature to be produce