is this code-style better? (more alphabetizing patches)

2009-08-19 Thread Mark Polesky
I made some changes to the code-style here.Let me know if you guys think anything is better or worse. I'll probably combine these into one patch. Thanks. - Mark From 44f978455fbc1c630879a115ce6d14900f85aa66 Mon Sep 17 00:00:00 2001 From: Mark Polesky Date: Wed, 19 Aug 2009 23:07:27 -0700

Re: [git 17e68b85] make error in documentation

2009-08-19 Thread Patrick McCarty
On 2009-08-20, Graham Percival wrote: > On Tue, Aug 18, 2009 at 10:33:11AM -0700, Patrick McCarty wrote: > > On 2009-08-18, John Mandereau wrote: > > > Le mardi 18 août 2009 à 03:55 -0700, Graham Percival a écrit : > > > > If necessary we could use inkscape or rsvg, but I'd rather not > > > > incre

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Patrick McCarty
On 2009-08-19, Mark Polesky wrote: > Graham Percival wrote: > > > Neil Puttock wrote: > > > Since it's a .ly file it shouldn't have hard tabs. > > > > Silly Mark, try to keep up here. :P .cc and .scm files should > > have "whatever emacs does", for a certain version number of emacs, > > unless

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Mark Polesky
Graham Percival wrote: > Neil Puttock wrote: > > Since it's a .ly file it shouldn't have hard tabs. > > Silly Mark, try to keep up here. :P .cc and .scm files should > have "whatever emacs does", for a certain version number of emacs, > unless there's any special exemptions that might be known

Move ambitus print callback to scheme.

2009-08-19 Thread hanwenn
Nice to see this type of code migrate to Scheme. http://codereview.appspot.com/110047/diff/1/11 File scm/output-lib.scm (right): http://codereview.appspot.com/110047/diff/1/11#newcode778 Line 778: (ly:grob-suicide! grob) this does not make sense. did you forget to check the length of the noteh

Re: [git 17e68b85] make error in documentation

2009-08-19 Thread Graham Percival
On Tue, Aug 18, 2009 at 10:33:11AM -0700, Patrick McCarty wrote: > On 2009-08-18, John Mandereau wrote: > > Le mardi 18 août 2009 à 03:55 -0700, Graham Percival a écrit : > > > If necessary we could use inkscape or rsvg, but I'd rather not > > > increase the build requirements. (IIRC inkscape isn'

[PATCH] Move ambitus print callback to scheme

2009-08-19 Thread Neil Puttock
Hi, Please review this patch, which implements ambitus::print in output-lib.scm and removes the hard-coded ambitus length via the property 'gap. http://codereview.appspot.com/110047/show Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Graham Percival
On Wed, Aug 19, 2009 at 08:39:38PM +0100, Neil Puttock wrote: > 2009/8/19 Mark Polesky : > > > Sure, I just thought we never came to an official > > agreement on that topic. > > Since it's a .ly file it shouldn't have hard tabs. Silly Mark, try to keep up here. :P .cc and .scm files should ha

Re: Quoting \set and \override (for cue notes etc.)

2009-08-19 Thread Neil Puttock
2009/8/14 Reinhold Kainhofer : > I tried adding various classes to the quotedEventTypes list, e.g. override- > property-event general-music override-property OverrideProperty property-set > PropertySet, but nothing seems to have any effect. Any idea how to make > lilypond also quote overrides and

Re: shouldn't \table-of-contents be "builtin"?

2009-08-19 Thread Nicolas Sceaux
Le 19 août 09 à 06:57, Mark Polesky a écrit : Can I change the \table-of-contents markup-command defintion (ly/toc-init.ly, line 34) fromdefine-markup-list-command to define-builtin-markup-list-command ? No. `define-builtin-markup*-command' is for markup command definition in the (lily) sche

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Neil Puttock
2009/8/19 Mark Polesky : > Sure, I just thought we never came to an official > agreement on that topic. Since it's a .ly file it shouldn't have hard tabs. > Besides, most of the file > uses hard tabs already, doesn't it? Changing them > to spaces would affect almost the whole file. Then > this w

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Mark Polesky
Neil Puttock wrote: > LGTM. > > Can you convert the hard tabs to spaces? Sure, I just thought we never came to an official agreement on that topic. Besides, most of the file uses hard tabs already, doesn't it? Changing them to spaces would affect almost the whole file. Then this would become a t

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Neil Puttock
2009/8/19 Mark Polesky : > oops, here's the patch. LGTM. Can you convert the hard tabs to spaces? Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Mark Polesky
Mark Polesky wrote: > Is this ready to apply? oops, here's the patch. - Mark From 9f1a02b3caaa10b9f2eaac89956fabe53fca8628 Mon Sep 17 00:00:00 2001 From: Mark Polesky Date: Wed, 19 Aug 2009 10:32:17 -0700 Subject: [PATCH] music-functions-init.ly: Alphabetize music-function list. --- l

[PATCH] music-functions-init.ly: Alphabetize music-function list.

2009-08-19 Thread Mark Polesky
Is this ready to apply? I never got a definitive explanation for this: http://lists.gnu.org/archive/html/lilypond-devel/2009-08/msg00785.html so I left that comment in for now (put it at the top). - Mark ___ lilypond-devel mailing list lily

Re: Fwd: GDP Docs compilation FAILED (2009.08.19-04:27)

2009-08-19 Thread Trevor Daniels
Graham Percival wrote Wednesday, August 19, 2009 1:00 PM I get the same thing even with "make". I've reverted Trevor's commit, although I have no clue what's wrong. These errors generally mean that the @menu wasn't updated, but he did that perfectly (as far as I can see). I'm baffled, but d

Re: Fwd: GDP Docs compilation FAILED (2009.08.19-04:27)

2009-08-19 Thread Graham Percival
I get the same thing even with "make". I've reverted Trevor's commit, although I have no clue what's wrong. These errors generally mean that the @menu wasn't updated, but he did that perfectly (as far as I can see). I'm baffled, but don't have time to investigate further right now. Cheers, - Gr

Fwd: GDP Docs compilation FAILED (2009.08.19-04:27)

2009-08-19 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 the docs curretly don't compile. A clean build also didn't change that. Cheers, Reinhold - -- Weitergeleitete Nachricht -- Betreff: GDP Docs compilation FAILED (2009.08.19-04:27) Datum: Mittwoch, 19. August 2009 Von: Lilypond Docum