Re: 3 Win32::API bugs

2012-05-16 Thread $Bill Luebkert
On 05/14/2012 11:33, bulk 88 wrote: I'm going to restart this discussion at http://www.perlmonks.org/?node_id=970481 . I hope more pairs of eyes see there and respond there. I can't log in there at the moment - won't take my password or email me a new one. Wouldn't something like this work

RE: 3 Win32::API bugs

2012-05-16 Thread bulk 88
> Date: Tue, 15 May 2012 11:44:30 -0700 > From: dbec...@roadrunner.com > To: bul...@hotmail.com > CC: libwin32@perl.org > Subject: Re: 3 Win32::API bugs > .. > This would also not break Win32::API::Prototype which would also >

Re: 3 Win32::API bugs

2012-05-16 Thread $Bill Luebkert
On 05/16/2012 12:35, bulk 88 wrote: I would rather not change the dll parameter to a dual purpose ref or non ref, its not obvious what the code is doing then. Someone might ask does Win32::API correct "unnormalized" dll names now or returns the full path name of the DLL loaded from a relative

RE: 3 Win32::API bugs

2012-05-16 Thread bulk 88
I reached an interesting problem. I added buffer overflow protection to SVPV pointer types. Win32::API's own test suite died from a buffer overflow here https://github.com/cosimo/perl5-win32-api/blob/45847136293a8d6939fc319f91702d0b91287726/t/00_API.t#L115 . The sentinal pattern is 2 wide nulls