Re: Updating domains definitions via API

On Mon 16 May 2022, 14:32 Michal Prívozník, wrote: > On 5/16/22 14:52, Darragh Bailey wrote: > > > So perhaps this is less a bug with the loader/nvram XML element handling > > and more a documentation bug and a possible enhancement that possibly > > the virDomainDefineXMLFlags could consider acce

Re: Updating domains definitions via API

On 5/16/22 14:52, Darragh Bailey wrote: > So perhaps this is less a bug with the loader/nvram XML element handling > and more a documentation bug and a possible enhancement that possibly > the virDomainDefineXMLFlags could consider accepting a flag to verify the > returned domain XML is equivalent

Re: Updating domains definitions via API

On Mon, 16 May 2022 at 12:30, Michal Prívozník wrote: > I mean, fixing this particular problem is trivial. But what's not as > trivial is fixing ALL occurrences of this problem (where an > attribute/element is ignored because of something we've parsed earlier). > Mostly because we don't know what

Re: Updating domains definitions via API

On 5/16/22 12:46, Darragh Bailey wrote: > > On Mon 16 May 2022, 10:10 Michal Prívozník, > wrote: > > On 5/14/22 21:23, Darragh Bailey wrote: > > > > On Fri, 13 May 2022 at 00:17, Darragh Bailey > mailto:daragh.bai...@gmail.com> > >

Re: Updating domains definitions via API

On Mon 16 May 2022, 10:10 Michal Prívozník, wrote: > On 5/14/22 21:23, Darragh Bailey wrote: > > > > On Fri, 13 May 2022 at 00:17, Darragh Bailey > > wrote: > > > > Unfortunately trying to call this via ruby-libvirt doesn't appear to > > behave as expected. It app

Re: Updating domains definitions via API

On 5/14/22 21:23, Darragh Bailey wrote: > > On Fri, 13 May 2022 at 00:17, Darragh Bailey > wrote: > > Hi, > > On Thu 12 May 2022, 21:34 Laine Stump, > wrote: > > The virDomainDefineXMLFlags API (and also the older/de

Re: Updating domains definitions via API

On 5/14/22 6:42 PM, Darragh Bailey wrote: Hi, On Sat 14 May 2022, 21:11 Laine Stump, > wrote: Caveat - I'm completely unfamiliar with ruby and the libvirt-ruby API bindings. If there is a problem that causes the domain config to not be updated, libvirt

Re: Updating domains definitions via API

Hi, On Sat, 14 May 2022 at 23:42, Darragh Bailey wrote: > Hi, > > On Sat 14 May 2022, 21:11 Laine Stump, wrote: > >> Caveat - I'm completely unfamiliar with ruby and the libvirt-ruby API >> bindings. >> >> If there is a problem that causes the domain config to not be updated, >> libvirt will re

Re: Updating domains definitions via API

Hi, On Sat 14 May 2022, 21:11 Laine Stump, wrote: > Caveat - I'm completely unfamiliar with ruby and the libvirt-ruby API > bindings. > > If there is a problem that causes the domain config to not be updated, > libvirt will return an error. So I would suspect one of the two things > is happening

Re: Updating domains definitions via API

On 5/14/22 3:23 PM, Darragh Bailey wrote: On Fri, 13 May 2022 at 00:17, Darragh Bailey > wrote: Hi, On Thu 12 May 2022, 21:34 Laine Stump, mailto:la...@redhat.com>> wrote: The virDomainDefineXMLFlags API (and also the older/deprecated v

Re: Updating domains definitions via API

On Fri, 13 May 2022 at 00:17, Darragh Bailey wrote: > Hi, > > On Thu 12 May 2022, 21:34 Laine Stump, wrote: > >> The virDomainDefineXMLFlags API (and also the older/deprecated >> virDomainDefineXML API) doesn't require that the domain first be >> undefined (with one notable exception - see below

Re: Updating domains definitions via API

Hi, On Thu 12 May 2022, 21:34 Laine Stump, wrote: > The virDomainDefineXMLFlags API (and also the older/deprecated > virDomainDefineXML API) doesn't require that the domain first be > undefined (with one notable exception - see below[*]). If you define a > domain that already exists with the sam

Re: Updating domains definitions via API

On 5/12/22 4:03 PM, Darragh Bailey wrote: Hi, Looking into a bug in vagrant-libvirt where an error during the update will cause the domain to be completely discarded. https://github.com/vagrant-libvirt/vagrant-libvirt/issues/949