On Fri, Jul 11, 2014 at 05:11:05PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
In XML format, by definition, order of fields should not matter, so
order of parsing the elements doesn't affect the end result. When
specifying guest NUMA cells, we depend on
On Fri, Jul 11, 2014 at 05:11:00PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
There were numerous places where numatune configuration (and thus
domain config as well) was changed in different ways. On some
places this even resulted in persistent domain
On Tue, Jul 15, 2014 at 04:32:03PM +0800, Jincheng Miao wrote:
In virObjectLockableNew, when virMutexInit fails,
virReportSystemError should use errno to get the right
error number, instead of VIR_ERR_INTERNAL_ERROR.
Signed-off-by: Jincheng Miao
---
src/util/virobject.c | 2 +-
1 file changed, 1
On Tue, Jul 15, 2014 at 04:32:01PM +0800, Jincheng Miao wrote:
In lxcContainerStart, when user namespace is not supported,
the virReportSystemError is called. But the first argument
should be ENOTSUPP, instead of VIR_ERR_CONFIG_UNSUPPORTED.
Signed-off-by: Jincheng Miao
---
src/lxc/lxc_container
On Fri, Jul 11, 2014 at 05:10:53PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf
On Fri, Jul 11, 2014 at 05:11:02PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf/numatune_conf.c | 187 +++--
.../qemuxml2argv-numatune-memnode-no-memory.xml| 30
#x27; parameter for the 'memory-backend-ram' object,
so let's use that.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c| 59 +-
.../qemuxml2argv-numatune-memnode-no-memory.args | 8 +++
.../qemuxml2argv-numatune
On Tue, Jul 15, 2014 at 02:38:36PM +0200, Michal Privoznik wrote:
Up to now it's possible to do something like this:
const char *ptr;
ptr = strdup("my example string");
VIR_FREE(ptr);
The problem is, const char * pointers should not be modified (and
freeing them is kind of modification). We s
On Tue, Jul 15, 2014 at 02:59:50PM +0200, Ján Tomko wrote:
Split into two patches, as we might want to backport the first one somewhere.
Ján Tomko (2):
Fix error on fs pool build failure
Fix assignment of comparison against zero
src/storage/storage_backend_fs.c | 2 +-
tests/virnettlshelpers.c
On Tue, Jul 15, 2014 at 10:47:04PM -0400, Jincheng Miao wrote:
- Original Message -
I'm not sure errno is set when using our virMutexInit(). Most of the
code uses virReportError instead, I suggest using that. This should
Actually, the implement of virMutexInit() already set errno whe
v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
v3:
- Michal's suggestions worked in
- rebased on current master
Martin Kletzander (16):
qemu: purely a code movement
qemu: remove useless error check
conf: purely a code movement
conf, schema: add 'id&
ut with the 'id' attribute they are parsed and formatted according to
that field. This will be useful when we have tuning settings for
particular guest NUMA node.
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 17 +
docs
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1d83f13..315ea6a
That can be lately achieved with by having .param == NULL in the
virQEMUCapsCommandLineProps struct.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c | 10 --
src/qemu/qemu_monitor.c | 6 --
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_monitor_json.c
Excerpt from the virCommandAddArgBuffer() description: "Correctly
transfers memory errors or contents from buf to cmd."
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_comma
The numa patch series in qemu adds "memory-backend-ram" object type by
which we can tell whether we can use such objects.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git
d in later patch.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.caps| 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 5 +
4 files
There are many places with numatune-related code that should be put
into special numatune_conf and this patch creates a basis for that.
Signed-off-by: Martin Kletzander
---
src/Makefile.am | 3 ++-
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c | 37
Signed-off-by: Martin Kletzander
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 3 +-
src/qemu/qemu_cgroup.c | 2 +-
src/qemu/qemu_driver.c | 10
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf/numatune_conf.c | 187 +++--
.../qemuxml2argv-numatune-memnode-no-memory.xml| 30
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 2185ef4..4307f1f 100644
--- a/src/qemu
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c| 26 ++--
.../qemuxml2argv-cpu-numa-disjoint.args| 6 +
.../qemuxml2argv-cpu-numa-disjoint.xml | 28 ++
tests/qemuxml2argvtest.c
#x27; parameter for the 'memory-backend-ram' object,
so let's use that.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c| 59 +-
.../qemuxml2argv-numatune-memnode-no-memory.args | 8 +++
.../qemuxml2argv-numatune
restrict kernel allocations.
This patch leaves the userspace numa_set_membind() in place and moves
the cpuset.mems setting after the point where monitor comes up, but
before vcpu and emulator sub-groups are created.
Signed-off-by: Martin Kletzander
---
Notes:
Another approach would be not
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_cgroup.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 40fe448..e95ad17 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
umatuneDef/virDomainNumatune/g
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 20 ++--
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c | 4 ++--
src/conf/numatune_conf.h | 20 ++--
src/libvirt_private.syms | 4 ++--
src/lxc/lxc_cgroup.
ig is dealt with, all
the internals are now accessible directly only in numatune_conf.c and
outside this file accessors must be used.
Signed-off-by: Martin Kletzander
---
po/POTFILES.in | 1 +
src/conf/domain_conf.c
On Wed, Jul 16, 2014 at 12:14:35PM -0600, Eric Blake wrote:
On 07/16/2014 08:42 AM, Martin Kletzander wrote:
In XML format, by definition, order of fields should not matter, so
order of parsing the elements doesn't affect the end result. When
specifying guest NUMA cells, we depend only o
On Wed, Jul 16, 2014 at 07:48:45PM +0200, Michal Privoznik wrote:
On 16.07.2014 16:42, Martin Kletzander wrote:
v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
v3:
- Michal's suggestions worked in
- rebased on current master
[...]
ACK series.
Althoug
That sets a new flag, but that flag does mean the child will get
LISTEN_FDS and LISTEN_PID environment variables properly set and
passed FDs reordered so that it corresponds with LISTEN_FDS (they must
start right after STDERR_FILENO).
Signed-off-by: Martin Kletzander
---
src
Signed-off-by: Martin Kletzander
---
src/locking/lock_daemon.c | 2 +-
src/rpc/virnetserverservice.c | 5 +
src/rpc/virnetserverservice.h | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c
index e9219d5..02d77e3
Signed-off-by: Martin Kletzander
---
tests/commandtest.c | 49 ++---
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 7d2161c..ba823f7 100644
--- a/tests/commandtest.c
+++ b/tests
Even line like this:
int asdf = i - somevar;
was matched by the regex, so this patch adds '=' to the list of
characters that break the regexp.
Signed-off-by: Martin Kletzander
---
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cfg.mk b/cfg.mk
index baaab7
It's just a wrapper around NewFD and NewUNIX that selects the right
option and increments the number of used FDs.
Signed-off-by: Martin Kletzander
---
src/libvirt_remote.syms | 1 +
src/rpc/virnetserverservice.c | 48 ++-
sr
Since not only systemd can do this (we'll be doing it as well few
patches later), change 'systemd' to 'caller' and fix LISTEN_FDS to
LISTEN_PID where applicable.
Signed-off-by: Martin Kletzander
---
src/libvirt_private.syms | 1 +
src/l
This eliminates the need for active waiting.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Signed-off-by: Martin Kletzander
---
src/rpc/virnetsocket.c | 58 +-
1 file changed, 39 insertions(+), 19 deletions(-)
diff --git a/src/rpc
: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Martin Kletzander (8):
util: abstract parsing of passed FDs into virGetListenFDs()
remote: create virNetServerServiceNewFDOrUNIX() wrapper
rpc: set listen backlog on FDs as well as on other sockets
daemon: support passing FDs from the
On Wed, Jul 16, 2014 at 12:21:24PM -0600, Eric Blake wrote:
On 07/16/2014 08:42 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
[...]
+++ b/docs/schemas/domaincommon.rng
@@ -789,6 +789,23
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander
---
daemon/libvirtd.c | 45 +++--
1 file changed, 27 insertions(+), 18 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon
On Wed, Jul 16, 2014 at 12:43:07PM -0600, Eric Blake wrote:
On 07/16/2014 12:33 PM, Martin Kletzander wrote:
On Wed, Jul 16, 2014 at 12:21:24PM -0600, Eric Blake wrote:
On 07/16/2014 08:42 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
[...]
Missing an here ( and
On Wed, Jul 16, 2014 at 02:53:09PM -0600, Eric Blake wrote:
On 07/16/2014 02:43 PM, Martin Kletzander wrote:
Good point, is this OK to push as trivial (git diff -w):
Count this as my ACK :)
I pushed it then, thank you.
Not my day. I was so focused on the 'diff -w' asp
On Thu, Jul 17, 2014 at 09:40:12AM +0100, Daniel P. Berrange wrote:
On Wed, Jul 16, 2014 at 08:29:58PM +0200, Martin Kletzander wrote:
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander
---
daemon/libvirtd.c | 45
On Tue, May 20, 2014 at 11:17:32AM +0200, Martin Kletzander wrote:
On Wed, May 14, 2014 at 08:23:21AM +, Wangrui (K) wrote:
Hi,
Libvirt does not support ivshmem(Inter-VM Shared Memory) device recently,
thus, I would like to know if there's any plan to support it in the future?
If n
On Thu, Jul 17, 2014 at 10:02:45PM +0400, Roman Bogorodskiy wrote:
Eric Blake wrote:
On 07/17/2014 10:57 AM, Roman Bogorodskiy wrote:
> Roman Bogorodskiy wrote:
>
>> Looks like this breaks build with clang:
>>
>> gmake[3]: Entering directory `/usr/home/novel/code/libvirt/src'
>> CC
This patch adds back the virDomainDef typedef into domain_conf and
makes all the numatune_conf functions independent of any virDomainDef
definitions.
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 9 +-
src/conf/domain_conf.h | 2 ++
src/conf/numatune_conf.c | 78
On Wed, Jul 16, 2014 at 08:30:02PM +0200, Martin Kletzander wrote:
This eliminates the need for active waiting.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Signed-off-by: Martin Kletzander
---
src/rpc/virnetsocket.c | 58 +-
1
On Tue, Jul 22, 2014 at 01:36:56PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 16, 2014 at 08:29:54PM +0200, Martin Kletzander wrote:
This is complete rework of:
http://www.redhat.com/archives/libvir-list/2013-April/msg01351.html
where Daniel suggested we use systemd-like passing of socket
On Wed, Jul 16, 2014 at 08:29:55PM +0200, Martin Kletzander wrote:
Since not only systemd can do this (we'll be doing it as well few
patches later), change 'systemd' to 'caller' and fix LISTEN_FDS to
LISTEN_PID where applicable.
Signed-off-by: Martin Kletzander
---
Signed-off-by: Martin Kletzander
---
Notes:
pretty late, but pushed as trivial
setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index 4e889da..334d7b2 100755
--- a/setup.py
+++ b/setup.py
@@ -309,7 +309,7 @@ class my_clean(clean):
_c_modules
On Tue, Jul 22, 2014 at 10:19:54PM -0600, Eric Blake wrote:
Introduced in commit 70571ccc. Caught by valgrind:
==9816== 170 (32 direct, 138 indirect) bytes in 1 blocks are definitely lost in
loss record 646 of 821
==9816==at 0x4A081D4: calloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd6
On Tue, Jul 22, 2014 at 10:08:21PM -0600, Eric Blake wrote:
Our seclabel parsing was repeatedly assigning malloc'd data into a
temporary variable, without first freeing the previous use. Among
other leaks flagged by valgrind:
==9312== 8 bytes in 1 blocks are definitely lost in loss record 88 of
On Tue, Jul 22, 2014 at 01:11:03PM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1122205
Although the edits were changing in-memory XML, it was not flushed
to disk; so unless some other action changes XML, a libvirtd restart
would lose the changed information.
And there
On Tue, Jul 22, 2014 at 10:42:29PM -0600, Eric Blake wrote:
Leak introduced in commit 16ebf10f (v1.2.6), detected by valgrind:
==9816== 216 (96 direct, 120 indirect) bytes in 6 blocks are definitely lost in
loss record 665 of 821
==9816==at 0x4A081D4: calloc (in
/usr/lib64/valgrind/vgprelo
On Fri, Jul 18, 2014 at 07:30:38AM -0600, Eric Blake wrote:
On 07/17/2014 10:49 PM, Jincheng Miao wrote:
Implement InitInternal functions for Mutex, RWLock and Cond, these functions
contain error report using virReportSystemErrorFull, it is controlled by
an argument 'quite'.
The related macros a
On Fri, Jul 18, 2014 at 03:23:51PM -0600, Eric Blake wrote:
Commit 5028160 accidentally weakened the strtol prohibitions to
skip ALL files under src/util instead of the former situation of
just protecting util/virsexpr.c; even though NONE of the files
in that directory need any protection.
Short
On Tue, Jul 22, 2014 at 05:11:23PM +0200, Martin Kletzander wrote:
On Tue, Jul 22, 2014 at 01:36:56PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 16, 2014 at 08:29:54PM +0200, Martin Kletzander wrote:
This is complete rework of:
http://www.redhat.com/archives/libvir-list/2013-April/msg01351
On Tue, Jul 01, 2014 at 02:00:56PM -0400, Matthew Rosato wrote:
Currently, there is one flag passed in during macvtap creation
(withTap) -- Let's convert this field to an unsigned int flag
field for future expansion.
Signed-off-by: Matthew Rosato
---
src/lxc/lxc_process.c |2 +-
src/qe
On Wed, Jul 23, 2014 at 06:46:24AM -0600, Eric Blake wrote:
On 07/22/2014 11:09 PM, Martin Kletzander wrote:
On Tue, Jul 22, 2014 at 01:11:03PM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1122205
Although the edits were changing in-memory XML, it was not flushed
to
On Wed, Jul 23, 2014 at 07:01:06AM -0600, Eric Blake wrote:
On 07/23/2014 03:25 AM, Daniel P. Berrange wrote:
We could however use umask() here if you use a virFork() to start a
single threaded process. Set umask, create the socket, and then exit,
allowing the parent to continue.
Similar to
On Tue, Jul 01, 2014 at 02:00:57PM -0400, Matthew Rosato wrote:
Defer MAC registration until net devices are actually going
to be used by the guest. This patch does so by setting the
devices online just before starting guest CPUs.
Does this have some upside/downside? Are you trying to fix so
On Wed, Jul 23, 2014 at 09:58:02AM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1092886
Rather than point off to some nefarious "pool-specific docs" page when
describing the "format" field for the target pool provide a link to the
storage driver page which describes the
Signed-off-by: Martin Kletzander
---
src/locking/lock_daemon.c | 2 +-
src/rpc/virnetserverservice.c | 5 +
src/rpc/virnetserverservice.h | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c
index e9219d5..02d77e3
Since not only systemd can do this (we'll be doing it as well few
patches later), change 'systemd' to 'caller' and fix LISTEN_FDS to
LISTEN_PID where applicable.
Signed-off-by: Martin Kletzander
---
src/libvirt_private.syms | 1 +
src/l
It's just a wrapper around NewFD and NewUNIX that selects the right
option and increments the number of used FDs.
Signed-off-by: Martin Kletzander
---
src/libvirt_remote.syms | 1 +
src/rpc/virnetserverservice.c | 50 ++-
sr
did:
https://www.redhat.com/archives/libvir-list/2014-July/msg00841.html
And now we are even able to start with socket-activation with systemd;
see patch 9/9.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Martin Kletzander (9):
util: abstract parsing of passed FDs into
Signed-off-by: Martin Kletzander
---
tests/commandtest.c | 49 ++---
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 7d2161c..ba823f7 100644
--- a/tests/commandtest.c
+++ b/tests
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander
---
daemon/libvirtd.c | 45 +++--
1 file changed, 27 insertions(+), 18 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon
Even line like this:
int asdf = i - somevar;
was matched by the regex, so this patch adds '=' to the list of
characters that break the regexp.
Signed-off-by: Martin Kletzander
---
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cfg.mk b/cfg.mk
index 0559ed
That sets a new flag, but that flag does mean the child will get
LISTEN_FDS and LISTEN_PID environment variables properly set and
passed FDs reordered so that it corresponds with LISTEN_FDS (they must
start right after STDERR_FILENO).
Signed-off-by: Martin Kletzander
---
src
Signed-off-by: Martin Kletzander
---
.gitignore | 1 +
daemon/Makefile.am | 14 --
daemon/libvirtd.conf | 5 +
daemon/libvirtd.service.in | 5 -
daemon/libvirtd.socket.in | 6 ++
libvirt.spec.in| 26
This eliminates the need for active waiting.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Signed-off-by: Martin Kletzander
---
src/rpc/virnetsocket.c | 102 -
1 file changed, 83 insertions(+), 19 deletions(-)
diff --git a/src/rpc
On Thu, Jul 24, 2014 at 10:17:45AM +0800, Wang Rui wrote:
From: James
virTimeFieldsThenRaw will never return negative result, so I delete related
judgement.
Looking at the code I think it was pretty nicely prepared for error
reporting, but then there was no error that could happen in the
fun
On Wed, Jul 23, 2014 at 09:06:07PM -0600, Eric Blake wrote:
Finding virPCIE* code is more intuitive if located in virpci.h
instead of node_device_conf.h.
* src/conf/node_device_conf.h (virPCIELinkSpeed, virPCIELink)
(virPCIEDeviceInfo): Move...
* src/util/virpci.h: ...here.
* src/conf/node_devic
On Wed, Jul 23, 2014 at 09:06:05PM -0600, Eric Blake wrote:
diff in v2: split out trivial fixes, refactor pcie code to
virpci.h, add proper free function to cover all leaks
Eric Blake (3):
nodedev: let compiler help us on switches
nodedev: move pci express types to virpci.h
nodedev: fix pci e
On Wed, Jul 23, 2014 at 02:03:17PM -0600, Eric Blake wrote:
Ping.
I'm not that skilled in spec files, but if you'd rebase it so it
applies onto current master (with changes from jdenemar), I'd my
convince myself to learn a bit more spec-magic and have a look at
it.
On 07/15/2014 05:31 PM, Er
uld cause weird logs, especially without stacked error
messages (I couldn't resist mentioning it again).
There is no (easy) way of getting the limits from kernel, since it's
not exposed.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1100769
Signed-off-by: Martin Kletzander
On Thu, Jul 24, 2014 at 03:31:53PM +0200, Ján Tomko wrote:
On 07/24/2014 02:03 PM, Martin Kletzander wrote:
This reflects the same change made in kernel commit df457f845e (before
v2.6.38-rc7). On the rare occasion when the user would try setting
the weight to value in range <10, 100) on ol
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=997802
Martin Kletzander (2):
virsh: add error message when no graphical display is found
virsh: add option for selecting domdisplay type
tools/virsh-domain.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion
Signed-off-by: Martin Kletzander
---
tools/virsh-domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index ba47258..4652b7e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -9543,6 +9543,9 @@ cmdDomDisplay(vshControl *ctl
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=997802
Signed-off-by: Martin Kletzander
---
tools/virsh-domain.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 4652b7e..6fcfd9c 100644
--- a
On Thu, Jul 24, 2014 at 09:31:33AM -0400, John Ferlan wrote:
During review of the iSCSI hostdev series, eblake noted that the
prototypes shouldn't have the extranenous space between the "*" and
the function name:
http://www.redhat.com/archives/libvir-list/2014-July/msg01227.html
Since it was mo
On Thu, Jul 24, 2014 at 04:30:43PM +0200, Peter Krempa wrote:
On 07/24/14 16:21, Daniel P. Berrange wrote:
On Thu, Jul 24, 2014 at 02:20:22PM +0200, Peter Krempa wrote:
...
For targetting the RAM module the target element could have the
following format:
"node" determines the guest numa
This was changed before:
https://www.redhat.com/archives/libvir-list/2013-October/msg00525.html
but not everywhere in the code.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1100769
Signed-off-by: Martin Kletzander
---
src/lxc/lxc_driver.c | 14 --
src/qemu
On Fri, Jul 25, 2014 at 04:45:55PM +0800, James wrote:
There's a kind of situation that when libvirtd's under a lot of pressure, just
as we
start a lot of VMs at the same time, some libvirt APIs may take a lot of time
to return.
And this will block the up level job to be finished. Mostly we can
Signed-off-by: Martin Kletzander
---
Notes:
Pushed as trivial
tools/libvirt-guests.sh.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in
index a158b62..1b17bbe 100644
--- a/tools/libvirt-guests.sh.in
+++ b
On Fri, Jul 25, 2014 at 04:13:57PM +0800, James wrote:
virTimeFieldsThenRaw will never return negative result, so I clean up
the related meaningless judgements to make it better.
Signed-off-by: James
---
src/util/virtime.c | 23 ---
src/util/virtime.h | 8
tests/vi
On Fri, Jul 25, 2014 at 03:53:45AM -0400, Li Yang wrote:
Signed-off-by: Li Yang
---
src/libvirt.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
What a funny typo, ACK and pushed, thanks.
diff --git a/src/libvirt.c b/src/libvirt.c
index 79bcdf1..143d319 100644
--- a/src/libvir
There are multiple mount points after commit 725a211f, but one comment
wasn't changed to use plurals.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index a079b93..7b
Le Ping...
On Wed, Jul 23, 2014 at 04:27:04PM +0200, Martin Kletzander wrote:
This started as a fix for virsh 20s timeout of waiting for session
daemon that failed to start:
http://www.redhat.com/archives/libvir-list/2013-April/msg01351.html
Then there was a idea that we can pass some FDs
On Sat, Jul 26, 2014 at 03:47:09PM +0800, James wrote:
On 2014/7/25 18:07, Martin Kletzander wrote:
On Fri, Jul 25, 2014 at 04:45:55PM +0800, James wrote:
There's a kind of situation that when libvirtd's under a lot of pressure, just
as we
start a lot of VMs at the same time, so
On Mon, Aug 04, 2014 at 11:10:45AM -0600, Eric Blake wrote:
Ever since libvirt commit 78c09530, it's easier to just use the
run script.
* README: Mention run script.
Signed-off-by: Eric Blake
---
README | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/README b/README
i
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 8eba8e8..a4a96af 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3456,7 +3456,9 @@ static
On Tue, Aug 05, 2014 at 03:15:18PM +0800, James wrote:
In fact, to deal with this kind of situation, we add some timeout codes in
libvirtd, during remote_dispatch process.
The mechanism is like this:
1. when we call an API, we start a thread to do the timer, when time out, the
timer set a timeo
On Wed, Aug 06, 2014 at 10:44:55AM +0200, Michal Privoznik wrote:
Since commit be0782e1 we are parsing /proc/meminfo to find out the
default huge page size. However, if the host we are running at does
not support any huge pages (e.g. CONFIG_HUGETLB_PAGE is turned off),
we will not successfully pa
On Tue, Aug 05, 2014 at 06:48:01PM +0200, Maxime Leroy wrote:
This patch documents XML elements used for support of ivshmem
devices.
At first, I'd like to thank you for the proposal. There were numerous
requests for this, but since ivshmem is not known much, it's not easy
to get it in. I'll
On Tue, Aug 05, 2014 at 06:48:02PM +0200, Maxime Leroy wrote:
This patch adds configuration support for the ivshmem device
as described in the schema in the previous patch.
Signed-off-by: Maxime Leroy
---
src/conf/domain_conf.c | 234 ++-
src/conf/do
On Thu, Aug 07, 2014 at 08:38:11AM -0600, Eric Blake wrote:
Jiri Moskovcak reported on IRC that the documentation on valid
was confusing because it didn't have unique dev='...'
entries.
* docs/formatdomain.html.in: Use unique names.
Signed-off-by: Eric Blake
---
docs/formatdomain.html.in |
On Thu, Aug 07, 2014 at 10:55:40AM -0400, Laine Stump wrote:
This makes the paragaph about attach-interface more descriptive and
correct, adding in a few bits of information that were previously
missing, e.g. --script is only allowed for bridge interfaces of Xen
domains, target name is regenerate
On Thu, Aug 07, 2014 at 05:34:35PM +0200, Maxime Leroy wrote:
On Thu, Aug 7, 2014 at 12:33 PM, Martin Kletzander wrote:
On Tue, Aug 05, 2014 at 06:48:01PM +0200, Maxime Leroy wrote:
This patch documents XML elements used for support of ivshmem
devices.
At first, I'd like to thank yo
1 - 100 of 5798 matches
Mail list logo
