[libvirt] [PATCH 0/7 RFC] RHEL-5 support, and a few preparatory fixes

2008-12-23 Thread Markus Armbruster
This patch series attempts to make libvirt just work on RHEL-5. Right now it doesn't, mostly because libvirt relies on version number checks in a couple of places, and RHEL-5's version numbers aren't the whole truth due to various backports of later stuff. The first two patches are plain bug fixe

[libvirt] [PATCH 4/7] Fix HVM network device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
Omit (type ioemu) on RHEL-5, because it breaks PV drivers on HVM there. Signed-off-by: Markus Armbruster --- src/xend_internal.c |8 +++- src/xm_internal.c |8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/xend_internal.c b/src/xend_internal.c index

[libvirt] [PATCH 5/7] Fix PVFB device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
PVFB configuration depends on the version. The version number check doesn't work for RHEL-5 because its PVFB device was backported from later versions. Special-case it. Signed-off-by: Markus Armbruster --- src/xend_internal.c |6 -- src/xm_internal.c |4 +++- 2 files chang

[libvirt] [PATCH 2/7] Fix graphics configuration inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() generates old-style HVM graphics configuration when xendConfigVersion is below 4. xenXMDomainConfigFormat() does that always. Change it to make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster --- src/xm_internal.c |2 +- 1 files changed, 1

[libvirt] [PATCH 1/7] Fix network device inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() adds (type ioemu) only if xendConfigVersion < 4. xenXMDomainConfigFormatNet() adds type=ioemu always. Change it make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster --- src/xm_internal.c |3 ++- 1 files changed, 2 insertions(+), 1 deleti

[libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-23 Thread Markus Armbruster
RHEL-5 has a peculiar version of Xen, which requires some special casing. Add a configure option for that. It will be used in later commits. Signed-off-by: Markus Armbruster --- configure.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure.in b

[libvirt] [PATCH 7/7] Don't treat missing topology information as error

2008-12-23 Thread Markus Armbruster
ned-off-by: Markus Armbruster --- src/xend_internal.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/xend_internal.c b/src/xend_internal.c index 9b9f98d..096e22f 100644 --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -2546,6 +2546,8 @@ sexpr_to_xend

[libvirt] [PATCH 6/7] Enable NUMA support for RHEL-5

2008-12-23 Thread Markus Armbruster
RHEL-5 supports NUMA since 5.2. Relax the version number checks. This breaks older versions, which will be fixed in the next commit. Signed-off-by: Markus Armbruster --- src/xen_internal.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/xen_internal.c b

Re: [libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-24 Thread Markus Armbruster
John Levon writes: > On Tue, Dec 23, 2008 at 04:05:13PM +0100, Markus Armbruster wrote: > >> RHEL-5 has a peculiar version of Xen, which requires some special >> casing. Add a configure option for that. It will be used in later >> commits. > > Ugh, shouldn'

Re: [libvirt] [PATCH 4/7] Fix HVM network device configuration for RHEL-5

2009-01-19 Thread Markus Armbruster
Daniel Veillard writes: > On Tue, Dec 23, 2008 at 04:05:14PM +0100, Markus Armbruster wrote: >> Omit (type ioemu) on RHEL-5, because it breaks PV drivers on HVM >> there. >> >> Signed-off-by: Markus Armbruster > > > &

[libvirt] [PATCH] COW storage volume compile fix

2009-02-02 Thread Markus Armbruster
Commit 2d4381d0 broke compilation for !HAVE_QEMU_IMG && HAVE_QCOW_CREATE. Fix that. Signed-off-by: Markus Armbruster --- Compile-tested only. diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c index 345dc40..0280c45 100644 --- a/src/storage_backend_fs.c +

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Markus Armbruster
Anthony Liguori writes: > On 03/23/2010 06:25 PM, Jamie Lokier wrote: >> Alexander Graf wrote: >> >>> I don't see why we shouldn't be able to automatically generate >>> libqemu.so. We have the *.hx files that describe the syntax of >>> parameters plus list all available options / commands. I'

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Markus Armbruster
't support multiple instances. For instance: commit 39a51dfda835a75c0ebbfd92705b96e4de77f795 Author: Markus Armbruster Date: Tue Oct 27 13:52:13 2009 +0100 qdev: Tag isa-fdc, PIIX3 IDE and PIIX4 IDE as no-user These devices are created automatically, and attem

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Markus Armbruster
Anthony Liguori writes: > On 03/25/2010 07:37 AM, Avi Kivity wrote: >> On 03/25/2010 02:33 PM, Anthony Liguori wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily available in >>

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-26 Thread Markus Armbruster
Anthony Liguori writes: > On 03/25/2010 11:50 AM, Markus Armbruster wrote: >> >>> The point is, C is a lowest common denominator and it's important to >>> support in a proper way. >>> >> No. The lowest truly common denominator is plain tex

[Libvir] has no effect

2007-11-14 Thread Markus Armbruster
Looks like within has no effect. I ran virsh dumpxml, inserted the , redefined the domain, and ran virsh dumpxml again. No shareable. I even ran virsh undefine and virsh define again, same thing. XML and output of xm list --long for this guest attached. rhel5pv 49a0c6ffc066539264983632d

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-01 Thread Markus Armbruster
Cc'ing libvirt following Stefan's lead. Benoît Canet writes: > Hi, > > I collected some items of a cloud provider wishlist regarding I/O accouting. Feedback from real power-users, lovely! > In a cloud I/O accouting can have 3 purpose: billing, helping the customers > and doing metrology to hel

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-01 Thread Markus Armbruster
Benoît Canet writes: > The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : >> Cc'ing libvirt following Stefan's lead. >> >> Benoît Canet writes: >> >> > Hi, >> > >> > I collected some items of a cloud provider w

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: >> To use virtio-serial device, unix socket created for chardev with >> default umask(022) has insufficient permissions. >> >> e.g. start kvm guest with: >> -device virtio-serial \ >> -chardev socket,path

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-02 Thread Markus Armbruster
Benoît Canet writes: > The Monday 01 Sep 2014 à 13:41:01 (+0200), Markus Armbruster wrote : >> Benoît Canet writes: >> >> > The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : [...] >> >> A quick stab at tasks: >> >> >>

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-08 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: >> Benoît Canet writes: >> >> > The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : >> >> Cc'ing libvirt following Stefan's lead. >> >>

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: >> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: >> > Add a configure option --enable-pc-1-0-qemu-kvm and the >> > corresponding --disable-pc-1-0-qemu-kvm, defaulting >> > to disabled.

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: >> Add a configure option --enable-pc-1-0-qemu-kvm and the >> corresponding --disable-pc-1-0-qemu-kvm, defaulting >> to disabled. >> >> Rename machine type pc-1.0 to pc-1.0-qemu-git. >> >> Make pc-1.0 mac

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Alex Bligh writes: > On 22 Sep 2014, at 16:45, Andreas Färber wrote: > >> What about adding a bool property "qemu-kvm-compat" to the MachineClass? >> Then a qemu-kvm shell script (like SUSE uses) can pass -global >> machine.qemu-kvm-compat=on whereas qemu-system-x86_64 would run in the No need

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-23 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: >> >> Add a configure option --enable-pc

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-24 Thread Markus Armbruster
Alex Bligh writes: > This patch series adds inbound migrate capability from qemu-kvm version > 1.0. The main ideas are those set out in Cole Robinson's patch here: > http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 > however, rather than patching stati

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu writes: > For ARM platform, we still do not have any interface to query > whether current QEMU/host support specific GIC version. This > patchset is trying to add one QMP interface for that. By querying > the GIC capability using the new interface, one should know exactly > what GIC vers

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu writes: > On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >> Peter Xu writes: >> >> > For ARM platform, we still do not have any interface to query >> > whether current QEMU/host support specific GIC version. This >> > patch

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Maydell writes: > On 15 February 2016 at 15:08, Markus Armbruster wrote: >> Peter Xu writes: >>> On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >>>> Peter Xu writes: >>>> Adding ad hoc queries as we go won't scale.

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Markus Armbruster
Peter Maydell writes: > On 15 February 2016 at 20:18, Andrew Jones wrote: >> On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: >>> How would the command line look like? >>> >> >> Here is what is available today >> >> # se

Re: [libvirt] [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently)

2015-06-08 Thread Markus Armbruster
Laszlo Ersek writes: > On 06/05/15 23:47, Eric Blake wrote: >> On 06/05/2015 03:42 PM, Laszlo Ersek wrote: >> >>> I found this qemu commit, ie. >>> >>> commit 65207c59d99f2260c5f1d3b9c491146616a522aa >>> Author: Markus Armbruster >>&g

Re: [libvirt] [Qemu-devel] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats

2014-05-15 Thread Markus Armbruster
Copying Luiz... Eric Blake writes: > On 05/15/2014 01:22 AM, Ján Tomko wrote: >> If virDomainMemoryStats is called too soon after domain startup, >> QEMU returns: >> "error":{"class":"GenericError","desc":"guest hasn't updated any stats yet"} >> when we try to query balloon stats. >> >> Check f

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

2014-05-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 23 May 2014 00:50:38 -0300 > Marcelo Tosatti wrote: > >> > Then the guest triggers an RTC update, so qemu sends an event, but the >> > event is lost. Then libvirtd starts again, and doesn't realize the >> > event is lost. >> >> Yes, but that case is also true f

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Markus Armbruster
Alex Bligh writes: [...] >>> +/* NB cirrus-vga default value is 8MB anyway, save if we >>> + * monkey patch it to change the default when the qemu-kvm-migration >>> + * machine parameter is selected >>> + */ >>> + >> >> This is too hacky for my taste. >> How about creating a new machine e.g. pc-

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: >> > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: >> > > Hi all, >> > > >> > > (added rjones from nbdkit fame -

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-10-21 Thread Markus Armbruster
Wouter Verhelst writes: > On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: >> >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M.

Re: [libvirt] [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/21/2014 12:10 AM, Gonglei wrote: > > There is a problem. > > 1. Qemu receive the "eject" command. > 2. Runs "eject_request_cb" when an eject request is issued from > the monitor, the tray > is closed, and the medium is locked. But the drive is no

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Markus Armbruster
Eduardo Habkost writes: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are p

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional fields: "runnable" and "unavailable-features". >> > "runnable" will tell if

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-11 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: >> >>

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-12 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, May 11, 2016 at 09:11:33AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >

Re: [libvirt] [Qemu-devel] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Markus Armbruster
Laine Stump writes: > On 10/15/2012 05:25 AM, Daniel P. Berrange wrote: >> On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: >>> On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it with

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.08.2012 09:20, schrieb Kevin Shanahan: >> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: > Set the block driver

Re: [libvirt] [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
ronnie sahlberg writes: > Since pretty much every cdrom drive use scsi today, shouldnt the > readonly/writeable flag for MMC devices rather > be done down in the hw/scsi* code rather than the generic block code? There are two separate things that can be read-only: device models and BlockDriverS

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.08.2012 04:48, schrieb Kevin Shanahan: >> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to >> try and open the backing file read only, which uses the ->read_only >> member of struct BlockDriverState to decide whether to pass the >> BDRV_O_RDRW flag to

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-29 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Aug 17, 2018 at 03:13:22PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: >> >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Be

Re: [libvirt] [Qemu-devel] [QEMU PATCH] net: Deprecate the old way of using a legacy net via "name" instead of "id"

2018-09-19 Thread Markus Armbruster
Thomas Huth writes: > In early times, network backends were specified by a "vlan" and "name" > tuple. With the introduction of netdevs, the "name" was replaced by an > "id" (which is supposed to be unique), but the "name" parameter stayed > as an alias which could be used instead of "id". Unfortu

Re: [libvirt] [Qemu-devel] [PATCH v2 4/4] hw/core/machine: Officially deprecate the enforce-config-section parameter

2018-09-20 Thread Markus Armbruster
Thomas Huth writes: > Commit 16f7244842b5135543ef068a1adafd94c6965953 added this parameter > to the documentation, including a note that it is deprecated. But it > has never been added to the "Deprecated features" appendix, which is > our official way to deprecate legacy parameters. So let's do t

Re: [libvirt] [Qemu-devel] [PATCH v2 1/4] Makefile: Add missing dependency for qemu-deprecated.texi

2018-09-20 Thread Markus Armbruster
\ > docs/qemu-cpu-models.texi Thanks for cleaning up the minor mess I made. Reviewed-by: Markus Armbruster -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH v2 3/4] net/slirp: Deprecate the [hub_id name] parameter tuple

2018-09-20 Thread Markus Armbruster
ing "vlans" only and when it did > not use unique "id"s yet). > > Signed-off-by: Thomas Huth Reviewed-by: Markus Armbruster -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] net: Deprecate the "name" parameter of -net

2018-09-20 Thread Markus Armbruster
aving it that way for a little longer is okay. > rather get rid of this old interface and deprecate the "name" parameter > now - this will also be less confusing for the users in the long run. > > Signed-off-by: Thomas Huth Reviewed-by: Markus Armbruster -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [QEMU PATCH] net: Deprecate the old way of using a legacy net via "name" instead of "id"

2018-09-21 Thread Markus Armbruster
Thomas Huth writes: > On 2018-09-20 08:07, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> In early times, network backends were specified by a "vlan" and "name" >>> tuple. With the introduction of netdevs, the "name" was re

Re: [libvirt] [Qemu-devel] [PATCH v4 2/4] block/rbd: Attempt to parse legacy filenames

2018-09-21 Thread Markus Armbruster
Jeff Cody writes: > When we converted rbd to get rid of the older key/value-centric > encoding format, we broke compatibility with image files with backing > file strings encoded in the old format. > > This leaves a bit of an ugly conundrum, and a hacky solution. > > If the initial attempt to par

Re: [libvirt] [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2018-10-09 Thread Markus Armbruster
Cc: libvir-list for review of the compatibility argument below. Daniel Henrique Barboza writes: > Hey David, > > On 9/21/18 9:29 AM, Dr. David Alan Gilbert wrote: >> * Daniel Henrique Barboza (danielhb...@gmail.com) wrote: >>> changes in v2: >>> - removed the "RFC" marker; >>> - added a new patc

Re: [libvirt] [Qemu-devel] [PULL 00/45] Machine queue, 2018-10-18

2018-10-22 Thread Markus Armbruster
d8e1bcc7dd5e819ce81e6a87fffe23e39c700cc: >> > > > > >> > > > > numa: Clean up error reporting in parse_numa() (2018-10-17 >> > > > > 16:33:40 -0300) >> > > > > >> > > > > ---

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-18 Thread Markus Armbruster
Cc'ing a few more people. Daniel Henrique Barboza writes: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: >> >> >> On 05/21/2018 03:14 PM, Eduardo Habkost wrote: >> > > Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's >> > > not even a property of the machine type. If it was,

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: > [...] >> >> Since no objection was made back then, this logic

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> > On Mon

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-28 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, May 25, 2018 at 08:30:59AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: > [...] >> >> >> Worse, a machine type property that is static f

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-06-20 Thread Markus Armbruster
Daniel Henrique Barboza writes: > Hi, > > Sorry for the delay. I'll summarize what I've understood from the discussion > so far: > > - query-target is the wrong place for this flag. query-machines is > (less) wrong > because it is not a static property of the machine object > > - a new "query-cur

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >> > The -drive option serial was deprecated in QEMU 2.10. It's time to >> > remove it. >> > >> > Tests need to be updated to set the serial number with -global ins

Re: [libvirt] Configuring pflash devices for OVMF firmware

2019-02-07 Thread Markus Armbruster
The thread got long, let me try to summarize, and elaborate a few points. * The problem at hand is configuring firmware residing in flash memory (OVMF requires this) without legacy -drive. * The wider problem is configuring onboard devices. Our general device configuration interface doesn't

Re: [libvirt] [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema

2019-02-07 Thread Markus Armbruster
Peter Krempa writes: > On Wed, Feb 06, 2019 at 12:42:05 -0600, Eric Blake wrote: >> Adding libvirt in cc >> >> On 2/6/19 12:17 PM, Markus Armbruster wrote: >> > query-events doesn't reflect compile-time configuration. Instead of >> > fixing that,

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-02-07 Thread Markus Armbruster
Laszlo Ersek writes: > Hi Markus, > > On 02/07/19 10:30, Markus Armbruster wrote: >> The thread got long, let me try to summarize, and elaborate a few >> points. >> >> * The problem at hand is configuring firmware residing in flash memory >> (OV

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-02-22 Thread Markus Armbruster
The other day, I described how my attempt to implement Paolo's suggestion to add block properties to the machine ran into difficulties. To recap briefly, creating devices within a machine's .instance_init() crashes. Turns out device_post_init() calls qdev_get_machine(), which calls container_get()

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-02-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/01/19 15:13, Markus Armbruster wrote: >> -global driver=cfi.pflash01,property=secure,value=on >> >> Affects *all* such devices, but fortunately we have at most two, and the >> one we don't want to affect happens to ignore the

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Mar 01, 2019 at 06:33:28PM +0100, Igor Mammedov wrote: >> On Fri, 1 Mar 2019 15:49:47 + >> Daniel P. Berrangé wrote: >> >> > On Fri, Mar 01, 2019 at 04:42:15PM +0100, Igor Mammedov wrote: >> > > The parameter allows to configure fake NUMA topology where

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Mar 04, 2019 at 08:13:53AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Mar 01, 2019 at 06:33:28PM +0100, Igor Mammedov wrote: >> >> On Fri, 1 Mar 2019 15:49:47 + >> >>

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Mar 04, 2019 at 12:45:14PM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Mar 04, 2019 at 08:13:53AM +0100, Markus Armbruster wrote: >> >> If we deprecate outdated NUMA configurations no

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 06, 2019 at 08:03:48PM +0100, Igor Mammedov wrote: >> On Mon, 4 Mar 2019 16:35:16 + >> Daniel P. Berrangé wrote: >> >> > On Mon, Mar 04, 2019 at 05:20:13PM +0100, Michal Privoznik wrote: >> > > We couldn't have done that. How we would migrate from ol

Re: [libvirt] [Qemu-devel] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-15 Thread Markus Armbruster
Pavel Hrdina writes: > On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote: >> From: Kővágó, Zoltán >> >> Audio drivers now get an Audiodev * as config paramters, instead of the >> global audio_option structs. There is some code in audio/audio_legacy.c >> that converts the old enviro

[libvirt] Evolve or go extinct (was: [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.)

2019-03-19 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: >> On Thu, 7 Mar 2019 10:07:05 + >> Daniel P. Berrangé wrote: >> >> > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote: >> > > On Wed, 6 Mar 2019 18:16:08 + >> > > Daniel P. Berrangé

Re: [libvirt] [Qemu-devel] Evolve or go extinct

2019-03-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 20, 2019 at 07:46:33AM +0100, Markus Armbruster wrote: >> We're going in circles. Igor keeps telling you QEMU needs to shed dead >> weight, badly. In Igor's words: >> >> We really need to figure ou

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-08 Thread Markus Armbruster
Peter Maydell writes: > On 6 July 2018 at 15:56, Kevin Wolf wrote: >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >>> That way, we can still easily remove old cruft (case (a)), but still >>> accommodate cases like this (case (c)). The obvious drawback is that >>> we'd need someone to c

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Jul 06, 2018 at 16:56:46 +0200, Kevin Wolf wrote: >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> > On Wed, 4 Jul 2018 17:14:02 +0100 >> > Peter Maydell wrote: >> > >> > > On 4 July 2018 at 14:34, Kevin Wolf wrote: >> > > > Essentially, what is import

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jul 09, 2018 at 01:08:38PM +0200, Cornelia Huck wrote: >> On Mon, 09 Jul 2018 08:33:05 +0200 >> Markus Armbruster wrote: >> >> > Peter Maydell writes: >> > >> > > On 6 July 2018 at 15:56, Kevin Wolf w

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >> On Tue, 10 Jul 2018 07:59:15 +0200 >> Markus Armbruster wrote: >> >> > In addition to actively pulling libvirt developers into review of >> > deprecation patches, we should

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Markus Armbruster
ote: >>>>> On Tue, 10 Jul 2018 07:59:15 +0200 >>>>> Markus Armbruster wrote: >> >> [...] >> >>>>> "ERROR: 'old_option' is deprecated and will be removed; use >>>>> 'modern_option' instead" &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >>> On Tue, 10 Jul 2018 07:59:15 +0200 >>> Markus Armbruster wrote: >>> >>> > In addition to actively pulling libvirt developers into re

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> On Tue, 10 Jul 2018 16:39:31 +0200 >> Peter Krempa wrote: >> > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: >> > > On Tue, 10 Jul 2018 07:59:15 +

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Cornelia Huck writes: > On Thu, 12 Jul 2018 08:51:16 +0200 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >> > Kevin Wolf writes: >> > >> >> I think the function should just take a message: >> >> >> >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Jul 12, 2018 at 08:38:25 +0200, Markus Armbruster wrote: >> Kevin Wolf writes: >> > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >> >> On Tue, 10 Jul 2018 07:59:15 +0200 >> >> Markus Armbruster wrote: >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Jul 12, 2018 at 08:59:44 +0200, Markus Armbruster wrote: >> Peter Krempa writes: >> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> >> On Tue, 10 Jul 2018 16:39:31 +0200 >> >> Peter Krempa wrote: >

[libvirt] [PATCH 1/2] qemu-doc: Move appendix "Deprecated features" to its own file

2018-07-16 Thread Markus Armbruster
Deprecated features/,/@node Supported build platforms/:qemu-doc.texi'" * It lets us use MAINTAINERS to copy interested parties on deprecation patches, so they can advise or object before they're a done deal. The next commit will do that for libvirt. Signed-off-by: Mar

[libvirt] [PATCH 0/2] Make it easier to track feature deprecation

2018-07-16 Thread Markus Armbruster
Markus Armbruster (2): qemu-doc: Move appendix "Deprecated features" to its own file MAINTAINERS: New section "Incompatible changes", copy libvir-list MAINTAINERS | 4 + qemu-deprecated.texi | 234 ++ qemu-d

[libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list

2018-07-16 Thread Markus Armbruster
Libvirt developers would like to be copied on patches to qemu-doc appendix "Deprecated features". Do them the favor. Signed-off-by: Markus Armbruster --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20eef3cb61..666e936812 10

Re: [libvirt] [Qemu-devel] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list

2018-07-16 Thread Markus Armbruster
Cornelia Huck writes: > On Mon, 16 Jul 2018 09:54:12 +0200 > Thomas Huth wrote: > >> On 16.07.2018 09:32, Markus Armbruster wrote: >> > Libvirt developers would like to be copied on patches to qemu-doc >> > appendix "Deprecated features". Do them

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: >> > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote: >> > > 5) Some guest OSes that we still want to support (and which would

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: >> On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: >> > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: >> > > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: >>

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Aug 23, 2018 at 05:26:47PM +0100, Daniel P. Berrangé wrote: > [...] >> There are countless mistakes in both QEMU & libvirt, but only some of >> them are worth the cost of changing. Agreed. >> I'm not seeing a compelling reas

Re: [libvirt] [Qemu-devel] [QEMU PATCH] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

2018-12-18 Thread Markus Armbruster
Thomas Huth writes: > It's been marked as deprecated in QEMU v2.6.0 already, so really nobody > should use the legacy "ivshmem" device anymore (but use ivshmem-plain or > ivshmem-doorbell instead). Time to remove the deprecated device now. > > Signed-off-by: Thomas Huth > --- > docs/specs/ivshm

Re: [libvirt] [Qemu-devel] [QEMU PATCH] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

2018-12-18 Thread Markus Armbruster
Thomas Huth writes: > On 2018-12-18 18:50, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> It's been marked as deprecated in QEMU v2.6.0 already, so really nobody >>> should use the legacy "ivshmem" device anymore (but use ivshmem-plain

[libvirt] Configuring pflash devices for OVMF firmware

2019-01-25 Thread Markus Armbruster
We configure OVMF firmware for PC machine types with -drive if=pflash. This is pretty much the last remaining use of -drive in libvirt we can't yet replace by -blockdev. Such a replacement is desirable, because -blockdev + -device is more flexible than -drive if=pflash. Also, once we don't need -

Re: [libvirt] [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: [...] >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than >> 'scsi-disk'? > > Yes, scsi-disk is a legacy device. Maybe we should formally deprecate > it. There's an internal use in scsi_bus_legacy_add_drive(

Re: [libvirt] [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.01.2019 um 17:55 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: >> [...] >> >> 2) Is actually using 'scsi-cd'/'scsi-hd' the bette

Re: [libvirt] [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id

2019-01-29 Thread Markus Armbruster
Kevin Wolf writes: > scsi-disk includes in the Device Identification VPD page, depending on > configuration amongst others, a vendor specific designator that consists > either of the serial number if given or the BlockBackend name (which is > a host detail that better shouldn't have been leaked t

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-29 Thread Markus Armbruster
: > On Fri, 25 Jan 2019 at 15:11, Markus Armbruster wrote: [...] >> To solve (2), we first have to understand the magic. Device >> cfi.pflash01 has the following properties: >> >> num-blocks Size of the device in

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-29 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 28 Jan 2019 at 12:40, Gerd Hoffmann wrote: >> The tricky part is the access control here. On physical hardware you >> typically have one flash rom, say 16M below 4G (on x86). >> >> Our pflash device doesn't allow to define multiple regions, so we use >> multiple

Re: [libvirt] [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-30 Thread Markus Armbruster
Cc: Paolo for additonal device infrastructure expertise. Peter Maydell writes: > On Fri, 25 Jan 2019 at 15:11, Markus Armbruster wrote: >> (1) cfi.pflash01 isn't available with -device. >> >> (2) "Magic board code picks up the backend [created for -drive >&g

  1   2   3   4   5   6   >