On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote:
> On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote:
> > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote:
> > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote:
> > >
> > &
On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote:
> On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote:
> > > On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote:
> > &g
On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote:
> On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote:
> > On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote:
> > >
On Tue, Aug 28, 2018 at 03:41:26PM +0200, Ján Tomko wrote:
> On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote:
> > > On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote:
> > > >
On Tue, Aug 28, 2018 at 04:10:53PM +0200, Erik Skultety wrote:
> On Tue, Aug 28, 2018 at 03:52:56PM +0200, Ján Tomko wrote:
> > On Tue, Aug 28, 2018 at 02:46:08PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 28, 2018 at 03:41:26PM +0200, Ján Tomko wrote:
> > > >
On Tue, Aug 28, 2018 at 11:39:22PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Learn to accept "vhost-user" model type:
>
>
>
The model element's purpose is to indicate the guest device type.
'vhost-user' is a host backend, not a new guest device type, so
t
On Tue, Aug 28, 2018 at 11:39:28PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Similar to the qemu_tpm.c, add a unit with a few functions to
> start/stop and setup the cgroup of the external vhost-user-gpu
> process. See function documentation.
>
> Signed-off-by: Marc
On Tue, Aug 28, 2018 at 11:39:20PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add a new memoryBacking source type "memfd", support by QEMU (when the
> capability is available).
>
> Sealing is enabled by default in qemu, and hugepage is easier to
> setup, which makes
, there is still one possible path where
> users can sneak in change: migration XML.
>
> Signed-off-by: Michal Privoznik
> ---
> src/conf/domain_conf.c | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Daniel P. Berrangé
>
> diff --git a/src/conf/domain_conf.c
On Thu, Aug 30, 2018 at 02:09:41PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> With qemu <= 3.0, when using "-seccomp on", the seccomp policy is only
> applied to the main thread, the vcpu worker thread and other worker
> threads created after seccomp policy is applied
On Thu, Aug 30, 2018 at 02:37:48PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 30, 2018 at 2:25 PM, Ján Tomko wrote:
> > On Thu, Aug 30, 2018 at 02:09:41PM +0200, marcandre.lur...@redhat.com wrote:
> >>
> >> From: Marc-André Lureau
> >>
> >> With qemu <= 3.0, when using "-seccomp on", t
On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote:
> On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > > Use preferred name: 'xen'.
> >
> > I'd be fine with this change if the actual code used the
On Thu, Aug 30, 2018 at 11:06:07AM -0400, John Ferlan wrote:
> Similar to nwfilterDefineXML, let's be sure the a filter binding
> creation is not attempted in session mode and generate the proper
> error message.
>
> Failure to open nwfilter in session mode (nwfilterConnectOpen)
> fails already, b
an
> ---
> src/conf/domain_nwfilter.c | 22 +++++++---
> 1 file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
On Thu, Aug 30, 2018 at 12:50:09PM -0400, John Ferlan wrote:
>
>
> On 08/30/2018 12:27 PM, Daniel P. Berrangé wrote:
> > On Thu, Aug 30, 2018 at 11:06:07AM -0400, John Ferlan wrote:
> >> Similar to nwfilterDefineXML, let's be sure the a filter binding
> >>
On Tue, Aug 28, 2018 at 12:22:51PM +0200, Ján Tomko wrote:
> Give the testing function access to the test name instead of only
> passing it to virTestRun.
>
> Signed-off-by: Ján Tomko
> ---
> tests/virjsontest.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
jsontest.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :
On Tue, Aug 28, 2018 at 12:22:53PM +0200, Ján Tomko wrote:
> Instead of printing the whole JSON in error messages,
> print just the test name.
>
> Signed-off-by: Ján Tomko
> ---
> tests/virjsontest.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
On Tue, Aug 28, 2018 at 12:22:54PM +0200, Ján Tomko wrote:
> We expect to get numbers as big as ULLONG_MAX from QEMU,
> add a test for them.
>
> Signed-off-by: Ján Tomko
> ---
> tests/virjsontest.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Daniel P. Berra
On Tue, Aug 28, 2018 at 12:22:55PM +0200, Ján Tomko wrote:
> Test that we correctly accept 64-bit unsigned numbers for QEMU.
>
> Signed-off-by: Ján Tomko
> ---
> tests/qemumonitorjsontest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. B
The result of libssh2_userauth_password is being assigned to 'ret' in
one branch and 'rc' in the other branch. Checks are all done against the
'ret' variable, so one branch never does the correct check.
Signed-off-by: Daniel P. Berrangé
---
src/rpc/virnetsshses
On Mon, Aug 27, 2018 at 10:08:13AM +0200, Michal Privoznik wrote:
> v3 of:
>
> https://www.redhat.com/archives/libvir-list/2018-August/msg00814.html
>
> What has changed since v2? A lot.
> - The lock manager was moved into security manager (which requires a lot
> of preparation which is done in
On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote:
> It's a better fit than domain_conf.
>
> Unfortunately, even after this change functions
> handling virPCIDeviceAddress are split pretty much
> evenly between conf/device_conf and utils/virpci:
> ideally everything would be moved t
On Fri, Aug 31, 2018 at 04:16:45PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-08-31 at 11:15 +0100, Daniel P. Berrangé wrote:
> > The result of libssh2_userauth_password is being assigned to 'ret' in
> > one branch and 'rc' in the other branch. Checks are all
On Fri, Aug 31, 2018 at 04:25:25PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-08-31 at 15:05 +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote:
> > > Unfortunately, even after this change functions
> > > handling vi
On Mon, Sep 03, 2018 at 12:09:42PM +0200, Ján Tomko wrote:
> On Mon, Sep 03, 2018 at 10:04:16AM +0200, Michal Prívozník wrote:
> > On 09/03/2018 09:38 AM, Povilas Kanapickas wrote:
> > > Hi!
> > >
> > > The online virsh command reference at [1] seems to be very out of date
> > > according to [2].
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
tests/vshtabletest.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/vshtabletest.c b/tests/vshtabletest.c
index 9e9c045226..1138e34161 100644
--- a/tests/vshtabletest.c
+++ b/tests/vshtabletest.c
@@ -21,6 +21,
If no JSON parser is available qemublocktest fails, so skip its execution.
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix for platforms without JSON parser installed
tests/qemublocktest.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions
On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote:
> > If no JSON parser is available qemublocktest fails, so skip its execution.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> &g
On Tue, Sep 04, 2018 at 02:10:56PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote:
> > > > Pushed as a build fix for platforms without JSON parser installed
> > >
> > > Which platforms? All machines in our CI en
The test driver provides a default storage pool at
/default-pool. Libvirt now enforces source path uniqueness, so we must
pick a different path for our test pools.
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
connect_test.go | 6 +++---
storage_pool_test.go | 2 +-
2 files
The path /default-pool is used by a predefined storage pool in the test
driver, and libvirt now enforces pool source uniqueness.
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
t/400-storage-pools.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/400-storage
On Tue, Sep 04, 2018 at 04:57:42PM +0200, Simon Kobyda wrote:
> On Tue, 2018-09-04 at 11:30 +0100, Daniel P. Berrangé wrote:
> > The expected output strings from the vshtabletest.c are created on a
> > modern Linux host where unicode printing support is very good. On
> > olde
| 9 +
> 2 files changed, 26 insertions(+), 7 deletions(-)
After chatting with one of the Fedora team about this, we
came to conclusion there's no nicer option right now, so
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.
On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
> Right now in virt-manager we only track a VM's OS name (win10, fedora28,
> etc.) during the VM install phase. This piece of data is important
> post-install though: if the user adds a new disk to the VM later, we want to
> be able to
On Wed, Sep 05, 2018 at 10:25:12AM +0200, Michal Privoznik wrote:
> There are two macros ("BuildRoot" and "defattr") that were
> required in RHEL-5 world. Things are different now and we do not
> need to specify those anymore.
>
> Signed-off-by: Michal Privoznik
> ---
> libvirt-snmp.spec.in | 5
On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote:
> On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
> > > Right now in virt-manager we only track a VM's OS name (win
On Fri, Sep 07, 2018 at 04:26:50PM +0200, Martin Kletzander wrote:
> On Thu, Sep 06, 2018 at 10:04:35AM -0400, Cole Robinson wrote:
> > On 09/06/2018 09:04 AM, Martin Kletzander wrote:
> > > On Wed, Sep 05, 2018 at 03:37:22PM +0100, Daniel P. Berrangé wrote:
> > > >
On Tue, Oct 02, 2018 at 04:43:01PM +0200, Peter Krempa wrote:
> On Tue, Oct 02, 2018 at 16:14:44 +0200, Andrea Bolognani wrote:
> > In this case we want to deprecate the API wholesale, so we
> > can simply report a warning in the public entry point.
> >
> > Signed-off-by: Andrea Bolognani
> > ---
On Thu, Oct 04, 2018 at 01:38:33PM +0200, Andrea Bolognani wrote:
> GTK+ does it, Qt does it; and I'm willing to bet there are more
> applications linking against either of them than there are linking
> against libvirt.
I don't think that's a positive example. As a developer who has
used GTK for m
On Tue, Oct 02, 2018 at 06:26:12PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-10-02 at 17:19 +0200, Peter Krempa wrote:
> > On Tue, Oct 02, 2018 at 16:14:39 +0200, Andrea Bolognani wrote:
> [...]
> > > Two concrete examples are considered here: one is the
> > > virConnectNumOfDomains() API which
On Thu, Oct 04, 2018 at 04:08:31PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-10-04 at 14:02 +0100, Daniel P. Berrangé wrote:
> > On Thu, Oct 04, 2018 at 01:38:33PM +0200, Andrea Bolognani wrote:
> > > GTK+ does it, Qt does it; and I'm willing to bet there are more
>
On Thu, Oct 04, 2018 at 04:49:43PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-10-04 at 14:13 +0100, Daniel P. Berrangé wrote:
> > I think we're largely missing the bigger picture here. Configuring
> > guests, and using libvirt APIs in general, can be very complicated.
>
On Fri, Oct 05, 2018 at 04:11:45PM +0800, Shi Lei wrote:
> This patch replaces those 'my varname;' with 'our varname;', i.e.
> it uses global var, rather than passing arguments to subroutine.
> So it can be a bit faster.
NACK
Use of global variables like this is harmful to maintenance of
the code
On Fri, Oct 05, 2018 at 04:11:23PM +0800, Shi Lei wrote:
> This series is batch(II) and it continues to fix misaligned arguments and
> misaligned
> conditions in src directory. The batch I:
> https://www.redhat.com/archives/libvir-list/2018-September/msg00888.html
> In addition to fix misaligned s
On Fri, Oct 05, 2018 at 10:34:33AM +0200, Jiri Denemark wrote:
> On Thu, Oct 04, 2018 at 14:13:41 +0100, Daniel P. Berrangé wrote:
> > The problem with saying applications were doing it "wrong" is that
> > this definition of "wrong" changes. Applications
On Fri, Oct 05, 2018 at 11:11:28AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-10-05 at 09:31 +0100, Daniel P. Berrangé wrote:
> > I've looked at clang-format before and it is pretty good. It does not
> > have ability to quite match our code style, but I don't thin
On Fri, Oct 05, 2018 at 11:38:14AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-10-05 at 09:54 +0100, Daniel P. Berrangé wrote:
> > On Fri, Oct 05, 2018 at 10:34:33AM +0200, Jiri Denemark wrote:
> > > But what if QEMU (or any other hypervisor) marks something (device
> > &
On Fri, Oct 05, 2018 at 12:33:57PM +0200, Jiri Denemark wrote:
> On Fri, Oct 05, 2018 at 09:54:02 +0100, Daniel P. Berrangé wrote:
> > On Fri, Oct 05, 2018 at 10:34:33AM +0200, Jiri Denemark wrote:
> > > On Thu, Oct 04, 2018 at 14:13:41 +0100, Daniel P. Berrangé wrote:
> &
numctl, numad and zfs-fuse are not available on riscv64 targets
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 667f89c0b9..90daefe6f1 100644
--- a/libvirt.spec.in
+++ b
gt; guests/playbooks/update/tasks/users.yml | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.co
On Thu, Sep 20, 2018 at 05:25:26PM +0200, Andrea Bolognani wrote:
> Now that we have reduced the number of sensible options down
> to either the native QEMU binary or RHEL's qemu-kvm, we can
> make virQEMUCapsInitGuest() a bit simpler.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_ca
On Mon, Oct 08, 2018 at 02:35:30PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-10-08 at 13:09 +0100, Daniel P. Berrangé wrote:
> > This patch is doing two things. It is moving the code block earlier,
> > to let you drop the duplicated virQEMUCapsCacheLookup(). Second it is
> &g
On Wed, Oct 03, 2018 at 12:23:53PM +, Mousumi Paul wrote:
> Trying to install libvirt 1.2.14 with the following command :./configure
> --prefix=/usr --localstatedir=/var --sysconfdir=/etc --with-esx=yes
> --with-xen=yes --with-hyperv=yes
>
> The above generates the following error:
> configu
On Wed, Oct 03, 2018 at 12:32:04PM +, Mousumi Paul wrote:
> I have installed libvirt-bin on ubuntu using the following command:sudo
> apt-get install libvirt-bin
> I checked the virsh version. It says 4.6.0.Now i want to recompile libvirt
> with esx, xen and hyperv driver.Therefore i went to
und g_strdup
- Fix arg syntax for qemu-nbd s/-/--/
- Remove QAPI (optional) annotation
- Fix some outdated usage example
Based-on: <20181009130442.26296-1-berra...@redhat.com>
Daniel P. Berrangé (6):
qemu-nbd: add support for authorization of TLS clients
nbd: allow authorization with n
From: "Daniel P. Berrange"
Currently any client which can complete the TLS handshake is able to use
the NBD server. The server admin can turn on the 'verify-peer' option
for the x509 creds to require the client to provide a x509 certificate.
This means the client will have to acquire a certificat
From: "Daniel P. Berrange"
The QEMU instance that runs as the server for the migration data
transport (ie the target QEMU) needs to be able to configure access
control so it can prevent unauthorized clients initiating an incoming
migration. This adds a new 'tls-authz' migration parameter that is
From: "Daniel P. Berrange"
As with the previous patch to qemu-nbd, the nbd-server-start QMP command
also needs to be able to specify authorization when enabling TLS encryption.
First the client must create a QAuthZ object instance using the
'object-add' command:
{
'execute': 'object-add
From: "Daniel P. Berrange"
Currently any client which can complete the TLS handshake is able to use
a chardev server. The server admin can turn on the 'verify-peer' option
for the x509 creds to require the client to provide a x509
certificate. This means the client will have to acquire a certific
From: "Daniel P. Berrange"
The VNC server has historically had support for ACLs to check both the
SASL username and the TLS x509 distinguished name. The VNC server was
responsible for creating the initial ACL, and the client app was then
responsible for populating it with rules using the HMP 'acl
authz' or 'sasl-authz' parameters to the VNC server, and
equivalent for other network services.
Signed-off-by: Daniel P. Berrangé
---
monitor.c| 23 +++
qemu-deprecated.texi | 6 ++
2 files changed, 29 insertions(+)
diff --git a/monitor.
On Tue, Oct 09, 2018 at 05:55:29PM +0200, Marc Hartmayer wrote:
> On s390x the struct member f_type of statsfs is hard coded to
> 'unsigned int'. So let's try to determine the type by means of the GNU
> extension typeof.
>
> This fixes the following error:
> ../../src/util/virfile.c:3578:38: error
On Thu, Sep 06, 2018 at 05:13:23PM +0200, Pino Toscano wrote:
> Hi,
>
> for reasons mostly lost in the history, after the libvirt-ocaml
> repository was converted to git, it was not used by its main author
> (Rich Jones); the development continued on Rich's git, at
> http://git.annexia.org/?p=oc
On Tue, Oct 09, 2018 at 04:45:01PM -0600, Jim Fehlig wrote:
> On 10/7/18 9:39 AM, Marek Marczykowski-Górecki wrote:
> > Since this is something between PV and HVM, it makes sense to put the
> > setting in place where domain type is specified.
> > To enable it, use It is
> > also included in ca
On Wed, Oct 10, 2018 at 09:39:03AM +0200, Pino Toscano wrote:
> On Thursday, 6 September 2018 17:13:23 CEST Pino Toscano wrote:
> > What do you think? Is it an acceptable path forward?
>
> Considering there seems consensus on this solution, how do we move
> forward? Should I fix the repository, p
On Wed, Oct 10, 2018 at 11:06:38AM +0200, Michal Privoznik wrote:
> On 10/10/2018 10:45 AM, Daniel P. Berrangé wrote:
> > On Tue, Oct 09, 2018 at 04:45:01PM -0600, Jim Fehlig wrote:
> >> On 10/7/18 9:39 AM, Marek Marczykowski-Górecki wrote:
> >>> Since this is so
On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
> Hi, all.
>
> On fat hosts which are capable to run hundreds of VMs restarting libvirtd
> makes it's services unavailable for a long time if VMs use network filters. In
> my tests each of 100 VMs has no-promisc [1] and no-mac-
of backend conventions to help with
> management layer implementation, and interoperability.
>
> v2:
> - drop --pidfile
> - add some notes about daemonizing & stdin/out/err
>
> Cc: libvir-list@redhat.com
> Cc: Gerd Hoffmann
> Cc: Daniel P. Berrangé
> Cc: Cha
On Sat, Sep 29, 2018 at 06:58:01PM +0800, Peng Hao wrote:
> sometimes we hoped that the memory of vm can be evenly distributed in
> all nodes according to interleave mode. But different hosts
> has different node number. So we add nodeset='all' for interleave mode.
>
> Signed-off-by: Peng Hao
> -
On Thu, Oct 11, 2018 at 12:03:44PM -0400, John Ferlan wrote:
>
>
> On 9/29/18 6:58 AM, Peng Hao wrote:
> > sometimes we hoped that the memory of vm can be evenly distributed in
> > all nodes according to interleave mode. But different hosts
> > has different node number. So we add nodeset='all' f
On Thu, Oct 11, 2018 at 03:57:10PM -0400, Laine Stump wrote:
> On 10/11/2018 06:20 AM, Daniel P. Berrangé wrote:
> > On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
> >
> >> What speed up is possible on conservative approach? First we can remove
>
On Fri, Oct 12, 2018 at 08:47:55AM +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 11, 2018 at 03:57:10PM -0400, Laine Stump wrote:
> > On 10/11/2018 06:20 AM, Daniel P. Berrangé wrote:
> > > On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
> > >
On Thu, Oct 11, 2018 at 04:48:34PM +0100, Daniel P. Berrangé wrote:
> Adding Markus since we're talking about new CLI argument and capability
> reporting standards.
>
> On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PA
On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé
> wrote:
> >
> > Adding Markus since we're talking about new CLI argument and capability
> > reporting standards.
> >
> >
On Fri, Oct 12, 2018 at 12:23:11PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > Note, I can't remember what Markus had proposed for CLI arguments in
> > QAPI, so I invented something arbitary but plausible.
>
> Using qapi visitors to parse the command line. Used by -blockdev and
> -display (and may
On Fri, Oct 12, 2018 at 01:14:51PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1632833
>
> When doing a SCSI passthrough we don't put format= onto the
> command line. This causes qemu to probe the format automatically
> which ends up in a warning in the domain log
On Fri, Oct 12, 2018 at 02:27:26PM +0200, Michal Privoznik wrote:
> On 10/12/2018 02:17 PM, Daniel P. Berrangé wrote:
> > On Fri, Oct 12, 2018 at 01:14:51PM +0200, Michal Privoznik wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1632833
> >>
> >> When d
On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote:
> Abstract
>
> The PCI representation in QEMU has recently been extended for S390
> allowing configuration of zPCI attributes like uid (user-defined
> identifier) and fid (PCI function identifier).
> The details can be found here
On Wed, Oct 10, 2018 at 01:09:50PM +0200, Andrea Bolognani wrote:
> Pavel helpfully pointed out that such a client already exists:
> it's called virt-xml and it's part of virt-manager.
>
> It needs a few tweaks before it can really fit the bill, but once
> that's been taken care of you should be a
On Sun, Oct 14, 2018 at 01:41:27PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-10-12 at 16:21 +0100, Daniel P. Berrangé wrote:
> > On Wed, Oct 10, 2018 at 01:09:50PM +0200, Andrea Bolognani wrote:
> > > So once we have these changes in place, command line users can be
On Mon, Oct 15, 2018 at 02:39:26PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1633562
>
> Under we allow users to configure various memory
> backing related knobs. However, there are some combinations that
> make no sense. For instance, requesting hugepages and f
On Tue, Oct 16, 2018 at 02:47:12PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Oct 12, 2018 at 1:56 PM Daniel P. Berrangé
> wrote:
> >
> > On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > >
On Fri, Oct 12, 2018 at 01:17:42PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 12, 2018 at 01:14:51PM +0200, Michal Privoznik wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1632833
> >
> > When doing a SCSI passthrough we don't put format= onto the
> > c
On Wed, Oct 17, 2018 at 11:06:43AM +0200, Michal Privoznik wrote:
> This new helper can be used to spawn a child process and run
> passed callback from it. This will come handy esp. if the
> callback is not thread safe.
>
> Signed-off-by: Michal Privoznik
> ---
> src/libvirt_private.syms | 1 +
On Wed, Oct 17, 2018 at 11:06:46AM +0200, Michal Privoznik wrote:
> Trying to use virlockd to lock metadata turns out to be too big
> gun. Since we will always spawn a separate process for relabeling
> we are safe to use thread unsafe POSIX locks and take out
> virtlockd completely out of the pictu
On Wed, Oct 17, 2018 at 12:52:50PM +0200, Michal Privoznik wrote:
> On 10/17/2018 11:45 AM, Daniel P. Berrangé wrote:
> > On Wed, Oct 17, 2018 at 11:06:46AM +0200, Michal Privoznik wrote:
> >> Trying to use virlockd to lock metadata turns out to be too big
> >> gun. S
us we use two sanity checks to decide if the vCPU
PID information is usable. First we see if the PID
duplicates the main emulator PID, and second we see
if the PID duplicates any other vCPUs.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_domain.c | 81 ++--
QEMU is using MTTCG by default on an increasingly large
set of host/guest combinations. This allows us to use the
normal vCPU pinning support we already have for KVM. We
just need to stop throwing away the PID info, and stop
artificially blocking pinning APIs.
Daniel P. Berrangé (2):
qemu: fix
know whether the
subsequent launch will use MTTCG or TCG, so we must allow
the pinning request. If the guest does use TCG on the next
launch it will fail, but this is no worse than if the user
had done a virDomainDefineXML with an XML doc specifying
vCPU pinning.
Signed-off-by: Daniel P. Berrangé
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote:
> > > I had some couch time at the start of the weekend and was finally able to
> > > try using this series with virt
gt; scripts/nwfilter/nwfilter_concurrent.sh | 2 +-
> scripts/selinux/100-static-relabel-no.t | 13 -
> 3 files changed, 14 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/p
On Thu, Oct 11, 2018 at 11:19:54AM +0200, Pino Toscano wrote:
> Not built on Debian 8, as the version of OCaml is not new enough.
>
> Signed-off-by: Pino Toscano
> ---
> jobs/defaults.yaml | 2 ++
> projects/libvirt-ocaml.yaml | 23 +++
> 2 files changed, 25 inserti
On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
> On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
> > On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> > > On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > > > On Sat, Oct 13, 2018 a
On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> On 10/19/18 8:14 AM, Daniel P. Berrangé wrote:
> > On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
> > > On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
> > > > On Thu, Oct 18, 2018 at 11:0
On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
> On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> > > own head) for either of the two modeling approaches
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0a63741b9e..12bef16fd6 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -5814,7 +5814,7
On Thu, Sep 20, 2018 at 07:44:46PM +0200, Marc Hartmayer wrote:
> For a domain definition there are numerous calls of
> virQEMUCapsCacheLookup (the same applies to the domain start). This
> slows down the process since virQEMUCapsCacheLookup validates that the
> QEMU capabilitites are still valid (
On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote:
> Daniel P. Berrangé [2018-10-24, 10:43PM +0100]:
> > We could optimize this by jcalling virFileAccessibleAs
> > once and storing the result in a global. Then just do a
> > plain stat() call in process to che
On Sat, Oct 20, 2018 at 05:19:57PM +0300, Roman Bolshakov wrote:
> Signed-off-by: Roman Bolshakov
> ---
> docs/schemas/domaincommon.rng | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 099a949cf8..2e1203f58e 100644
> -
1 - 100 of 9063 matches
Mail list logo
