Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Paolo Bonzini
On 06/29/2010 08:52 AM, Gary V. Vaughan wrote: Well, really the problem is this: while $# -gt 0; do opt=$1; shift case $opt in -p) opt_p="$1"; shift ;; -q) opt_q="$1"; shift ;; -x) opt_x=: ;; -y) opt_y=: ;; -p*|-q*) # option args func_split_short_arg $opt

Re: [PATCH RFC] Add sysroot support.

2010-07-08 Thread Paolo Bonzini
On 07/07/2010 11:51 AM, Thierry Reding wrote: Hi, the following patch adds support for gcc's --sysroot argument to libtool. I'll post the patch first and will reply to it, giving more details where needed. I've been building a number of packages with variations of this patch depending on the li

Re: [PATCH RFC] Add sysroot support.

2010-07-21 Thread Paolo Bonzini
On 07/21/2010 03:58 PM, Charles Wilson wrote: On 7/8/2010 1:02 PM, Paolo Bonzini wrote: I have another sysroot patch that seems (from a first cursory view) pretty different. I'll rebase and send. Ping? Rebasing was a bit troublesome due to the "replace shell function impl

[RFC PATCH 0/8] sysroot support

2010-07-22 Thread Paolo Bonzini
. However, I haven't retested this at all, so I trust my old runs from mid 2009 which were done with Fedora 12 and its mingw cross-compilation environment. Sorry for the delay. Paolo Bonzini (8): handle sysroot flags fix buglet provide shell functions to configure Add --with-sysroot

[RFC PATCH 8/8] emit sysrooted paths when installing .la files

2010-07-22 Thread Paolo Bonzini
--- libltdl/config/ltmain.m4sh | 43 --- libltdl/m4/libtool.m4 | 15 +++ 2 files changed, 47 insertions(+), 11 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 1a8041f..206bda9 100644 --- a/libltdl

[RFC PATCH 5/8] add a basic sysroot test

2010-07-22 Thread Paolo Bonzini
-*- Autotest -*- +# +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Paolo Bonzini, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the

[RFC PATCH 1/8] handle sysroot flags

2010-07-22 Thread Paolo Bonzini
--- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index ebd3909..8864916 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4sh @@ -4155,7 +4155,7 @@ func_mode_link (

[RFC PATCH 2/8] fix buglet

2010-07-22 Thread Paolo Bonzini
--- libltdl/m4/libtool.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 3a65ec4..0638091 100644 --- a/libltdl/m4/libtool.m4 +++ b/libltdl/m4/libtool.m4 @@ -6413,7 +6413,7 @@ if AC_TRY_EVAL(ac_compile); then pre_te

[RFC PATCH 4/8] Add --with-sysroot

2010-07-22 Thread Paolo Bonzini
The first baby step. Support the option, and replace it properly in the libtool script. --- libltdl/m4/libtool.m4 | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index ef4aa0f..

[RFC PATCH 3/8] provide shell functions to configure

2010-07-22 Thread Paolo Bonzini
--- libltdl/m4/libtool.m4 | 56 +++- 1 files changed, 41 insertions(+), 15 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 0638091..ef4aa0f 100644 --- a/libltdl/m4/libtool.m4 +++ b/libltdl/m4/libtool.m4 @@ -166,6 +166,7 @

[RFC PATCH 6/8] teach libtool -L= and -R=

2010-07-22 Thread Paolo Bonzini
--- libltdl/config/ltmain.m4sh | 81 --- 1 files changed, 60 insertions(+), 21 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 8864916..4251bb3 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4s

[RFC PATCH 7/8] handle sysrooted paths when reading dependencies to la files

2010-07-22 Thread Paolo Bonzini
--- libltdl/config/ltmain.m4sh | 18 ++ tests/sysroot.at |6 ++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 4251bb3..1a8041f 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/c

Re: [RFC PATCH 0/8] sysroot support

2010-07-24 Thread Paolo Bonzini
On 07/23/2010 06:12 AM, Charles Wilson wrote: On 7/22/2010 2:36 PM, Paolo Bonzini wrote: This patch series is on top of 04329d83555b5f8d2fd02428418a79ea392b2d91. The basic idea is to look for -L= and -R= to expand the sysroot, and for the sysroot to remove it in .la files. Some missing

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

2010-07-26 Thread Paolo Bonzini
On 07/26/2010 01:57 PM, Charles Wilson wrote: These are rebased versions of Paolo's sysroot patches, rebased to 0e01d00c70fe1eba2b746a6bb52e3c9277a4f1ef (Sun Jul 18 17:17:15 2010 +0200) As it happens, Paolo's old 3/8 'provide shell functions to configure.patch' didn't apply very well at all, gi

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

2010-07-28 Thread Paolo Bonzini
On Wed, Jul 28, 2010 at 10:10, Charles Wilson wrote: > Well, after the first 7 of 9 (no star trek jokes, please), in native > mode, all of the problematic tests pass (old: > tagdemo-conf.test+tagdemo-make.test; new: 41, 101). That's good. > So, I can either squash 8 and 9, and treat it atomicall

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

2010-07-28 Thread Paolo Bonzini
On 07/28/2010 02:47 PM, Charles Wilson wrote: On 7/28/2010 5:05 AM, Paolo Bonzini wrote: On Wed, Jul 28, 2010 at 10:10, Charles Wilson But that doesn't appear to be the case for cross builds, in the new tests. But I don't think it was bisectable in cross builds in your original d

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

2010-07-28 Thread Paolo Bonzini
ndency_libs/ -- this was in my patchset too + ;; + -R*) + func_stripname -R '' "$i" + func_replace_sysroot "$func_stripname_result" + func_append newdeplibs " -R$func_replace_sysroot_result" s/newdeplibs/newdependency_libs/ -- also in my patchset. This should f

Re: [REBASED PATCH 6/9] teach libtool -L= and -R=

2010-07-28 Thread Paolo Bonzini
On 07/22/2010 08:36 PM, Charles Wilson wrote: @@ -5777,11 +5812,13 @@ func_mode_link () for deplib in $dependency_libs; do newdependency_libs="$deplib $newdependency_libs" if $opt_preserve_dup_deps ; then + func_resolve_sysroot "$deplib" +

Re: [REBASED PATCH 6/9] teach libtool -L= and -R=

2010-07-28 Thread Paolo Bonzini
On 07/29/2010 01:20 AM, Charles Wilson wrote: On 7/28/2010 6:25 PM, Paolo Bonzini wrote: On 07/22/2010 08:36 PM, Charles Wilson wrote: @@ -5777,11 +5812,13 @@ func_mode_link () for deplib in $dependency_libs; do newdependency_libs="$deplib $newdependency_libs" if $opt_preserve_dup_d

[RFT PATCH v3 0/9] Sysroot patches

2010-07-28 Thread Paolo Bonzini
This is the update of the series, with the bug fixes (thanks Charles for the hand work!) and structured to preserve bisectability. Paolo Bonzini (9): fix bug in postdeps computation handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading

[RFT PATCH v3 3/9] add --with-sysroot

2010-07-28 Thread Paolo Bonzini
* libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT. Signed-off-by: Paolo Bonzini --- Right now the default is to use a sysroot. Probably it is a bit too aggressive, especially because most existing cross

[RFT PATCH v3 2/9] handle sysroot flags

2010-07-28 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot option. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 897a5e8..4f373db

[RFT PATCH v3 6/9] process postdeps to include sysrooted paths

2010-07-28 Thread Paolo Bonzini
. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/m4/libtool.m4 | 42 ++ 1 files changed, 38 insertions(+), 4 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 52efd48..3560740 100644 --- a/libltdl/m4

[RFT PATCH v3 9/9] initial version of the NEWS entry

2010-07-28 Thread Paolo Bonzini
* NEWS: Document sysroot support. --- I am not sure where to talk about the sysroot support in the manual. Probably it would deserve an entire section of its own! In the meanwhile, a NEWS entry is just a little better than nothing... NEWS | 12 1 f

[RFT PATCH v3 7/9] emit sysrooted paths when installing .la files

2010-07-28 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_replace_sysroot): New. (func_mode_link): Prepend paths in $libdir with the sysroot. Further, replace the sysroot with = (using func_replace_sysroot) whenever such a path is written in a .la file. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson

[RFT PATCH v3 1/9] fix bug in postdeps computation

2010-07-28 Thread Paolo Bonzini
* libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS): Actually concatenate $prev and $p. Signed-off-by: Paolo Bonzini --- libltdl/m4/libtool.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 47d2558..f61be28 100644

[RFT PATCH v3 8/9] add sysroot test

2010-07-28 Thread Paolo Bonzini
* Makefile.am (TESTSUITE_AT): Add tests/sysroot.at. * tests/sysroot.at: New. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- Makefile.am |3 +- tests/sysroot.at | 201 ++ 2 files changed, 203 insertions(+), 1

[RFT PATCH v3 4/9] teach libtool -L= and -R=

2010-07-28 Thread Paolo Bonzini
resolve sysroot paths there. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/config/ltmain.m4sh | 81 --- 1 files changed, 60 insertions(+), 21 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh

[RFT PATCH v3 5/9] handle sysrooted paths when reading dependencies to la files

2010-07-28 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_execute, func_mode_install, func_mode_link): Whenever a .la file occurs in another .la file, expand the sysroot path in it. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh | 18 ++ 1 files changed, 14 insertions(+), 4

Re: [RFT PATCH v3 0/9] Sysroot patches

2010-07-29 Thread Paolo Bonzini
On Thu, Jul 29, 2010 at 10:04, Charles Wilson wrote: > On 7/28/2010 7:23 PM, Paolo Bonzini wrote: >> This is the update of the series, with the bug fixes (thanks Charles >> for the hand work!) and structured to preserve bisectability. >> > > Sadly, the newest patchset

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-07-29 Thread Paolo Bonzini
On Thu, Jul 29, 2010 at 10:01, Charles Wilson wrote: > On 7/28/2010 7:23 PM, Paolo Bonzini wrote: >> * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. >> (LT_SETUP): Require _LT_WITH_SYSROOT. >> >> Signed-off-by: Paolo Bonzini >> --- >&

Re: [RFT PATCH v3 0/9] Sysroot patches

2010-07-30 Thread Paolo Bonzini
On 07/30/2010 08:55 PM, Charles Wilson wrote: Since the bug is cross-platform, it should be easy(er) to fix for you non-cygwin types. Any ideas, Paolo? You removed any excuse that I had for not looking at it more deeply. :) PS. Note that all these tests were done using the patches as submitt

Re: [RFT PATCH v3 0/9] Sysroot patches

2010-07-31 Thread Paolo Bonzini
On 07/30/2010 08:55 PM, Charles Wilson wrote: > Since the bug is cross-platform, it should be easy(er) to fix for you > non-cygwin types. Any ideas, Paolo? Not tested yet, but I am pretty sure this should do it: diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index b0b0ebc.

[RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

2010-08-01 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_replace_sysroot): New. (func_mode_link): Prepend paths in $libdir with the sysroot. Further, replace the sysroot with = (using func_replace_sysroot) whenever such a path is written in a .la file. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson

[RFT PATCH v4 1/8] handle sysroot flags

2010-08-01 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot option. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 897a5e8..4f373db

[RFT PATCH v4 4/8] handle sysrooted paths when reading dependencies to la files

2010-08-01 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_execute, func_mode_install, func_mode_link): Whenever a .la file occurs in another .la file, expand the sysroot path in it. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh | 18 ++ 1 files changed, 14 insertions(+), 4

[PATCH] fixup for teach libtool -L= and -R=

2010-08-01 Thread Paolo Bonzini
This fixes 37 and 38 (and likely a bunch of other failures). The 37/38 failure is really a logic bug, the other two are cut-and-paste problems. It seems like I didn't review the patch even. (I did; what I didn't do was testing it beyond sysroot.at :). I'll squash it in 3/9. Paolo --- libltdl/

[RFT PATCH v4 3/8] teach libtool -L= and -R=

2010-08-01 Thread Paolo Bonzini
resolve sysroot paths there. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/config/ltmain.m4sh | 87 +--- 1 files changed, 65 insertions(+), 22 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh

[RFT PATCH v4 8/8] initial version of the NEWS entry

2010-08-01 Thread Paolo Bonzini
* NEWS: Document sysroot support. --- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 95fa97d..68ebcee 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,16 @@ New in 2.2.12 2010-08-??: git version 2.2.11a, Libtool team: * New features: + - Sysr

[RFT PATCH v4 2/8] add --with-sysroot

2010-08-01 Thread Paolo Bonzini
* libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT. Signed-off-by: Paolo Bonzini --- libltdl/m4/libtool.m4 | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/libltdl

[RFT PATCH v4 7/8] add sysroot test

2010-08-01 Thread Paolo Bonzini
* Makefile.am (TESTSUITE_AT): Add tests/sysroot.at. * tests/sysroot.at: New. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- Makefile.am |3 +- tests/sysroot.at | 201 ++ 2 files changed, 203 insertions(+), 1

[RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Paolo Bonzini
double-check of the testsuite.dir would be nice. Paolo Paolo Bonzini (8): handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths emit sysrooted paths when installing .la f

[RFT PATCH v4 5/8] process postdeps to include sysrooted paths

2010-08-01 Thread Paolo Bonzini
. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/m4/libtool.m4 | 42 ++ 1 files changed, 38 insertions(+), 4 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 52efd48..3560740 100644 --- a/libltdl/m4

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Paolo Bonzini
On 08/01/2010 07:22 PM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: This should, and I say "should" :) pass all tests. Thanks for the repost. Did anything change beside the discussion attached to the last patch series post? No. This pas

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Paolo Bonzini
On 08/01/2010 08:43 PM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-08-01 Thread Paolo Bonzini
On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: Next one: 3/9. This is a bit of a preliminary review, because I haven't read all patches and all of the discussion yet. * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:16AM CEST: * libltdl/m4/libtool.m4 (_LT_HOST_NONCANO

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Paolo Bonzini
On Mon, Aug 2, 2010 at 22:13, Ralf Wildenhues wrote: > More issues: > > - the part of ltmain starting with >        # Collect and forward deplibs of preopened libtool libs > > will source .la files but looks like it mistreats = in $dependency_libs Ok. > - is it intended that the = remain in the

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-03 Thread Paolo Bonzini
On 08/03/2010 07:52 AM, Charles Wilson wrote: On 8/2/2010 1:53 PM, Ralf Wildenhues wrote: This should be fixed: | ++ make all | stderr: | lib2.c: In function 'g': | lib2.c:6:13: warning: initialization makes pointer from integer without a cast | stdout: This addendum appears to do it (Tested

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-03 Thread Paolo Bonzini
On 08/02/2010 07:55 PM, Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Aug 01, 2010 at 10:04:16PM CEST: support, use --prefix=/mingw + DESTDIR=/the-sysroot. What about the w32 users that use --prefix=C:/mingw and then cannot use DESTDIR because that will not concatenate? Also, in 'ln -

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

2010-08-03 Thread Paolo Bonzini
On 08/01/2010 08:31 PM, Ralf Wildenhues wrote: Although it is fairly unlikely, I prefer not relying on :+ support, so please replace with 'if test -z "$lt_sysroot"...'. Two instances. Is this still true in the light of the recent discussion on autoconf mailing lists? Paolo

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-08-03 Thread Paolo Bonzini
On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: Actually, I don't see any other uses of target in the whole patch series, so why not just omit that here? All of this is dead code actually... > + AC_MSG_RESULT([$with_sysroot]) > + lt_sysroot=`echo "$with_sysroot" | sed -e "$sed_quote_subst"

[PATCH 0/2] sysroot patches followup

2010-08-11 Thread Paolo Bonzini
Given testing natively is stuck on missing ld support for sysroot, the only other issue to be solved is the conflict with --with-sysroot in GCC. I'm thinking of just renaming the option to --enable-sysroot... Paolo Paolo Bonzini (2): reorganize parsing of --mode=finish arguments add libt

[PATCH 1/2] reorganize parsing of --mode=finish arguments

2010-08-11 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 117 ++-- 1 files changed, 70 insertions(+), 47 deletions(-) diff --git a/libltdl/config/l

[PATCH 2/2] add libtool --mode=finish mode for sysroot

2010-08-11 Thread Paolo Bonzini
--- doc/libtool.texi | 17 + libltdl/config/ltmain.m4sh | 20 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/doc/libtool.texi b/doc/libtool.texi index 914bd1d..5b21a32 100644 --- a/doc/libtool.texi +++ b/doc/libtool.texi @@ -1721,

Re: [PATCH 1/2] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Paolo Bonzini
On 08/12/2010 12:58 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 117

Re: [PATCH 2/2] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Paolo Bonzini
On 08/12/2010 01:12 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: + sed -e "${sysroot_cmd} s/\([ ']-[LR]\)=/\1/g" $lib> $tmpdir/tmp-la Hmmm. Some of the test cases end up with dependency_libs like this: dependency_libs=' -L=/mingw/

[PATCH v2 0/3] sysroot followup patches

2010-08-12 Thread Paolo Bonzini
e for the --mode=finish changes. Ok to push to sysroot branch? Paolo Bonzini (4): fix sysroot tests to pass on Fedora 13 fix sysroot handling for deplibs of preopened libtool libs reorganize parsing of --mode=finish arguments add libtool --mode=finish mode for sysroot doc/libtool.texi

[PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 109 +--- 1 files changed, 62 insertions(+), 47 deletions(-) diff --git a/libltdl/config/l

[PATCH v2 1/4] fix sysroot tests to pass on Fedora 13

2010-08-12 Thread Paolo Bonzini
* tests/sysroot.at: Link $prefix/include into the sysroot as well, as required by newer GCC. --- tests/sysroot.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/sysroot.at b/tests/sysroot.at index 850e0cd..869c9c4 100644 --- a/tests/sysroot.at +++ b/tests/sysroot.a

[PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

2010-08-12 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool through func_resolve_sysroot. --- libltdl/config/ltmain.m4sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 3888cb0..563c3af 100644 ---

[PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Paolo Bonzini
--- doc/libtool.texi | 18 -- libltdl/config/ltmain.m4sh | 21 + tests/sysroot.at |3 +++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/doc/libtool.texi b/doc/libtool.texi index 914bd1d..4b256bf 100644 --- a/doc/libt

Re: [PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-15 Thread Paolo Bonzini
On 08/13/2010 12:59 AM, Ralf Wildenhues wrote: Erm, you should be mentioning the files you change in your log entries, and Libtool also doesn't auto-generate its ChangeLog (yet), so you need that, too, also for all the other patches in the sysroot branch. I was planning to form a merged changel

Re: [PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

2010-08-15 Thread Paolo Bonzini
On 08/13/2010 06:14 AM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:04AM CEST: * libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool through func_resolve_sysroot. This looks ok, but is it covered in the testsuite? Apparently not. If it

[PATCH] improve code for sysroot --mode=finish

2010-08-15 Thread Paolo Bonzini
Here are the improvements you suggested. I'll send a patch for sed_make_literal_regex soon. Ok? Paolo * libltdl/config/ltmain.m4sh (func_mode_finish): Change sysroot_regex and sysroot_cmd delimiter from pipe to slash. Wrap the entire for loop with "if $opt_dry_run...fi" and print an explanator

[PATCH] Factor the sed command used to make a regex from a literal.

2010-08-15 Thread Paolo Bonzini
In func_generate_dlsyms, the resulting regex is used with grep rather than sed. I don't think grep has problems with \/ in practice, but of course I can change it to use sed, too. Ok? (if so, which way?) Paolo 2010-08-15 Paolo Bonzini * libltdl/config/general

Re: [RFT PATCH v4 3/8] teach libtool -L= and -R=

2010-08-19 Thread Paolo Bonzini
On 08/19/2010 06:58 AM, Ralf Wildenhues wrote: +# func_resolve_sysroot PATH +# Change PATH to an absolute path or replace a leading = with a +# sysroot. Store the result into func_resolve_sysroot_result +func_resolve_sysroot () +{ + func_resolve_sysroot_result=$1 + case $func_resolve_sysroot_r

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-22 Thread Paolo Bonzini
> Paolo, are you going to squash this: > http://lists.gnu.org/archive/html/libtool-patches/2010-08/msg00145.html > perhaps without this change: >> -      if $opt_dry_run; then >> +      if ${opt_dry_run-false}; then > into > [PATCH] improve code for sysroot --mode=finish.eml Yes of course. Paolo

Re: [PATCH] Do not absolutize paths eagerly.

2010-08-22 Thread Paolo Bonzini
On 08/21/2010 08:03 AM, Ralf Wildenhues wrote: Fixed the regression as expected, didn't show up any other failures. OK to apply to the sysroot branch? I still need somebody to test a sysroot-enabled setup with this. I'm testing it now. Paolo

Re: [PATCH] Do not absolutize paths eagerly.

2010-08-22 Thread Paolo Bonzini
On 08/21/2010 08:03 AM, Ralf Wildenhues wrote: * Ralf Wildenhues wrote on Fri, Aug 20, 2010 at 06:34:58AM CEST: * libltdl/config/ltmain.m4sh (func_resolve_sysroot): Partly revert v2.2.10-83-gc45a288: Do not absolutize path here, only do sysroot replacement. (func_mode_link): Adjust. Fixes AIX te

[PATCH] Add missing sysroot resolution

2010-10-09 Thread Paolo Bonzini
c...@cs.tu-berlin.de 2002-11-05 Jan Kratochvil project-libt...@jankratochvil.net 2003-01-28 Raja R. Harinath harin...@acm.org 2003-02-25 + Paolo Bonzinibonz...@gnu.org 2003-03-01 Richard Nich

[RFC PATCH] Strip trailing slashes from libdir and destdir

2010-10-09 Thread Paolo Bonzini
I found this patch at OpenEmbedded, http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-October/025133.html It looks to me like the code can be simplified by unconditionally stripping trailing slashes from $libdir and $destdir (i.e. not introducing the new variables). Ideas? Paolo * li

Re: [PATCH] Add missing sysroot resolution

2010-10-09 Thread Paolo Bonzini
On 10/09/2010 10:51 AM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: I'm applying this patch since it's pretty obvious. Thank you. Is this fixing (part) of the reported bug? Lionel pointed us to the patch, so I assumed it fixed all of it.

Re: [PATCH] Add missing sysroot resolution

2010-10-09 Thread Paolo Bonzini
> Paolo, I'm sorry if I made you though this patch was fixing my problem > (in fact after a quick test, it does not). I just wanted to point it > out, because Openembedded like buildroot, are projects which try to > crosscompile source packages. I though it might be a good start to > investigate th

Re: Bug 9210: fix to replace Linux with GNU/Linux where needed

2011-09-12 Thread Paolo Bonzini
On 09/04/2011 03:22 PM, Ralf Wildenhues wrote: > -# This must be Linux ELF. > +# This must be GNU/Linux ELF. The comment does not match the code below it, see the following line. Not your fault, and generally I don't want to take patches hostage on unrelated bugs, but*please* make this # T

Re: FYI: HACKING update

2005-05-10 Thread Paolo Bonzini
+ ÐÑÑÐÐÑÑÐÐÐ ÐÑÐÐ ÐÐÐÑÑ [EMAIL PROTECTED] I do not speak Russian, but (from my limited knowledge of Cyrillic, and my memories of reading Dostoevski in high school) I think that: - ÐÑÐÐ is the name (Yuri in Latin characters) - ÐÐÐÑÑ stands for his father's name (Andreyevich or Andreevich,

Re: _LT_COMPILER_OPTION/_LT_LINKER_OPTION/ sed fix

2005-06-10 Thread Paolo Bonzini
As detailedly explained in the comment above this change, `$ECHO' is not necessary instead of `echo'. Also, sed regex `?' is not portable (and in fact not recognized by GNU sed 4.1.2), but \{0,1\} is. ? is plain wrong, since sed uses basic regular expressions. No GNU sed ever recognized it; t

PING**n (PR/19210, PR/21921, toplevel bootstrap)

2005-06-10 Thread Paolo Bonzini
http://gcc.gnu.org/ml/gcc-patches/2005-05/msg00464.html PR/19210: Add -{f,W}unsafe-loop-optimizations http://gcc.gnu.org/ml/gcc-patches/2005-06/msg00260.html Always create target tools in the gcc directory, take 6 (4.1 stage 2 project, toplevel bootstrap) I think I sent at least six pings each f

Re: PING**n (PR/19210, PR/21921, toplevel bootstrap)

2005-06-11 Thread Paolo Bonzini
Ralf Wildenhues wrote: * Paolo Bonzini wrote on Fri, Jun 10, 2005 at 07:48:00PM CEST: *snip gcc-patches pings* And they have exactly what to do with Libtool? :-) Absolutely nothing! ;-) Paolo

Re: workaround for virtualpc bug

2005-11-03 Thread Paolo Bonzini
Cannot export : symbol not defined Creating library file: $output_objdir/$libname.dll.a collect2: ld returned 1 exit status Could you try using a patched sed that prints the argument to compile_program (e.g. on stderr)? Paolo

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-28 Thread Paolo Bonzini
4.3 cannot compile Java source code until its build has finished. Paolo 2007-05-27 Paolo Bonzini <[EMAIL PROTECTED]> * libtool.m4 (_LT_LANG_GCJ_CONFIG): Run tests on .class files. Index: libtool.m4 === --- libto

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-28 Thread Paolo Bonzini
end up in the output. Needs another method to convert text to binary. We can emit them as FF, and then use "tr" to convert them to NULs. This ought to work. Paolo 2007-05-27 Paolo Bonzini <[EMAIL PROTECTED]> * libtool.m4 (_LT_LANG_GCJ_CONFIG): Run tests on .class

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-29 Thread Paolo Bonzini
This patch allows me to run aclocal and autoconf. However, it still doesn't work. But we can't use conftest* as Java class file name since it will be removed after a test is done. That means the second gcj test will fail since those class files have been removed. If we rename them to something

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-29 Thread Paolo Bonzini
It doesn't work since gcj isn't functional at that time. configure complains configure:16060: /export/build/gnu/gcc-isa/build-x86_64-linux/gcc/gcj -B/export/build/gnu/gcc-isa/build-x86_64-linux/x86_64-unknown-linux-gnu/libjava/ -B/export/build/gnu/gcc-isa/build-x86_64-linux/gcc/ -c -O2 -g -O2

Re: PATCH: PR libjava/32078: Update libtool in classpath

2007-05-29 Thread Paolo Bonzini
> Certainly. Any compile-and-link tests won't work. I'm sorry, I missed the "and link" part of your question. Configury tests of this kind really aren't going to work. For things like tests for PIC, it's pointless: gcj supports the same options as gcc. Then, does anybody know the very rea

Re: PATCH: PR libjava/32078: Update libtool in classpath

2007-05-29 Thread Paolo Bonzini
Certainly. Any compile-and-link tests won't work. I'm sorry, I missed the "and link" part of your question. Configury tests of this kind really aren't going to work. For things like tests for PIC, it's pointless: gcj supports the same options as gcc. Then, does anybody know the very reason w

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-29 Thread Paolo Bonzini
Gcj isn't available for compile-and-link test when building libjava. I found a solution, which is to add a ltgcc.m4 file to the toplevel, where we can override macros as we wish. For example, you can put a copy of the Java configuration macro there with your hack. I will approve such a patc

Re: PATCH: PR libjava/32098: New libtool doesn't support libjava

2007-05-30 Thread Paolo Bonzini
H. J. Lu wrote: On Wed, May 30, 2007 at 08:09:25AM +0200, Paolo Bonzini wrote: Gcj isn't available for compile-and-link test when building libjava. I found a solution, which is to add a ltgcc.m4 file to the toplevel, where we can override macros as we wish. For example, you can put a co

Re: Using getconf to set max_cmd_len

2007-05-30 Thread Paolo Bonzini
Steve Ellcey wrote: While integrating a newer libtool into GCC, an issue arose with what value libtool was setting max_cmd_len to. This patch uses 'getconf ARG_MAX' to set lt_cv_sys_max_cmd_len instead of going through a loop to try and divine the right value, this should give a more accurate va

Re: PATCH: Use AC_DEFUN instead of m4_defun in libtool.m4

2007-07-01 Thread Paolo Bonzini
I don't know much about m4, autoconf nor libtool. This patch works for me on both gcc and binutils. Looks good, but let's make sure it is applied to upstream libtool as well. Paolo 2007-06-30 H.J. Lu <[EMAIL PROTECTED]> * libtool.m4 (_LT_CC_BASENAME): Use AC_DEFUN instead of

Re: PATCH: Use AC_DEFUN instead of m4_defun in libtool.m4

2007-07-01 Thread Paolo Bonzini
It is fixed in th next libtool. Should I check in my work around in gcc and src? No, please test their bugfix and see if it works for you (just trying to minimize the chance that it breaks next time we update). Paolo

Re: PATCH: Use AC_DEFUN instead of m4_defun in libtool.m4

2007-07-02 Thread Paolo Bonzini
H.J. Lu wrote: On Mon, Jul 02, 2007 at 06:59:52AM +0200, Paolo Bonzini wrote: It is fixed in th next libtool. Should I check in my work around in gcc and src? No, please test their bugfix and see if it works for you (just trying to minimize the chance that it breaks next time we update). I

Re: [4/11] Native MSVC support (file-magic-glob)

2007-07-13 Thread Paolo Bonzini
[lL][iI][bB][nN][aA][mM][eE] by using this sed expr s/[aA]/[aA]/g;s/[bB]/[bB]/g;<22 more>;s/[yY]/[yY]/g;s/[zZ]/[zZ]/g; Isn't there a better way? (I can't think of one offhand, given how this is used to generate a list of "potential_libs", but still...this can't be very efficient.) I would d

Re: [4/11] Native MSVC support (file-magic-glob)

2007-07-13 Thread Paolo Bonzini
s/[A-Za-z]/*|&|ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ*/g s/\*|\(.\)|[A-Za-z]*\1[A-Za-z]\{25\}\([A-Za-z]\)[A-Za-z]*\*/[\1\2]/g Ah, that's a nice solution. I was considering the following: This is inspired me the following in turn, which is faster than m

Re: missing libtool sources?

2007-08-16 Thread Paolo Bonzini
I think we should adjust the Libtool sources in this case. While CVS HEAD's ltmain.sh is generated from ltmain.m4sh, and we prefer patches against the latter file, the former is definitely in a source code form that makes modifications just as easy: both are shell scripts without lots of redundan

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Paolo Bonzini
Behdad Esfahbod wrote: On Fri, 2008-04-18 at 22:27 +0300, Roumen Petrov wrote: I perfectly know that user cannot go in build-dir and just to run secure shell daemon/client. And if you are happy with that, good for you. In GNOME though, we want our users to be able to run uninstalled programs.

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Paolo Bonzini
In GNU Smalltalk, "./gst" is used if you don't need to load any plugin, while "tests/gst" is used if you need plugins; "tests/gst" is created by config.status. Most of the time launching "./gst" is enough; and since its startup time is much faster than "tests/gst", I didn't feel the need

[PATCH] allow unquoted "test $?"

2008-07-31 Thread Paolo Bonzini
With git libtool, sh.test is failing. Either the offending line should be fixed, or the attached patch to sh.test should be applied to allow not quoting $?. Thanks! Paolo 2008-07-31 Paolo Bonzini <[EMAIL PROTECTED]> * tests/sh.test: Allow unquoted "test $?" di

[PATCH] cosmetic fix to ltmain.m4sh

2008-07-31 Thread Paolo Bonzini
This small patch makes sure that all braces are paired in ltmain.m4sh. 2008-07-31 Paolo Bonzini <[EMAIL PROTECTED]> * ltmain.m4sh (func_emit_cwrapperexe_src): Factor multiple closed braces into the next cat command. diff --git a/libltdl/config/ltmain.m4sh b/libltdl/

[PATCH] Atomic creation of fast-install relinked binary

2008-07-31 Thread Paolo Bonzini
in8.11.0, with the following results: i686-pc-linux-gnu: All 124 tests passed 71 tests behaved as expected. 2 tests were skipped (23 and 73). powerpc-apple-darwin: All 106 tests passed ==== 66 tests behaved as expecte

[PATCH 1/6] Avoid that autom4te complains about unexpanded macros

2008-11-07 Thread Paolo Bonzini
This patch series has the purpose of removing the "fallback echo" code from Libtool, replacing it with usage of printf. More detailed information on the tradeoffs and the rationale are in the description of patch 6/6. In the meanwhile, the series cleans up some problematic usages of M4sh, so the

  1   2   >