[PATCH 08/25] syntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_makefile_TAB_only_indentation from list of disabled checks. * Makefile.am (libltdl/Makefile.am): Replace leading spaces with TABs. * libltdl/Makefile.am (libltdl_libltdl_la_SOURCES): Ditto. Signed-off-by: Gary V. Vaughan --- Makefile.am | 10

[PATCH 10/25] syntax-check: fix violations and re-enable sc_prohibit_cvs_keyword.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_cvs_keyword from list of disabled checks. * tests/tagdemo/README: Remove spurious CVS keyword. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - tests/tagdemo/README |2 -- 2 files changed, 0 insertions(+), 3 deletions

[PATCH 11/25] syntax-check: fix violations and re-enable sc_prohibit_doubled_word.

2011-11-15 Thread Gary V. Vaughan
it across lines in a comment. Signed-off-by: Gary V. Vaughan --- build-aux/general.m4sh |4 ++-- cfg.mk |1 - tests/lt_dladvise.at |2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/build-aux/general.m4sh b/build-aux/general.m4sh index b6e3d41..34940f

[PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_makefile_at_at_check from list of disabled checks. * configure.ac (order-only prerequisites): Test with the order-only pipe symbol in a macro. * Makefile.am, tests/mdemo/Makefile.am: Convert all @FOO@ to $(FOO). Signed-off-by: Gary V. Vaughan

[PATCH 17/25] syntax-check: fix violations and re-enable sc_probibit_test_minus_ao.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_probhibit_test_minus_ao from list of disabled checks. (exclude_file_name_regexp--sc_prohibit_tests_minus_ao): The matches from this syntax-check in libtool.m4 are all bogus. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 ++- 1 files changed, 2

[PATCH 15/25] syntax-check: fix violations and re-enable sc_prohibit_stddef_without_use.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_stddef_without_use from list of disabled checks. * libltdl/argz.c, libltdl/lt__dirent.c, libltdl/slist.c: Remove spurious stddef.h #include lines. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - libltdl/argz.c |1

[PATCH 12/25] syntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF.

2011-11-15 Thread Gary V. Vaughan
, tests/mdemo/README, tests/mdemo2/README, tests/pdemo-inst.test: Remove spurious empty lines from the end of these files. Signed-off-by: Gary V. Vaughan --- THANKS |1 - build-aux/getopt.m4sh|1 - cfg.mk |1 - libltdl/argz.c |1

[PATCH 14/25] syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_magic_number_exit from list of disabled checks. * ltmain.c: Removed unused file. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - ltmain.c | 36 2 files changed, 0 insertions(+), 37 deletions

[PATCH 13/25] syntax-check: fix violations and re-enable sc_prohibit_have_config_h.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_have_config_h from list of disabled checks. * tests/f77demo/foo.h, tests/fcdemo/foo.h: Remove spurious HAVE_CONFIG_H guards for #include . Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - tests/f77demo/foo.h |2 -- tests

[PATCH 18/25] syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_undesirable_word_seq from list of disabled checks. * doc/libtool.texi, libltdl/config/ltmain.m4sh, libltdl/m4/libtool.m4, libtoolize.m4sh: Replace all uses of "can not" with "cannot". Signed-off-by: Gary V.

[PATCH 16/25] syntax-check: fix violations and re-enable sc_prohibit_strcmp.

2011-11-15 Thread Gary V. Vaughan
all callers. * tests/slist.at: Add STREQ definition. Change all !strcmp calls to STREQ. * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): Add and use STREQ definition. Signed-off-by: Gary V. Vaughan --- build-aux/ltmain.m4sh | 10 ++ cfg.mk|3

[PATCH 20/25] syntax-check: fix violations and re-enable sc_useless_cpp_parens.

2011-11-15 Thread Gary V. Vaughan
/lt__strl.c, libltdl/ltdl.c, libltdl/ltdl.h, libltdl/m4/libtool.m4, tests/demo/foo.h, tests/depdemo/sysdep.h, tests/exceptions.at, tests/export.at, tests/pdemo/foo.h, tests/stresstest.at: Remove useless parens in cpp `#if defined(foo)' statements. Signed-off-by: Gary V. Vaughan --- buil

[PATCH 19/25] syntax-check: fix violations and re-enable sc_space_tab.

2011-11-15 Thread Gary V. Vaughan
es by reversing them in regexps, and deleting leading spaces in indentation. Signed-off-by: Gary V. Vaughan --- Makefile.am |2 +- build-aux/general.m4sh|2 +- build-aux/ltmain.m4sh |2 +- cfg.mk|

[PATCH 22/25] syntax-check: enable sc_bindtextdomain.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

[PATCH 23/25] syntax-check: enable sc_program_name.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-skip): Remove sc_program_name list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[PATCH 24/25] syntax-check: enable sc_prohibit_always_true_header_tests.

2011-11-15 Thread Gary V. Vaughan
* cfg.mk (local-checks-to-fix): Remove sc_prohibit_always_true_header_tests from list of disabled checks, because it no longer flags any violations. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index 48d063e

[PATCH 21/25] syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676.

2011-11-15 Thread Gary V. Vaughan
mdemo/main.c, tests/mdemo/mlib.c, tests/objectlist.test, tests/static.at, tests/template.at, tests/testsuite.at: Remove trailing blanks. Signed-off-by: Gary V. Vaughan --- bootstrap.conf |2 +- build-aux/extract-trace |4 ++-- build-aux/ltmain.m4sh |2 +- build-aux/op

[PATCH 25/25] dist: hook syntax-check into `make distcheck'.

2011-11-15 Thread Gary V. Vaughan
To make sure we don't accidentally release anything with failing syntax-checks, have `make distcheck' run the syntax-checks automatically. * Makefile.am (distcheck-hook): New rule depending on syntax-check. Signed-off-by: Gary V. Vaughan --- Makefile.am |2 ++ 1 files changed, 2

FYI: [PATCH] gnulib: update gnulib submodule.

2011-11-15 Thread Gary V. Vaughan
This patch has been applied upstream already. Signed-off-by: Gary V. Vaughan --- gl/top/maint.mk.diff | 68 -- gnulib |2 +- 2 files changed, 1 insertions(+), 69 deletions(-) delete mode 100644 gl/top/maint.mk.diff diff --git

Re: [PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

2011-11-15 Thread Gary V. Vaughan
Hi Eric, Thanks for the review! On 15 Nov 2011, at 22:07, Eric Blake wrote: > On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: >> * cfg.mk (local-checks-to-fix): Remove >> sc_cast_of_argument_to_free from list of disabled checks. >> * libltdl/config/ltmain.m4sh, libltd

Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.

2011-11-15 Thread Gary V . Vaughan
like having more checks even if they don't (yet) catch anything, rather than fewer checks. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH 23/25] syntax-check: enable sc_program_name.

2011-11-15 Thread Gary V. Vaughan
7;t check demo >> programs for use of set_program_name. >> >> Signed-off-by: Gary V. Vaughan >> --- >> cfg.mk |3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/cfg.mk b/cfg.mk >> index 1d6ca3c..48d063e 1

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

2011-11-15 Thread Gary V. Vaughan
Hi Eric, Chuck, Thanks both for taking the time to review. On 15 Nov 2011, at 23:43, Eric Blake wrote: > On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: >> * cfg.mk (local-checks-to-fix): Remove >> sc_cast_of_x_alloc_return_value from list of disabled checks. > > That che

Re: [PATCH 1/4] libtoolize: simplify file-copying and -linking call-graph.

2011-11-15 Thread Gary V. Vaughan
Hi Eric, Thanks again for taking the time to review these patches. On 16 Nov 2011, at 00:00, Eric Blake wrote: > On 11/14/2011 04:04 AM, Gary V. Vaughan wrote: >> This series of changesets are either necessary for, or at least >> make the application of the directory move patche

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-15 Thread Gary V. Vaughan
Hi Chuck, Eric, Thanks both for the review! On 15 Nov 2011, at 23:07, Charles Wilson wrote: > On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: > tests/mdemo/Makefile.am >> -## use @LIBLTDL@ because some broken makes do not accept macros in targets >> +## use $(LIBLTDL) because so

FYI: [PATCH] bootstrap: accept --gnulib-srcdir=/path/to/gnulib again.

2011-11-15 Thread Gary V. Vaughan
Petrov. Signed-off-by: Gary V. Vaughan --- libltdl/config/options-parser |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/libltdl/config/options-parser b/libltdl/config/options-parser index 4f03dce..5400833 100644 --- a/libltdl/config/options-parser +++ b/libltdl

[PATCH] bootstrap: display accurate usage message.

2011-11-15 Thread Gary V. Vaughan
Applied as obvious. After splitting bootstrap up, we also lost bootstraps usage message, and were incorrectly displaying a partial extract-trace message. * bootstrap (usage): Set appropriately. Signed-off-by: Gary V. Vaughan --- bootstrap |2 ++ 1 files changed, 2 insertions(+), 0

FYI: [PATCH] options-parser: provide a saner pluggable API.

2011-11-15 Thread Gary V. Vaughan
ep, libtool_parse_options) (libtool_validate_options): Ditto. Signed-off-by: Gary V. Vaughan --- bootstrap | 11 --- bootstrap.conf| 10 -- libltdl/config/options-parser | 25 - 3 files changed, 20 insertions(+), 26 deletions(-)

Re: [PATCH 23/25] syntax-check: enable sc_program_name.

2011-11-16 Thread Gary V. Vaughan
on't fail or can be fixed easily from the list of disabled checks. Since these tests are not doing any harm, and might catch something useful one day, there seems no reason to go to the effort of explicitly turning them off. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Gary V. Vaughan
> +make implementations that do not accept macros in targets. >> >> I suppose we can resuscitate make portability if anyone complains loudly >> enough. We may want to also ask on the automake list if this is still a >> real limitation, or whether automake has given up on worrying about this >> as well. >> > See above. When my Internet comes back reliably and I can do more than just put mail in qmail's queue for the next time I have a bit of bandwidth, I'll make sure to test the HEAD of libtool master on the architectures I have access to, including both HP/UX and IRIX. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Gary V. Vaughan
[[automake list removed from Cc:]] On 17 Nov 2011, at 08:08, Eric Blake wrote: > On 11/16/2011 06:04 PM, Gary V. Vaughan wrote: >> Right, and even when I wrote the dubious comment quoted above in 2003, other >> parts of libtool were still using macro expansions in make targets,

[PATCH] maint: generate full and correct ChangeLog.

2011-11-17 Thread Gary V. Vaughan
amend=F option. * libltdl/config/git-hooks/commit-msg: New commit message hook for git. * libltdl/config/git-log-fix: New file, with ChangeLog fixes. * HACKING (Using git): Update. Signed-off-by: Gary V. Vaughan --- HACKING | 33 +++--- Makefile.am

HOWTO: track '(tiny change)' in gitlog-to-changelog generated ChangeLog

2011-11-17 Thread Gary V . Vaughan
ains an up-to-date copy in its own git repo, and that should still be available from here (even if you are from the future, as long as it's not too far from now anyway): http://git.savannah.gnu.org/cgit/libtool.git/plain/gl/build-aux/gitlog-to-changelog.diff In the worst case, you might ne

[PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.

2011-11-21 Thread Gary V. Vaughan
e we don't reintroduce useless quoted case expressions. * build-aux/ltmain.m4sh, m4/libtool.m4, tests/bindir.at, tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test, tests/demo-nopic.test, tests/link-2.test, tests/quote.test, tests/sysroot.at: Remove spurious quotes. Signed-off-

[PATCH 4/7] syntax-check: fix violations and implement sc_prohibit_bare_basename.

2011-11-21 Thread Gary V. Vaughan
sts/fcdemo-shared.test, tests/fcdemo-static.test, tests/libtoolize.at: Fix violations. Signed-off-by: Gary V. Vaughan --- build-aux/general.m4sh | 12 ++-- build-aux/git-hooks/commit-msg |4 ++-- build-aux/ltmain.m4sh |2 +- build-aux/options-parser |6 +++-

[PATCH 3/7] tests: migrate tests/sh.test checks to syntax-checks.

2011-11-21 Thread Gary V. Vaughan
, tests/static.at, tests/stresstest.at, tests/subproject.at, tests/sysroot.at, tests/tagtrace.test, tests/testsuite.at: Fix violations of the new syntax checks. Signed-off-by: Gary V. Vaughan --- Makefile.am |3 +- bootstrap | 21 --- build-aux/edit-readme

[PATCH 7/7] syntax-check: fix violations and implement sc_prohibit_sed_s_comma.

2011-11-21 Thread Gary V. Vaughan
@list='$(pkgltdl_files)' && for p in $$list; do \ - d=`echo "$(DESTDIR)$(pkgdatadir)/$$p" |$(SED) 's,[^/]*$$,,'`; \ + d=`echo "$(DESTDIR)$(pkgdatadir)/$$p" |$(SED) 's|[^/]*$$||'`; \ test -d "$$d" || $(m

[PATCH 8/7] syntax-check: fix violations and implement sc_useless_quotes_in_case_branch.

2011-11-21 Thread Gary V. Vaughan
Hi Eric, On 21 Nov 2011, at 23:15, Eric Blake wrote: > On 11/21/2011 07:47 AM, Gary V. Vaughan wrote: >> Contrary to popular belief, Bourne shell does not resplit case >> expressions after expansion, so if there are no shell unquoted >> shell metacharacters or whitespace, t

Re: [PATCH 3/7] tests: migrate tests/sh.test checks to syntax-checks.

2011-11-21 Thread Gary V. Vaughan
itespace in $file because of the for loop, there still might be other shell meta-characters in there. All uses of $file (including a bunch in the following lines) should be quoted correctly, but that is another patch. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH 4/7] syntax-check: fix violations and implement sc_prohibit_bare_basename.

2011-11-21 Thread Gary V. Vaughan
ts/fcdemo-static.test, tests/libtoolize.at: Fix violations. >> >> Signed-off-by: Gary V. Vaughan >> >> diff --git a/build-aux/general.m4sh b/build-aux/general.m4sh >> index 1f44535..790f4e0 100644 >> --- a/build-aux/general.m4sh >> +++ b/bu

Re: [PATCH 5/7] syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.

2011-11-21 Thread Gary V. Vaughan
Hi Eric, Thanks for the feedback. On 22 Nov 2011, at 03:05, Eric Blake wrote: > On 11/21/2011 07:47 AM, Gary V. Vaughan wrote: >> Until now, libtool sources have used braced variable names >> seemingly at random! Almost always the braces are just noise, so >> remove all

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-21 Thread Gary V. Vaughan
Hi Eric, On 22 Nov 2011, at 03:07, Eric Blake wrote: > On 11/21/2011 07:47 AM, Gary V. Vaughan wrote: >> To safely use a non-literal first argument to `test', you must >> always prepend a literal non-`-' character, but often the second >> operand is a con

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-21 Thread Gary V. Vaughan
so, > it goes against the (unofficial) conventions of autoconf, which is > to use either `test "x$b" = xa' or `test "x$b" = Xa'. I was unable to find any shells that choke on: test a != -b || echo bug Where it's easy to upset test with: t

Re: [PATCH 8/7] syntax-check: fix violations and implement sc_useless_quotes_in_case_branch.

2011-11-22 Thread Gary V. Vaughan
Hi Eric, On 22 Nov 2011, at 12:09, Gary V. Vaughan wrote: > On 21 Nov 2011, at 23:15, Eric Blake wrote: >> On 11/21/2011 07:47 AM, Gary V. Vaughan wrote: >>> Contrary to popular belief, Bourne shell does not resplit case >>> expressions after expansion, so if there are

FYI: [PATCH] build: fix a quoting bug when regenerating with bootstrap_edit.

2011-11-25 Thread Gary V. Vaughan
Applied as obvious. * Makefile.am (m4/ltversion.m4, build-aux/ltmain.sh): The bootstrap_edit make macro already contains double quotes, so when echoing it, don't surround it with more double quotes since it is not escaped. Signed-off-by: Gary V. Vaughan --- Makefile.am |4 ++-- 1

FYI: [PATCH] maint: quote $file correctly in bootstrap.

2011-11-25 Thread Gary V. Vaughan
From: "Gary V. Vaughan" Applied as obvious. * bootstrap (func_insert_sorted_if_absent): Don't forget the double quotes, since we can't control the content of $file. Reported by Steffano Lattarini. Signed-off-by: Gary V. Vaughan --- bootstrap |6 +++--- 1 files changed

[PATCH 1/4] libtoolize: rename and reorder copy filter functions.

2011-11-25 Thread Gary V. Vaughan
_m4_filter) (require_configure_ac_filter): Renamed from these... (require_filter_Makefile_am, require_filter_ltdl_mk) (require_filter_aclocal_m4, require_filter_configure_ac): ...to these, respectively. Move the definitions to maintain asciibetical ordering of require functions. Signed-off-by: Gary

[PATCH 2/4] maint: share useful functions from general.m4sh.

2011-11-25 Thread Gary V. Vaughan
func_append. * tests/getopt-m4sh.at (_LT_AT_FALLBACK_FUNC_EXTRACT): Removed. Fallback functions are now in any m4sh generated file automatically. Signed-off-by: Gary V. Vaughan --- build-aux/general.m4sh | 42 ++ build-aux/ltmain.m4sh | 31

[PATCH 4/4] libtoolize: refactor copying filter creation.

2011-11-25 Thread Gary V. Vaughan
scripts for func_copy filtering. (require_filter_Makefile_am, require_filter_aclocal_m4) (require_filter_configure_ac): Simplify. (require_ltdl_relative_aux_dir): Remove. (require_ltdl_relative_macro_dir): Ditto. Signed-off-by: Gary V. Vaughan --- libtoolize.m4sh | 167

[PATCH 3/4] maint: pick XSI funcs at runtime, not configure time.

2011-11-25 Thread Gary V. Vaughan
, func_stripname and func_dirname_and_basename. * NEWS: Updated. Signed-off-by: Gary V. Vaughan --- NEWS |4 + build-aux/general.m4sh | 162 --- build-aux/getopt.m4sh | 38 ++-- build-aux/ltmain.m4sh | 33 -- m4

[PATCH 01/10] tests: migrate legacy tests/cdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
test, tests/cdemo-undef-make.test, tests/cdemo-undef.test: ...these legacy test cases, now removed. tests/cdemo/Makefile.am, tests/cdemo/README, tests/cdemo/configure.ac, tests/cdemo/foo.c, tests/cdemo/foo.h, tests/cdemo/main.c: Remove. * configure.ac (CONF_SUBDIRS): Remove tests/cdemo. * Makefile.am:

[PATCH 04/10] tests: migrate legacy tests/tagdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
/conv.cpp, tests/tagdemo/conv.h, tests/tagdemo/foo.cpp, tests/tagdemo/foo.h, tests/tagdemo/main.cpp: Remove. * configure.ac (CONF_SUBDIRS): Remove tests/tagdemo. * Makefile.am: Adjust. Signed-off-by: Gary V. Vaughan --- Makefile.am| 32 +--- configure.ac

[PATCH 07/10] tests: migrate legacy tests/mdemo2 tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
. * configure.ac (CONF_SUBDIRS): Remove tests/mdemo2. * Makefile.am: Adjust. Signed-off-by: Gary V. Vaughan --- Makefile.am |9 + configure.ac |3 +- tests/mdemo.at| 83 + tests/mdemo2-conf.test

[PATCH 05/10] tests: migrate legacy tests/pdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
, tests/pdemo/longer_file_name_hell2.c, tests/pdemo/longer_file_name_hello.c, tests/pdemo/longer_file_name_main.c: Remove. * configure.ac (CONF_SUBDIRS): Remove tests/pdemo. * Makefile.am: Adjust. Signed-off-by: Gary V. Vaughan --- Makefile.am |9 -- configure.ac

[PATCH 08/10] tests: migrate legacy tests/f77demo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
. * configure.ac (CONF_SUBDIRS): Remove tests/f77demo. Signed-off-by: Gary V. Vaughan --- Makefile.am| 41 +- configure.ac |2 +- tests/f77demo-conf.test| 34 tests/f77demo-exec.test| 35 - tests/f77demo-make.test

[PATCH 10/10] bootstrap: remove support for `-r' and `reconf_dirs'.

2011-11-25 Thread Gary V. Vaughan
se_options) (libtool_validate_options): Remove. Signed-off-by: Gary V. Vaughan --- bootstrap.conf | 175 +--- 1 files changed, 41 insertions(+), 134 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index f7bc1ac..8763a33 100644 --- a/bootstrap.conf +++ b/boot

[PATCH 09/10] tests: migrate legacy tests/fcdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
, distdir) (fake-distclean-legacy, $(DIST_MAKEFILE_LIST)): Remove. (COMMON_TESTS): Rename from this... (TESTS): ...to this. Signed-off-by: Gary V. Vaughan --- .gitignore|1 - Makefile.am | 64 +--- configure.ac | 11 -- tests

Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.

2011-11-25 Thread Gary V. Vaughan
On 21 Nov 2011, at 21:47, Gary V. Vaughan wrote: > I'll push the whole series in 72 hours or so as usual. Pushed. > [[snip]] > > Contrary to popular belief, Bourne shell does not resplit case > expressions after expansion, so if there are no shell unquoted > shell metac

Re: [PATCH 01/10] tests: migrate legacy tests/cdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
http://vaughan.pe/libtool/libtool-2.4.2.135-aa59c.tar.xz > But > then you should allow for more than three days for sending feedback > -- at least a week. That's fine, and running on those arches would be a great help in giving me confidence the migration didn't break anything. It'll take me at least a week to redo everything into smaller pieces anyway... (unless you think the time spent here will not make much difference to your review). But do let me know either way :) And thanks also for offering to make the time to look them over. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

[PATCH] maint: Fix generated ChangeLog typos.

2011-11-25 Thread Gary V. Vaughan
Applied as obvious. * build-aux/git-log-fix: Spell Stefano Lattarini's name correctly. Don't use my home email address for GNU commits. Signed-off-by: Gary V. Vaughan --- build-aux/git-log-fix | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a

[PATCH] m4: fix logic error leading to -fno-rtti being added wrongly.

2011-11-25 Thread Gary V. Vaughan
Applied as the obvious fix for an error in translation in commit 962aa919. * m4/libtool.m4 (_LT_COMPILER_OPTION): Negate comparison so that compiler flags are added correctly. Signed-off-by: Gary V. Vaughan --- m4/libtool.m4 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH 01/10] tests: migrate legacy tests/cdemo tests to Autotest.

2011-11-25 Thread Gary V. Vaughan
Hi Chuck, On 26 Nov 2011, at 11:39, Charles Wilson wrote: > On 11/25/2011 4:10 AM, Gary V. Vaughan wrote: >> As usual, subject to feedback, I'll push this whole series in >> 72 hours or so. Make distcheck passes for me on my Mac 10.7 and >> my Arch Linux x86_64 machines

Re: [PATCH 3/4] maint: pick XSI funcs at runtime, not configure time.

2011-11-28 Thread Gary V. Vaughan
Hi Peter, On 28 Nov 2011, at 15:48, Peter Rosin wrote: > Gary V. Vaughan skrev 2011-11-25 09:57: >> Determine, on a function by function basis, what XSI features >> are available in the shell that is actually running the script, >> rather than the one that was picked at

Re: [PATCH 3/4] maint: pick XSI funcs at runtime, not configure time.

2011-11-28 Thread Gary V. Vaughan
Hi Peter, On 28 Nov 2011, at 18:05, Peter Rosin wrote: > Gary V. Vaughan skrev 2011-11-28 10:20: >> On 28 Nov 2011, at 15:48, Peter Rosin wrote: >>> Gary V. Vaughan skrev 2011-11-25 09:57: >>>> Determine, on a function by function basis, what XSI features >>&

FYI: [PATCH 1/5] bootstrap: make sure patch is available to bootstrap if necessary.

2011-12-07 Thread Gary V. Vaughan
Signed-off-by: Gary V. Vaughan --- bootstrap | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/bootstrap b/bootstrap index ae65e37..81a4a0d 100755 --- a/bootstrap +++ b/bootstrap @@ -556,6 +556,7 @@ func_gnulib

FYI: [PATCH 2/5] bootstrap: ensure consistent function header comments.

2011-12-07 Thread Gary V. Vaughan
* bootstrap (require_bootstrap_uptodate) (require_buildtools_uptodate): Use `require_...' in header comment for these functions to be consistent with the rest, rather than `func_require_...'. Signed-off-by: Gary V. Vaughan --- bootstrap |8 1 files changed, 4 insert

FYI:[PATCH 3/5] bootstrap: use _buildreq as a prefix for better ordering.

2011-12-07 Thread Gary V. Vaughan
, require_buildreq_autopoint) (require_buildreq_libtoolize, require_buildreq_patch): ...to these, respectively. Adjust all callers. Signed-off-by: Gary V. Vaughan --- bootstrap | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/bootstrap b

FYI: [PATCH 4/5] bootstrap: reorder function definitions to keep func_buildreq_* together.

2011-12-07 Thread Gary V. Vaughan
From: "Gary V. Vaughan" * bootstrap: Restore asciibetical order, so that all the buildreq function definitions are together. Signed-off-by: Gary V. Vaughan --- bootstrap | 252 ++-- 1 files changed, 126 insertions(+), 126

FYI: [PATCH 5/5] bootstrap: escape quotes properly in generated functions.

2011-12-07 Thread Gary V. Vaughan
* bootstrap: Although not a real bug, for consistency, be sure to correctly escape single quotes inside a single quoted function generator. Signed-off-by: Gary V. Vaughan --- bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bootstrap b/bootstrap index 5cd9cb0

FYI: [PATCH 1/3] libtoolize: rename ltdl.mk filter function.

2011-12-08 Thread Gary V. Vaughan
from this... (require_ltdl_mk_filter): ...to this. Adjust all callers. Signed-off-by: Gary V. Vaughan --- libtoolize.m4sh | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libtoolize.m4sh b/libtoolize.m4sh index 31bbf3e..65972e7 100644 --- a

FYI: [PATCH 2/3] libtoolize: use _filter as a prefix for better ordering.

2011-12-08 Thread Gary V. Vaughan
, respectively. Adjust all callers. (Makefile_am_filter, ltdl_mk_filter, aclocal_m4_filter) (configure_ac_filter): Rename these global variables from this... (filter_Makefile_am, filter_ltdl_mk, filter_aclocal_m4) (filter_configure_ac): ...to this, respectively. Signed-off-by: Gary V. Vaughan

FYI: [PATCH 3/3] libtoolize: reorder function definitions to keep func_filter_* together.

2011-12-08 Thread Gary V. Vaughan
* libtoolize: Restore asciibetical order, so that all the filter function definitions are together. Signed-off-by: Gary V. Vaughan --- libtoolize.m4sh | 242 +++--- 1 files changed, 121 insertions(+), 121 deletions(-) diff --git a

Re: [PATCH 3/4] maint: pick XSI funcs at runtime, not configure time.

2011-12-08 Thread Gary V. Vaughan
allel builds. > > I have become used to seeing substantial speedup with 'make -j 4' on a > Windows system with four cores. I just pushed the series containing this patch, but refactored to add only 3 additional forks per invocation, and with a patch to follow which might be good enough to eliminate even those 3 forks on windows machines. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

FYI: [PATCH] bootstrap: put back missing spaces before parens.

2011-12-08 Thread Gary V. Vaughan
d add it to `$buildreq'. require_buildreq_automake=func_require_buildreq_automake -func_require_buildreq_automake() +func_require_buildreq_automake () { $debug_cmd -- 1.7.8 Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

FYI: [PATCH] maint: eliminate some more spurious leading Xs.

2011-12-08 Thread Gary V. Vaughan
Applied as obvious. * m4/libtool.m4: Reverse argument order to eliminate spurious leading X's. Signed-off-by: Gary V. Vaughan --- m4/libtool.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/libtool.m4 b/m4/libtool.m4 index 0eef323..9c2574f 100644 ---

[PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Gary V. Vaughan
. Signed-off-by: Gary V. Vaughan --- build-aux/general.m4sh | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/build-aux/general.m4sh b/build-aux/general.m4sh index 252b2d2..2ac6238 100644 --- a/build-aux/general.m4sh +++ b/build-aux/general.m4sh @@ -56,6 +56,7

FYI: [PATCH] tests: make sure file restore traps are called correctly on AIX.

2011-12-08 Thread Gary V. Vaughan
(func_save_files): Ditto. Reported by Stefano Lattarini. Signed-off-by: Gary V. Vaughan --- tests/demo-noinst-link.test |5 - tests/demo-relink.test |4 +++- tests/depdemo-relink.test |4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/demo-noinst

FYI: [PATCH] tests: s/snippit/snippet/.

2011-12-08 Thread Gary V. Vaughan
Applied as obvious. * tests/demo/foo.h, tests/pdemo/foo.h: Spell `snippet' correctly. Reported by Stefano Lattarini. Signed-off-by: Gary V. Vaughan --- tests/demo/foo.h |2 +- tests/pdemo/foo.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/demo/fo

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Gary V. Vaughan
Hi Peter, On 8 Dec 2011, at 20:40, Peter O'Gorman wrote: > On 12/08/2011 04:21 AM, Gary V. Vaughan wrote: >> The recently pushed series of patches included the controversial >> introduction of an additional 3 forks per invocation, which might >> add a minute or two o

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Gary V. Vaughan
Hi Eric, On 8 Dec 2011, at 19:56, Eric Blake wrote: > On 12/08/2011 03:21 AM, Gary V. Vaughan wrote: >> The recently pushed series of patches included the controversial >> introduction of an additional 3 forks per invocation, which might >> add a minute or two of wall-clock

[PATCH 1/2] maint: disable prohibit_always-defined_macros syntax check.

2011-12-08 Thread Gary V. Vaughan
... (local-checks-to-skip): ...to here. Reported by Peter O'Gorman. Signed-off-by: Gary V. Vaughan --- cfg.mk |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index dc89660..ef1637a 100644 --- a/cfg.mk +++ b/cfg.mk @@ -38,7 +38,6 @@

FYI [PATCH] libtool: minimise forks per invocation under bash.

2011-12-17 Thread Gary V. Vaughan
ything else if they do not work. -# NOTE: You can short-circuit the fork and test on every invocation (e.g. -# on Windows where fork emulations are unreasonably slow) by setting this -# in the environment of this script. test -z "$lt_HAVE_XSI_OPS" \ && (eval 'x=a/b/c; test 5aa/bb/cc = "${#x}${x%%/*}${x%/*}${x#*/}${x##*/}"') 2>/dev/null \ -- 1.7.8 Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

FYI: [PATCH] bootstrap: adopt autoconf echo normalization code.

2011-12-17 Thread Gary V. Vaughan
be overly long. Reported by Reuben Thomas. Signed-off-by: Gary V. Vaughan --- bootstrap| 20 +++--- build-aux/extract-trace |8 +++--- build-aux/options-parser | 60 ++--- 3 files changed, 64 insertions(+), 24 deletion

Re: FYI [PATCH] libtool: minimise forks per invocation under bash.

2011-12-18 Thread Gary V. Vaughan
Hi Stefano, On 18 Dec 2011, at 17:02, Stefano Lattarini wrote: > On 12/18/2011 10:52 AM, Stefano Lattarini wrote: >> On 12/18/2011 06:15 AM, Gary V. Vaughan wrote: >>> +# We should try to minimise forks, especially on Windows where they are >>> +# unreasonably slow,

Re: FYI [PATCH] libtool: minimise forks per invocation under bash.

2011-12-18 Thread Gary V. Vaughan
Hi Stefano, On 18 Dec 2011, at 17:19, Stefano Lattarini wrote: > On 12/18/2011 11:07 AM, Gary V. Vaughan wrote: >> On 18 Dec 2011, at 17:02, Stefano Lattarini wrote: >>> On 12/18/2011 10:52 AM, Stefano Lattarini wrote: >>>> On 12/18/2011 06:15 AM, Gary V. Vaughan wr

FYI: [PATCH] libtool: make fork minimisation compatible with dash and zsh.

2011-12-18 Thread Gary V. Vaughan
Stefano Lattarini. Signed-off-by: Gary V. Vaughan --- build-aux/general.m4sh | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/build-aux/general.m4sh b/build-aux/general.m4sh index e96c0e4..3cfecee 100644 --- a/build-aux/general.m4sh +++ b/build-aux/general.m4sh

Re: FYI: [PATCH] bootstrap: adopt autoconf echo normalization code.

2011-12-23 Thread Gary V. Vaughan
Hi Eric, On 19 Dec 2011, at 20:48, Eric Blake wrote: > On 12/18/2011 12:46 AM, Gary V. Vaughan wrote: >> Pushed as obvious. >> >> Dash shipped with Ubutu-11.10 as /bin/sh, among others, still >> has a crippled echo builtin that mis-handles backslashes. > >

FYI: [PATCH] gnulib: update gnulib submodule.

2011-12-23 Thread Gary V. Vaughan
todays master HEAD revision. Signed-off-by: Gary V. Vaughan --- gnulib |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gnulib b/gnulib index f51babf..576e46c 16 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit f51babfaf400eb509f854cad509f5e649b9182b1

FYI: [PATCH] bootstrap: fix Autoconf version typo.

2011-12-23 Thread Gary V. Vaughan
Pushed as obvious. I must have forgotten to rerun `git add build-aux/options-parser` in my local tree between fixing this very short-lived typo and pushing the patch that came after it. Sorry about that. * build-aux/options-parses: s/2\.62/2.68/ Signed-off-by: Gary V. Vaughan --- build-aux

FYI: [PATCH] gnulib: update gnulib submodule.

2011-12-23 Thread Gary V. Vaughan
ixes the reference to a local commit. * gnulib: Updated to todays master HEAD revision. * gl/top/README-release.diff: Update to account for changes to gnulib/top/README-release since the last gnulib update. Signed-off-by: Gary V. Vaughan --- gl/top/README-release.diff |

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Gary V. Vaughan
...but I never got that to work in the test. It worked in an > interactive bash though. Strange. M4 will strip one level of square brackets as it generates the testsuite script. Normally we just put an extra level of quoting around regexps/globs to account for that: [*" "[^-]* | *" "-[^D]*]) real_pic=: ;; (untested -- still on vacation ;-) Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Gary V. Vaughan
nyway... Thanks for finding it, and sparing me from the additional shame. > Bottom line: More eyes needed on that patch! > > Ok to push the below? I think it will be safer to revert the broken patch, and then write a script to reapply those changes automatically as I should have done originally, and only then to merge the result back to head. If you hold off for a few days, I'll do that as penance for my sins when I get back to my computer. But please hold on to your test case to verify that I've made a better job of things on the do over. > Cheers, > Peter Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-21 Thread Gary V. Vaughan
Hi Peter, On 19 Sep 2012, at 21:50, Peter Rosin wrote: > On 2012-09-19 16:20, Gary V. Vaughan wrote: >> Hi Peter, >> >> My bad, I'm embarrassed to say. I started to write a script to make the >> appropriate changes, but ended up doing it manually rather tha

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-26 Thread Gary V. Vaughan
> Hi Peter, Ping? > On 19 Sep 2012, at 21:50, Peter Rosin wrote: > >> On 2012-09-19 16:20, Gary V. Vaughan wrote: >>> Hi Peter, >>> >>> My bad, I'm embarrassed to say. I started to write a script to make the >>> appropriate changes, bu

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-27 Thread Gary V. Vaughan
Hi Peter, On 27 ก.ย. 2012, at 5:03, Peter Rosin wrote: > On 2012-09-26 14:57, Peter Rosin wrote: >> On 2012-09-22 05:31, Gary V. Vaughan wrote: > > [Heavily snipped] > >> Why not commit the sc_prohibit_test_const_follows_var improvement >> last, after fixing all

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-10-02 Thread Gary V. Vaughan
Hi Peter, Sorry for the delay, it was more complicated than I had imagined :-o On 28 Sep 2012, at 11:08, "Gary V. Vaughan" wrote: > On 27 ก.ย. 2012, at 5:03, Peter Rosin wrote: >> On 2012-09-26 14:57, Peter Rosin wrote: >>> On 2012-09-22 05:31, Gary V. Vaughan wr

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-10-02 Thread Gary V. Vaughan
e world a better place! :-) > I just fired up a test suite run... Thanks! I'm crossing my fingers -- I'll sleep a lot better when we've put this one behind us. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-10-05 Thread Gary V. Vaughan
Hi Peter, On Oct 3, 2012, at 4:53 PM, Peter Rosin wrote: > On 2012-10-03 05:45, Gary V. Vaughan wrote: >> On Oct 3, 2012, at 12:32 AM, Peter Rosin wrote: >>> I just fired up a test suite run... > > Good news! Clean runs on Cygwin, MSYS/MinGW and MSYS/MSVC. Awesome.

Windows Line Endings [WAS Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-273-ge24f183]

2012-10-05 Thread Gary V. Vaughan
gt; $1.t && mv -f $1.t $1 (untested on Windows, but doesn't mess with whitespace on Mac or Linux) Please do push patches that improve the situation for Windows rather than holding out for a fix-all mega-patch. This will allow us to keep each other informed of breakages on platforms the other doesn't have access to. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)

Re: Windows Line Endings

2012-10-05 Thread Gary V. Vaughan
Hi Eric, On 5 Oct 2012, at 23:42, Eric Blake wrote: > On 10/05/2012 10:03 AM, Gary V. Vaughan wrote: >> Is there a legal way to get access >> to Windows and the various flavours of gcc and MSVC that libtool users >> care about, without spending hundreds of dollars on soft

<    1   2   3   4   5   6   7   8   9   10   >