FYI [PATCH] libtoolize: remove NL2SP and initialisation.

Cherry picked from my patch queue and applied as obvious. There's only a single use of NL2SP, and that is redundant. * libtoolize.m4sh (func_serial_update): Factor away use of NL2SP. (NL2SP, SP2NL): Remove initialisation. Signed-off-by: Gary V. Vaughan --- libtoolize.m4sh | 15 +--

[PATCH 01/25] syntax-check: skip sc_unmarked_diagnostics.

Taking advantage of more of the nice development tools that gnulib gives us, this series of patches gradually fixes problems flagged by the builtin `make syntax-check' tests, re-enabling the newly passing checks as it goes. There's nothing really controversial in here anywhere, but I won't push fo

[PATCH 02/25] syntax-check: fix violations and re-enable sc_avoid_if_before_free.

* cfg.mk (local-checks-to-fix): Remove sc_avoid_if_before_free from list of disabled checks. According to gnulib/doc/free.texi: "On old platforms such as SunOS4, @code{free (NULL)} fails. However, since all such systems are so old as to no longer be considered ``reasonable portability targets,'' t

[PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

* cfg.mk (local-checks-to-fix): Remove sc_cast_of_argument_to_free from list of disabled checks. * libltdl/config/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, libltdl/lt__dirent.c: Casting argument to free is never necessary. Signed-off-by: Gary V. Vaughan --- build-aux/ltmain.m4sh |2 +-

[PATCH 05/25] syntax-check: fix violations and re-enable sc_error_message_uppercase.

* cfg.mk (local-checks-to-fix): Remove sc_error_message_uppercase from list of disabled checks. (exclude_file_name_regexp--sc_error_message_uppercase): Don't match cvsu, which is not our file to edit. * doc/libtool.texi: Use lowercase error message in example. Signed-off-by: Gary V. Vaughan ---

[PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

* cfg.mk (local-checks-to-fix): Remove sc_cast_of_x_alloc_return_value from list of disabled checks. * libltdl/config/ltmain.m4sh (XMALLOC, XFREE): Unroll into their xmalloc and free expansions so that this syntax-check can find violations, and then fix them. * iibltdl/libltdl/lt__alloc.h (MALLOC,

[PATCH 06/25] syntax-check: fix violations and re-enable sc_file_system.

* cfg.mk (local-checks-to-fix): Remove sc_file_system from list of disabled checks. (VC_LIST_ALWAYS_EXCLUDE_REGEX): Match mail directory correctly to avoid running its contents through syntax-check. * libltdl/config/ltmain.m4sh (func_mode_link): Use correct spelling for "file system". * libltdl/ltd

[PATCH 07/25] syntax-check: fix violations and re-enable sc_m4_quote_check.

* cfg.mk (local-checks-to-fix): Remove sc_m4_quote_check from list of disabled checks. * libltdl/m4/libtool.m4 (_LT_CHECK_OBJDIR): Quote LT_OBJDIR correctly. Signed-off-by: Gary V. Vaughan --- cfg.mk|1 - m4/libtool.m4 |2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff

[PATCH 08/25] syntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation.

* cfg.mk (local-checks-to-fix): Remove sc_makefile_TAB_only_indentation from list of disabled checks. * Makefile.am (libltdl/Makefile.am): Replace leading spaces with TABs. * libltdl/Makefile.am (libltdl_libltdl_la_SOURCES): Ditto. Signed-off-by: Gary V. Vaughan --- Makefile.am | 10 +-

[PATCH 10/25] syntax-check: fix violations and re-enable sc_prohibit_cvs_keyword.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_cvs_keyword from list of disabled checks. * tests/tagdemo/README: Remove spurious CVS keyword. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - tests/tagdemo/README |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) di

[PATCH 11/25] syntax-check: fix violations and re-enable sc_prohibit_doubled_word.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_doubled_word from list of disabled checks. * libltdl/config/general.m4sh (func_quote_for_eval): Remove one of a pair of "and"s in a comment. * tests/lt_dladvise.at (hint_global): Remove one of a pair of consecutive "to"s split across lines in a com

[PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

* cfg.mk (local-checks-to-fix): Remove sc_makefile_at_at_check from list of disabled checks. * configure.ac (order-only prerequisites): Test with the order-only pipe symbol in a macro. * Makefile.am, tests/mdemo/Makefile.am: Convert all @FOO@ to $(FOO). Signed-off-by: Gary V. Vaughan --- Makefil

[PATCH 17/25] syntax-check: fix violations and re-enable sc_probibit_test_minus_ao.

* cfg.mk (local-checks-to-fix): Remove sc_probhibit_test_minus_ao from list of disabled checks. (exclude_file_name_regexp--sc_prohibit_tests_minus_ao): The matches from this syntax-check in libtool.m4 are all bogus. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 ++- 1 files changed, 2 inserti

[PATCH 15/25] syntax-check: fix violations and re-enable sc_prohibit_stddef_without_use.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_stddef_without_use from list of disabled checks. * libltdl/argz.c, libltdl/lt__dirent.c, libltdl/slist.c: Remove spurious stddef.h #include lines. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - libltdl/argz.c |1 - l

[PATCH 12/25] syntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_empty_lines_at_EOF from list of disabled checks. * THANKS, libltdl/argz.c, libltdl/config/getopt.m4sh, tests/f77demo/README, tests/f77demo/cprogram.c, tests/f77demo/fprogram.f, tests/fcdemo/README, tests/fcdemo/cprogram.c, tests/libtoolize.at, test

[PATCH 14/25] syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_magic_number_exit from list of disabled checks. * ltmain.c: Removed unused file. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - ltmain.c | 36 2 files changed, 0 insertions(+), 37 deletions(-) delet

[PATCH 13/25] syntax-check: fix violations and re-enable sc_prohibit_have_config_h.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_have_config_h from list of disabled checks. * tests/f77demo/foo.h, tests/fcdemo/foo.h: Remove spurious HAVE_CONFIG_H guards for #include . Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - tests/f77demo/foo.h |2 -- tests/fcde

[PATCH 18/25] syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_undesirable_word_seq from list of disabled checks. * doc/libtool.texi, libltdl/config/ltmain.m4sh, libltdl/m4/libtool.m4, libtoolize.m4sh: Replace all uses of "can not" with "cannot". Signed-off-by: Gary V. Vaughan Conflicts: libtoolize

[PATCH 16/25] syntax-check: fix violations and re-enable sc_prohibit_strcmp.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_strcmp from list of disabled checks. (exclude_file_name_regexp--sc_prohibit_strcmp): Ignore violations in libtool.texi and any demo C files. * libltdl/libltdl/lt__private.h (strneq, streq): Renamed from this... (STRNEQ, STREQ): ..to this. Adjust a

[PATCH 20/25] syntax-check: fix violations and re-enable sc_useless_cpp_parens.

* cfg.mk (local-checks-to-fix): Remove sc_useless_cpp_parens from list of disabled checks. * doc/libtool.texi, libltdl/argz.c, libltdl/argz_.h, libltdl/config/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, libltdl/libltdl/lt__dirent.h, libltdl/libltdl/lt__glibc.h, libltdl/libltdl/lt__private.h, libltdl/

[PATCH 19/25] syntax-check: fix violations and re-enable sc_space_tab.

* cfg.mk (local-checks-to-fix): Remove sc_space_tab from list of disabled checks. (exclude_file_name_regexp--sc_space_tab): Don't flag space-tab sequences in diff files as an error. * Makefile.am, libltdl/Makefile.in, libltdl/config/general.m4sh, libltdl/config/ltmain.m4sh, libltdl/loaders/dyld.c,

[PATCH 22/25] syntax-check: enable sc_bindtextdomain.

* cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --gi

[PATCH 23/25] syntax-check: enable sc_program_name.

* cfg.mk (local-checks-to-skip): Remove sc_program_name list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH 24/25] syntax-check: enable sc_prohibit_always_true_header_tests.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_always_true_header_tests from list of disabled checks, because it no longer flags any violations. Signed-off-by: Gary V. Vaughan --- cfg.mk |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index 48d063e..d

[PATCH 21/25] syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676.

* cfg.mk (local-checks-to-fix): Move sc_trailing_blank from here... (local-checks-to-skip): ...to here, because otherwise it flags valid RFC3676 signature blocks. (sc_trailing_blank-non-rfc3676): An improved sc_trailing_blank implementation that doesn't flag signature blocks as violations. * Makefi

[PATCH 25/25] dist: hook syntax-check into `make distcheck'.

To make sure we don't accidentally release anything with failing syntax-checks, have `make distcheck' run the syntax-checks automatically. * Makefile.am (distcheck-hook): New rule depending on syntax-check. Signed-off-by: Gary V. Vaughan --- Makefile.am |2 ++ 1 files changed, 2 insertions(+

FYI: [PATCH] gnulib: update gnulib submodule.

Applied as obvious, to collect some bug fixes and move one of our local gnulib patches upstream where it belongs. Among others, this fixes a bug in _build-aux expansion so that `make syntax-check' works again. * gnulib: Updated to todays master HEAD revision. * gl/top/maint.mk.diff: Remove. This p

Re: [PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: > * cfg.mk (local-checks-to-fix): Remove > sc_cast_of_argument_to_free from list of disabled checks. > * libltdl/config/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, > libltdl/lt__dirent.c: Casting argument to free is never > necessary. Not true; sometime

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: > * cfg.mk (local-checks-to-fix): Remove > sc_cast_of_x_alloc_return_value from list of disabled checks. That check is only useful for pure C projects. If the intention is that libtool can be compiled under both C and C++, then C++ requires that you

Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.

On Tuesday 15 November 2011, Gary V wrote: > * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain > list of disabled checks. > (exclude_file_name_regexp--sc_program_name): Don't check demo s|set_program_name|bindtextdomain| here? > programs for use of set_program_name. > And here as well? Re

Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.

On Tuesday 15 November 2011, Gary V wrote: > * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain > list of disabled checks. > (exclude_file_name_regexp--sc_program_name): Don't check demo > programs for use of set_program_name. > > Signed-off-by: Gary V. Vaughan > --- > cfg.mk |3 +-- >

Re: [PATCH 23/25] syntax-check: enable sc_program_name.

On Tuesday 15 November 2011, Gary V wrote: > * cfg.mk (local-checks-to-skip): Remove sc_program_name > list of disabled checks. > (exclude_file_name_regexp--sc_program_name): Don't check demo > programs for use of set_program_name. > > Signed-off-by: Gary V. Vaughan > --- > cfg.mk |3 +-- >

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: > * cfg.mk (local-checks-to-fix): Remove > sc_cast_of_x_alloc_return_value from list of disabled checks. > * libltdl/config/ltmain.m4sh (XMALLOC, XFREE): Unroll into their > xmalloc and free expansions so that this syntax-check can find > violations, an

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

On 11/15/2011 11:36 AM, Charles Wilson wrote: > On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: >> * cfg.mk (local-checks-to-fix): Remove >> sc_cast_of_x_alloc_return_value from list of disabled checks. >> * libltdl/config/ltmain.m4sh (XMALLOC, XFREE): Unroll into their >> xmalloc and free expansions

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: tests/mdemo/Makefile.am > -## use @LIBLTDL@ because some broken makes do not accept macros in targets > +## use $(LIBLTDL) because some broken makes do not accept macros in targets This comment now makes zero sense. If you are now forcing the following

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

On 11/15/2011 09:49 AM, Charles Wilson wrote: > On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: > tests/mdemo/Makefile.am >> -## use @LIBLTDL@ because some broken makes do not accept macros in targets >> +## use $(LIBLTDL) because some broken makes do not accept macros in targets > > This comment no

Re: [PATCH 1/4] libtoolize: simplify file-copying and -linking call-graph.

On 11/14/2011 04:04 AM, Gary V. Vaughan wrote: > This series of changesets are either necessary for, or at least > make the application of the directory move patches coming in the > next set as straight forward as possible. > > It turns out that we haven't needed to fork a tar process for > every

Re: [PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

Hi Eric, Thanks for the review! On 15 Nov 2011, at 22:07, Eric Blake wrote: > On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: >> * cfg.mk (local-checks-to-fix): Remove >> sc_cast_of_argument_to_free from list of disabled checks. >> * libltdl/config/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, >> lib

Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.

Hi Stefano, Thanks for the review. > On Tuesday 15 November 2011, Gary V wrote: >> * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain >> list of disabled checks. >> (exclude_file_name_regexp--sc_program_name): Don't check demo > s|set_program_name|bindtextdomain| here? > >> programs for u

Re: [PATCH 23/25] syntax-check: enable sc_program_name.

Hi Stefano, Thanks for the review. On 15 Nov 2011, at 22:39, Stefano Lattarini wrote: > On Tuesday 15 November 2011, Gary V wrote: >> * cfg.mk (local-checks-to-skip): Remove sc_program_name >> list of disabled checks. >> (exclude_file_name_regexp--sc_program_name): Don't check demo >> programs fo

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

Hi Eric, Chuck, Thanks both for taking the time to review. On 15 Nov 2011, at 23:43, Eric Blake wrote: > On 11/15/2011 05:53 AM, Gary V. Vaughan wrote: >> * cfg.mk (local-checks-to-fix): Remove >> sc_cast_of_x_alloc_return_value from list of disabled checks. > > That check is only useful for pur

Re: [PATCH 1/4] libtoolize: simplify file-copying and -linking call-graph.

Hi Eric, Thanks again for taking the time to review these patches. On 16 Nov 2011, at 00:00, Eric Blake wrote: > On 11/14/2011 04:04 AM, Gary V. Vaughan wrote: >> This series of changesets are either necessary for, or at least >> make the application of the directory move patches coming in the >>

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

Hi Chuck, Eric, Thanks both for the review! On 15 Nov 2011, at 23:07, Charles Wilson wrote: > On 11/15/2011 7:53 AM, Gary V. Vaughan wrote: > tests/mdemo/Makefile.am >> -## use @LIBLTDL@ because some broken makes do not accept macros in targets >> +## use $(LIBLTDL) because some broken makes do n

FYI: [PATCH] bootstrap: accept --gnulib-srcdir=/path/to/gnulib again.

Applied as obvious. During the split of bootstrap into options-parser and extract-trace, the generic long-option splitting code got lost. * libltdl/config/options-parser (func_parse_options): Add the code to split any long option separated by an equals from its optarg back in. Reported by Roumen P

[PATCH] bootstrap: display accurate usage message.

Applied as obvious. After splitting bootstrap up, we also lost bootstraps usage message, and were incorrectly displaying a partial extract-trace message. * bootstrap (usage): Set appropriately. Signed-off-by: Gary V. Vaughan --- bootstrap |2 ++ 1 files changed, 2 insertions(+), 0 deletions

FYI: [PATCH] options-parser: provide a saner pluggable API.

Applied as on obvious and straight-forward improvement. I have a few more cleanups to implement, and then I'll try again to move all of bootstrap and it's supporting code into gnulib, leaving just bootstrap.conf in libtool as it should be. It's much too easy to forget that the functions you hook