Fix cwrapper test failure with --disable-static.

2010-11-10 Thread Ralf Wildenhues
shows among others (some of which are NixOS and not Libtool issues) the following failure: libtool: compile: gcc -g -O2 -c m.c -fPIC -DPIC -o .libs/m.o ./cwrapper.at:255: $LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m1$EXEEXT m.$OBJEXT foo/liba.la s

Re: Fix cwrapper test failure with --disable-static.

2010-11-10 Thread Charles Wilson
On 11/10/2010 1:29 PM, Ralf Wildenhues wrote: > > -AT_CHECK([$LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c m.c], > - [], [ignore], [ignore]) > +AT_CHECK([$CC $CPPFLAGS $CFLAGS -c m.c], [], [ignore], [ignore]) > > AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m1$EXE

Re: Fix cwrapper test failure with --disable-static.

2010-11-10 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Wed, Nov 10, 2010 at 09:46:54PM CET: > On 11/10/2010 1:29 PM, Ralf Wildenhues wrote: > > > > -AT_CHECK([$LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c m.c], > > - [], [ignore], [ignore]) > > +AT_CHECK([$CC $CPPFLAGS $CFLAGS -c m.c], [], [i

Re: [patch] allow --with-pic to accept package names

2010-11-10 Thread Ralf Wildenhues
Hi Ollie, * Ollie Wild wrote on Mon, Nov 08, 2010 at 05:09:44AM CET: > On Sat, Oct 23, 2010 at 2:32 AM, Ralf Wildenhues wrote: > > > > This patch looks ok but it uses $pkg and $p which are not in Libtool's > > name space, and it lacks updates to NEWS, libtool.texi, and the test > > suite.  Oh yes,

Re: Fix cwrapper test failure with --disable-static.

2010-11-10 Thread Charles Wilson
On 11/10/2010 4:07 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Wed, Nov 10, 2010 at 09:46:54PM CET: >> Wouldn't a better fix be to change the link command to reference m.lo >> instead of m.$OBJEXT ? > > That would be an alternative, but it would mean that we (needlessly) use > PIC code

Re: Fix cwrapper test failure with --disable-static.

2010-11-10 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Nov 10, 2010 at 11:23:52PM CET: > On 11/10/2010 4:07 PM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Wed, Nov 10, 2010 at 09:46:54PM CET: > >> Wouldn't a better fix be to change the link command to reference m.lo > >> instead of m.$OBJEXT ? > > > > That woul

Re: [patch] allow --with-pic to accept package names

2010-11-10 Thread Ollie Wild
On Wed, Nov 10, 2010 at 3:41 PM, Ralf Wildenhues wrote: > > Thanks.  The patch looks good to me, with only trivial nits: > the testsuite addition should be sorted under the 'libtool script > generation' banner rather than with the sysroot tests, and I don't > think that it is necessary to skip the