Re: [PATCH] tests: import variables for MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-25 07:28 skrev Charles Wilson: > On 9/24/2010 2:46 PM, Peter Rosin wrote: >> Now I'm also confused. > > That's not good. > >> /me double checks (see below) >> >> WHAT? It doesn't work as I stated!?! >> >> *ponders that for a bit* >> *scratches head* >> >> Ahh, you said "libtool does t

Re: [PATCH] tests: import variables for MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 10:45 skrev Peter Rosin: > Den 2010-09-25 07:28 skrev Charles Wilson: >> With regards to Ralf's question re: _MSC_VER. Well, technically you'd >> probably be "more" correct to do: >> >> #if (defined(_WIN32) || defined(_WIN32_WCE)) && !defined(__GNUC__) >> ... >> >> rather than _MSC_

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-27 Thread Peter Rosin
Den 2010-09-24 19:37 skrev Ralf Wildenhues: > Hi Peter, > > * Peter Rosin wrote on Fri, Sep 24, 2010 at 11:30:07AM CEST: >> Den 2010-09-24 06:20 skrev Ralf Wildenhues: >>> The part about this patch which I'm unsure about is this: >>> >>> Does the testsuite otherwise cover well enough the fact that

[PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Hi! Ok to push? Passes with MSVC, MinGW/gcc and Cygwin/gcc. If I trivially break the compile step, it skips as designed. Cheers, Peter >From 7a3874ef05fcdb58c23b563c80c2dc63a64c0e2f Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Mon, 27 Sep 2010 16:33:14 +0200 Subject: [PATCH] tests: check if

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 16:37 skrev Peter Rosin: > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,5 +1,10 @@ > 2010-09-27 Peter Rosin > > + tests: check if sys_lib_search_path_spec works on MSVC. > + * tests/sys-lib.at: New test, catching regressions in > + v2.2.10-207-g09142ea. > + * Makef

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Sep 27, 2010 at 04:37:17PM CEST: > Ok to push? Passes with MSVC, MinGW/gcc and Cygwin/gcc. If I trivially > break the compile step, it skips as designed. Interesting. If it were late in the release cycle, I'd be a bit wary of this patch without a fair amount

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Hi Ralf, Den 2010-09-27 19:55 skrev Ralf Wildenhues: > * Peter Rosin wrote on Mon, Sep 27, 2010 at 04:37:17PM CEST: >> Ok to push? Passes with MSVC, MinGW/gcc and Cygwin/gcc. If I trivially >> break the compile step, it skips as designed. > > Interesting. If it were late in the release cycle, I'

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 20:19 skrev Peter Rosin: > From c5bce8258136b2766d349a6451b933efae7b885b Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Mon, 27 Sep 2010 20:09:53 +0200 > Subject: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC. > > * tests/sys-lib.at: New test, making sure v2.