Hi Chuck!
Nice. Some nits below...
Den 2010-08-30 01:50 skrev Charles Wilson:
> +as a @code{$host} (MinGW) application, must set the @var{$PATH} variable so
> +that the true application's dependent libraries can be located -- but the
> +contents of the @var{$PATH} variable must be structured for
Hi!
The archive-in-archive.at test uses ar "blindly". It also assumes that
the "old archive" of libfoo.la is named libfoo.a, but both that's not
portable. See attached patch.
Cheers,
Peter
>From 34b258415367f49d4015e289a52ba49667174526 Mon Sep 17 00:00:00 2001
From: Peter Rosin
Date: Mon, 30 Aug
[adding bug-bash]
On 08/29/2010 08:48 AM, Ralf Wildenhues wrote:
With Solaris 10 sh (and others):
cat<
Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm
thinking it may be a bash bug; hence the cc.
Eric, did you have this in your recent autoconf.texi additions alread
On 08/29/2010 08:59 AM, Ralf Wildenhues wrote:
-AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+" (Build:$TIMESTAMP)"}
AC_PACKAGE_VERSION])
+timestamp_string=
+if test -n "$TIMESTAMP"; then
+ timestamp_string=" (Build:$TIMESTAMP)"
+fi
Why not:
timestamp_string="${TIMESTAMP:+ (Build:$TIMES
On 08/30/2010 08:57 AM, Eric Blake wrote:
[adding bug-bash]
On 08/29/2010 08:48 AM, Ralf Wildenhues wrote:
With Solaris 10 sh (and others):
cat<
Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm
thinking it may be a bash bug; hence the cc.
Sorry about that; I read my res
On 08/29/2010 08:59 AM, Ralf Wildenhues wrote:
+++ b/configure.ac
@@ -113,7 +113,11 @@ case $lt_alpha in
TIMESTAMP=
;;
esac
-AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+" (Build:$TIMESTAMP)"}
AC_PACKAGE_VERSION])
According to 'git gui blame configure.ac', libtool has been
Hi Charles,
* Charles Wilson wrote on Mon, Aug 30, 2010 at 01:50:12AM CEST:
> * doc/libtool.texi (Platform quirks): Add new subsections
> 'Cross compiling' and 'File name/path conversion'.
> OK to push?
Looks fine to me too, only one or two issues are not markup or typo
nits (but I have been ver
Hi Peter,
* Peter Rosin wrote on Mon, Aug 30, 2010 at 03:25:30PM CEST:
> The archive-in-archive.at test uses ar "blindly". It also assumes that
> the "old archive" of libfoo.la is named libfoo.a, but both that's not
> portable. See attached patch.
OK with nits below.
I don't like that we don't h
Hi Eric,
* Eric Blake wrote on Mon, Aug 30, 2010 at 05:09:05PM CEST:
> On 08/29/2010 08:59 AM, Ralf Wildenhues wrote:
> >-AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+" (Build:$TIMESTAMP)"}
> >AC_PACKAGE_VERSION])
> >+timestamp_string=
> >+if test -n "$TIMESTAMP"; then
> >+ timestamp_strin
On 8/30/2010 2:48 PM, Ralf Wildenhues wrote:
* Charles Wilson wrote on Mon, Aug 30, 2010 at 01:50:12AM CEST:
OK to push?
Looks fine to me too, only one or two issues are not markup or typo
nits (but I have been very nitpicky below).
I expected that. This is really only a first draft with li
* Charles Wilson wrote on Mon, Aug 30, 2010 at 09:45:00PM CEST:
> On 8/30/2010 2:48 PM, Ralf Wildenhues wrote:
> >Looks fine to me too, only one or two issues are not markup or typo
> >nits (but I have been very nitpicky below).
>
> I expected that. This is really only a first draft with little i
Starting to go through the test logs that I posted (I sent a patch for
autobuild to have them sorted by mode as well), here's a testsuite
addition Bob has suggested before: let's not rely on Solaris printf
to catch NULL return from lt_dlerror for us; also, mark the test as
XFAIL as the bug itself i
See testsuite failures 1-5 here:
http://autobuild.josefsson.org/libtool/log-20100829151228732.txt
I'm applying an obvious fix:
Cheers,
Ralf
tests: avoid getopt-m4sh failures when autom4te is not available.
* tests/getopt-m4sh.at (_LT_AT_GETOPT_M4SH_SETUP):
Check $M4SH --versi
http://autobuild.josefsson.org/libtool/log-201008291316239205000.txt
Don't you love those permissive compilers where only the linker fails
later with:
libtool: link: /opt/fsw/bin/cc -g -Wall -Werror -o .libs/usea usea.o
./.libs/liba.so -rpath /foo
Invalid flag usage: Wall, -Wx,-option must appea
On 08/30/2010 03:06 PM, Ralf Wildenhues wrote:
http://autobuild.josefsson.org/libtool/log-201008291316239205000.txt
Don't you love those permissive compilers where only the linker fails
later with:
libtool: link: /opt/fsw/bin/cc -g -Wall -Werror -o .libs/usea usea.o
./.libs/liba.so -rpath /foo
* Eric Blake wrote on Mon, Aug 30, 2010 at 11:13:22PM CEST:
> On 08/30/2010 03:06 PM, Ralf Wildenhues wrote:
> >Don't you love those permissive compilers where only the linker fails
> >later with:
> >
> >libtool: link: /opt/fsw/bin/cc -g -Wall -Werror -o .libs/usea usea.o
> >./.libs/liba.so -rpat
In the process of moving our version number tracking (and associated
run-time sanity checks) over to git-version-gen, I ended up with a
full-blown 'use-gnulib' topic branch (which I'll post here after the
next release).
That branch as a whole is potentially destabilizing, but I've backported
the n
From: Gary V. Vaughan
* libltdl/config/announce-gen.m4sh: Add support for gnulib
announce-gen options, previously missing from our m4sh
implementation, and enforce specifying --gnulib-version when
`gnulib' is listed in --bootstrap-tools.
---
ChangeLog|8
libl
From: Gary V. Vaughan
* clcommit.m4sh (func_commit): Commit only staged files instead
of passing `-a' when no file list was given on the command line.
Signed-off-by: Gary V. Vaughan
---
ChangeLog |6 ++
clcommit.m4sh | 15 +++
2 files changed, 17 insertions(+), 4 dele
From: Gary V. Vaughan
* libltdl/config/announce-gen.m4sh (func_print_locations): Don't
bail out or print garbage when trying to find the size of a
non-existent file.
Signed-off-by: Gary V. Vaughan
---
ChangeLog|7 +++
libltdl/config/announce-gen.m4sh |8
From: Gary V. Vaughan
* bootstrap: Add a proper option parsing loop, along with copies
of supporting functions from `libltd/m4/getopt.m4sh' and
`libltdl/m4/general.m4sh'.
Reformat header comments to work with `func_help' and
`func_version'.
(my_sed_traces): Expanded to extract all parameters from
From: Gary V. Vaughan
* Makefile.am (bootstrap_files): List files that need to be
generated at bootstrap time before `./configure && make' can
work. It turns out that this is considerably fewer files than we
had thought necessary previously.
(bootstrap-deps-prep): Ensure minimum set of required
From: Gary V. Vaughan
* bootstrap (rebuild): Set the shell variable `revision' rather
than `correctver' for clarity.
(edit): Split into two parts...
(bootstrap_edit): ...substitutions that should happen at bootstrap
time...
(configure_edit): ...and substitution that should not happen until
config
23 matches
Mail list logo
