Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Aug 28, 2010 at 08:57:04AM CEST: > This is just an FYI. The take-away here is that I did go ahead and > rename all the functions to > func_convert_{file|path}_X_to_Y > and moved them to just before func_mode_compile. I changed all comments > and function names to

Fix AC_LANG_PROGRAM warnings from git Autoconf.

2010-08-28 Thread Ralf Wildenhues
This patch should fix all warnings emitted by git Autoconf due to the new AC_LANG_PROGRAM check: http://lists.gnu.org/archive/html/autoconf-patches/2010-08/msg00080.html As far as I can see, the first two instances were fairly benign *before* the Autoconf patch, but the last one exposed a real bug

Re: Fix AC_LANG_PROGRAM warnings from git Autoconf.

2010-08-28 Thread Gary V. Vaughan
Hallo Ralf, On 28 Aug 2010, at 14:10, Ralf Wildenhues wrote: > OK to commit? I didn't test, but by inspection everything looks good from here. >Fix AC_LANG_PROGRAM warnings from git Autoconf. > >* libltdl/m4/libtool.m4 (_LT_SYS_MODULE_PATH_AIX): Fix >underquoted AC_LANG_PROGRAM call

ChangeLog entries for sysroot branch, and merge

2010-08-28 Thread Ralf Wildenhues
OK to apply to the sysroot branch and merge? I'm not sure if I need to ask, so I'll leave a bit of time for comments. I don't actually care too much if after the merge, ChangeLog dates are not all monotonic. That's just life with trying to map a graph linearly. Thanks, Ralf diff --git a/ChangeL

Re: ChangeLog entries for sysroot branch, and merge

2010-08-28 Thread Gary V. Vaughan
Hallo Ralf, On 28 Aug 2010, at 15:16, Ralf Wildenhues wrote: > OK to apply to the sysroot branch and merge? > I'm not sure if I need to ask, so I'll leave a bit of time for comments. I'm assuming that the ChangeLog entries map to the actual changes? How come the ChangeLogs weren't committed at t

Re: ChangeLog entries for sysroot branch, and merge

2010-08-28 Thread Ralf Wildenhues
Good afternoon Gary, * Gary V. Vaughan wrote on Sat, Aug 28, 2010 at 10:29:01AM CEST: > On 28 Aug 2010, at 15:16, Ralf Wildenhues wrote: > > > OK to apply to the sysroot branch and merge? > > I'm not sure if I need to ask, so I'll leave a bit of time for comments. > > I'm assuming that the Chang

Re: Fix AC_LANG_PROGRAM warnings from git Autoconf.

2010-08-28 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sat, Aug 28, 2010 at 09:25:41AM CEST: > On 28 Aug 2010, at 14:10, Ralf Wildenhues wrote: > > OK to commit? > > I didn't test, but by inspection everything looks good from here. > > >Fix AC_LANG_PROGRAM warnings from git Autoconf. > > > >* libltdl/m4/l

Fix archiver @FILE support test

2010-08-28 Thread Ralf Wildenhues
Yay for IRIX ar handing back a useless exit status: configure:6118: checking for archiver @FILE support configure:6135: cc -c -g conftest.c >&5 configure:6135: $? = 0 configure:6138: ar cru libconftest.a @conftest.lst ar: Error: @conftest.lst cannot open configure:6141: $? = 0 configure:6152: res

Fix quoting in non-XSI func_xform, for IRIX sh.

2010-08-28 Thread Ralf Wildenhues
Another regression from some post-2.2.10 patch I didn't bother to track down now. Hopefully fixes all of the 20-some failures I'm seeing on IRIX ... Pushed to master. Cheers, Ralf Fix quoting in non-XSI func_xform, for IRIX sh. * libltdl/config/ltmain.m4sh (func_xform): Remove spur

Re: [PATCH 1/4] Support GCC LTO on GNU/Linux.

2010-08-28 Thread Ralf Wildenhues
I'm going to at least try to see how much we can get Libtool in shape for LTO. This one should be easy: * Dave Korn wrote on Wed, Apr 07, 2010 at 01:13:08AM CEST: > On 06/04/2010 22:39, Paolo Bonzini wrote: > > On 04/06/2010 04:01 AM, Charles Wilson wrote: > >>> > As for whether it would get

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
Since the question asked in: * Ralf Wildenhues wrote on Tue, Jun 29, 2010 at 06:49:39AM CEST: > > . was now answered in I feel confident enough for

Re: [PATCH 4/4] Add $pic_flag to archive_cmds and archive_expsym_cmds.

2010-08-28 Thread Ralf Wildenhues
[ ] * Ralf Wildenhues wrote on Sun, Apr 04, 2010 at 10:57:04AM CEST: > * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) > > [GNU ld, netbsd]: Add $pic_flag if ELF. > [GNU ld, solaris]: Likewise. > [GNU ld, default case]: Likewis

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Charles Wilson
On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; that is only defined by Watcom C/C++. I think this should be changed to _WIN32 throughout. See http://predef.sourceforge.net/preos.html

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > > [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST > I don't think __WINDOWS__ is the correct symbol; that is only defined by > Watcom C/C++. I think this sh

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Charles Wilson
On 8/28/2010 11:31 AM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST >> I don't think __WINDOWS__ is the correct symbol; that is only defin

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Vincent Torri
On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; that is only defined by Watcom C/C++. I think this should be changed to _WIN32 throughout.

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Charles Wilson
On 8/28/2010 11:43 AM, Vincent Torri wrote: > On Sat, 28 Aug 2010, Charles Wilson wrote: >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST >> I don't think __WINDOWS__ is the correct symbol; that is only defined by >> Watcom C/C++.

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Vincent Torri
On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 11:43 AM, Vincent Torri wrote: On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; t

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Aug 28, 2010 at 05:31:57PM CEST: > On 8/28/2010 11:31 AM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONS

[PATCH] [cygwin|mingw|cross-compile]: Path conversion support.

2010-08-28 Thread Charles Wilson
* configure.ac: Ensure to_host_file_cmd is available to Makefile. * TODO: Document QoI issue with file name conversion functions. * libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): New function sets libtool variable $to_host_file_cmd, and employs cache. (_LT_SETUP): Require it. * tests/testsu

Re: [PATCH] [cygwin|mingw|cross-compile]: Path conversion support.

2010-08-28 Thread Charles Wilson
On 7/18/2010 9:07 PM, Charles Wilson wrote: Aaarrrgh. Sorry again for the messed-up date. -- Chuck

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-28 Thread Charles Wilson
On 8/28/2010 2:57 AM, Charles Wilson wrote: > Ok, I've addressed all of the review comments, including the results of > the four ***QQQ***estions. Quick-N-Dirty spot testing on native cygwin, > native mingw, cygwin->mingw, linux->mingw, linux->cygwin all look good, > so I'm about to rebase on my p

[PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Charles Wilson
libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. tests/sysroot.at: Search also for crt0.o to accommodate cygwin. --- Somehow this patch got dropped when the sysroot branch was merged. Rebased against master... OK to push? -- Chuck libltdl/m4/libtool.m4 |2 +- tests/sysroot.at |

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Vincent Torri
On Sat, 28 Aug 2010, Charles Wilson wrote: libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. tests/sysroot.at: Search also for crt0.o to accommodate cygwin. --- Somehow this patch got dropped when the sysroot branch was merged. Rebased against master... OK to push? -- Chuck libltdl/m4/li

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Charles Wilson
On 8/28/2010 6:38 PM, Vincent Torri wrote: >> case ${with_sysroot} in #( >> yes) >>if test "$GCC" = yes; then >> - lt_sysroot=`$GCC --print-sysroot 2>/dev/null` >> + lt_sysroot=`$CC --print-sysroot 2>/dev/null` > > what is the interest of testing $GCC if you use $CC ? $GCC != "gcc".

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 29, 2010 at 12:27:15AM CEST: > libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. > tests/sysroot.at: Search also for crt0.o to accommodate cygwin. > --- > Somehow this patch got dropped when the sysroot branch > was merged. Rebased against master... > > OK to

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Charles Wilson
On 8/28/2010 8:10 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sun, Aug 29, 2010 at 12:27:15AM CEST: >> libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. >> tests/sysroot.at: Search also for crt0.o to accommodate cygwin. >> --- >> Somehow this patch got dropped when the sysroot branch >

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Charles Wilson
On 8/28/2010 8:10 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sun, Aug 29, 2010 at 12:27:15AM CEST: >> libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. >> tests/sysroot.at: Search also for crt0.o to accommodate cygwin. >> >> OK to push? > > Sure. Done. -- Chuck

Re: Fix archiver @FILE support test

2010-08-28 Thread Peter Rosin
Den 2010-08-28 12:24 skrev Ralf Wildenhues: > Peter, can you check whether ar-lib, lib, and 'link -lib' reliably fail > when an @file contains a nonexistent file name? I haven't run the testsuite, but manual testing shows that the patch should be ok. If the testsuite reveals unexpected problems I'