Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: > > In that case, Ralf's suggested libfile_$(transliterated implib name) > > is used, because we have the .la file available which allows that > > shortcut. The only time we need `dlltool --identify' is when > > dlpreopening a non-lib

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Charles Wilson
On 6/27/2010 4:43 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: >>> In that case, Ralf's suggested libfile_$(transliterated implib name) >>> is used, because we have the .la file available which allows that >>> shortcut. The only time we need `dlltool

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Bob Friesenhahn
On Sun, 27 Jun 2010, Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: In that case, Ralf's suggested libfile_$(transliterated implib name) is used, because we have the .la file available which allows that shortcut. The only time we need `dlltool --identify

[PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-06-27 Thread Gary V. Vaughan
Looking through the XSI substitutions, or more correctly the bash/ksh func_append usage, there's room here to consistently use func_append everywhere to make for easier maintenance... but rather than take the additional overhead of a function call in the sensitive quadratic scaling parts that promp

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-27 Thread Gary V. Vaughan
Hallo Ralf, Thanks for the review. On 27 Jun 2010, at 19:02, Ralf Wildenhues wrote: > * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:58:03PM CEST: >> Okay to push? > > No, ${parameter:offset} and ${parameter:offset:length} are bash specific > not XSI mandated. Ah, okay. Didn't think to loo

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-06-27 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: > Looking through the XSI substitutions, or more correctly the bash/ksh > func_append usage, there's room here to consistently use func_append > everywhere to make for easier maintenance... but rather than take the > additio

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Ralf Wildenhues
Hello Charles, * Charles Wilson wrote on Mon, Jun 28, 2010 at 12:05:40AM CEST: > On 6/27/2010 4:43 PM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: > >> So...can I get a verdict? Is -dlpreopen not-an-la-file supposed to work? > > > > I think Pierre's

Re: [PATCH] getopt.m4sh generated libtool option parser, and XSI improvements.

2010-06-27 Thread Gary V. Vaughan
Hallo Ralf, On 27 Jun 2010, at 00:44, Ralf Wildenhues wrote: > * Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST: >> This is the improved (and renamed) `Use getopt.m4sh to generate libtool >> option parser.' patch I promised yesterday. I'm pretty happy with this, >> save that even

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 08:57:58AM CEST: > commit ee2dde86ba2f1bdc0638726c6580b96800ad4b39 > Author: Gary V. Vaughan > Date: Sun Jun 27 13:57:50 2010 +0700 > > Fix portability regressions in today's earlier changeset. > > * libltdl/m4/libtool.m4

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Gary V. Vaughan
Hallo Ralf, On 27 Jun 2010, at 15:49, Ralf Wildenhues wrote: > * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 08:57:58AM CEST: >> commit ee2dde86ba2f1bdc0638726c6580b96800ad4b39 >> Author: Gary V. Vaughan >> Date: Sun Jun 27 13:57:50 2010 +0700 >> >>Fix portability regressions in today's

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 11:52:32AM CEST: > On 27 Jun 2010, at 15:49, Ralf Wildenhues wrote: > >> --- a/libltdl/m4/libtool.m4 > >> +++ b/libltdl/m4/libtool.m4 > >> +} # XSI $1 implementation' "$cfgfile" > $cfgfile.tmp \ > >> + && mv -f "$cfgfile.tmp" "$cfgfile"

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Gary V. Vaughan
Hallo Ralf, On 27 Jun 2010, at 17:23, Ralf Wildenhues wrote: > * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 11:52:32AM CEST: >> On 27 Jun 2010, at 15:49, Ralf Wildenhues wrote: --- a/libltdl/m4/libtool.m4 +++ b/libltdl/m4/libtool.m4 > +} # XSI $1 implementation' "$cfgfile" > $cf

[PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-27 Thread Gary V. Vaughan
Okay to push? * libltdl/m4/libtool.m4 (_LT_CHECK_SHELL_FEATURES): Also ensure that XSI substring extraction is supported. (_LT_PROG_XSI_SHELLFNS): Use XSI substring extraction to split short options to avoid unnecessary forks if the host shell supports that. --- ChangeLog |7 +

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:53:39PM CEST: > On 27 Jun 2010, at 17:23, Ralf Wildenhues wrote: > > The warning is almost never the last line I'd see, because for me, > > configure gets triggered by 'make' which then happily proceeds to do > > nasty things. No, if the

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-27 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:58:03PM CEST: > Okay to push? No, ${parameter:offset} and ${parameter:offset:length} are bash specific not XSI mandated. IIRC we already have a separate test for bash features that won't regress on non-bash XSI shells. Please add the test there.

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Charles Wilson
On 6/26/2010 2:51 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Fri, Jun 25, 2010 at 04:57:15AM CEST: >> However, with this patch, helldl.exeS.c has: > > IOW, all the spurious declarations are gone? That'd be cool. Correct. >> (*) Note that you only need to determine the dll name for a