Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson <...> | | Ensure cwrapper compiles without warnings under -std=c99. | Looks ok, except for these nits: | | -# func_emit_wrapper arg | +# func_emit_wrapper_part1 ar

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson <...> | | * libltdl/config/ltmain.m4sh (func_to_native_path): I've become accustomed to using a 1-line summary in my ChangeLog messages prior to the first '* file:'

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

On 6 May 2008, at 09:20, Eric Blake wrote: Doesn't func_error die when called? If so, how do the subsequent three errors get printed? If not, the name seems a bit misleading... We have func_echo, func_warn, and func_error for automatic prefixing of output, and func_fatal_error for non-ret

[PATCH 370] Implement lt_dlopening of only preloaded modules.

* libltdl/m4/ltdl.m4 (LTDL_INIT): Check for a libltdl that provides lt_dladvise_preopen when deciding if installed libltdl is 'new enough'. * libltdl/libltdl/lt__private.h (lt__advise): Add a new is_preload flag. * libltdl/ltdl.c (lt_dladvise_preload): New api call to set it. (try_dlopen): If it is

Re: [PATCH 370] Implement lt_dlopening of only preloaded modules.

Hi Gary, a quick nit review (I haven't looked thoroughly yet): * Gary V. Vaughan wrote on Tue, May 06, 2008 at 07:24:46PM CEST: > > This makes it possible to build a libltdl client with some preloaded > modules, and limit lt_dlopenadvise to open only the preloaded modules. > --- a/NEWS > +++ b/

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Charles, In addition to Eric's review, here's some extremely picky nits: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: > 2008-05-05 Charles Wilson <...> > > Ensure cwrapper compiles without warnings under -std=c99. > * libltdl/config/ltmain.m4sh (func_emit_wrap

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Hi Charles, In addition to Eric's review: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: > > * libltdl/config/ltmain.m4sh (func_to_native_path): > new function. If $host is mingw, and $build is mingw > or cygwin, convert path to mingw native format. > (fu

Re: --with-included-ltdl infers --enable-ltdl-convenience

Hi Bob, * Bob Friesenhahn wrote on Sun, Apr 13, 2008 at 11:25:38PM CEST: > With latest libtool and autoconf, if the argument --with-included-ltdl is > provided, then libtool adds a --with-included-ltdl to config.status. If > this configuration is then re-used, autoconf warns about > --with-inc

Re: --with-included-ltdl infers --enable-ltdl-convenience

On Tue, 6 May 2008, Ralf Wildenhues wrote: This patch shuts up the warning about --enable-ltdl-convenience (I suppose the fact that you write --with-included-ltdl in the paragraph is a typo, as you use the correct one in the Subject:). However, it I don't believe that it is a typo since if --w

Re: [PATCH] Ensure $OBJDUMP is defined

Ralf Wildenhues wrote: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: 2008-05-05 Charles Wilson <...> Yaakov Selkowitz <...> Ensure $OBJDUMP is defined * libltdl/m4/libtool.m4 (_LT_DECL_OBJDUMP): new macro ensures that $OBJDUMP is always

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | -# func_emit_wrapper arg | +# func_emit_wrapper_part1 arg Since you provide a default, I'd show that arg is optional, as in: # func_emit_wrapper_part1 [arg=no] Ack. Is func_emit_wrapper_part1_arg1 even used? Why not just

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Ralf Wildenhues wrote: In addition to Eric's review, here's some extremely picky nits: -# func_emit_wrapper arg +# func_emit_wrapper_part1 arg Isn't that .libs/_libs aka $objdir here? This is not new here, but further below. Capitalization, period at end of the sentence. # func_emit_wrap

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson <...> | | * libltdl/config/ltmain.m4sh (func_to_native_path): I've become accustomed to using a 1-line summary in my ChangeLog messages prior to the first '* file:' line; that way, the summary ca

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Ralf Wildenhues wrote: Hi Charles, You can simplify the remaining part of the ChangeLog entry: or even to this: (func_emit_cwrapperexe_src) [lt_setenv, lt_extend_str] [lt_split_name_value, lt_opt_process_env_set] [lt_opt_process_env_prepend, lt_opt_process_env_append]