Re: Unify line endings in localization test

2009-01-26 Thread Ralf Wildenhues
* Peter Rosin wrote on Sat, Jan 24, 2009 at 08:47:03PM CET: > Den 2009-01-24 14:03, skrev Ralf Wildenhues: >> * Eric Blake wrote on Sat, Jan 24, 2009 at 02:00:15PM CET: >>> According to Ralf Wildenhues on 1/24/2009 2:37 AM: >> >> Ah yes, that sounds like it was the problem here. Surely that makes

Re: Unify line endings in localization test

2009-01-24 Thread Peter Rosin
Den 2009-01-24 14:03, skrev Ralf Wildenhues: * Eric Blake wrote on Sat, Jan 24, 2009 at 02:00:15PM CET: According to Ralf Wildenhues on 1/24/2009 2:37 AM: One funny thing (funny strange, not haha) is that the ChangeLog entries from master appeared in reverse order in the pr-msvc-support ChangeL

Re: Unify line endings in localization test

2009-01-24 Thread Ralf Wildenhues
* Eric Blake wrote on Sat, Jan 24, 2009 at 02:00:15PM CET: > According to Ralf Wildenhues on 1/24/2009 2:37 AM: > >> One funny thing (funny strange, not haha) is that the ChangeLog entries > >> from master appeared in reverse order in the pr-msvc-support ChangeLog > >> after the merge, and I had to

Re: Unify line endings in localization test

2009-01-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 1/24/2009 2:37 AM: >> One funny thing (funny strange, not haha) is that the ChangeLog entries >> from master appeared in reverse order in the pr-msvc-support ChangeLog >> after the merge, and I had to fix that up manuall

Re: Unify line endings in localization test

2009-01-24 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jan 23, 2009 at 04:39:02PM CET: > > I'm preparing a merge with master now instead. Just got to run the > testsuite on a couple of $hosts/compilers (sigh) before I push... > > One funny thing (funny strange, not haha) is that the ChangeLog entries > from master appeared i

Re: Unify line endings in localization test

2009-01-23 Thread Peter Rosin
Den 2009-01-23 16:39 skrev Peter Rosin: I'm preparing a merge with master now instead. Just got to run the testsuite on a couple of $hosts/compilers (sigh) before I push... Four hours later, and four popups later, the testsuite has completed as expected on Cygwin and MSYS/MSVC. That's on a dua

Re: Unify line endings in localization test

2009-01-23 Thread Peter Rosin
Den 2009-01-23 07:57 skrev Ralf Wildenhues: OK. That way you did not merge the rest of master's current changes into pr-msvc-support. I would not have minded if you had done that, either, but it doesn't matter. The ChangeLog rotation made it complex (at least it looked complex to me) and I di

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jan 23, 2009 at 12:01:00AM CET: > Den 2009-01-22 21:54 skrev Ralf Wildenhues: >> >> 1) create, in your own repository, a new branch pr-tests-newline-fixes >> containing this one patch, then merge this patch into both >> pr-msvc-support and into master, then push the last

Re: Unify line endings in localization test

2009-01-22 Thread Peter Rosin
Den 2009-01-22 21:54 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET: Something like the attached? Yes, with nits below addressed. Ok, so push to master or pr-msvc-support? This change is ok for both. However, let's move away from manual additi

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET: >>> Something like the attached? >> >> Yes, with nits below addressed. > Ok, so push to master or pr-msvc-support? This change is ok for both. However, let's move away from manual addition of the same change to more than one

Re: Unify line endings in localization test

2009-01-22 Thread Peter Rosin
Den 2009-01-21 23:09, skrev Ralf Wildenhues: * Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET: Den 2009-01-19 21:35 skrev Ralf Wildenhues: This looks a bit hackish. We already have a handful of places which we fixed up in order to avoid line ending issues. This one looks hackish eno

Re: Unify line endings in localization test

2009-01-21 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET: > Den 2009-01-19 21:35 skrev Ralf Wildenhues: >> This looks a bit hackish. We already have a handful of places which we >> fixed up in order to avoid line ending issues. This one looks hackish >> enough to deserve being wrapped in a macr

Re: Unify line endings in localization test

2009-01-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Jan 19, 2009 at 09:52:50PM CET: > Den 2009-01-19 21:35 skrev Ralf Wildenhues: >> >> I think we shouldn't be constantly rebasing pr-msvc-support. I think >> instead when we can't decide soonish whether to merge it into master or >> to redo it (because it would

Re: Unify line endings in localization test

2009-01-19 Thread Peter Rosin
Den 2009-01-19 21:35 skrev Ralf Wildenhues: This looks a bit hackish. We already have a handful of places which we fixed up in order to avoid line ending issues. This one looks hackish enough to deserve being wrapped in a macro (in testsuite.at, below LT_AT_HOST_DATA?), so that future instances

Re: Unify line endings in localization test

2009-01-19 Thread Peter Rosin
Hi Ralf, Den 2009-01-19 21:35 skrev Ralf Wildenhues: Ok to push? Or should I just push it to the pr-msvc-support branch for now? I think we shouldn't be constantly rebasing pr-msvc-support. I think instead when we can't decide soonish whether to merge it into master or to redo it (because it

Re: Unify line endings in localization test

2009-01-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jan 17, 2009 at 12:42:34AM CET: > In the localization test, the output of the compiler is compared > with the grepped output of the compiler when run through libtool. > > MSVC outputs its messages with \r\n, but the grep in the above > strips that down to just