Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-08 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Sep 08, 2009 at 09:44:46AM CEST: > Den 2009-09-07 21:09 skrev Ralf Wildenhues: > >>>+ eval "`$LIBTOOL --tag=$tag --config | $EGREP > >>>'^(wl|archive_cmds|reload_cmds)='`" > >>You are not using $reload_cmds anywhere. > > > >Indeed; I added it because I thoug

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-08 Thread Peter Rosin
Den 2009-09-07 21:09 skrev Ralf Wildenhues: + eval "`$LIBTOOL --tag=$tag --config | $EGREP '^(wl|archive_cmds|reload_cmds)='`" You are not using $reload_cmds anywhere. Indeed; I added it because I thought of running a reload command, until I realized that it wouldn't contain these flags anyw

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-07 Thread Ralf Wildenhues
* Peter Rosin wrote on Sun, Sep 06, 2009 at 07:57:52PM CEST: > Den 2009-09-06 11:44 skrev Ralf Wildenhues: > >* Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: > >>If the test is going to be good enough on w32 I don't know. For gcc > >>it should behave just as on any unix, so what's left

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-07 Thread Ralf Wildenhues
Hello Peters, * Peter O'Gorman wrote on Mon, Sep 07, 2009 at 05:35:33AM CEST: > On Sep 6, 2009, at 2:44 AM, Ralf Wildenhues wrote: > >+for tag in CC CXX F77 FC; do > >+ if $LIBTOOL --tag=$tag 2>&1 | grep 'unknown tag'; then > >+continue > >+ fi > I get test failures for this test on a darwi

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-07 Thread Peter Rosin
Oops, one more thing: +eval set program "$library_and_module" I guess you can prevent a future patch from Roumen by changing that to program$EXEEXT Cheers, Peter

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-07 Thread Peter Rosin
Hi Ralf, Den 2009-09-06 11:44 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: Den 2009-09-04 19:44 skrev Ralf Wildenhues: Further, the patch needs a testsuite addition, but I can do that later if you don't want to. I was thinking of a new set of

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-06 Thread Peter O'Gorman
On Sep 6, 2009, at 2:44 AM, Ralf Wildenhues wrote: Add testsuite exposure for passing of compiler and linker flags. * tests/flags.at (passing flags through libtool): New file, new test, for bug fixed in previous commit. * Makefile.am (TESTSUITE_AT): Add tests/flags.at. + +for tag

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-06 Thread Peter Rosin
Hi Ralf, Den 2009-09-06 11:44 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: If the test is going to be good enough on w32 I don't know. For gcc it should behave just as on any unix, so what's left is my msvc branch where -Wl, isn't supported ATM so I really

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-06 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: > Den 2009-09-04 19:44 skrev Ralf Wildenhues: > >Further, the patch needs a testsuite addition, but I can do that later > >if you don't want to. I was thinking of a new set of tests flags.at and > >running a bunch of > > libt

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-05 Thread Peter Rosin
Den 2009-09-05 09:05 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: Ok to commit this? Yes, thanks. Pushed. Thanks for reviewing! Cheer, Peter

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-05 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Sep 04, 2009 at 10:31:14PM CEST: > Ok to commit this? Yes, thanks. Cheers, Ralf > 2009-09-04 Peter Rosin > > Make -Wc,FLAG behave like -Xcompiler FLAG in link mode. > * libltdl/config/ltmain.m4sh (func_mode_link): Remove "-Wc," > instead of repla

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-04 Thread Peter Rosin
Hi Ralf, Den 2009-09-04 19:44 skrev Ralf Wildenhues: Hello Peter, * Peter Rosin wrote on Fri, Sep 04, 2009 at 12:38:48PM CEST: Make -Wc,foo behave like -Xcompiler foo in link mode. * libltdl/config/ltmain.m4sh (func_mode_link): Remove "-Wc," instead of replacing it with

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.

2009-09-04 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Fri, Sep 04, 2009 at 12:38:48PM CEST: > Make -Wc,foo behave like -Xcompiler foo in link mode. > * libltdl/config/ltmain.m4sh (func_mode_link): Remove "-Wc," > instead of replacing it with "$wl". This patch is ok, but please state clearly that