Re: [PATCH] msvc: handle symbols from different files independently.

Den 2010-10-04 20:07 skrev Ralf Wildenhues: > Go! Pushed, thanks for reviewing! Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

Hi Peter, * Peter Rosin wrote on Mon, Oct 04, 2010 at 01:25:42PM CEST: > Den 2010-10-02 08:40 skrev Ralf Wildenhues: > > Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set. > > It's a pest that you can have: > > DUMPBIN="link -dump" > NM="dumpbin -symbols" > > or > > DUMPBI

Re: [PATCH] msvc: handle symbols from different files independently.

Den 2010-10-04 13:25 skrev Peter Rosin: > +AT_CHECK([eval "cat dumpbin-output | $global_symbol_pipe"], [], [stdout]) Oops, forgot one nit, I'm going with +AT_CHECK([< dumpbin-output eval "$global_symbol_pipe"], [], [stdout]) instead. Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

Den 2010-10-02 08:40 skrev Ralf Wildenhues: > Hi Peter, > > * Peter Rosin wrote on Fri, Oct 01, 2010 at 01:38:42PM CEST: >> Anyway, is this test case good enough? Should I find a better >> way to skip on non-dumpbin runs? How? > > Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN

Re: [PATCH] msvc: handle symbols from different files independently.

Hi Peter, * Peter Rosin wrote on Fri, Oct 01, 2010 at 01:38:42PM CEST: > Anyway, is this test case good enough? Should I find a better > way to skip on non-dumpbin runs? How? Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set. How for a slight improvement at least something

Re: [PATCH] msvc: handle symbols from different files independently.

Den 2010-09-30 23:29 skrev Ralf Wildenhues: > * Peter Rosin wrote on Thu, Sep 30, 2010 at 10:53:13PM CEST: >> Den 2010-09-30 21:25 skrev Ralf Wildenhues: >>> * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: Ok to push when I have tested with various MSVC versions? >>> >>> I guess,

Re: [PATCH] msvc: handle symbols from different files independently.

* Peter Rosin wrote on Thu, Sep 30, 2010 at 10:53:13PM CEST: > Den 2010-09-30 21:25 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: > >> Ok to push when I have tested with various MSVC versions? > > > > I guess, but you should really add testsuite exposure.

Re: [PATCH] msvc: handle symbols from different files independently.

Hi Ralf, Den 2010-09-30 21:25 skrev Ralf Wildenhues: > * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: >> Ok to push when I have tested with various MSVC versions? > > I guess, but you should really add testsuite exposure. I don't know any controlled way to create a pair of object f

Re: [PATCH] msvc: handle symbols from different files independently.

Hi Peter, * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: > Ok to push when I have tested with various MSVC versions? I guess, but you should really add testsuite exposure. Thanks, Ralf > Subject: [PATCH] msvc: handle symbols from different files independently. > > * libltdl/m4/li