Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 20:07 skrev Ralf Wildenhues: > Go! Pushed, thanks for reviewing! Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Ralf Wildenhues
it before deplibs-mingw.at and changed the banner to "Windows > tests.", quietly fixing the cosmetic bug that deplibs-mingw.at isn't a > darwin test to begin with. Ah, good. > > OK with nits below. > > One more iteration since I'm not sure if redoing the con

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 13:25 skrev Peter Rosin: > +AT_CHECK([eval "cat dumpbin-output | $global_symbol_pipe"], [], [stdout]) Oops, forgot one nit, I'm going with +AT_CHECK([< dumpbin-output eval "$global_symbol_pipe"], [], [stdout]) instead. Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
"Windows tests.", quietly fixing the cosmetic bug that deplibs-mingw.at isn't a darwin test to begin with. > OK with nits below. One more iteration since I'm not sure if redoing the configure test is ok. Cheers, Peter >From 2975fc3e74374fcf1c949766f65db5670d8c61a9

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-01 Thread Ralf Wildenhues
system-specific, and grouping those testing the same systems, or family of systems (such as w32). And then using one AT_BANNER for a set of test groups. OK with nits below. Thanks, Ralf > Subject: [PATCH] msvc: handle symbols from different files independently. > > * libltdl/m4/lib

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-01 Thread Peter Rosin
y, is this test case good enough? Should I find a better way to skip on non-dumpbin runs? How? Cheers, Peter >From 8189aca834f90ab5d439c58370fcceb699eb0bef Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Fri, 1 Oct 2010 13:32:32 +0200 Subject: [PATCH] msvc: handle symbols from different files independently. * libltdl/m4/li

Re: [PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Sep 30, 2010 at 10:53:13PM CEST: > Den 2010-09-30 21:25 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: > >> Ok to push when I have tested with various MSVC versions? > > > > I guess, but you should really add testsuite exposure.

Re: [PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Peter Rosin
Hi Ralf, Den 2010-09-30 21:25 skrev Ralf Wildenhues: > * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: >> Ok to push when I have tested with various MSVC versions? > > I guess, but you should really add testsuite exposure. I don't know any controlled way to create a pair of object f

Re: [PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: > Ok to push when I have tested with various MSVC versions? I guess, but you should really add testsuite exposure. Thanks, Ralf > Subject: [PATCH] msvc: handle symbols from different files independently. > >

[PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Peter Rosin
ons? Cheers, Peter >From cd30a11c9702b6102fcdb62b67af4c226f87f300 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Thu, 30 Sep 2010 15:06:31 +0200 Subject: [PATCH] msvc: handle symbols from different files independently. * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS) : Make all sections via