Re: [PATCH] Set library search path empty in dlloader-api test.

2010-06-24 Thread Charles Wilson
On 6/24/2010 7:26 PM, Peter Rosin wrote: > Zapping with the search path seems overly complicated and will > not represent anything even remotely normal. > > But all this is just my opinion of course. But I think I agree. See [PATCH] Avoid false failures caused by filesystem interaction which mig

Re: [PATCH] Set library search path empty in dlloader-api test.

2010-06-24 Thread Peter Rosin
Hi Chuck, Den 2010-06-25 00:50 skrev Charles Wilson: On 6/20/2010 2:31 AM, Charles Wilson wrote: Tested on cygwin, mingw, linux, and works. But, given the issues raised above...comments? discussion? Additional testing on esoteric platforms? OK to push? NOTE: From the autoconf manual: Posix

Re: [PATCH] Set library search path empty in dlloader-api test.

2010-06-24 Thread Charles Wilson
On 6/20/2010 2:31 AM, Charles Wilson wrote: > Tested on cygwin, mingw, linux, and works. But, given the issues > raised above...comments? discussion? Additional testing on esoteric > platforms? OK to push? > > NOTE: From the autoconf manual: > Posix prefers `setenv' to `putenv'; among other thin

Re: [PATCH] Set library search path empty in dlloader-api test.

2010-06-20 Thread Charles Wilson
On 6/20/2010 2:31 AM, Charles Wilson wrote: > This patch takes the approach that we should not make any assumptions > about files in $LD_LIBRARY_PATH or $PATH -- especially when the > name of the "library" we're attempting to lt_dlopen is not uglified: > "last" is a quite command /usr/bin/ command.

[PATCH] Set library search path empty in dlloader-api test.

2010-06-19 Thread Charles Wilson
Avoid false positives, in which an actual library is found in the default search path whose name matches the 'magic' value used in the test, to exercise custom loader. This false positive causes test failure. * tests/dlloader-api.at: Check value of libtool variable shlibpath_var, and define macro