Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Gary V. Vaughan
Hallo Ralf, On 9 Aug 2010, at 12:15, Ralf Wildenhues wrote: > I think we should have a rule to not apply pure optimization patches > without measurement results. Agreed. We should document that somewhere too, so that we don't forget. Cheers, -- Gary V. Vaughan (g...@gnu.org)

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Aug 08, 2010 at 08:50:12AM CEST: > On 7 Aug 2010, at 18:15, Ralf Wildenhues wrote: > > > I don't see that the +=/func_append substitution is causing any additional > concerns to the XSI functi

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Ralf Wildenhues
Hi Gary, * Ralf Wildenhues wrote on Mon, Jun 28, 2010 at 07:34:35AM CEST: > * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: > > Looking through the XSI substitutions, or more correctly the bash/ksh > > func_append usage, there's room here to consistently use func_append > > everyw

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Gary V. Vaughan
On 7 Aug 2010, at 18:15, Ralf Wildenhues wrote: > Hi Gary, Hallo Ralf, > * Ralf Wildenhues wrote on Mon, Jun 28, 2010 at 07:34:35AM CEST: >> * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: >>> Looking through the XSI substitutions, or more correctly the bash/ksh >>> func_append u

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-03 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Jul 01, 2010 at 07:38:45PM CEST: > Den 2010-06-28 01:24 skrev Gary V. Vaughan: > >@@ -704,15 +710,14 @@ func_mode_compile () > > save_ifs="$IFS"; IFS=',' > > for arg in $args; do > > IFS="$save_ifs" > >-func_quote_for_eval "$arg" > >-l

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-07-03 Thread Peter Rosin
Den 2010-07-03 09:18 skrev Gary V. Vaughan: s/func_append/func_append_quoted/ ? Yes, please push. Done. Cheers, Peter

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-07-03 Thread Gary V. Vaughan
Hi Peter, On 2 Jul 2010, at 00:38, Peter Rosin wrote: > Den 2010-06-28 01:24 skrev Gary V. Vaughan: >> Looking through the XSI substitutions, or more correctly the bash/ksh >> func_append usage, there's room here to consistently use func_append >> everywhere to make for easier maintenance... but r

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-07-03 Thread Gary V. Vaughan
Hi Peter, On 2 Jul 2010, at 00:25, Peter Rosin wrote: > Den 2010-06-28 01:24 skrev Gary V. Vaughan: >> Looking through the XSI substitutions, or more correctly the bash/ksh >> func_append usage, there's room here to consistently use func_append >> everywhere to make for easier maintenance... but r

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-07-01 Thread Peter Rosin
Hi Gary, Den 2010-06-28 01:24 skrev Gary V. Vaughan: Looking through the XSI substitutions, or more correctly the bash/ksh func_append usage, there's room here to consistently use func_append everywhere to make for easier maintenance... but rather than take the additional overhead of a function

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-07-01 Thread Peter Rosin
Hi Gary! Den 2010-06-28 01:24 skrev Gary V. Vaughan: Looking through the XSI substitutions, or more correctly the bash/ksh func_append usage, there's room here to consistently use func_append everywhere to make for easier maintenance... but rather than take the additional overhead of a function

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-06-27 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: > Looking through the XSI substitutions, or more correctly the bash/ksh > func_append usage, there's room here to consistently use func_append > everywhere to make for easier maintenance... but rather than take the > additio

[PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-06-27 Thread Gary V. Vaughan
Looking through the XSI substitutions, or more correctly the bash/ksh func_append usage, there's room here to consistently use func_append everywhere to make for easier maintenance... but rather than take the additional overhead of a function call in the sensitive quadratic scaling parts that promp