Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/22/2008 8:18 PM: | Eric Blake wrote: |> Slightly better, but what about: |> |> m4 --some-option --lt-... |> |> You don't know whether --some-option takes an argument, and the developer |> really intended to pass the li

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-22 Thread Charles Wilson
Eric Blake wrote: Slightly better, but what about: m4 --some-option --lt-... You don't know whether --some-option takes an argument, and the developer really intended to pass the literal string --lt-... as the argument to that option, or if --some-option takes no argument, so --lt-... is a true

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/20/2008 10:23 PM: | | Counter-proposal: remove "--" handling in the wrapper, but don't worry | about requiring "leading" options only. Instead, the wrapper just eats | --${LTWRAPPER_OPTION_NAMESPACE}-* options (and th

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-20 Thread Charles Wilson
Eric Blake wrote: Eric Blake byu.net> writes: | + /* otherwise ... */ | + newargz[++newargc] = xstrdup (argv[i]); Shouldn't you handle "--" as the end of wrapper options, in case the user really wants to pass --lt-env-* as the first option to the wrapped executable? This caused a

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-19 Thread Eric Blake
Eric Blake byu.net> writes: > > | + /* otherwise ... */ > | + newargz[++newargc] = xstrdup (argv[i]); > > Shouldn't you handle "--" as the end of wrapper options, in case the user > really wants to pass --lt-env-* as the first option to the wrapped executable? This caused a regressio

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-13 Thread Charles Wilson
Charles Wilson wrote: Cygwin: passes 115 (9 skip) on old test suite only two "unexpected" failures on new test suite -- but 25 and 72 are actually expected on cygwin. Mingw (msys): no regressions over previous results: old test suite: fails demo-exec after demo-shared (helldl) fails the fortra

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-10 Thread Roumen Petrov
Charles Wilson wrote: Roumen Petrov wrote: libtool 2.2.4 patched with both patches still fail: ... (lt_setenv) setting 'PATH' to ':/usr/local/src//lt-2.2.4-mingw-mlib/lib2/.libs:/usr/local/src//lt-2.2.4-mingw-mlib/lib1/.libs:/tmp/test/pkg/lt-2.2.4-mingw-mlib/lib:/tmp/test/pkg/l

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-10 Thread Charles Wilson
Roumen Petrov wrote: Hi Charles, About following comment: /* execv doesn't actually work on mingw as expected on unix */ Actually execXXX on microsoft windows create a new process and it is not mingw problem. What about to substitute "mingw" with "windows" ? Disagree. The FSF discourages to

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-10 Thread Charles Wilson
Roumen Petrov wrote: libtool 2.2.4 patched with both patches still fail: ... (lt_setenv) setting 'PATH' to ':/usr/local/src//lt-2.2.4-mingw-mlib/lib2/.libs:/usr/local/src//lt-2.2.4-mingw-mlib/lib1/.libs:/tmp/test/pkg/lt-2.2.4-mingw-mlib/lib:/tmp/test/pkg/lt-2.2.4-mingw-mlib/bin:

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-10 Thread Roumen Petrov
Charles Wilson wrote: Charles Wilson wrote: 2008-05-05 Charles Wilson <...> * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto,

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-10 Thread Roumen Petrov
Hi Charles, About following comment: /* execv doesn't actually work on mingw as expected on unix */ Actually execXXX on microsoft windows create a new process and it is not mingw problem. What about to substitute "mingw" with "windows" ? Roumen Charles Wilson wrote: Charles Wilson wrote:

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-09 Thread Charles Wilson
Charles Wilson wrote: 2008-05-05 Charles Wilson <...> * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto, for

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-06 Thread Charles Wilson
Ralf Wildenhues wrote: Hi Charles, You can simplify the remaining part of the ChangeLog entry: or even to this: (func_emit_cwrapperexe_src) [lt_setenv, lt_extend_str] [lt_split_name_value, lt_opt_process_env_set] [lt_opt_process_env_prepend, lt_opt_process_env_append]

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-06 Thread Charles Wilson
Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson <...> | | * libltdl/config/ltmain.m4sh (func_to_native_path): I've become accustomed to using a 1-line summary in my ChangeLog messages prior to the first '* file:' line; that way, the summary ca

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-06 Thread Ralf Wildenhues
Hi Charles, In addition to Eric's review: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: > > * libltdl/config/ltmain.m4sh (func_to_native_path): > new function. If $host is mingw, and $build is mingw > or cygwin, convert path to mingw native format. > (fu

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-06 Thread Gary V. Vaughan
On 6 May 2008, at 09:20, Eric Blake wrote: Doesn't func_error die when called? If so, how do the subsequent three errors get printed? If not, the name seems a bit misleading... We have func_echo, func_warn, and func_error for automatic prefixing of output, and func_fatal_error for non-ret

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson <...> | | * libltdl/config/ltmain.m4sh (func_to_native_path): I've become accustomed to using a 1-line summary in my ChangeLog messages prior to the first '* file:'

[PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-05 Thread Charles Wilson
2008-05-05 Charles Wilson <...> * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto, for :-separated pathlis

[PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-05 Thread Charles Wilson
2008-05-05 Charles Wilson <...> * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto, for :-separated pathlis