Charles Wilson wrote:
> The bits removed from this commit are attached as
> "cygwin-cwrapper-cleanups.patch".
Will start a new thread with these cleanups.
--
Chuck
Ralf Wildenhues wrote:
> Can you test those changes for me, please (TESTSUITEFLAGS='-v -d -x -k
> cwrapper')
> and ensure that test passes, but only with your ltmain patch applied?
Works fine, with a few additional changes. I'll post as a patch on a
separate thread shortly.
--
Chuck
* Charles Wilson wrote on Thu, Jan 22, 2009 at 04:14:51AM CET:
> Ralf Wildenhues wrote:
>
> > I don't see a need to skip the test elsewhere. Here's what I'd do:
> > transform $LIBTOOL to have CFLAGS and LTCFLAGS also contain -std=c89
> > -Werror. (The test would be even cleaner with a re-configu
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET:
> [...] EVERY separate patchset requires an independent full testsuite
> run. Until recently, that was 5 hours of sitting in front of my
> computer waiting for popups, while that computer was completely useless
> for anything else (100
Ralf Wildenhues wrote:
> I don't see a need to skip the test elsewhere. Here's what I'd do:
> transform $LIBTOOL to have CFLAGS and LTCFLAGS also contain -std=c89
> -Werror. (The test would be even cleaner with a re-configured libtool,
> but let's not go overboard here.)
Being a total novice wi
* Charles Wilson wrote on Wed, Jan 21, 2009 at 10:10:08PM CET:
> Ralf Wildenhues wrote:
> > Part (1) is easy to review: it is obvious that regressions are very
> > unlikely to be system-dependent. One does get the impression that it
> > might just be more efficient to let libtool save the cwrapper
Ralf Wildenhues wrote:
> Part (1) is easy to review: it is obvious that regressions are very
> unlikely to be system-dependent. One does get the impression that it
> might just be more efficient to let libtool save the cwrapper text
> somewhere and the program just cat that. But still, this part
Ralf Wildenhues wrote:
> * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET:
>> Part of my tendency to include minor -- easy to review -- changes with
>> larger ones is due to (a) see it, fix it, otherwise it'll be forgotten
>> and (b) EVERY separate patchset requires an independent full
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET:
> Ralf Wildenhues wrote:
> > I am very sorry that reviewing takes so long. Mostly this is due to
> > time constraints on my side.
>
> On the plus side, your reviews are usually insightful, and lead to ideas
> for better code, like the
Ralf Wildenhues wrote:
> I am very sorry that reviewing takes so long. Mostly this is due to
> time constraints on my side.
On the plus side, your reviews are usually insightful, and lead to ideas
for better code, like the libfile_$(transliterated implib name) thing.
> You can make things easier
Hello Charles,
* Charles Wilson wrote on Wed, Jan 21, 2009 at 04:21:01PM CET:
> Thanks, Peter; your validation on msvc is useful and encouraging. Now
> I'm just waiting for a go/no-go from one of the four libtool
> maintainers: Gary Vaughan, Peter O'Gorman, Ralf Wildenhues, or Bob
> Friesenhahn.
Peter Rosin wrote:
> Den 2009-01-16 15:15 skrev Charles Wilson:
>> Charles Wilson wrote:
>>> Charles Wilson wrote:
* libltdl/config/ltmain.m4sh: Update copyright date.
(func_emit_wrapper_part1): move contents to...
(func_emit_wrapper_part2): move contents to...
(func_emit_wrappe
Den 2009-01-16 15:15 skrev Charles Wilson:
Charles Wilson wrote:
Charles Wilson wrote:
* libltdl/config/ltmain.m4sh: Update copyright date.
(func_emit_wrapper_part1): move contents to...
(func_emit_wrapper_part2): move contents to...
(func_emit_wrapper): here.
(func_emit_cwrapperexe_src) [file
Charles Wilson wrote:
> Charles Wilson wrote:
>> * libltdl/config/ltmain.m4sh: Update copyright date.
>> (func_emit_wrapper_part1): move contents to...
>> (func_emit_wrapper_part2): move contents to...
>> (func_emit_wrapper): here.
>> (func_emit_cwrapperexe_src) [file scope]: re-organized
>> includ
Charles Wilson wrote:
> * libltdl/config/ltmain.m4sh: Update copyright date.
> (func_emit_wrapper_part1): move contents to...
> (func_emit_wrapper_part2): move contents to...
> (func_emit_wrapper): here.
> (func_emit_cwrapperexe_src) [file scope]: re-organized
> includes and portability macros. Avo
Charles Wilson wrote:
Now I get completely new working cross-environment: git show correctly
modified files, patch work too :) .
[SNIP]
No regressions on msys/mingw from the last time I ran the testsuite on
that platform (2.2.5a). IOW:
Old testsuite results:
[SNIP]
No regression on unix/min
Roumen Petrov wrote:
> Charles Wilson wrote:
> [SNIP]
>> This patch attempts to correct the issues raised in this thread:
>> "msys/mingw warnings about string length and putenv absence with gcc
>> -Wall -ansi"
>> http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html
>>
> [SNIP]
> Patc
Charles Wilson wrote:
[SNIP]
This patch attempts to correct the issues raised in this thread:
"msys/mingw warnings about string length and putenv absence with gcc -Wall
-ansi"
http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html
[SNIP]
Patch fail for trunk(origin):
$ patch -p1 -
Charles Wilson wrote:
> Spot checked some regression tests on cygwin (all passed).
> Running full regression suite on mingw. OK to push, pending
> testsuite results?
No regressions on msys/mingw from the last time I ran the testsuite on
that platform (2.2.5a). IOW:
Old testsuite results:
=
* libltdl/config/ltmain.m4sh: Update copyright date.
(func_emit_wrapper_part1): move contents to...
(func_emit_wrapper_part2): move contents to...
(func_emit_wrapper): here.
(func_emit_cwrapperexe_src) [file scope]: re-organized
includes and portability macros. Avoid oldnames on MINGW32
and MSVC fo
20 matches
Mail list logo
