Hi Eric.
On 12/19/2011 02:44 PM, Eric Blake wrote:
On 12/17/2011 10:22 PM, Gary V. Vaughan wrote:
We should try to minimise forks, especially on Windows where they are
+# unreasonably slow, so skip the feature probes when bash is being used:
+if test set = "${BASH_VERSION+set}"; then
+: ${
On 12/18/2011 11:07 AM, Gary V. Vaughan wrote:
Hi Stefano,
On 18 Dec 2011, at 17:02, Stefano Lattarini wrote:
On 12/18/2011 10:52 AM, Stefano Lattarini wrote:
On 12/18/2011 06:15 AM, Gary V. Vaughan wrote:
+# We should try to minimise forks, especially on Windows where they are
On 12/18/2011 10:52 AM, Stefano Lattarini wrote:
On 12/18/2011 06:15 AM, Gary V. Vaughan wrote:
+# We should try to minimise forks, especially on Windows where they are
+# unreasonably slow, so skip the feature probes when bash is being
used:
+if test set = "${BASH_VERSION+set}&q
On 12/18/2011 06:15 AM, Gary V. Vaughan wrote:
+# We should try to minimise forks, especially on Windows where they are
+# unreasonably slow, so skip the feature probes when bash is being used:
+if test set = "${BASH_VERSION+set}"; then
+: ${lt_HAVE_ARITH_OP="yes"}
+: ${lt_HAVE_XSI_OPS="y
Hi Eric.
On Thursday 08 December 2011, Eric Blake wrote:
>
> Instead of doing it this way, I'd almost rather see:
>
> if test "${BASH_VERSION+set}" = set; then
>
> although if cygwin ever follows debian's lead of using dash for faster
> /bin/sh, I'm not sure if there is a reliable forkless way t
On Friday 25 November 2011, Gary V wrote:
> On 25 Nov 2011, at 18:59, Stefano Lattarini wrote:
> > On Friday 25 November 2011, Gary V wrote:
> >>
> >> The best reason I can find for keeping the various demo directories
> >> around (despite the fact we alre
Hi Gary.
On Friday 25 November 2011, Gary V wrote:
> The best reason I can find for keeping the various demo directories
> around (despite the fact we already make use of the much better test
> harness of Autotest for all our new test cases) from the last time
> I wanted to migrate everything out
Only a quick incomplete review ...
On Friday 25 November 2011, Gary V wrote:
> +{
> +test -n "$objdir" || exit 1
> +$lt_INSTALL -d "$objdir/temp/libs"
> +cp -f libhello.la "$objdir/temp"
> +cp -f "$objdir"/libhello.* "$objdir/lt-hell$EXEEXT" "$objdir/temp/libs"
> +trap "func_re
On Tuesday 22 November 2011, Eric Blake wrote:
> touch =; test -f =; echo $?
>
This is problematic also with pdksh 5.2.14 on Debian:
$ pdksh -c 'touch ./=; test -f =; echo $?'
pdksh: test: =: missing second argument
2
and with /bin/sh on OpenBSD 4.6 as well:
$ /bin/sh -c 'touch ./=; test
On Tuesday 22 November 2011, Gary V wrote:
> Hi Stefano,
>
> On 22 Nov 2011, at 02:52, Stefano Lattarini wrote:
> > Hi Gary. Just a quick nit (I haven't looked at the whole
> > series, and not even at the whole patch in fact; sorry).
>
> No apologies necessary
[adding bug-autoconf in CC]
On Tuesday 22 November 2011, Gary V wrote:
> Hi Eric,
>
> On 22 Nov 2011, at 03:07, Eric Blake wrote:
>
> > On 11/21/2011 07:47 AM, Gary V. Vaughan wrote:
> >> To safely use a non-literal first argument to `test', you must
> >> always prepend a literal non-`-' charact
Hi Gary. Few more random nits...
On Monday 21 November 2011, Gary V wrote:
> To safely use a non-literal first argument to `test', you must
> always prepend a literal non-`-' character, but often the second
> operand is a constant that doesn't begin with a `-' already, so
> always use `test a = "
Hi Gary. Again, few quick nits here, probably incomplete.
On Monday 21 November 2011, Gary V wrote:
> * cfg.mk (sc_prohibit_bare_basename, sc_prohibit_basename_with_sed):
> Make sure not to go back to using occasional `|$basename' or
> `|$dirname' syntax.
> * build-aux/general.m4sh, build-aux/git
Hi Gary. Just a quick nit (I haven't looked at the whole
series, and not even at the whole patch in fact; sorry).
On Monday 21 November 2011, Gary V wrote:
> for file
> do
> - test -f $file || touch $file
> + test -f "$file" || touch $file
>
What's the point of quoting file a
[adding automake list in CC]
Hi Eric.
On Wednesday 16 November 2011, Eric Blake wrote:
> >
> > + - At some point we were supporting some undetermined `broken make', as
> > +evidenced by having carried the following code since 2003:
> > +
> > + ## use @LIBLTDL@ because some broken make
Hi Gary.
On Wednesday 16 November 2011, Gary V wrote:
> Hi Stefano,
>
> Thanks for the review.
>
> >>
> >> # GPL_version: checks for GPLv3, which we don't use
> >> -# program_name: libtool has no programs!
> >>
> > But then, since libtool doesn't offer any "real" program, what is
> > the point
On Tuesday 15 November 2011, Gary V wrote:
> * cfg.mk (local-checks-to-skip): Remove sc_program_name
> list of disabled checks.
> (exclude_file_name_regexp--sc_program_name): Don't check demo
> programs for use of set_program_name.
>
> Signed-off-by: Gary V. Vaughan
> ---
> cfg.mk |3 +--
>
On Tuesday 15 November 2011, Gary V wrote:
> * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain
> list of disabled checks.
> (exclude_file_name_regexp--sc_program_name): Don't check demo
> programs for use of set_program_name.
>
> Signed-off-by: Gary V. Vaughan
> ---
> cfg.mk |3 +--
>
On Tuesday 15 November 2011, Gary V wrote:
> * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain
> list of disabled checks.
> (exclude_file_name_regexp--sc_program_name): Don't check demo
s|set_program_name|bindtextdomain| here?
> programs for use of set_program_name.
>
And here as well?
Re
On Wednesday 02 November 2011, Gary V wrote:
> Hi Stefano,
>
> On 1 Nov 2011, at 21:57, Stefano Lattarini wrote:
> > Hi Gary, hope you won't mind few nits from an outsider ...
>
> Absolutely not, any and all feedback is always extremely welcome. Thank you.
>
&g
Hi Gary.
On Wednesday 02 November 2011, Gary V wrote:
>
> >> package_revision=`$SHELL $ac_aux_dir/git-version-gen .tarball-version`
> >> diff --git a/libltdl/.gitignore b/libltdl/.gitignore
> >> index 2f39096..5795dbc 100644
> >> --- a/libltdl/.gitignore
> >> +++ b/libltdl/.gitignore
> >> @@ -2,5
On Tuesday 01 November 2011, Gary V wrote:
> Similarly to 1/3, full compressed patch attached. 72 hours etc etc.
>
> * bootstrap.conf (libtool_link_libltdl_subdirs): Add `m4'.
> * cfg.mk (exclude_file_name_regexp--sc_prohibit_test_minus_ao):
> Adjust path.
> * configure.ac (AC_CONFIG_MACRO_DIR): A
Hi Gary, hope you won't mind few nits from an outsider ...
On Tuesday 01 November 2011, Gary V wrote:
>
> diff --git a/Makefile.am b/Makefile.am
> index d4e25cc..db98870 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -343,9 +343,9 @@ $(lt_Makefile_in): $(lt_Makefile_am) $(lt_aclocal_m4)
> #
On Thursday 02 September 2010, Peter Rosin wrote:
> It is actually a bug in ar-lib. When you issue
> .../ar-lib lib x foo.lib
> it runs this loop:
>
> $AR -NOLOGO -LIST "$archive" | while read member
> do
> $AR -NOLOGO -EXTRACT:"$member" "$archive" || exit $?
> done
>
> (w
24 matches
Mail list logo
