Re: Bug 9210: fix to replace Linux with GNU/Linux where needed

On 09/04/2011 03:22 PM, Ralf Wildenhues wrote: > -# This must be Linux ELF. > +# This must be GNU/Linux ELF. The comment does not match the code below it, see the following line. Not your fault, and generally I don't want to take patches hostage on unrelated bugs, but*please* make this # T

Re: [PATCH] Add missing sysroot resolution

> Paolo, I'm sorry if I made you though this patch was fixing my problem > (in fact after a quick test, it does not). I just wanted to point it > out, because Openembedded like buildroot, are projects which try to > crosscompile source packages. I though it might be a good start to > investigate th

Re: [PATCH] Add missing sysroot resolution

On 10/09/2010 10:51 AM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: I'm applying this patch since it's pretty obvious. Thank you. Is this fixing (part) of the reported bug? Lionel pointed us to the patch, so I assumed it fixed all of it.

[RFC PATCH] Strip trailing slashes from libdir and destdir

I found this patch at OpenEmbedded, http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-October/025133.html It looks to me like the code can be simplified by unconditionally stripping trailing slashes from $libdir and $destdir (i.e. not introducing the new variables). Ideas? Paolo * li

[PATCH] Add missing sysroot resolution

c...@cs.tu-berlin.de 2002-11-05 Jan Kratochvil project-libt...@jankratochvil.net 2003-01-28 Raja R. Harinath harin...@acm.org 2003-02-25 + Paolo Bonzinibonz...@gnu.org 2003-03-01 Richard Nich

Re: [PATCH] Do not absolutize paths eagerly.

On 08/21/2010 08:03 AM, Ralf Wildenhues wrote: * Ralf Wildenhues wrote on Fri, Aug 20, 2010 at 06:34:58AM CEST: * libltdl/config/ltmain.m4sh (func_resolve_sysroot): Partly revert v2.2.10-83-gc45a288: Do not absolutize path here, only do sysroot replacement. (func_mode_link): Adjust. Fixes AIX te

Re: [PATCH] Do not absolutize paths eagerly.

On 08/21/2010 08:03 AM, Ralf Wildenhues wrote: Fixed the regression as expected, didn't show up any other failures. OK to apply to the sysroot branch? I still need somebody to test a sysroot-enabled setup with this. I'm testing it now. Paolo

Re: [PATCH v2 0/3] sysroot followup patches

> Paolo, are you going to squash this: > http://lists.gnu.org/archive/html/libtool-patches/2010-08/msg00145.html > perhaps without this change: >> -      if $opt_dry_run; then >> +      if ${opt_dry_run-false}; then > into > [PATCH] improve code for sysroot --mode=finish.eml Yes of course. Paolo

Re: [RFT PATCH v4 3/8] teach libtool -L= and -R=

On 08/19/2010 06:58 AM, Ralf Wildenhues wrote: +# func_resolve_sysroot PATH +# Change PATH to an absolute path or replace a leading = with a +# sysroot. Store the result into func_resolve_sysroot_result +func_resolve_sysroot () +{ + func_resolve_sysroot_result=$1 + case $func_resolve_sysroot_r

[PATCH] Factor the sed command used to make a regex from a literal.

In func_generate_dlsyms, the resulting regex is used with grep rather than sed. I don't think grep has problems with \/ in practice, but of course I can change it to use sed, too. Ok? (if so, which way?) Paolo 2010-08-15 Paolo Bonzini * libltdl/config/general

[PATCH] improve code for sysroot --mode=finish

Here are the improvements you suggested. I'll send a patch for sed_make_literal_regex soon. Ok? Paolo * libltdl/config/ltmain.m4sh (func_mode_finish): Change sysroot_regex and sysroot_cmd delimiter from pipe to slash. Wrap the entire for loop with "if $opt_dry_run...fi" and print an explanator

Re: [PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

On 08/13/2010 06:14 AM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:04AM CEST: * libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool through func_resolve_sysroot. This looks ok, but is it covered in the testsuite? Apparently not. If it

Re: [PATCH v2 4/4] add libtool --mode=finish mode for sysroot

On 08/13/2010 12:59 AM, Ralf Wildenhues wrote: Erm, you should be mentioning the files you change in your log entries, and Libtool also doesn't auto-generate its ChangeLog (yet), so you need that, too, also for all the other patches in the sysroot branch. I was planning to form a merged changel

[PATCH v2 4/4] add libtool --mode=finish mode for sysroot

--- doc/libtool.texi | 18 -- libltdl/config/ltmain.m4sh | 21 + tests/sysroot.at |3 +++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/doc/libtool.texi b/doc/libtool.texi index 914bd1d..4b256bf 100644 --- a/doc/libt

[PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

* libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool through func_resolve_sysroot. --- libltdl/config/ltmain.m4sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 3888cb0..563c3af 100644 ---

[PATCH v2 3/4] reorganize parsing of --mode=finish arguments

* libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 109 +--- 1 files changed, 62 insertions(+), 47 deletions(-) diff --git a/libltdl/config/l

[PATCH v2 1/4] fix sysroot tests to pass on Fedora 13

* tests/sysroot.at: Link $prefix/include into the sysroot as well, as required by newer GCC. --- tests/sysroot.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/sysroot.at b/tests/sysroot.at index 850e0cd..869c9c4 100644 --- a/tests/sysroot.at +++ b/tests/sysroot.a

[PATCH v2 0/3] sysroot followup patches

e for the --mode=finish changes. Ok to push to sysroot branch? Paolo Bonzini (4): fix sysroot tests to pass on Fedora 13 fix sysroot handling for deplibs of preopened libtool libs reorganize parsing of --mode=finish arguments add libtool --mode=finish mode for sysroot doc/libtool.texi

Re: [PATCH 2/2] add libtool --mode=finish mode for sysroot

On 08/12/2010 01:12 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: + sed -e "${sysroot_cmd} s/\([ ']-[LR]\)=/\1/g" $lib> $tmpdir/tmp-la Hmmm. Some of the test cases end up with dependency_libs like this: dependency_libs=' -L=/mingw/

Re: [PATCH 1/2] reorganize parsing of --mode=finish arguments

On 08/12/2010 12:58 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 117

[PATCH 2/2] add libtool --mode=finish mode for sysroot

--- doc/libtool.texi | 17 + libltdl/config/ltmain.m4sh | 20 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/doc/libtool.texi b/doc/libtool.texi index 914bd1d..5b21a32 100644 --- a/doc/libtool.texi +++ b/doc/libtool.texi @@ -1721,

[PATCH 1/2] reorganize parsing of --mode=finish arguments

* libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 117 ++-- 1 files changed, 70 insertions(+), 47 deletions(-) diff --git a/libltdl/config/l

[PATCH 0/2] sysroot patches followup

Given testing natively is stuck on missing ld support for sysroot, the only other issue to be solved is the conflict with --with-sysroot in GCC. I'm thinking of just renaming the option to --enable-sysroot... Paolo Paolo Bonzini (2): reorganize parsing of --mode=finish arguments add libt

Re: [RFT PATCH v3 3/9] add --with-sysroot

On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: Actually, I don't see any other uses of target in the whole patch series, so why not just omit that here? All of this is dead code actually... > + AC_MSG_RESULT([$with_sysroot]) > + lt_sysroot=`echo "$with_sysroot" | sed -e "$sed_quote_subst"

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

On 08/01/2010 08:31 PM, Ralf Wildenhues wrote: Although it is fairly unlikely, I prefer not relying on :+ support, so please replace with 'if test -z "$lt_sysroot"...'. Two instances. Is this still true in the light of the recent discussion on autoconf mailing lists? Paolo

Re: [RFT PATCH v4 0/8] Sysroot series

On 08/02/2010 07:55 PM, Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Aug 01, 2010 at 10:04:16PM CEST: support, use --prefix=/mingw + DESTDIR=/the-sysroot. What about the w32 users that use --prefix=C:/mingw and then cannot use DESTDIR because that will not concatenate? Also, in 'ln -

Re: [RFT PATCH v4 0/8] Sysroot series

On 08/03/2010 07:52 AM, Charles Wilson wrote: On 8/2/2010 1:53 PM, Ralf Wildenhues wrote: This should be fixed: | ++ make all | stderr: | lib2.c: In function 'g': | lib2.c:6:13: warning: initialization makes pointer from integer without a cast | stdout: This addendum appears to do it (Tested

Re: [RFT PATCH v4 0/8] Sysroot series

On Mon, Aug 2, 2010 at 22:13, Ralf Wildenhues wrote: > More issues: > > - the part of ltmain starting with >        # Collect and forward deplibs of preopened libtool libs > > will source .la files but looks like it mistreats = in $dependency_libs Ok. > - is it intended that the = remain in the

Re: [RFT PATCH v3 3/9] add --with-sysroot

On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: Next one: 3/9. This is a bit of a preliminary review, because I haven't read all patches and all of the discussion yet. * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:16AM CEST: * libltdl/m4/libtool.m4 (_LT_HOST_NONCANO

Re: [RFT PATCH v4 0/8] Sysroot series

On 08/01/2010 08:43 PM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths

Re: [RFT PATCH v4 0/8] Sysroot series

On 08/01/2010 07:22 PM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: This should, and I say "should" :) pass all tests. Thanks for the repost. Did anything change beside the discussion attached to the last patch series post? No. This pas

[RFT PATCH v4 5/8] process postdeps to include sysrooted paths

. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/m4/libtool.m4 | 42 ++ 1 files changed, 38 insertions(+), 4 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 52efd48..3560740 100644 --- a/libltdl/m4

[RFT PATCH v4 0/8] Sysroot series

double-check of the testsuite.dir would be nice. Paolo Paolo Bonzini (8): handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths emit sysrooted paths when installing .la f

[RFT PATCH v4 7/8] add sysroot test

* Makefile.am (TESTSUITE_AT): Add tests/sysroot.at. * tests/sysroot.at: New. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- Makefile.am |3 +- tests/sysroot.at | 201 ++ 2 files changed, 203 insertions(+), 1

[RFT PATCH v4 2/8] add --with-sysroot

* libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT. Signed-off-by: Paolo Bonzini --- libltdl/m4/libtool.m4 | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/libltdl

[RFT PATCH v4 8/8] initial version of the NEWS entry

* NEWS: Document sysroot support. --- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 95fa97d..68ebcee 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,16 @@ New in 2.2.12 2010-08-??: git version 2.2.11a, Libtool team: * New features: + - Sysr

[PATCH] fixup for teach libtool -L= and -R=

This fixes 37 and 38 (and likely a bunch of other failures). The 37/38 failure is really a logic bug, the other two are cut-and-paste problems. It seems like I didn't review the patch even. (I did; what I didn't do was testing it beyond sysroot.at :). I'll squash it in 3/9. Paolo --- libltdl/

[RFT PATCH v4 3/8] teach libtool -L= and -R=

resolve sysroot paths there. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/config/ltmain.m4sh | 87 +--- 1 files changed, 65 insertions(+), 22 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh

[RFT PATCH v4 4/8] handle sysrooted paths when reading dependencies to la files

* libltdl/config/ltmain.m4sh (func_mode_execute, func_mode_install, func_mode_link): Whenever a .la file occurs in another .la file, expand the sysroot path in it. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh | 18 ++ 1 files changed, 14 insertions(+), 4

[RFT PATCH v4 1/8] handle sysroot flags

* libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot option. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 897a5e8..4f373db

[RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

* libltdl/config/ltmain.m4sh (func_replace_sysroot): New. (func_mode_link): Prepend paths in $libdir with the sysroot. Further, replace the sysroot with = (using func_replace_sysroot) whenever such a path is written in a .la file. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson

Re: [RFT PATCH v3 0/9] Sysroot patches

On 07/30/2010 08:55 PM, Charles Wilson wrote: > Since the bug is cross-platform, it should be easy(er) to fix for you > non-cygwin types. Any ideas, Paolo? Not tested yet, but I am pretty sure this should do it: diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index b0b0ebc.

Re: [RFT PATCH v3 0/9] Sysroot patches

On 07/30/2010 08:55 PM, Charles Wilson wrote: Since the bug is cross-platform, it should be easy(er) to fix for you non-cygwin types. Any ideas, Paolo? You removed any excuse that I had for not looking at it more deeply. :) PS. Note that all these tests were done using the patches as submitt

Re: [RFT PATCH v3 3/9] add --with-sysroot

On Thu, Jul 29, 2010 at 10:01, Charles Wilson wrote: > On 7/28/2010 7:23 PM, Paolo Bonzini wrote: >> * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. >> (LT_SETUP): Require _LT_WITH_SYSROOT. >> >> Signed-off-by: Paolo Bonzini >> --- >&

Re: [RFT PATCH v3 0/9] Sysroot patches

On Thu, Jul 29, 2010 at 10:04, Charles Wilson wrote: > On 7/28/2010 7:23 PM, Paolo Bonzini wrote: >> This is the update of the series, with the bug fixes (thanks Charles >> for the hand work!) and structured to preserve bisectability. >> > > Sadly, the newest patchset

[RFT PATCH v3 5/9] handle sysrooted paths when reading dependencies to la files

* libltdl/config/ltmain.m4sh (func_mode_execute, func_mode_install, func_mode_link): Whenever a .la file occurs in another .la file, expand the sysroot path in it. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh | 18 ++ 1 files changed, 14 insertions(+), 4

[RFT PATCH v3 4/9] teach libtool -L= and -R=

resolve sysroot paths there. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/config/ltmain.m4sh | 81 --- 1 files changed, 60 insertions(+), 21 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh

[RFT PATCH v3 8/9] add sysroot test

* Makefile.am (TESTSUITE_AT): Add tests/sysroot.at. * tests/sysroot.at: New. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- Makefile.am |3 +- tests/sysroot.at | 201 ++ 2 files changed, 203 insertions(+), 1

[RFT PATCH v3 7/9] emit sysrooted paths when installing .la files

* libltdl/config/ltmain.m4sh (func_replace_sysroot): New. (func_mode_link): Prepend paths in $libdir with the sysroot. Further, replace the sysroot with = (using func_replace_sysroot) whenever such a path is written in a .la file. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson

[RFT PATCH v3 9/9] initial version of the NEWS entry

* NEWS: Document sysroot support. --- I am not sure where to talk about the sysroot support in the manual. Probably it would deserve an entire section of its own! In the meanwhile, a NEWS entry is just a little better than nothing... NEWS | 12 1 f

[RFT PATCH v3 1/9] fix bug in postdeps computation

* libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS): Actually concatenate $prev and $p. Signed-off-by: Paolo Bonzini --- libltdl/m4/libtool.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 47d2558..f61be28 100644

[RFT PATCH v3 6/9] process postdeps to include sysrooted paths

. Signed-off-by: Paolo Bonzini Signed-off-by: Charles Wilson --- libltdl/m4/libtool.m4 | 42 ++ 1 files changed, 38 insertions(+), 4 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 52efd48..3560740 100644 --- a/libltdl/m4

[RFT PATCH v3 2/9] handle sysroot flags

* libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot option. Signed-off-by: Paolo Bonzini --- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 897a5e8..4f373db

[RFT PATCH v3 3/9] add --with-sysroot

* libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT. Signed-off-by: Paolo Bonzini --- Right now the default is to use a sysroot. Probably it is a bit too aggressive, especially because most existing cross

[RFT PATCH v3 0/9] Sysroot patches

This is the update of the series, with the bug fixes (thanks Charles for the hand work!) and structured to preserve bisectability. Paolo Bonzini (9): fix bug in postdeps computation handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading

Re: [REBASED PATCH 6/9] teach libtool -L= and -R=

On 07/29/2010 01:20 AM, Charles Wilson wrote: On 7/28/2010 6:25 PM, Paolo Bonzini wrote: On 07/22/2010 08:36 PM, Charles Wilson wrote: @@ -5777,11 +5812,13 @@ func_mode_link () for deplib in $dependency_libs; do newdependency_libs="$deplib $newdependency_libs" if $opt_preserve_dup_d

Re: [REBASED PATCH 6/9] teach libtool -L= and -R=

On 07/22/2010 08:36 PM, Charles Wilson wrote: @@ -5777,11 +5812,13 @@ func_mode_link () for deplib in $dependency_libs; do newdependency_libs="$deplib $newdependency_libs" if $opt_preserve_dup_deps ; then + func_resolve_sysroot "$deplib" +

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

ndency_libs/ -- this was in my patchset too + ;; + -R*) + func_stripname -R '' "$i" + func_replace_sysroot "$func_stripname_result" + func_append newdeplibs " -R$func_replace_sysroot_result" s/newdeplibs/newdependency_libs/ -- also in my patchset. This should f

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

On 07/28/2010 02:47 PM, Charles Wilson wrote: On 7/28/2010 5:05 AM, Paolo Bonzini wrote: On Wed, Jul 28, 2010 at 10:10, Charles Wilson But that doesn't appear to be the case for cross builds, in the new tests. But I don't think it was bisectable in cross builds in your original d

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

On Wed, Jul 28, 2010 at 10:10, Charles Wilson wrote: > Well, after the first 7 of 9 (no star trek jokes, please), in native > mode, all of the problematic tests pass (old: > tagdemo-conf.test+tagdemo-make.test; new: 41, 101). That's good. > So, I can either squash 8 and 9, and treat it atomicall

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

On 07/26/2010 01:57 PM, Charles Wilson wrote: These are rebased versions of Paolo's sysroot patches, rebased to 0e01d00c70fe1eba2b746a6bb52e3c9277a4f1ef (Sun Jul 18 17:17:15 2010 +0200) As it happens, Paolo's old 3/8 'provide shell functions to configure.patch' didn't apply very well at all, gi

Re: [RFC PATCH 0/8] sysroot support

On 07/23/2010 06:12 AM, Charles Wilson wrote: On 7/22/2010 2:36 PM, Paolo Bonzini wrote: This patch series is on top of 04329d83555b5f8d2fd02428418a79ea392b2d91. The basic idea is to look for -L= and -R= to expand the sysroot, and for the sysroot to remove it in .la files. Some missing

[RFC PATCH 7/8] handle sysrooted paths when reading dependencies to la files

--- libltdl/config/ltmain.m4sh | 18 ++ tests/sysroot.at |6 ++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 4251bb3..1a8041f 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/c

[RFC PATCH 6/8] teach libtool -L= and -R=

--- libltdl/config/ltmain.m4sh | 81 --- 1 files changed, 60 insertions(+), 21 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 8864916..4251bb3 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4s

[RFC PATCH 3/8] provide shell functions to configure

--- libltdl/m4/libtool.m4 | 56 +++- 1 files changed, 41 insertions(+), 15 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 0638091..ef4aa0f 100644 --- a/libltdl/m4/libtool.m4 +++ b/libltdl/m4/libtool.m4 @@ -166,6 +166,7 @

[RFC PATCH 4/8] Add --with-sysroot

The first baby step. Support the option, and replace it properly in the libtool script. --- libltdl/m4/libtool.m4 | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index ef4aa0f..

[RFC PATCH 2/8] fix buglet

--- libltdl/m4/libtool.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 index 3a65ec4..0638091 100644 --- a/libltdl/m4/libtool.m4 +++ b/libltdl/m4/libtool.m4 @@ -6413,7 +6413,7 @@ if AC_TRY_EVAL(ac_compile); then pre_te

[RFC PATCH 1/8] handle sysroot flags

--- libltdl/config/ltmain.m4sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index ebd3909..8864916 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4sh @@ -4155,7 +4155,7 @@ func_mode_link (

[RFC PATCH 8/8] emit sysrooted paths when installing .la files

--- libltdl/config/ltmain.m4sh | 43 --- libltdl/m4/libtool.m4 | 15 +++ 2 files changed, 47 insertions(+), 11 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 1a8041f..206bda9 100644 --- a/libltdl

[RFC PATCH 5/8] add a basic sysroot test

-*- Autotest -*- +# +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Paolo Bonzini, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the

[RFC PATCH 0/8] sysroot support

. However, I haven't retested this at all, so I trust my old runs from mid 2009 which were done with Fedora 12 and its mingw cross-compilation environment. Sorry for the delay. Paolo Bonzini (8): handle sysroot flags fix buglet provide shell functions to configure Add --with-sysroot

Re: [PATCH RFC] Add sysroot support.

On 07/21/2010 03:58 PM, Charles Wilson wrote: On 7/8/2010 1:02 PM, Paolo Bonzini wrote: I have another sysroot patch that seems (from a first cursory view) pretty different. I'll rebase and send. Ping? Rebasing was a bit troublesome due to the "replace shell function impl

Re: [PATCH RFC] Add sysroot support.

On 07/07/2010 11:51 AM, Thierry Reding wrote: Hi, the following patch adds support for gcc's --sysroot argument to libtool. I'll post the patch first and will reply to it, giving more details where needed. I've been building a number of packages with variations of this patch depending on the li

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

On 06/29/2010 08:52 AM, Gary V. Vaughan wrote: Well, really the problem is this: while $# -gt 0; do opt=$1; shift case $opt in -p) opt_p="$1"; shift ;; -q) opt_q="$1"; shift ;; -x) opt_x=: ;; -y) opt_y=: ;; -p*|-q*) # option args func_split_short_arg $opt

Re: overridable pic_flag

On 06/15/2010 07:45 PM, Ralf Wildenhues wrote: Ping! I would at least like a comment upon this, why it would be too dangerous, and all that. (No, this patch is unrelated to the -flto patches I just pinged.) I'm al

Re: [PATCH 1/4] Support GCC LTO on GNU/Linux.

On 04/06/2010 04:01 AM, Charles Wilson wrote: > As for whether it would get dropped if you did, I'd imagine that's quite > plausible; you might want to add a volatile qualifier. 'static volatile const char * MAGIC = ...' ^^ err...maybe just 'volatile'! Volatile const

Re: [PATCH 0/2] Re: ifdef expessions in Makefile.am

On 12/22/2009 09:38 AM, Joakim Tjernlund wrote: bonz...@gnu.org wrote on 22/12/2009 09:16:59: From: Paolo Bonzini Here is where I was at. After that it was not immediate how to use a tag-dependent cache variable. Strictly speaking however using a cache variable is not needed to make the PIC

Re: avoid compiler warning

On 11/02/2009 08:17 PM, Eric Blake wrote: >Even better to post a > GCC patch to avoid emitting this warning. I have no idea where to patch that, but I guess I could go ahead and submit the bug report. I'd say the real bug is that it doesn't emit the warning for a char *const. Paolo

Re: avoid compiler warning

The compiler warning is bogus. Your patch pessimizes the code; IIRC it can cause runtime-initialization of the pointer. Load-time relocation, to be precise. Paolo

Re: make commit conflicts in configure files less likely

On 08/22/2009 09:32 PM, Ralf Wildenhues wrote: Nodaways, most projects don't commit generated configure scripts to version control any more, but some notable ones still do, e.g., GCC and the GNU toolchain. The Libtool macros provide a bit of a stumbling block for this as they are the most promin

Re: GCC_NO_EXECUTABLES and Libtool

Ralf Wildenhues wrote: > [ gcc-patches: OK to pull the libtool.m4 bits over to the GCC tree > once they are applied upstream? ] Yes. Paolo

Re: [SCM] GNU Libtool branch, master, updated. v2.2.6-56-g9c9cde2

> Ouch. I don't have ~/devel. Almost no one has. :-) Reverted. Paolo

Re: Typo in the documentation?

Akim Demaille wrote: > LIBTOOL_DEPS = @LIBTOOL_DEPS@ > libtool: $(LIBTOOL_DEPS) > $(SHELL) ./config.status --recheck > > Do you really mean --recheck? In that case there is no reason for > config.status to recreate libtool, unless I missing something. Don't

Re: $ECHO change uncovered underquoting

> Luckily, both are orthogonal: we can still do the latter later. > Your patch introduces a wee bit of slowdown, but not much (all of these > commands are used at most a couple of times per invocation). And nowhere near the fork that `...` is already doing. Pushed, thanks. Paolo

Re: $ECHO change uncovered underquoting

. It seems to me that func_echo_all is never needed in config.status. A testsuite run is in progress. Paolo 2008-11-26 Paolo Bonzini <[EMAIL PROTECTED]> * HACKING: Document func_echo_all. * m4/libtool.m4sh: Add it and use it throughout instead of $ECHO inside eval'

Re: $ECHO change uncovered underquoting

> 1) Add more escaping to the input lines. E.g., > _LT_TAGVAR(archive_cmds, $1)='$CC -o $lib $libobjs $compiler_flags > `$ECHO "$deplibs" | $SED '\''s/ -lc$//'\''` -link -dll~linknames=' > > would become > _LT_TAGVAR(archive_cmds, $1)='$CC -o $lib $libobjs $compiler_flags > `\$ECHO

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

> IIUC then this code has two problems: first, it changes PATH and FPATH > for any _AS_DETECT_SUGGESTED shell snippets expanded right after this > one. Second, it uses an unsafe replacement path (this problem stems > from before your patch). Oops, I remembered that each snippet expanded to a sub

Re: Revenge of the $ECHO. Kill most uses of Xsed.

> Well. This code is meant to find out the maximum command line length > limit. It is supposed to fork and exec. Thinking about it, I wonder. > It will likely fork with most shells (but not all), but chances are not > that high that it will exec. Means the test looks broken anyway. :-/ You c

Re: Revenge of the $ECHO. Kill most uses of Xsed.

>> $ECHO "run \`$progname --help | more' for full usage" > > This can be echo rather than $ECHO, since the \` is flattened during "" > interpratation prior to the echo call. Several similar places exist. What about $progname? I think $ECHO->echo is almost always a bad idea whenever there

Re: Revenge of the $ECHO. Kill most uses of Xsed.

Ralf Wildenhues wrote: > I guess now that $ECHO copes with leading hyphen, we can throw away some > $Xsed uses, and turn all the rest to plain $SED. Is that what you had > in mind, Paolo? I hope you weren't also working on this? No, but I will look over for typos and also for more problematic us

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

> Yes; I usually give the other maintainers a day to comment before adding > write access; sorry if I wasn't clear enough about this. No feedback, > so I added you now. Can you try if it works now? I was actually checking if I already had write access (did not remember). Does not work yet, but

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

Paolo Bonzini wrote: >> 1) I don't have access to systems that are old or weird enough to check >> if the performance penalty will happen often. What do you think? >> >> 2) If ksh had a way to print without interpreting escapes *and dashes*, >> I'd be

Re: [PATCH 6/6] use print or printf or cat as $ECHO

> 1) I don't have access to systems that are old or weird enough to check > if the performance penalty will happen often. What do you think? > > 2) If ksh had a way to print without interpreting escapes *and dashes*, > I'd be glad to add it; do you know one? I thought of one after lunch: "print

Re: [PATCH 6/6] use printf as $ECHO

+if test "X`printf %s $ECHO`" = "X$ECHO"; then + ECHO='printf %s\n' >>> Just for safety, shouldn't the test use '%s\n' rather than bare %s (in >>> other >>> words, make our test match our usage pattern)? >> _AS_ECHO_PREPARE does the same... > > Here's a chance to fix both at once. :-

Re: [PATCH 6/6] use printf as $ECHO

>> M4SH_VERBATIM([[ > > Hmm. This is a nicer name for m4_echo, for how it is being used; maybe it is > time to migrated it into the Autoconf manual (perhaps under the name > AS_VERBATIM)? Maybe, yes. >> : ${CP="cp -f"} >> -: ${ECHO="echo"} >> +: ${ECHO=$as_echo} > > This is delving a bit

Re: [PATCH 4/6] tweak to config.status->libtool quoting (correct?)

> This might be a bit easier to write (and thus review) if we used AS_ESCAPE > rather than supplying all the \ ourselves (perhaps as an independent patch > prior to this one). s/might be/would have been/; s/we used/Libtool had been using/ in other words, that's a separate cleanup IMNSHO. Paol

Re: [PATCH 3/6] use documented m4sh interfaces

> I know you mentioned (in 7/6) that you can turn on enough porting hacks to > allow running with Autoconf 2.60; does that include this patch? No, the porting hacks allow *building* with Autoconf 2.60. This patch is just to stop using now-deprecated interfaces. Where it touches libtool.m4, it

Re: [PATCH 7/6] remove dependency on Autoconf 2.62 - postscriptum

Entire series tested with Autoconf 2.62; patches 1/6 to 6/6 tested with Autoconf git, both in a normal configuration and faking that the used printf is an external builtin printf from /bin/sh. Paolo

[PATCH 7/6] remove dependency on Autoconf 2.62

This patch is just a proposal, I don't really think it is needed to apply it. It removes the build dependency on Autoconf 2.62, but at the price of requiring a working `printf' to be either a builtin of a shell in the path, or the first `printf' in the path. In addition, there is some duplicate c

[PATCH 6/6] use printf as $ECHO

This is the bulk of the patch series, and it removes $ECHO in favor of `some printf' that works. This printf can be: 1) a shell builtin for the current shell; 2) a printf binary; 3) a shell builtin for another shell. There is a lot of simplification -- and more can be done because this patch remo

  1   2   >