HO=$as_echo}
+: ${ECHO='printf %s\n'}
for tool in ACLOCAL AUTOHEADER AUTOCONF AUTOMAKE AUTORECONF; do
if eval \$$tool --version >/dev/null 2>&1; then :; else eval $tool=no; fi
done
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
argument. But that fact is
true regardless of this patch, and I did not bother auditing whether we
violate that usage pattern anywhere (perhaps we could make $ECHO expand
to a function call, where the function loudly complains about $# > 1, if
we wanted to make such an audit easier).
nt to keep m4 from eating things. If
that fails, m4sh supports quadrigraphs, where you can write @S|@@ to get
$@ in the resulting file.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
patches to this list, rather
than making us chase a URL (in particular, github is notorious for
requiring the use of non-free client-side javascript for the full
experience, while posting a patch to the mailing list frees recipients
from having to decline non-free software).
--
Eric Blake, Pri
directory”. I did some
>
> cfgfile=${ofile}T
> trap "$RM \"$cfgfile\"; exit 1" 1 2 15
> -$RM "$cfgfile"
> +if test -e "$cfgfile" ; then
> + $RM "$cfgfile"
> +fi
That's a TOCTTOU data race. Wouldn't it
nd
comparable to what we have a few lines earlier:
eval 'cat <<_LTECHO_EOF
$[]1
_LTECHO_EOF'
}
ECHO='func_fallback_echo'
fi
# func_echo_all arg...
# Invoke $ECHO with all args, space-separated.
func_echo_all ()
{
$ECHO "$*"
--
Eric Blake eblake redhat
clear on no leading space and one space only as separator.
No, POSIX states that " " means at least one whitespace (could be
multiple; implementations can align at will), and "Δ" means exactly one
space character. Since nm didn't use the delta character, the code is
corre
On 11/24/2015 09:22 AM, Eric Blake wrote:
> On 11/05/2015 10:43 AM, David Edelsohn wrote:
>> TLS symbols in AIX display a new, different symbol type in nm output.
>> Libtool explicitly creates a list of exported symbols for AIX shared
>> libraries using nm and does not
$ 2 == "B") || (\$ 2 == "W") || (\$ 2
> == "V") || (\$ 2 == "Z")) && ([substr](\$ 1,1,1) != ".")) { if ((\$ 2 == "W")
> || (\$ 2 == "V") || (\$ 2 == "Z")) { print \$ 1 " weak" } else { print \$ 1 }
> } }'\'' | sort -u > $export_symbols'
> + _LT_TAGVAR(export_symbols_cmds, $1)='`func_echo_all $NM | $SED -e
> '\''s/B\([[^B]]*\)$/P\1/'\''` -PCpgl $libobjs $convenience | awk '\''{ if
> (((\$ 2 == "T") || (\$ 2 == "D") || (\$ 2 == "B") || (\$ 2 == "L") || (\$ 2
> == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) && ([substr](\$ 1,1,1) != ".")) {
> if ((\$ 2 == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) { print \$ 1 " weak" }
> else { print \$ 1 } } }'\'' | sort -u > $export_symbols'
> fi
> aix_use_runtimelinking=no
>
> --
> 2.4.3
>
I'm not an AIX expert, and have no way to test it, but the explanation
is reasonable and I don't see how it can hurt (particularly since the
two changes are under "aix[[4-9]]*)" case blocks).
I'll go ahead and push this patch (assuming my commit rights are still
active) in 24 hours if no one speaks up to the contrary.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
7;version'
> macro gone to infinite recursion (until ENOMEM). So rather
s/gone to infinite/enters an infinite/
> re-define all potentially dangerous macros by empty strings,
> suggested by Eric Blake.
>
> While we are on it, merge the macro-"blacklist" with simila
define
> +# macros of the same name as file included in their bodies - which
> +# results in infinite recursion.
> +m4_define([m4_include], [])
I'd recommend that you use the same fix as gettext, and define ALL of
these macros to an empty string, rather than special-casing m4_
ith GREP but use \{0,1\} instead of \?.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
tunately the NEWS file is checksummed to prevent changes after a
> release,
> so not easy to fix without tweaking the release process :-(
It's possible to update the expected checksum when intentionally
correcting old news entries. Since you are using gnulib's maint.mk,
look at th
nged, 7 insertions(+), 2 deletions(-)
Now pushed.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ot;; echo $?
0
However, this idiom is already in use elsewhere in git-version-gen, so
it should be fixed in an independent patch.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
*blush*
>
> v5 coming up.
Ugg, I saw v4 and pushed 1/2 before I saw this thread; I'll make sure
that I'm using v5 for the 2/2 patch.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
nged, 4 insertions(+), 2 deletions(-)
Thanks for resending, and sorry for my abysmal reply delay. This one is
now simple enough that I have pushed it.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
n't
been forgotten, and gentle pings do help. Alas, I'm not one of the
actual maintainers.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
git diff-index --name-only HEAD) \
> || exit 1; \
> @@ -1345,7 +1345,7 @@
> # cannot be built from a fresh clone.
> .PHONY: public-submodule-commit
> public-submodule-commit:
> - $(AM_V_GEN)if test -d $(srcdir)/.git; then \
> + $(AM_V_GEN)if test -d $(srcdir)/.git && git --version >& /dev/null;
> then \
As does this (although wrapping both changes to avoid long lines would
be preferable).
> cd $(srcdir) && \
> git submodule --quiet foreach test '$$(git rev-parse $$sha1)' \
> = '$$(git merge-base origin $$sha1)' \
>
>
>
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
to
do this sort of thing (that is, turn it into a gui where you
point-and-click on the request to install a Windows trial version, and
then everything else from downloading the correct iso and installing it
is all automated), but haven't tried that yet.
--
Eric Blake ebl...@
wo into a single statement:
: ${lt_HAVE_ARITH_OP=yes} ${lt_HAVE_XSI_OPS=yes}
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
fork.
>
>> Or, to be even safer, you could directly poke at $BASH_VERSION instead:
>>
>> case $BASH_VERSION in
>>[12].*|3.0.*) ;;
>>*) lt_HAVE_PLUSEQ_OP=yes;;
>> esac
>
> Ah, true... I guess I was too focussed on a straight forward one li
uot; = "X$bs_echo") 2>/dev/null; then
> + bs_echo='print -r --'
> + bs_echo_n='print -rn --'
Also, I'm not sure that I like the name $bs_echo - it's not namespace
clean. I would have expected something more like $lt_echo.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
l. Otherwise, shells like Solaris
/bin/sh will choke on trying to parse this line:
$ /bin/sh -c 'echo "$((${BASH_VERSINFO[0]}*1000 + \
${BASH_VERSINFO[1]}))"'
/bin/sh: bad substitution
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
s a lot of forkes.
As for actual timing comparisons, I have not done any recently.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t; subordinate shells?
By default, bash sets up $BASH_VERSION as an internal variable, and not
exported. It is unwise for users (or scripts) to export BASH_VERSION to
child processes.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
s debian's lead of using dash for faster
/bin/sh, I'm not sure if there is a reliable forkless way to detect dash.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t;". In the case
where $a is unquoted, we are passing fnmatch the string "*", but where
$a was quoted, the shell is correctly treating * as a literal and
passing fnmatch the string "\\*".
Bash, ksh, and dash are correct; mksh and Solaris 10 (among other
shells) are b
n demonstrate a problem with leading hyphen, on Solaris 10 at least:
$ touch =; /bin/sh -c 'test -f ='; echo $?
/bin/sh: test: argument expected
1
>>
>> I'll postpone pushing this patch until we get to the bottom of the
>> issue though.
I withdraw my objection to the libtool patch. It might not be a common
idiom to list the constant first, but who knows? maybe you've started a
new trend.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
doc/COPYINGv2
>> doc/fdl.texi
>>
> [SNIP]
> hmm, origin is only with end apostrophe .
That's not a problem. It's merely changing:
var="$expanded"'literal'
to the equivalent
var=$expanded'literal'
where the literal por
s that | has to be shell-quoted
to be used, while , does not, which means a user is more likely to have
a filename containing comma than they are to have a filename containing
a pipe.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
both
sides of the comparison with x or X. Conversely, if you CAN guarantee
the contents of "$b" (for example, if you did b=$?, then you KNOW that b
is a numeric tring with no problematic characters), then you might as
well use the more idiomatic comparison of variable to constant.
-
or
sure; even if it didn't, the stylistic convention of ${1} for shell
expansion vs. $1 for m4 expansion made the file slightly easier to maintain.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
)
> # store the result into func_replace_sysroot_result.
> func_replace_sysroot ()
> {
> - case "$lt_sysroot:$1" in
> + case $lt_sysroot:$1 in
>?*:"$lt_sysroot"*)
Likewise in the pattern expression; you could further change this to:
case $lt_sysr
s commit is purely for future repo archaeology.
Then it's not NEWS-worthy. It's worth keeping that analysis in the git
commit message (as you say, for repo archaeology), but let's limit it to
just there, rather than potentially causing users to worry about some
perceived loss of porta
anyone complains loudly
enough. We may want to also ask on the automake list if this is still a
real limitation, or whether automake has given up on worrying about this
as well.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
iding
$TAR (even though we no longer use it) to keep our namespace pollution
constant, all so that users upgrading to newer libtool don't complain
about an undocumented change.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ts.
As an alternative, revert this change, and instead add a setting of
_makefile_at_at_check_exceptions in cfg.mk that exempts just @LIBLTDL@.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
at you
cast the result of allocation functions (only C lets you get away with
going from void* to any other pointer without cast). Are we sure that
no one tries to compile libtool with a C++ compiler?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvi
native is to add a
syntax-check exception in cfg.mk for the particular files where we
define the macros that cast away const).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
git setup, with 'git config
--global diff.renames true'.
At any rate, I'm certainly in favor of this series, in the name of
easier maintenance, although I didn't review it closely.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
ile building others with non-PIC objects.
> + - Added -shortname option to specify a short name for a DLL (OS/2 only)
Long options should start with --, not -, per GNU coding conventions
(gcc is an exception, but libtool should not be).
--
Eric Blake ebl...@redhat.com+1-801-3
name, to avoid
having to create manual symlinks (the existence of the anchor will mean
that the old name still goes somewhere in the web). For example, see
how autoconf.texi @node Specifying Target Triplets has an
@anchor{Specifying Names}.
--
Eric Blake ebl...@redhat.com+1-801-349-268
t;b c"`
reliably assigns "b c" to $a in all shells.
I just stated tangential info since the problematic
quoting needed fixing, and since that is fixed I don't see any need
to do a re-spin just because of this.
Agreed.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
On 09/22/2010 12:22 PM, Ralf Wildenhues wrote:
* Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST:
$(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh
+ $(MAKE) libtool
$(update_mans) --help-option=--help-all libtool
When -jN has been passed, the two makes may both
/libtoolize.1: $(srcdir)/libtoolize.in
+ $(MAKE) libtoolize
$(update_mans) libtoolize
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
nly source tree. Moreover,
help2man is something the user is expected to not have to install prior
to building Libtool.
Is it acceptable instead to use a nested $(MAKE) invocation prior to
running help2man to ensure the binary is up-to-date?
--
Eric Blake ebl...@redhat.com+1-801-3
* HACKING: Update.
Signed-off-by: Eric Blake
---
I'm pushing this under the obvious rule, given that the whole point
of my previous patch was to remove this dependency, and since this
is a docs-only patch.
ChangeLog |3 +++
HACKING |4 +---
2 files changed, 4 insertions(
On 09/20/2010 12:44 PM, Ralf Wildenhues wrote:
* Eric Blake wrote on Mon, Sep 20, 2010 at 08:13:25PM CEST:
Shipping a copy of autobuild.m4 makes it so that users need not
pre-install autobuild just for aclocal to find the macro AB_INIT.
* libltdl/m4/.gitignore: Drop autobuild.m4.
* libltdl/m4
-by: Eric Blake
---
> Be sure to *not* list autobuild.m4 anywhere else, e.g., in Makefile.am.
> It is picked up automatically. You can make the AB_INIT call in
> configure.ac unconditional, but then again, no loss in leaving it as it
> is.
I've tested that 'make dist'
On 09/14/2010 07:58 AM, Eric Blake wrote:
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format.
* Makefile.maint (git-release, git-dist, prev-tarball)
(new-tarball, diffs): Use correct extension.
* HACKING: Update instructions.
Hmm - I mentioned it in ChangeLog, but hadn't yet
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format.
* Makefile.maint (git-release, git-dist, prev-tarball)
(new-tarball, diffs): Use correct extension.
* HACKING: Update instructions.
* .gitignore: Ignore .xz files.
Signed-off-by: Eric Blake
---
> > I'm fine with, if you
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format.
Signed-off-by: Eric Blake
---
Any objections to this patch? xz is a more robust successor to lzma.
ChangeLog|5 +
configure.ac |2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b
[adding bug-autoconf]
On 09/13/2010 08:18 AM, Eric Blake wrote:
On 09/13/2010 08:16 AM, Eric Blake wrote:
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD.
cat>file<
Ouch - that's a nasty bug. Have you reporte
On 09/13/2010 08:16 AM, Eric Blake wrote:
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD.
cat>file<
Ouch - that's a nasty bug. Have you reported it to the zsh list yet?
Hmm, rather than fixing all _our_ uses
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD.
cat>file<
Ouch - that's a nasty bug. Have you reported it to the zsh list yet?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization l
On 09/02/2010 03:16 PM, Charles Wilson wrote:
On 9/2/2010 5:08 PM, Eric Blake wrote:
On 09/02/2010 03:00 PM, Charles Wilson wrote:
Two people worked on a single patch, or someone submitted it, and then
one of the people with commit access modified the patch slightly. The
GCS says you should
;; I've
never tried and I'm not sure how thoroughly git checks the --author
argument.
You can munge anything before the email, but can't add (tiny change)
afterwards (in other words, git hard-codes the email address to be
last). I'd rather not munge --author, since 'git short
e you planning on swapping over to gnulib's announce-gen once gnulib
is fully integrated? And in the meantime, what good does it do to have
a --gnulib-version option if we aren't using gnulib yet?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
rpath /foo
Invalid flag usage: Wall, -Wx,-option must appear after -_SYSTYPE_SVR4
ld: Usage: ld [options] file [...]
stdout:
./../libtool/tests/cwrapper.at:77: exit code was 1, expected 0
Does this have any ramifications for autoconf's AC_LANG_WERROR?
--
Eric Blake ebl...@redhat.com+1-80
evidence that autoconf's recent move to
document that : is reliable for null substitutions is reasonable for all
shells that support functions.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
On 08/30/2010 08:57 AM, Eric Blake wrote:
[adding bug-bash]
On 08/29/2010 08:48 AM, Ralf Wildenhues wrote:
With Solaris 10 sh (and others):
cat<
Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm
thinking it may be a bash bug; hence the cc.
Sorry about that; I
p_string="${TIMESTAMP:+ (Build:$TIMESTAMP)}"
instead of the if/fi?
+AS_BOX([Configuring AC_PACKAGE_TARNAME$timestamp_string AC_PACKAGE_VERSION])
Or, since we know the workaround is to remove the "" inside here-docs,
why not:
AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+ (
[adding bug-bash]
On 08/29/2010 08:48 AM, Ralf Wildenhues wrote:
With Solaris 10 sh (and others):
cat<
Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm
thinking it may be a bash bug; hence the cc.
Eric, did you have this in your recent autoconf.texi additions alread
ly also go upstream to gnulib.
Yes, will sync there later.
Sync'd to gnulib now.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
xtended-shell func_split_short_opt' $abs_top_builddir/libtool
> >/dev/null 2>&1 || exit 77
>
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
of these
downstream projects when doing so.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ng in
assignment contexts, so the effect of
concat="$e"$f
is the same as if you had done
concat=$e$f
or
concat="$e$f"
in all three cases, concat is assigned the value ' val', which is indeed
length 4.
But it is unrelated to the bash bug at hand, which is that when "$e"$f
is in a context subject to word splitting, then it must result in the
two words '' and 'val', not the single word 'val'.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
x27;
+ n '' val
+ echo 2
2
And meanwhile, I found a ksh93 parsing bug (don't know where to report
that):
$ ksh -c 'a(){ echo hi; }; a'
ksh: syntax error at line 1: `}' unexpected
$ ksh -c 'a() { echo hi; }; a'
hi
$ bash -c 'a(){ echo hi; }; a&#x
ode; }'
That's how m4sh already does it for AS_VAR_APPEND (take a look at
practically any configure script built with recent autoconf):
if (eval "as_var=1; as_var+=2; test x\$as_var = x12") 2>/dev/null; then :
eval 'as_fn_append ()
{
eval $1+=\$2
}'
else
robe/require XSI
support, but that will have to wait until after autoconf 2.66.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 06/28/2010 04:19 PM, Ralf Wildenhues wrote:
> Hi Eric,
>
> thanks for the suggestion. I had considered the idea for a second, but
> failed to see the nontrivial half.
>
> * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST:
>> tmp=${1#?}
>> patt=
>>
> No, ${parameter:offset} and ${parameter:offset:length} are bash specific
> not XSI mandated.
But we don't need bash-specific hacks.
${parameter#??} serves as a great XSI alternative to ${parameter:2},
and with a (lot) more thought, ${1:1:1} can be written without forks
and without bash-isms as:
a specific Makefile substitution to
append -Werror (or the empty string) to the various CFLAGS throughout
the project. You can check out coreutils' ./configure
--enable-gcc-warnings option.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
lls end up doing "eval ''" if the `` is interrupted. You want:
str=`$EGREP '^(old_library)=' < $libdir/libbar.la`
eval "$str"
or possibly even "$libdir" in the first line to be robust to spaces in
file names.
--
Eric Blake ebl...@redhat.com
ut
autoconf's colored output patch committed yet.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
n gnulib,
perl and m4sh versions, side-by-side. The beauty of gnulib is that it
provides a nice source for pieces you care about, even if you don't use
every piece available. So it does seem like a better (eventual) home
for these recent libtool m4sh scripts.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
was the one that
patched autoconf to intentionally issue that warning.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/17/2010 01:23 PM, Dave Korn wrote:
> On 17/03/2010 17:14, Eric Blake wrote:
>> On 03/16/2010 04:24 AM, Dave Korn wrote:
>>> On 16/03/2010 06:17, Ralf Wildenhues wrote:
>>>
>>>> Microsoft @sc{dos} and Windows systems. The @sc{gnu}
>>> Sho
On 03/16/2010 04:24 AM, Dave Korn wrote:
> On 16/03/2010 06:17, Ralf Wildenhues wrote:
>
>> Microsoft @sc{dos} and Windows systems. The @sc{gnu}
>
> Should capitalise DOS and GNU.
@sc{} does the capitalization for you. This is correct texinfo usage.
--
Eric Blake ebl..
your patch to further ensure deterministic behavior across
different default locales?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
are interested, we can run build-aux/update-copyright from
gnulib in order to achieve that action (it also has the benefit of
normalizing copyrights into a consistent format).
--
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
signature.asc
Descr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 12/29/2009 7:25 PM:
> Hi!
>
> I'm about to push this too as obvious, I hope I'm not getting too bold...
It looks obvious enough; go ahead.
- --
Don't work too hard, make some time for
to long
lines)
> Even better to post a
> GCC patch to avoid emitting this warning.
I have no idea where to patch that, but I guess I could go ahead and submit the
bug report.
From: Eric Blake
Date: Mon, 2 Nov 2009 11:58:28 -0700
Subject: [PATCH] Allow gcc builds with -Wall -Werr
ing a const * instead of an array silences
the warning. OK to commit this?
From: Eric Blake
Date: Mon, 2 Nov 2009 11:58:28 -0700
Subject: [PATCH] Allow gcc builds with -Wall -Werror.
* libltdl/ltdl.c (libext): Declare as pointer rather than array to
silence gcc warning.
Signed-off-by: Eric
ter of time before Debian picks it up:
http://git.kernel.org/?p=utils/dash/dash.git;a=commit;h=0df9679
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcas
sing $ expansions to hide tool names is
one case where you DO want word splitting):
ECHO='printf %s\n'
$ECHO "$1"
And beyond that, it's just lots of practice. I agree that it often feels
like you have to memorize loads of information to write portable shell,
but at least th
th_result="$func_dirname_result"
> ;;
> *)
> # Actual path component, append it.
>
> func_normal_abspath_result="$func_normal_abspath_result/$func_normal_abspath_tcomponent"
> ;;
> esac
> # Processed it all y
fest
Would it be more efficient to use tee or cp, rather than two calls to
func_emit_exe_manifest? Does the .manifest need +x permissions?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cy
t libtool contributor, so if you want to wait
72 hours for anyone else to also chime in with a review, that would be fine
with me. If the three days pass without further comment, then consider my
review as sufficient.
--
Eric Blake
_LIMIT([$ac_compiler $ac_option >&AS_MESSAGE_LOG_FD])
done
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~e
d one, just like coreutils.
Personally, I like a checked-in ChangeLog; with a generated one, you have
no way to fix typos in previous entries short of running a git filter
operation and changing history.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 1/9/2009 3:11 AM:
> Den 2009-01-09 03:58 skrev Eric Blake:
>> Check out Bruno Haible's git-merge-changelog, currently in the gnulib
>> repository. It handles rebasing/merging of ChangeLog entries wi
out 2%.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using Gnu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 12/19/2008 6:45 AM:
> Den 2008-12-19 14:10 skrev Eric Blake:
> *snipped*
>
>> +Fix copyright notice.
>> +* libltdl/config/ltmain.m4sh: Add missing comma.
>
> Oooaa, excellent (and
need this patch, or is it sufficient to
entirely delete libtool's IFS initialization in favor of m4sugar's, thanks
to Paolo's recent cleanups to use m4sugar as documented?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEG
looks sensible, except that while we are adjusting
the line, we might as well wrap to fit in 80 columns. And we need a
ChangeLog entry. I'm pushing this:
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Versio
uiltin. On
Solaris, we _want_ to choose ksh over /bin/sh, because builtin print is
faster than the here-doc fallback used in /bin/sh. I think the last line
has to be:
( PATH=/empty FPATH=/empty; export PATH FPATH
test "X`printf %s $ECHO`" = "X$ECHO" \
|| test &q
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/22/2008 7:31 AM:
> Maybe a better suggested test would be one that checks for either print or
> printf (that way, a Solaris machine will let ksh pass the suggested test).
>Since the overall test is running wi
t messages about command not found. In other words, why
not:
_AS_DETECT_SUGGESTED([
ECHO='\\\'
ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO
ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO$ECHO
test "X`print -r -- $ECHO`" = "X$ECHO" \
|| test "X`prin
1 - 100 of 245 matches
Mail list logo
