Re: [PATCH 1/7] bootstrap: split into reusable parts.

2011-11-05 Thread Charles Wilson
On 11/5/2011 12:40 PM, Gary V. Vaughan wrote: By the end of this particular set, libtoolize will have moved from the kludgy sed based interrogation of configure.ac to probe the arguments to various important macros so that it can determine what files to copy and where... to the much more splendid

Re: [PATCH 2/3] build: substitute paths into defs.m4sh instead of recalculating.

2011-11-05 Thread Gary V. Vaughan
On 31 Oct 2011, at 22:20, Gary V. Vaughan wrote: > More DRY inspired cleanup. 72 hours... etc etc. > > * Makefile.am (configure_edit): Add substitutions for aux_dir, > macro_dir and srcdir. > * tests/defs.m4sh: Don't recalculate srcdir. > (aux_dir, macro_dir, srcdir): Convert to absolute paths.

[PATCH 4/4] libtoolize: massage installed auxiliary script list at make time.

2011-11-05 Thread Gary V. Vaughan
* Makefile.am (configure_edit): Rename pkgconfig_files substitution to pkgaux_files, and add pkgaux_install_files and pkgaux_parent_files substitutions for atlocal. (pkgauxdir): Where to install pkgaux_files. (auxfiles): Removed, and replaced by... (pkgaux_parent_files, pkgaux_install_files, pkgaux

[PATCH 3/4] libtoolize: massage installed libltdl file list at make time.

2011-11-05 Thread Gary V. Vaughan
* libtoolize.m4sh (pkgltdldir, pkgdatadir): Put installable libltdl files in pkgdatadir. When testing, and _lt_pkgdatadir is set, adjust to look in libltdl subdirectory. (func_massage_pkgltdl_files): Removed function and only caller, because... (pkgltdl_files, extra_pkgltdl_files): ...we substitute

[PATCH 2/4] libtoolize: massage installed macro list at make time.

2011-11-05 Thread Gary V. Vaughan
(Please excuse the brute force rearrangement of libtoolize.at expout files... I have a much nicer patch to generate these from the filelists that libtoolize itself is using, but I want to get back to the directory renaming patches in as few steps as possible, without flooding the list with patche

[PATCH 1/4] libtoolize: use only space delimited file lists.

2011-11-05 Thread Gary V. Vaughan
This next series of patches simplifies both Makefile.am and libtoolize.m4sh enough that manipulations of the file lists by libtoolize at install time become managable enough to do a nice rewrite of the config->build-aux rename patch that I'll get to next. By itself, this one is obvious enough. Th

[PATCH 7/7] libtoolize: remove sed based configure scanning.

2011-11-05 Thread Gary V. Vaughan
* libtoolize (func_scan_files): Removed function and callers. (require_seen_ltdl, require_seen_libtool): Factor out remaining functionality of former sed based scanning. (func_check_macros): Adjust. * NEWS: Updated. Signed-off-by: Gary V. Vaughan --- NEWS|7 libtoolize.m4sh

[PATCH 6/7] libtoolize: refactor ltdl_mode discovery.

2011-11-05 Thread Gary V. Vaughan
* libtoolize.m4sh (require_ac_ltdl_mode) (require_ac_ltdl_options, require_ltdl_mode): New functions factored out of func_scan_files for scanning and setting ltdl_mode and friends. (func_scan_files): Remove the factored out code. (func_install_pkgmacro_files, func_install_pkgltdl_files) (func_insta

[PATCH 5/7] libtoolize: refactor ltdl_dir discovery.

2011-11-05 Thread Gary V. Vaughan
* libtoolize.m4sh (require_ac_ltdl_dir, require_ltdl_dir): New functions factored out of func_scan_files for scanning and setting ac_ltdl_dir and ltdl_dir resp. (func_scan_files): Remove the factored out code. (func_fixup_Makefile, func_serial_update_check) (func_install_pkgltdl_files, func_install

[PATCH 4/7] libtoolize: refactor aux_dir discovery.

2011-11-05 Thread Gary V. Vaughan
* libtoolize.m4sh (require_ac_aux_dir, require_aux_dir): New functions factored out of func_scan_files for scanning and setting aux_dir and friends. (func_scan_files): Remove the factored out code to scan configure.ac with sed, and then set macro_dir appropriately. (func_install_pkgconfig_subprojec

[PATCH 3/7] libtoolize: refactor macro_dir discovery around extract-trace script.

2011-11-05 Thread Gary V. Vaughan
* libtoolize.m4sh (func_extract_trace): Function to call $aux_dir/extract-trace. The name and footprint are the same as the core function in the extract-trace script file so that we can choose to source that file when the option processing becomes compatible with ours. (require_ac_macro_dir, requi

[PATCH 2/7] libtoolize: refactor configure_ac discovery.

2011-11-05 Thread Gary V. Vaughan
Make a start on decomposing some of the giant functions at the heart of libtoolize into the much more flexible and manageable (albeit somewhat more verbose) model of self-organising $require_ function pointers. * libtoolize.m4sh (require_configure_ac): New function factored out of func_scan_files f

libtoolize: fix a scoping bug in func_aclocal_update_check.

2011-11-05 Thread Gary V. Vaughan
Pushed as obvious. libtoolize.m4sh (func_aclocal_update_check): This body of this function used a global variable set by the outer loop of the caller. Fix to Use the function argument correctly. Signed-off-by: Gary V. Vaughan --- libtoolize.m4sh |8 +--- 1 files changed, 5 insertions(+)

Re: [PATCH 1/3] maint: rename `libltdl/config' directory to standard `build-aux'.

2011-11-05 Thread Gary V. Vaughan
Hi Stefano, On 2 Nov 2011, at 16:29, Stefano Lattarini wrote: > On Wednesday 02 November 2011, Gary V wrote: >> >> I like to make sure the tree is capable of passing `make distcheck' after >> every patch, >> > And this is a very good policy, with which I fully agree. What I meant > was: wouldn'

Re: [PATCH 1/3] maint: rename `libltdl/config' directory to standard `build-aux'.

2011-11-05 Thread Gary V. Vaughan
Hi Bob, Thanks again for the sanity check. Sorry for my late response; my internet access is very spotty at the moment. On 2 Nov 2011, at 21:12, Bob Friesenhahn wrote: > On Wed, 2 Nov 2011, Gary V. Vaughan wrote: >>> >>> Did you consider this existing use while developing the plan to rename th

FYI: maint: rename the debug shell-command variable to `debug_cmd'.

2011-11-05 Thread Gary V. Vaughan
Applied as an obvious refactoring. Not only does it make more sense, it also matches bootstrap and others. * libtoolize.m4sh, libltdl/config/ltmain.m4sh, libltdl/config/getopt.m4sh, tests/defs.m4sh (opt_debug): Rename to debug_cmd. Signed-off-by: Gary V. Vaughan --- libltdl/config/getopt.m4sh |

Re: [PATCH 2/3] build: substitute paths into defs.m4sh instead of recalculating.

2011-11-05 Thread Gary V. Vaughan
On 31 Oct 2011, at 22:20, Gary V. Vaughan wrote: > More DRY inspired cleanup. 72 hours... etc etc. > > * Makefile.am (configure_edit): Add substitutions for aux_dir, > macro_dir and srcdir. > * tests/defs.m4sh: Don't recalculate srcdir. > (aux_dir, macro_dir, srcdir): Convert to absolute paths.

Re: [PATCH 3/3] maint: dynamically strip unused scripts from libltdl Makefile.

2011-11-05 Thread Gary V. Vaughan
On 31 Oct 2011, at 22:24, Gary V. Vaughan wrote: > * configure.ac (pkgaux_scripts): Centrally maintain the complete > list of aux scripts required to build libltdl, and which need to > be installed by libtoolize --ltdl, and consequently need to be > placed in $pkgdatadir by make install. > * Makef

Re: [PATCH 1/3] build: support AM_SILENT_RULES

2011-11-05 Thread Gary V. Vaughan
On 31 Oct 2011, at 22:18, Gary V. Vaughan wrote: > I'll apply in 72 hours or so, along with any changes inspired by review or > other > feedback. > > * configure.ac: Add AM_SILENT_RULES. > * Makefile.am (.version, ChangeLog, README, doc/notes.txt) > (libtool, libtoolize, libtoolize.in, libltdl/M