On 1 Sep 2010, at 12:25, Ralf Wildenhues wrote:
> Hello Gary,
Hallo Ralf,
> * Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 03:59:19AM CEST:
>> On 1 Sep 2010, at 00:41, Ralf Wildenhues wrote:
>>> I personally find the M4SH_GETOPTS rather unreadable; it's a nice table,
>>> but I cannot make sense
On 1 Sep 2010, at 12:32, Ralf Wildenhues wrote:
> func_show_eval
> is still buggy in that it causes more filename expansion than we'd like
> to have (leading to commits like v2.2.10-48-g3ab9879), but yes, that
> shouldn't be an issue here.
Ah... I had wondered what that was all about. It makes se
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 07:18:12AM CEST:
> From earlier discussion, there is no need to clutter the
> Libtool tree with these scripts, and we can amend our release
> process to use the gnulib announce-gen script in due course.
>
> * libltdl/config/announce-gen.m4sh: Removed
Hi Gary,
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 06:50:51AM CEST:
> * clcommit.m4sh: Removed. This script was written to help keep
> ChangeLog and commit messages in sync when committing to CVS,
> and is an anachronism now that Libtool uses git.
> * Makefile.maint (commit): Target removed.
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 04:42:52AM CEST:
> On 1 Sep 2010, at 01:16, Ralf Wildenhues wrote:
> > * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:20AM CEST:
> >> -test -f clcommit.m4sh && $MAKE -f Makefile.maint ./commit \
> >> -srcdir=. top_srcdir=. PACKAGE="$package
Hello Gary,
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 03:59:19AM CEST:
> On 1 Sep 2010, at 00:41, Ralf Wildenhues wrote:
> > I personally find the M4SH_GETOPTS rather unreadable; it's a nice table,
> > but I cannot make sense of the entries, or review them, except by
> > looking at the gener
>From earlier discussion, there is no need to clutter the
Libtool tree with these scripts, and we can amend our release
process to use the gnulib announce-gen script in due course.
* libltdl/config/announce-gen.m4sh: Removed. This script has
no apparent connection to libtool functionality, and mo
Total Annihilation: Removed insidious references from the rest of
the tree.
* clcommit.m4sh: Removed. This script was written to help keep
ChangeLog and commit messages in sync when committing to CVS,
and is an anachronism now that Libtool uses git.
* Makefile.maint (commit): Target removed.
* boo
Hi Chuck,
On 1 Sep 2010, at 10:50, Charles Wilson wrote:
> On 8/31/2010 10:53 PM, Gary V. Vaughan wrote:
>> Does anyone else use the commit script?
>>
>> * clcommit.m4sh: Removed. This script was written to help keep
>> ChangeLog and commit messages in sync when committing to CVS,
>> and is an a
On 8/31/2010 10:53 PM, Gary V. Vaughan wrote:
> Does anyone else use the commit script?
>
> * clcommit.m4sh: Removed. This script was written to help keep
> ChangeLog and commit messages in sync when committing to CVS,
> and is an anachronism now that Libtool uses git.
>
> Okay to push?
>
> ---
Does anyone else use the commit script?
* clcommit.m4sh: Removed. This script was written to help keep
ChangeLog and commit messages in sync when committing to CVS,
and is an anachronism now that Libtool uses git.
Okay to push?
---
ChangeLog |7 +
clcommit.m4sh | 375 --
On 1 Sep 2010, at 01:16, Ralf Wildenhues wrote:
> This is a fairly nice cleanup that I think is valuable to redo without
> the other rejected patches. Please resubmit with nit below addressed,
> and I will approve it then after looking over once more.
Well, since it has zero impact on user-facing
On 1 Sep 2010, at 01:12, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:19AM CEST:
>> From: Gary V. Vaughan
>>
>> * bootstrap (rebuild): Set the shell variable `revision' rather
>> than `correctver' for clarity.
>> (edit): Split into two parts...
>> (bootstrap_edit
On 1 Sep 2010, at 01:03, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:18AM CEST:
>> * bootstrap: Add a proper option parsing loop, along with copies
>> of supporting functions from `libltd/m4/getopt.m4sh' and
>> `libltdl/m4/general.m4sh'.
>> Reformat header comment
On 1 Sep 2010, at 00:49, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:17AM CEST:
>> * libltdl/config/announce-gen.m4sh (func_print_locations): Don't
>> bail out or print garbage when trying to find the size of a
>> non-existent file.
>
> OK thanks. While you're a
Hallo Ralf,
On 1 Sep 2010, at 00:46, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:16AM CEST:
>> * clcommit.m4sh (func_commit): Commit only staged files instead
>> of passing `-a' when no file list was given on the command line.
>
> FWIW, I've never used clcommit
On 1 Sep 2010, at 00:41, Ralf Wildenhues wrote:
> this is a review, not an approval.
No problem; thanks for the review.
[[Review comments I agree with elided...]]
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:15AM CEST:
>> * libltdl/config/announce-gen.m4sh: Add support for gnulib
>> a
Hallo Ralf,
On 1 Sep 2010, at 00:38, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:14AM CEST:
>> Okay to push?
Please ignore this patch series. Cherry picking back to master from
a long divergent branch that has fairly intrusive reorganisation to
move Libtool to
Den 2010-08-31 19:30 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 07:21:34PM CEST:
>> Den 2010-08-31 19:11 skrev Ralf Wildenhues:
>>> libtool --mode=link $CC ... -o libfoo.a baz.o libbar.a
>>>
>>> should be adding baz.o and all objects in libbar.a to libfoo.a, i.e., it
>>>
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:20AM CEST:
> * Makefile.am (bootstrap_files): List files that need to be
> generated at bootstrap time before `./configure && make' can
> work. It turns out that this is considerably fewer files than we
> had thought necessary previously.
> (bo
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:19AM CEST:
> From: Gary V. Vaughan
>
> * bootstrap (rebuild): Set the shell variable `revision' rather
> than `correctver' for clarity.
> (edit): Split into two parts...
> (bootstrap_edit): ...substitutions that should happen at bootstrap
> ti
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:18AM CEST:
> * bootstrap: Add a proper option parsing loop, along with copies
> of supporting functions from `libltd/m4/getopt.m4sh' and
> `libltdl/m4/general.m4sh'.
> Reformat header comments to work with `func_help' and
> `func_version'.
> (my
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:17AM CEST:
> * libltdl/config/announce-gen.m4sh (func_print_locations): Don't
> bail out or print garbage when trying to find the size of a
> non-existent file.
OK thanks. While you're at it, TAB before space is a little less likely
to be garb
Hello Gary,
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:16AM CEST:
> * clcommit.m4sh (func_commit): Commit only staged files instead
> of passing `-a' when no file list was given on the command line.
FWIW, I've never used clcommit since we moved to git; I just use
plain git. Here's a c
Hello Gary,
this is a review, not an approval.
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:15AM CEST:
> * libltdl/config/announce-gen.m4sh: Add support for gnulib
> announce-gen options, previously missing from our m4sh
> implementation, and enforce specifying --gnulib-version when
> `g
Hello Gary,
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:14AM CEST:
> Okay to push?
For your information: I'm getting more reluctant to approve your
patches, based on how much I expect we have to fix regressions stemming
from them later on, when you are not present.
Please state if and
* Peter Rosin wrote on Tue, Aug 31, 2010 at 07:21:34PM CEST:
> Den 2010-08-31 19:11 skrev Ralf Wildenhues:
> > libtool --mode=link $CC ... -o libfoo.a baz.o libbar.a
> >
> > should be adding baz.o and all objects in libbar.a to libfoo.a, i.e., it
> > should extract all objects from libbar.a Inst
Den 2010-08-31 18:57 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 06:54:28PM CEST:
>> Den 2010-08-31 18:49 skrev Ralf Wildenhues:
>>> AC_TRY_EVAL already redirects stderr in config.log, and that was quite
>>> helpful when debugging the macro recently. Why not, instead of yo
Den 2010-08-31 19:11 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 07:09:30PM CEST:
>> Den 2010-08-31 19:04 skrev Ralf Wildenhues:
>>> * Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST:
Pushing as attached, expected fail on Cygwin/ar and unexpected pass on
* Peter Rosin wrote on Tue, Aug 31, 2010 at 07:09:30PM CEST:
> Den 2010-08-31 19:04 skrev Ralf Wildenhues:
> > * Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST:
> >> Pushing as attached, expected fail on Cygwin/ar and unexpected pass on
> >> MSYS/lib just as before.
> >
> > Why does it
Den 2010-08-31 19:04 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST:
>> Pushing as attached, expected fail on Cygwin/ar and unexpected pass on
>> MSYS/lib just as before.
>
> Why does it pass with MSYS/lib? Does lib expand the individual objects
> of the pass
* Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST:
> Pushing as attached, expected fail on Cygwin/ar and unexpected pass on
> MSYS/lib just as before.
Why does it pass with MSYS/lib? Does lib expand the individual objects
of the passed library-to-add? If no, then can we make the test s
* Peter Rosin wrote on Tue, Aug 31, 2010 at 06:54:28PM CEST:
> Den 2010-08-31 18:49 skrev Ralf Wildenhues:
> > AC_TRY_EVAL already redirects stderr in config.log, and that was quite
> > helpful when debugging the macro recently. Why not, instead of your
> > patch, redirect stdout also >&AS_MESSAGE
Den 2010-08-31 18:49 skrev Ralf Wildenhues:
> Hi Peter,
>
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 01:44:00PM CEST:
>> Microsoft lib prints a failure message though. I assume other
>> archivers are not unlikely to also do so...
>>
>> Pushing the attached as obvious.
>
> AC_TRY_EVAL already r
Hi Peter,
* Peter Rosin wrote on Tue, Aug 31, 2010 at 01:44:00PM CEST:
> Microsoft lib prints a failure message though. I assume other
> archivers are not unlikely to also do so...
>
> Pushing the attached as obvious.
AC_TRY_EVAL already redirects stderr in config.log, and that was quite
helpful
Den 2010-08-29 23:30 skrev Roumen Petrov:
> Peter Rosin wrote:
>> Den 2010-08-27 00:27 skrev Roumen Petrov:
>>> Ralf Wildenhues wrote:
Hi Charles,
>>> [SNIP]
> + func_wine_to_win32_path_result="$1"
> + if test -n "$1"; then
> +# Unfortunately, winepath does not exit with
Hi Eric,
On 31 Aug 2010, at 21:08, Eric Blake wrote:
> On 08/31/2010 12:43 AM, Gary V. Vaughan wrote:
>> From: Gary V. Vaughan
>>
>> * libltdl/config/announce-gen.m4sh: Add support for gnulib
>> announce-gen options, previously missing from our m4sh
>> implementation, and enforce specifying --gnu
On 08/31/2010 12:43 AM, Gary V. Vaughan wrote:
From: Gary V. Vaughan
* libltdl/config/announce-gen.m4sh: Add support for gnulib
announce-gen options, previously missing from our m4sh
implementation, and enforce specifying --gnulib-version when
`gnulib' is listed in --bootstrap-tools.
Are you p
Den 2010-08-29 07:54 skrev Peter Rosin:
> Den 2010-08-28 12:24 skrev Ralf Wildenhues:
>> Peter, can you check whether ar-lib, lib, and 'link -lib' reliably fail
>> when an @file contains a nonexistent file name?
>
> I haven't run the testsuite, but manual testing shows that the patch
> should be o
Pushed as obvious.
Remove double `Generated from foo.m4sh' lines.
We now require a modern Autoconf to bootstrap libtool, which
will add the `Generated by ...' boiler-plate automatically,
so we can remove the hand-rolled @configure_input@
substitutions we had been doing:
* clcommit.m4sh, libtooliz
Den 2010-08-30 20:55 skrev Ralf Wildenhues:
> Hi Peter,
>
> * Peter Rosin wrote on Mon, Aug 30, 2010 at 03:25:30PM CEST:
>> The archive-in-archive.at test uses ar "blindly". It also assumes that
>> the "old archive" of libfoo.la is named libfoo.a, but both that's not
>> portable. See attached patc
41 matches
Mail list logo
