Re: [PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:06AM CEST: > --- Erm, you should be mentioning the files you change in your log entries, and Libtool also doesn't auto-generate its ChangeLog (yet), so you need that, too, also for all the other patches in the sysroot branch. Sorry for not notic

Re: [PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:05AM CEST: > * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for > directories and *.la files. Add .la files for all directories. Ah, there's another nit. > --- a/libltdl/config/ltmain.m4sh > +++ b/libltdl/config/ltmain.m4sh >

Re: [PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:05AM CEST: > * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for > directories and *.la files. Add .la files for all directories. OK if you fix the log entry. IIUC the last sentence is wrong. Thanks, Ralf

Re: [PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:04AM CEST: > * libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool > through func_resolve_sysroot. This looks ok, but is it covered in the testsuite? (If not, I can try to do it later, but at least would like to be sure we make

Re: [PATCH v2 1/4] fix sysroot tests to pass on Fedora 13

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:03AM CEST: > * tests/sysroot.at: Link $prefix/include into the sysroot as well, as > required by newer GCC. Obviously. Thanks! Ralf

[PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Paolo Bonzini
--- doc/libtool.texi | 18 -- libltdl/config/ltmain.m4sh | 21 + tests/sysroot.at |3 +++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/doc/libtool.texi b/doc/libtool.texi index 914bd1d..4b256bf 100644 --- a/doc/libt

[PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

2010-08-12 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool through func_resolve_sysroot. --- libltdl/config/ltmain.m4sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 3888cb0..563c3af 100644 ---

[PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 109 +--- 1 files changed, 62 insertions(+), 47 deletions(-) diff --git a/libltdl/config/l

[PATCH v2 1/4] fix sysroot tests to pass on Fedora 13

2010-08-12 Thread Paolo Bonzini
* tests/sysroot.at: Link $prefix/include into the sysroot as well, as required by newer GCC. --- tests/sysroot.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/sysroot.at b/tests/sysroot.at index 850e0cd..869c9c4 100644 --- a/tests/sysroot.at +++ b/tests/sysroot.a

[PATCH v2 0/3] sysroot followup patches

2010-08-12 Thread Paolo Bonzini
These cover bullets 3/5 of Charles' list: 3) issue with '# Collect and forward deplibs of preopened libtool libs' In progress? Anything? 4,5) * patch for old libtool, to not barf on '=' * TBD mechanism to strip '=' from .la after deployment on $host 6) support in libltdl for '=' in .la fi

Re: [PATCH 0/2] sysroot patches followup

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Thu, Aug 12, 2010 at 06:12:15AM CEST: > Hi, I pushed the first 8 sysroot patches to refs/heads/sysroot on > Savannah. Thanks. So far, with a merge of sysroot to master, I see one regression on AIX with runtimelinking (configure LDFLAGS=-Wl,-brtl) and a different one on So

Re: [PATCH] Allow the use of a listing file if the archiver supports it.

2010-08-12 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Aug 12, 2010 at 03:28:57PM CEST: > This is a patch that makes use of @FILE support in the > archiver, if the archiver supports it. That makes linking > succeed for long command lines when using MSVC, as MSVC > can't do piecewise linking (-r -o) which is the cu

Re: [PATCH 2/2] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Paolo Bonzini
On 08/12/2010 01:12 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: + sed -e "${sysroot_cmd} s/\([ ']-[LR]\)=/\1/g" $lib> $tmpdir/tmp-la Hmmm. Some of the test cases end up with dependency_libs like this: dependency_libs=' -L=/mingw/lib =/mingw/lib/lib1.la' T

Re: [PATCH 1/2] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Paolo Bonzini
On 08/12/2010 12:58 AM, Charles Wilson wrote: On 8/12/2010 12:12 AM, Paolo Bonzini wrote: * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for directories and *.la files. Add .la files for all directories. --- libltdl/config/ltmain.m4sh | 117 ++---

[PATCH] Allow the use of a listing file if the archiver supports it.

2010-08-12 Thread Peter Rosin
Hi! This is a patch that makes use of @FILE support in the archiver, if the archiver supports it. That makes linking succeed for long command lines when using MSVC, as MSVC can't do piecewise linking (-r -o) which is the current fallback. Absolute paths still needs work, but that will have to wait