Fifth time lucky! (Why do I say these things, I'm only asking for trouble!)
libtool/ChangeLog:
* Makefile.am (TESTSUITE_AT): Add bindir.at.
* libltdl/config/general.m4sh (func_normal_abspath): New function.
(func_relative_path): Likewise.
* libltdl/config/ltmai
Roumen Petrov wrote:
> Dave Korn wrote:
>> Roumen Petrov wrote:
>>> I think that processing of '..' in a path is too naive. It will fail to
>>> produce correct results on filesystems with links.
>>
>> this function implements 'abspath', not 'realpath',
^^^
Roumen Petrov wrote:
> Dave Korn wrote:
>> Roumen Petrov wrote:
>>> I think that processing of '..' in a path is too naive. It will fail to
>>> produce correct results on filesystems with links.
>>
>> As I explained to Eric, this function implements 'abspath', not
>> 'realpath',
>> and given that
Dave Korn wrote:
Roumen Petrov wrote:
I think that processing of '..' in a path is too naive. It will fail to
produce correct results on filesystems with links.
As I explained to Eric, this function implements 'abspath', not 'realpath',
and given that we can't assume any of the directories e
Dave Korn wrote:
> Guess I'll have to `ls *foo*0*` them and test -z the output, that
> should work.
Nope, may have whitespace. Is checking the return status of ls portable?
cheers,
DaveK
Ralf Wildenhues wrote:
> * Dave Korn wrote on Sun, Aug 16, 2009 at 06:26:11PM CEST:
+AT_CHECK([$LIBTOOL --mode=install $lt_INSTALL main$EXEEXT
$curdir/bin/main$EXEEXT], [], [ignore], [ignore])
+AT_CHECK([$LIBTOOL --mode=execute $curdir/bin/main$EXEEXT], [], [stdout])
>>> This one s
Roumen Petrov wrote:
>
> I think that processing of '..' in a path is too naive. It will fail to
> produce correct results on filesystems with links.
As I explained to Eric, this function implements 'abspath', not 'realpath',
and given that we can't assume any of the directories even exist when
Dave Korn wrote:
So, here I hope is the final respin. Built and tested on i686-pc-cygwin and
i686-pc-linux-gnu with no regressions and all new tests passing (see below sig
separator for details).
libtool/ChangeLog:
* Makefile.am (TESTSUITE_AT): Add bindir.at.
* libltdl/config
* Dave Korn wrote on Sun, Aug 16, 2009 at 06:26:11PM CEST:
> Ralf Wildenhues wrote:
> > sorry for making you go through another round.
>
> :-/ That'll teach me to say "unless there's anything else?"
Hehe.
> > \+ is a GNU sed extension, \{1,\} is Posix (two instances).
> > Nested \( \) are
Ralf Wildenhues wrote:
> Hi Dave,
>
> sorry for making you go through another round.
:-/ That'll teach me to say "unless there's anything else?"
>> +pathcar="s,^/\([^/]*\).*$,\1,"
>> +pathcdr="s,^/[^/]*,,"
>> +removedotparts="s,/\(\.\(/\|$\)\)\+,/,g"
>> +collapseslashes="s,/\+,/,g"
>
> \+
Hi Dave,
sorry for making you go through another round.
Except for the sed issues the following nits are all mechanical, and it
would suffice if you re-checked only your new tests and only on one of
the affected systems.
I consider the patch ready after this round, but I will probably leave a
co
11 matches
Mail list logo
