Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Chuck, On 6 May 2008, at 22:47, Charles Wilson wrote: Unresolved: (1) whether func_emit_wrapper_part1 should even TAKE an argument (2) whether the cwrapper src, when printing a const char*, should use puts() in preference to printf("%s",...) The quality of your patches has always been

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Chuck, On 6 May 2008, at 22:47, Charles Wilson wrote: Please refer to arguments in all caps: ARG (as is done elsewhere). See above (.libs). # func_emit_wrapper [ARG=no] Somewhat confusingly, we took our inspiration from the text rendering of a gnu info document, so the line above would st

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Charles Wilson wrote: Roumen Petrov wrote: libtool 2.2.4 patched with both patches still fail: ... (lt_setenv) setting 'PATH' to ':/usr/local/src//lt-2.2.4-mingw-mlib/lib2/.libs:/usr/local/src//lt-2.2.4-mingw-mlib/lib1/.libs:/tmp/test/pkg/lt-2.2.4-mingw-mlib/lib:/tmp/test/pkg/l

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Roumen Petrov wrote: Hi Charles, About following comment: /* execv doesn't actually work on mingw as expected on unix */ Actually execXXX on microsoft windows create a new process and it is not mingw problem. What about to substitute "mingw" with "windows" ? Disagree. The FSF discourages to

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Roumen Petrov wrote: libtool 2.2.4 patched with both patches still fail: ... (lt_setenv) setting 'PATH' to ':/usr/local/src//lt-2.2.4-mingw-mlib/lib2/.libs:/usr/local/src//lt-2.2.4-mingw-mlib/lib1/.libs:/tmp/test/pkg/lt-2.2.4-mingw-mlib/lib:/tmp/test/pkg/lt-2.2.4-mingw-mlib/bin:

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Charles Wilson wrote: Charles Wilson wrote: 2008-05-05 Charles Wilson <...> * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto,

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Hi Charles, About following comment: /* execv doesn't actually work on mingw as expected on unix */ Actually execXXX on microsoft windows create a new process and it is not mingw problem. What about to substitute "mingw" with "windows" ? Roumen Charles Wilson wrote: Charles Wilson wrote: