Re: bootstrap patch

2014-01-27 Thread Eric Blake
On 01/26/2014 11:08 AM, Bruce Korb wrote: > Hi, > > "test -f .git"? Do you mean "test -d .git"? No, because .git can be a symlink, in which case test -d .git fails but test -f .git passes. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: bootstrap patch

2014-01-27 Thread Bruce Korb
Hi Gary, On Sun, Jan 26, 2014 at 6:21 PM, Gary V. Vaughan wrote: >> Anyway, if you want to test for "are we in a git repo hierarchy?" >> would not "git rev-parse --git-dir" be better? > > No, because bootstrap absolutely has to run in $srcdir, and I don't want to $top_srcdir, I would guess. I w

Re: bootstrap patch

2014-01-27 Thread Gary V. Vaughan
Hi Eric, > On Jan 28, 2014, at 2:30 AM, Eric Blake wrote: > >> On 01/26/2014 11:08 AM, Bruce Korb wrote: >> Hi, >> >> "test -f .git"? Do you mean "test -d .git"? > > No, because .git can be a symlink, in which case test -d .git fails but > test -f .git passes. Urgh. Now I'm confused... the m

Re: bootstrap patch

2014-01-27 Thread Eric Blake
On 01/27/2014 12:24 PM, Gary V. Vaughan wrote: > Hi Eric, > >> On Jan 28, 2014, at 2:30 AM, Eric Blake wrote: >> >>> On 01/26/2014 11:08 AM, Bruce Korb wrote: >>> Hi, >>> >>> "test -f .git"? Do you mean "test -d .git"? >> >> No, because .git can be a symlink, in which case test -d .git fails but

Re: bootstrap patch

2014-01-27 Thread Gary V. Vaughan
Hi Eric, On Jan 28, 2014, at 8:35 AM, Eric Blake wrote: > On 01/27/2014 12:24 PM, Gary V. Vaughan wrote: >>> On Jan 28, 2014, at 2:30 AM, Eric Blake wrote: >>> On 01/26/2014 11:08 AM, Bruce Korb wrote: Hi, "test -f .git"? Do you mean "test -d .git"? >>> >>> No, because .g