First, thanks for working on this. It is definitely needed in the
manual. I have re-engineered this a couple of times already, but the
collected wisdom should be in the manual in the first place.
Peter Rosin writes:
> #if defined _WIN32 && !defined __GNUC__
> # ifdef BUILDING_LIBFOO
> # ifdef
Hi Simon,
Thanks for the feedback.
Den 2010-10-14 09:34 skrev Simon Josefsson:
> First, thanks for working on this. It is definitely needed in the
> manual. I have re-engineered this a couple of times already, but the
> collected wisdom should be in the manual in the first place.
Indeed.
> Pe
Den 2010-10-13 20:50 skrev Ralf Wildenhues:
> Hi Peter,
>
> * Peter Rosin wrote on Wed, Oct 13, 2010 at 08:19:27PM CEST:
>> Can you spot any errors?
>
> See below. I've only checked for things obvious to me; I hope somebody
> else verifies the w32 semantics and details. ;-)
>
> Thanks for writ
Peter Rosin writes:
> DLL_EXPORT comes from libtool, so it should not be changed to
> LIBFOO_DLL_EXPORT.
Right.
> And while I approve of starting with LIBFOO_ instead of BUILDING_,
> LIBFOO_BUILDING sounds very wrong as BUILDING changes from a verb to a
> noun. LIBFOO_BUILD perhaps? Other sugg
Den 2010-10-14 13:09 skrev Simon Josefsson:
> Peter Rosin writes:
>
>>> For comparison, in my projects I'm using a variant of this:
>>>
>>> # ifndef GSASL_API
>>> # if defined GSASL_BUILDING && defined HAVE_VISIBILITY && HAVE_VISIBILITY
>>> # define GSASL_API __attribute__((__visibility__("def
Peter Rosin writes:
>> The first issue (i.e., MSC static builds) could be handled by the means
>> in the second point (i.e., project specifying -DGSASL_API="") though.
>> Then there would be no need for GSASL_STATIC.
>>
>> Anyway, I think the block will likely need to be adapted by each
>> proje
