On 01/27/14 06:57, Bruce Korb wrote:
Hi Gary,
On Sun, Jan 26, 2014 at 6:21 PM, Gary V. Vaughan wrote:
Anyway, if you want to test for "are we in a git repo hierarchy?"
would not "git rev-parse --git-dir" be better?
No, because bootstrap absolutely has to run in $srcdir, and I don't want to
Hi Eric,
On Jan 28, 2014, at 8:35 AM, Eric Blake wrote:
> On 01/27/2014 12:24 PM, Gary V. Vaughan wrote:
>>> On Jan 28, 2014, at 2:30 AM, Eric Blake wrote:
>>>
On 01/26/2014 11:08 AM, Bruce Korb wrote:
Hi,
"test -f .git"? Do you mean "test -d .git"?
>>>
>>> No, because .g
On 01/27/2014 12:24 PM, Gary V. Vaughan wrote:
> Hi Eric,
>
>> On Jan 28, 2014, at 2:30 AM, Eric Blake wrote:
>>
>>> On 01/26/2014 11:08 AM, Bruce Korb wrote:
>>> Hi,
>>>
>>> "test -f .git"? Do you mean "test -d .git"?
>>
>> No, because .git can be a symlink, in which case test -d .git fails but
Hi Eric,
> On Jan 28, 2014, at 2:30 AM, Eric Blake wrote:
>
>> On 01/26/2014 11:08 AM, Bruce Korb wrote:
>> Hi,
>>
>> "test -f .git"? Do you mean "test -d .git"?
>
> No, because .git can be a symlink, in which case test -d .git fails but
> test -f .git passes.
Urgh. Now I'm confused... the m
Hi Gary,
On Sun, Jan 26, 2014 at 6:21 PM, Gary V. Vaughan wrote:
>> Anyway, if you want to test for "are we in a git repo hierarchy?"
>> would not "git rev-parse --git-dir" be better?
>
> No, because bootstrap absolutely has to run in $srcdir, and I don't want to
$top_srcdir, I would guess. I w
On 01/26/2014 11:08 AM, Bruce Korb wrote:
> Hi,
>
> "test -f .git"? Do you mean "test -d .git"?
No, because .git can be a symlink, in which case test -d .git fails but
test -f .git passes.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Hi Bruce,
On Jan 27, 2014, at 7:08 AM, Bruce Korb wrote:
> Hi,
>
> "test -f .git"? Do you mean "test -d .git"?
D'oh! Yes. I made a hasty change from test -f .gitignore... which was even
more misguided.
I pushed the s|-f|-d| fix already. Thank you!
> Anyway, if you want to test for "are we
