Re: When to bump library api version (current)

2010-05-19 Thread Adam Mercer
On Wed, May 19, 2010 at 23:36, Daniel Herring wrote: Daniel > ISTM that this is not an ABI change; the addition of const only affects the > code being called, and in a manner compatible with the non-const version > (assuming calling code did not expect this parameter to be changed). This was my

Re: When to bump library api version (current)

2010-05-19 Thread Daniel Herring
On Wed, 19 May 2010, Adam Mercer wrote: double calculate_ligo_snr_from_strain( REAL4TimeVectorSeries *strain, SimInspiralTable *thisInj, char ifo[3]); has changed to: double calculate_ligo_snr_from_strain( REAL4TimeVectorSeries *strain, SimInspiralTable *thisInj, const char ifo[3]); i.e

When to bump library api version (current)

2010-05-19 Thread Adam Mercer
Hi We are coming up for a new release of one of the libraries I maintain and I'm not sure whether the library api version needs bumping (specifically current). The only API change is that the function below: double calculate_ligo_snr_from_strain( REAL4TimeVectorSeries *strain, SimInspiralTabl