https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #63 from Dave Gilbert ---
Yeh I noticed that; got to dig myself out of some other bugs first.
The first thing to figure out is what ifdef etc you'd use to test for the
version of pdfium new enough to use it with.
--
You are r
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Buovjaga changed:
What|Removed |Added
CC||ilmari.lauhakangas@libreoff
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #61 from Dave Gilbert ---
Great; so that means we can now read PDFs without the custom keys in, with the
old stuff still supported.
I'm not sure what else could be done for this bug.
The only thing I've got outstanding is to di
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #60 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/d629416be0a3742afda0f5c50c2f80a15553143c
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #59 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/7c46138b61e1dfa9b5d649d6a797737304d225fa
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #58 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/f3fd83098f3020c9f69032911754a5c1d2fc4fd5
tdf#55425,tdf#
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #57 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/0d4d2563091eccb125a3d0f11b2df858d059d6a7
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #56 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/b7a8ce65b47bd85e31ae3ff8e81f23f79380de87
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #55 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/bc680499b5fa782c7396f7ab688c8f5498b58b46
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #54 from Commit Notification
---
Dr. David Alan Gilbert committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/9b401a09c5cde0250457f45d9540ee15ab8e43f9
tdf#55425, tdf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.6.0|target:7.6.0 target:25.8.0
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #53 from Dave Gilbert ---
OK, the series at:
https://gerrit.libreoffice.org/c/core/+/183765/4
allows loading of Hybrids looking only at the embeddedFile.
If the embedded file is not found it checks the old scheme as well; so
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #52 from Dave Gilbert ---
A problem with the 'EmbeddedFile' approach is that it's not readable until
after decryption - and as far as I can tell the filename isn't either.
That means we need to be able to decrypt in the ::detec
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #51 from Dave Gilbert ---
OK, I have a WIP at:
https://gerrit.libreoffice.org/c/core/+/183765
(Not added the password check yet, so doesn't work for encrypted files,
and I've not tidied any of the style up yet, and it's one big
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #45 from Michael Meeks ---
I guess we are well up for patching PDFium to add more API that we need here
:-)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #40 from Dave Gilbert ---
Tomaz:
Actually, I might have a simplification - am I right in saying that there
aren't any valid Hybrids that are:
a) AES encrypted (PDF2 )
and
b) Only have the old trailer syntax (not
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #49 from Tomaz Vajngerl ---
(In reply to Dave Gilbert from comment #46)
> How do people feel about just going with Original.oXX (with oXX being
> checked for sanity) until PDFium is improved?
Sure, it should be safe to rely on
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #48 from Dave Gilbert ---
(In reply to Dave Gilbert from comment #47)
> Question posted to:
> https://groups.google.com/g/pdfium/c/W9XS-2GIECA
I was pointed to create a bug entry, so we now have:
https://issues.chromium.org/i
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #47 from Dave Gilbert ---
Question posted to:
https://groups.google.com/g/pdfium/c/W9XS-2GIECA
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #46 from Dave Gilbert ---
Yeh I had a dig about in fpdfsdk/fpdf_attachment.cpp before posting.
I'll start by posting to the PDFium list.
How do people feel about just going with Original.oXX (with oXX being checked
for sanity)
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #44 from Miklos Vajna ---
I would again suspect that simply there is no public pdfium API to provide that
info, it's something that could be added.
In pdfium.git, fpdfsdk/fpdf_attachment.cpp seems to be the code for this, if
y
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #43 from Dave Gilbert ---
Hmm this was looking promising, until I've hit another thing PDFium doesn't
seem to implement.
I can't see a way of getting the MIME type of the attachment being loaded to
check it matches:
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #42 from Dave Gilbert ---
Excellent, right that gives me something to get on with.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #41 from Tomaz Vajngerl ---
C(In reply to Dave Gilbert from comment #40)
> Tomaz:
> Actually, I might have a simplification - am I right in saying that there
> aren't any valid Hybrids that are:
>
> a) AES encrypted (PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #39 from Miklos Vajna ---
Sure, I'm not trying to tell you what to do. :-)
One aspect to keep in mind is the --enable-mpl-subset case, which lacks
poppler. So if you switch the hybrid PDF detection to poppler, you may want to
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #38 from Dave Gilbert ---
(In reply to Miklos Vajna from comment #37)
> > But that seems the only API it's got for getting any trailer info isn't it?
>
> Ah, I see. The pdfium API is intentionally high-level, so most probably
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Dave Gilbert changed:
What|Removed |Added
CC||caolan.mcnamara@collabora.c
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #37 from Miklos Vajna ---
> But that seems the only API it's got for getting any trailer info isn't it?
Ah, I see. The pdfium API is intentionally high-level, so most probably it
won't give you access to raw dictionaries, and
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #36 from Dave Gilbert ---
(In reply to Miklos Vajna from comment #35)
> The pdfium API is a bit higher level, see if FPDFDoc_GetAttachmentCount(),
> FPDFDoc_GetAttachment(), FPDFAttachment_GetName() and so in
> fpdf_attachment.
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #35 from Miklos Vajna ---
The pdfium API is a bit higher level, see if FPDFDoc_GetAttachmentCount(),
FPDFDoc_GetAttachment(), FPDFAttachment_GetName() and so in fpdf_attachment.h
provides what you need.
We also have a C++ wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #26 from Miklos Vajna ---
> Oh, and does anyone understand why we have the /DocChecksum
My guess is that some PDF readers have this feature to remember e.g. what page
were you looking last and this keeps working even if you re
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #34 from Dave Gilbert ---
(In reply to Tomaz Vajngerl from comment #32)
> (In reply to Dave Gilbert from comment #30)
> > (Copying Caolán in due to the hybrid performance hack)
> > Hi Tomaz,
> > Thanks for replying.
> > For c
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #33 from Caolán McNamara ---
You can probably disregard detectHasAdditionalStreams as just an optimization
for the state of things at the time it was added.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #32 from Tomaz Vajngerl ---
(In reply to Dave Gilbert from comment #30)
> (Copying Caolán in due to the hybrid performance hack)
> Hi Tomaz,
> Thanks for replying.
> For context, one reason I'm asking abotu this stuff is that
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #31 from Miklos Vajna ---
(In reply to Tomaz Vajngerl from comment #28)
> > My guess is that some PDF readers have this feature to remember e.g. what
> > page were you looking last and this keeps working even if you rename the
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #29 from Tomaz Vajngerl ---
Also BTW, we don't write those to the trailer anymore, if we export to PDF/A
variant or PDF/UA is enabled.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #28 from Tomaz Vajngerl ---
(In reply to Miklos Vajna from comment #26)
> > Oh, and does anyone understand why we have the /DocChecksum
>
> My guess is that some PDF readers have this feature to remember e.g. what
> page were
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #27 from Tomaz Vajngerl ---
(In reply to Dave Gilbert from comment #25)
> Two thoughts about the use of trailers:
> a) Without a trailer, I don't understand how a hybrid loader is supposed
> to understand that a PDF embedded
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Dave Gilbert changed:
What|Removed |Added
CC||freedesk...@treblig.org
--- Commen
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
V Stuart Foote changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #24 from peter.wy...@pdfa.org ---
The latest ISO standard for PDF (ISO 32000-2:2020) no longer prohibits custom
keys in trailers - in fact, it explicitly permits keys that are 2nd-class
names: "The PDF file trailer dictionary ma
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Stéphane Guillou (stragu) changed:
What|Removed |Added
See Also||https://bugs.documentf
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Stéphane Guillou (stragu) changed:
What|Removed |Added
CC||stephane.guillou@libre
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #22 from Commit Notification
---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/9740331d8bc56a9b6fbe3e4c1b26fb97f6639cc6
tdf#66580 write more m
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #21 from Commit Notification
---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/8640e24b12c7df3170c9f3e7ff3edced81fd0838
tdf#66580 added hybrid
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #20 from Commit Notification
---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/e052f6e1d49a5289411b31561d6e310bf414d896
tdf#66580 write ODF do
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Commit Notification changed:
What|Removed |Added
Whiteboard||target:7.6.0
--
You are re
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
V Stuart Foote changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Aron Budea changed:
What|Removed |Added
Blocks|103378 |143999
CC|
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
V Stuart Foote changed:
What|Removed |Added
CC||peter.maiw...@web.de
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #18 from Julien Nabet ---
Here are some code pointers:
https://opengrok.libreoffice.org/search?project=core&full=AdditionalStreams&defs=&refs=&path=&hist=&type=&si=full
To create the pdf:
emitTrailer() method from vcl/source/g
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #17 from kurt.pfei...@gmail.com ---
(In reply to Michael Meeks from comment #15)
> The hybrid PDF functionality was a great innovation, and the standard didn't
> cover it then of course.
Indeed the hybrid PDF functionality i s
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #16 from Julien Nabet ---
Thank you Michael for your very quick feedback! :-)
I took a look at
https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdf
which 1.4 version (released in 20
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #15 from Michael Meeks ---
The hybrid PDF functionality was a great innovation, and the standard didn't
cover it then of course. It would be great to find some resources / and/or
interested people to implement the new standard
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Jean-Baptiste Faure changed:
What|Removed |Added
Version|3.3.0 release |Inherited From OOo
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Julien Nabet changed:
What|Removed |Added
CC||michael.me...@collabora.com
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #12 from Alexis de Lattre ---
It is very very strange that a project such as LibreOffice that promote the
OpenDocument standard and interoperability in general doesn't respect the PDF
standard ! Adding proprietary keys in the P
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #11 from QA Administrators ---
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to rete
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #10 from kurt.pfei...@gmail.com ---
(In reply to Jos van den Oever from comment #9)
> PDF documents created with version 5.1.2.2.0 on Linux 4.4 still add the key
> /DocChecksum and /AdditionalStreams to the PDF files.
Jos, the
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
Xisco Faulí changed:
What|Removed |Added
Keywords||filter:pdf
Blocks|
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #9 from Jos van den Oever ---
PDF documents created with version 5.1.2.2.0 on Linux 4.4 still add the key
/DocChecksum and /AdditionalStreams to the PDF files.
--
You are receiving this mail because:
You are the assignee for
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #8 from QA Administrators ---
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retes
https://bugs.documentfoundation.org/show_bug.cgi?id=66580
--- Comment #7 from QA Administrators ---
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retes
https://bugs.freedesktop.org/show_bug.cgi?id=66580
kurt.pfei...@gmail.com changed:
What|Removed |Added
Severity|major |trivial
Priority|mediu
https://bugs.freedesktop.org/show_bug.cgi?id=66580
--- Comment #5 from kurt.pfei...@gmail.com ---
To give you a link to the relevant PDF-1.4 specification:
http://acroeng.adobe.com/PDFReference/PDF_1.4/PDF%20Reference%201.4.pdf
The quote given by Jos in his bug report is from named page 723
https://bugs.freedesktop.org/show_bug.cgi?id=66580
kurt.pfei...@gmail.com changed:
What|Removed |Added
CC||kurt.pfei...@gmail.com
--- Comme
https://bugs.freedesktop.org/show_bug.cgi?id=66580
Cor Nouws changed:
What|Removed |Added
Version|4.1.0.0.beta2 |3.3.0 release
--- Comment #3 from Cor Nouws
https://bugs.freedesktop.org/show_bug.cgi?id=66580
--- Comment #2 from Jos van den Oever ---
The /DocChecksum and /AdditionalStreams were added to OpenOffice on 2007-03-26.
In the LibreOffice git repository this is commit
d217c079d7b3ca7b5039428594e7cdfdf9a0c4a9
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=66580
Cor Nouws changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
CC|
70 matches
Mail list logo
