[PATCH] fdo#61458, index should be "flat"

2013-03-08 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2603 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/2603/1 fdo#61458, index should be "flat" Change-Id: I46db120fc5e7d616cd4c9eadee7fc4c502569e86 --- M sw/source/core/doc/

[PUSHED] fdo#60691 add modelines to *.src and *.hrc files

2013-03-08 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2533 Approvals: Caolán McNamara: Verified; Looks good to me, approved Objections: Michael Meeks: Do not merge -- To view, visit https://ger

[PATCH] coverity#989730 and coverity#989729: Uninitialized scalar fi...

2013-03-08 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2607 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/2607/1 coverity#989730 and coverity#989729: Uninitialized scalar field Change-Id: Iaecfa720b898746d457de731734b332226d3

[PATCH] Documentation to avoid a real use-after-free bug

2013-03-08 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2608 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2608/1 Documentation to avoid a real use-after-free bug Change-Id: Ie8a4432b0a70703fbfe92480ad0608b659a887d0 --- M svto

[PATCH] coverity#989728: uninitialized scalar

2013-03-08 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2609 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/2609/1 coverity#989728: uninitialized scalar Change-Id: Ic8e248eff6db54f407ec894cab28a27957c6fd0f --- M svtools/source/

[PUSHED] Fix typo in libreoffice man page.

2013-03-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2610 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2610 To unsubscribe, v

[PUSHED] Related to fdo#60724: Fix grammar.

2013-03-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2611 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2611 To unsubscribe, v

[PATCH] Make ComboBox::CalcSize to return the right width

2013-03-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2612 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/2612/1 Make ComboBox::CalcSize to return the right width Change-Id: I83f5075281b2edd3f7a5e94709f0529d0c744ff8 --- M vcl

[PATCH] use system python for building if possible

2013-03-09 Thread via Code Review
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2563 to look at the new patch set (#5). Change subject: use system python for building if possible .. use syste

[PUSHED] Add back subsequencecheck targets accidentally removed ...

2013-03-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2630 Approvals: Matúš Kukan: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2630 To unsubscribe, visit

[PATCH] fdo#61421 Added line to prevent screenlocking during present...

2013-03-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2640/1 fdo#61421 Added line to prevent screenlocking during presentation Added line to xml layout to prevent locking sc

[PATCH] build concat-deps as ordinary executable

2013-03-11 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2659 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2659/1 build concat-deps as ordinary executable Change-Id: I6404472040f38c14ec7ca4a2c51be0d2f7f8199a --- M Repository.m

[PATCH] use system python for building if possible

2013-03-11 Thread via Code Review
Hello LibreOffice gerrit bot, David Ostrovsky, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2563 to look at the new patch set (#6). Change subject: use system python for building if possible

[ABANDONED] fdo#46808, continued

2013-03-11 Thread via Code Review
Gergő Mocsi has abandoned this change. Change subject: fdo#46808, continued .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2189 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-

[ABANDONED] fdo#46808, in chart and chart2

2013-03-11 Thread via Code Review
Gergő Mocsi has abandoned this change. Change subject: fdo#46808, in chart and chart2 .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2191 To unsubscribe, visit https://gerrit.libreoffice.org/setting

[PATCH] Polishing 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2676 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2676/1 Polishing 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10 Change-Id: I73334fca8429dc0ad4250ce638027fa52245dec4 --- M un

[PATCH] solenv: remove versionlist.hrc

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2677 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2677/1 solenv: remove versionlist.hrc Change-Id: Iddbfcacd17c1022293357ff5240ab7a52b1a390e --- M config_host/config_ver

[PUSHED] Removal finished of CreateFromAscii

2013-03-12 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2685 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2685 To unsubscribe, visit

[PATCH] Replace XubString with OUString (dbggui.cxx)

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2688 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2688/1 Replace XubString with OUString (dbggui.cxx) Change-Id: I080f6671eaa923790fd41d4ed9f147c44c721442 --- M vcl/sour

[PATCH] Replace XubString with OUString (vcl/ilstbox)

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2690 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2690/1 Replace XubString with OUString (vcl/ilstbox) Change-Id: Ia2cefe1649538d411ae858e21a3145ca01fff2ee --- M vcl/inc

[PUSHED] coverity#705734: Resource leak

2013-03-12 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2689 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2689 To unsubscribe, vi

[PUSHED libreoffice-4-0] Resolves: #i120773 Numbering lost when saving or opening a p...

2013-03-13 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2692 Approvals: Radek Doulík: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2692 To unsubscribe, visit

[PUSHED libreoffice-4-0-2] -Werror=shadow/-Werror=unused-variable

2013-03-13 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2699 Approvals: Caolán McNamara: Verified; Looks good to me, approved Bosdonnat Cedric: Verified; Looks good to me, but someone else must appro

[PUSHED libreoffice-4-0-2] Fix Set/Let mixup ( from String -> OUString rework ) fdo#607...

2013-03-13 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2706 Approvals: Caolán McNamara: Verified; Looks good to me, approved Fridrich Strba: Looks good to me, but someone else must approve -- To

[PATCH libreoffice-4-0] Resolves: rhbz#918938 crash in danish thesaurus/spell intera...

2013-03-13 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2710 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2710/1 Resolves: rhbz#918938 crash in danish thesaurus/spell interaction Change-Id: I911fc382a8e4b895262dcd5ae5c67c4a81

[PATCH libreoffice-4-0-2] Resolves: rhbz#918938 crash in danish thesaurus/spell intera...

2013-03-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2720 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2720/1 Resolves: rhbz#918938 crash in danish thesaurus/spell interaction Change-Id: I911fc382a8e4b895262dcd5ae5c67c4a81

[PATCH libreoffice-4-0] safer order of replacement

2013-03-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2721 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2721/1 safer order of replacement Change-Id: I912dbb6eddbb91bd9d5e18fb169f498df692d0e6 --- M hunspell/hunspell.rhbz9189

[PATCH libreoffice-4-0] hackaround for assert

2013-03-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2722 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2722/1 hackaround for assert regression since 1c22545edf9085b9f2656ca92781158b6b123db3 Change-Id: Ia9aa06ed7fd0f314992

[PUSHED] Show LibreOffice controls in Glade's tool palette

2013-03-14 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2724 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2724 To unsubscribe, vi

[PUSHED] converted sd/source/ui/dlg/present.src to .ui

2013-03-14 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2732 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2732 To unsubscribe, vi

[PUSHED] updated help after .ui conversion for sd/source/ui/dlg/prese...

2013-03-14 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2733 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2733 To unsubscribe, vi

[PUSHED] fdo#38448 No scrolling in mailmerge's create new address lis...

2013-03-14 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2454 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2454 To unsubscribe, vi

[PATCH libreoffice-4-0] fdo#62360: fix word breaking in Writer for spell checking

2013-03-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2737 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/2737/1 fdo#62360: fix word breaking in Writer for spell checking Change-Id: I0f23e9f7f076f3a82d1d5df92d9d4d3919fc816d -

[PATCH libreoffice-4-0] remove trailing whitespace

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2739 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/2739/1 remove trailing whitespace - as this is being quoted, this causes breakage Change-Id: I6834a3235ae2334a0d6f7df0

[PATCH] replace SKIP_TESTS with a generic selection of target group

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2742 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2742/1 replace SKIP_TESTS with a generic selection of target group - this allows e.g. tinderboxes, which know that they

[PATCH libreoffice-4-0] Resolves: rhbz#906137 slide show inverts outputs

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2743 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/2743/1 Resolves: rhbz#906137 slide show inverts outputs we go to some effort to determine the right value of ret and th

[PUSHED libreoffice-4-0-2] fdo#54275: Fix GVFS UCP, so saving docs works again

2013-03-15 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2731 Approvals: Caolán McNamara: Verified; Looks good to me, approved Michael Meeks: Looks good to me, but someone else must approve Fridrich

[PATCH libreoffice-4-0] Related: rhbz#906137 g_module_symbol returned nothing

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2744 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2744/1 Related: rhbz#906137 g_module_symbol returned nothing for gdk_screen_get_primary_monitor but osl_getAsciiFunctio

[PATCH libreoffice-4-0-2] Resolves: rhbz#906137 slide show inverts outputs

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2745 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/2745/1 Resolves: rhbz#906137 slide show inverts outputs we go to some effort to determine the right value of ret and th

[PATCH libreoffice-3-6] Resolves: rhbz#906137 slide show inverts outputs

2013-03-15 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2746 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/2746/1 Resolves: rhbz#906137 slide show inverts outputs we go to some effort to determine the right value of ret and th

[PUSHED libreoffice-4-0] compareToAscii(RTL_CONSTASCII_STRINGPARAM(s)) != compareToAs...

2013-03-15 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2760 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2760 To unsubscribe, visit

[PUSHED] first crack at writing a linter for .ui files

2013-03-15 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2762 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2762 To unsubscribe, vi

[PUSHED] various .ui fixes caught by linter tool

2013-03-15 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2763 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2763 To unsubscribe, vi

[PATCH] Remove STRINGPARAM in tools (qa)

2013-03-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2768 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2768/1 Remove STRINGPARAM in tools (qa) Change-Id: I1bff00d261c24e37f9ed41322c49c670850a940f --- M tools/qa/cppunit/tes

[PATCH] Remove RTL_CONSTASCII_(U)STRING in toolkit

2013-03-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2770 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2770/1 Remove RTL_CONSTASCII_(U)STRING in toolkit Change-Id: I62c89716d93c4dfb51a38b78f795a532e2b1d0b7 --- M toolkit/in

[PATCH] Replace String with OUString in toolkit(vclxprinter.cxx)

2013-03-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2771 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/2771/1 Replace String with OUString in toolkit(vclxprinter.cxx) Change-Id: I265b413923837aaba47abf242803fae7359f8ea8 --

[PATCH] Remove RTL_CONSTASCII_(U)STRINGPARAM (toolkit)

2013-03-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2772 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2772/1 Remove RTL_CONSTASCII_(U)STRINGPARAM (toolkit) Change-Id: I558a97be9ed883242455e6fd29267aed5d0a550c --- M toolki

[PATCH] Reuse ImplPower10()

2013-03-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2774 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/2774/1 Reuse ImplPower10() Change-Id: I0a86e43065689d2478ced4804ab083244d8d35f5 --- M vcl/source/control/field.cxx 1 fi

[PUSHED] coverity#705115 Using invalid iterator

2013-03-17 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2785 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2785 To unsubscribe, v

[PUSHED] coverity#982272 Copy-paste error

2013-03-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2806 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Tomáš Chvátal: Verified; Looks good to me, approved -- To v

[PUSHED] coverity#982269 Copy-paste error

2013-03-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2801 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Tomáš Chvátal: Verified; Looks good to me, approved -- To v

[PUSHED] coverity#735373 Copy-paste error

2013-03-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2797 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Tomáš Chvátal: Verified; Looks good to me, approved -- To v

[PUSHED] coverity#735372 Copy-paste error

2013-03-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2795 Approvals: Tomáš Chvátal: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2795 To unsubscribe, visi

[PATCH] fdo#60780, Save a Copy wip

2013-03-18 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2829 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2829/1 fdo#60780, Save a Copy wip The saving seems to work fine, but immediately opening the copy doesn't work, you hav

[PATCH] Remove RTL_CONSTASCII_(U)STRINGPARAM in sw (2)

2013-03-19 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2837 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/2837/1 Remove RTL_CONSTASCII_(U)STRINGPARAM in sw (2) Change-Id: I5f84d997855321145179a9d6198a0d093dc62a95 --- M sw/sou

[PATCH] odk: do not pack unused component.map file

2013-03-19 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2838 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/2838/1 odk: do not pack unused component.map file Change-Id: I768acf83234eec46c0271dad2e5bef3bd3cba3cf --- M odk/Custom

[PATCH] use -isystem instead of -I for 3rd party headers

2013-03-19 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2846 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/2846/1 use -isystem instead of -I for 3rd party headers This should avoid gcc warnings in external code we don't care a

[PATCH] fdo#39468: Translated German comments

2013-03-19 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2847 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/2847/1 fdo#39468: Translated German comments Change-Id: I840ab979486a8cdfed4b19f4966eef1b9f287a5b --- M sc/source/core/

[PUSHED] fdo#39445 writing out tools/fsys.hxx (rsc)

2013-03-19 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2853 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2853 To unsubscribe, v

[PUSHED] fdo#39445 writing out tools/fsys.hxx (sot)

2013-03-19 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2852 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2852 To unsubscribe, v

[PATCH] simplify OUString assignments

2013-03-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2863 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2863/1 simplify OUString assignments Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb --- M basegfx/test/basegfx2d.

[PATCH] Replace String with OUString (unotools)

2013-03-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2864 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2864/1 Replace String with OUString (unotools) Change-Id: I9a0677cb36805d0a27514824c937901f73fee1c8 --- M cui/source/di

[PATCH] use -isystem instead of -I for 3rd party headers

2013-03-20 Thread via Code Review
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2846 to look at the new patch set (#2). Change subject: use -isystem instead of -I for 3rd party headers .. use

[PUSHED] use -isystem instead of -I for 3rd party headers

2013-03-20 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2846 -- To view, visit https://gerrit.libreoffice.org/2846 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PUSHED] introduce gb_Module_SKIPTARGETS

2013-03-21 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2742 Approvals: Björn Michaelsen: Verified; Looks good to me, approved Matúš Kukan: Looks good to me, approved -- To view, visit https://ger

[PATCH] Replace String with OUString in RecodeString

2013-03-22 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2919 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/2919/1 Replace String with OUString in RecodeString Change-Id: I987f738d1cd7d640a253f3cd31864290b6d763bf --- M unotools

[PUSHED] fixed the dialog because there was an overlap

2013-03-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2926 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2926 To unsubscribe, v

[PUSHED] Translations of comments from German into English

2013-03-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2934 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2934 To unsubscribe, v

[PUSHED] After presentation is finished always have previous go to la...

2013-03-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2933 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2933 To unsubscribe, v

[PATCH] fdo#47576: Support for textual links added (SVG Export)

2013-03-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2936 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/2936/1 fdo#47576: Support for textual links added (SVG Export) Added Support to export textual links in SVG files, imag

[PUSHED] Fixed templates notes view and master pages

2013-03-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2939 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2939 To unsubscribe, v

[PATCH] Remove HTMLMODE_FRM_COLUMNS and export column-count CSS attr...

2013-03-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2950 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/2950/1 Remove HTMLMODE_FRM_COLUMNS and export column-count CSS attribute For multi-column sections in Writer, HTMLMODE_

[PATCH] Use OUString and sal_Int32 in filterText()

2013-03-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2956 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/2956/1 Use OUString and sal_Int32 in filterText() Change-Id: I31437125b51b07be490de3d979e193fad9750f51 --- M vcl/generi

[PATCH] fdo#47576: Hyperlinks work for SVG Exports

2013-03-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2957 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/2957/1 fdo#47576: Hyperlinks work for SVG Exports For different objects (images, shapes...) hyperlinks are exported by

[PATCH] Use OUString and sal_Int32 in ImplPrepareLayoutArgs() and Ge...

2013-03-24 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2959 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2959/1 Use OUString and sal_Int32 in ImplPrepareLayoutArgs() and GetTextIsRTL() Change-Id: Ib1b659aa56a38efdfc2dddb5e36

[PATCH] Use OUString and sal_Int32 in GetTextArray() and ImplLayout(...

2013-03-24 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2967 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2967/1 Use OUString and sal_Int32 in GetTextArray() and ImplLayout() Change-Id: I2c1e5b7d53c0d78f2ccf9ac317a7ff40298cd6

[PATCH] Clean obsolete tools/filesystem abstraction

2013-03-24 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2968 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2968/1 Clean obsolete tools/filesystem abstraction Change-Id: I74f99c48b822644b26486a66d2f15386991154d6 --- M tools/sou

[PATCH] Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxx

2013-03-24 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2975/1 Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxx Change-Id: Ibfce9af9bec2e1bac435514ad6d3d27eac5f1a17 --- M ucb/

fdo#38838 Unistring::Fill() -> OUString::padRight()

2012-11-28 Thread via Code Review
gerhard öttl has abandoned this change. Change subject: fdo#38838 Unistring::Fill() -> OUString::padRight() .. Patch Set 2: Abandoned Obsoleted by commit 721b1aca38a851c390f8e00ea96b761198db8bd5. Anyway - I have learned much

[PATCH] Change in core[libreoffice-3-6]: bigendian utext mixup triggering regression test failure

2012-11-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1188 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/1188/1 bigendian utext mixup triggering regression test failure text takes a pointer to a sal_uInt8 buffer but utext ta

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#57640 we really want to *titlecase* the initia...

2012-11-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1191 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1191/1 Resolves: fdo#57640 we really want to *titlecase* the initial character http://srfi.schemers.org/srfi-13/mail-ar

[PATCH] Removal ::rtl:: prefixes and macros in IO

2012-11-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1194 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/1194/1 Removal ::rtl:: prefixes and macros in IO This commit removes some ::rtl:: prefixes and RTL_CONSTASCII_STRINGPAR

[PUSHED] use $PIPESTATUS instead of pipefail option

2012-11-29 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1190 Approvals: Matúš Kukan: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1190 To unsubscribe, vis

[PUSHED] fdo#45495 pptx Export saves rotation of pictures, shapes, text

2012-11-29 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1030 Approvals: Radek Doulík: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1030 To unsubscribe, vi

[PATCH] Removal ::rtl:: prefixes and macros in IO

2012-11-29 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1200 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/1200/1 Removal ::rtl:: prefixes and macros in IO This commit removes some ::rtl:: prefixes and RTL_CONSTASCII_STRINGPAR

[PATCH] Change in core[libreoffice-3-6]: split qnametostr up to try and make .o's small enough for pp...

2012-11-30 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1201 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1201/1 split qnametostr up to try and make .o's small enough for ppc64 i.e. relocation truncated to fix: R_PPC64_TOC16_

[PUSHED] migrate 'Insert Footnote' dialog to .ui file

2012-11-30 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1193 -- To view, visit https://gerrit.libreoffice.org/1193 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] migrate 'Insert Bookmark' dialog to .ui file

2012-11-30 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1199 -- To view, visit https://gerrit.libreoffice.org/1199 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] WIP: move base check for bibliography to sfx2

2012-11-30 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1207 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1207/1 WIP: move base check for bibliography to sfx2 - in the libbiblio component the frame is already created, and a f

[PATCH] Removal ::rtl:: prefixes and macros in oxx

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1211 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1211/1 Removal ::rtl:: prefixes and macros in oxx This commit removes some ::rtl:: prefixes and RTL_CONSTASCII_STRINGPA

[PATCH] Removal ::rtl:: prefixes and macros in oxx

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1212 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1212/1 Removal ::rtl:: prefixes and macros in oxx This commit removes some ::rtl:: prefixes and RTL_CONSTASCII_STRINGPA

[PATCH] Removal ::rtl:: prefixes and macros in IO

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1210 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1210/1 Removal ::rtl:: prefixes and macros in IO This commit removes some ::rtl:: prefixes and RTL_CONSTASCII_STRINGPAR

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#56549 crash in format->autocorrect->apply and ...

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1218 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1218/1 Resolves: fdo#56549 crash in format->autocorrect->apply and edit changes regression from cad9afa15f53d547733fa55

[PATCH] fdo#51083 calc: fix mathematical errors in BinomDist, B, Cri...

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1213 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1213/1 fdo#51083 calc: fix mathematical errors in BinomDist, B, CritBinom and NegBinomDist In these functions the prec

[PATCH] do not redirect output in build.pl, i.e. dump build_error.lo...

2012-12-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1216 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1216/1 do not redirect output in build.pl, i.e. dump build_error.log and other logs Given that nowadays almost everythi

[PUSHED] OUStringBuffer constructor from OUStringBuffer should use co...

2012-12-01 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1209 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1209 To unsubscribe, vis

[PUSHED] do not redirect output in build.pl, i.e. dump build_error.lo...

2012-12-01 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1216 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1216 To unsubscribe, vis

[PUSHED] Insert Table Dialog: Rename button back to "AutoFormat", Acc...

2012-12-01 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1217 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1217 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: fdo#57708 fix fake page break problem during RTF import

2012-12-01 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1214 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1214 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: fdo#57708 fix RTF import of pictures right before text frame...

2012-12-01 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1215 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1215 To unsubscribe,

  1   2   3   4   5   6   7   8   9   10   >